* [PATCH] gprofng: Fix build with 64bit file offset on 32bit machines
@ 2023-07-31 22:31 Khem Raj
2023-08-01 18:05 ` Vladimir Mezentsev
0 siblings, 1 reply; 4+ messages in thread
From: Khem Raj @ 2023-07-31 22:31 UTC (permalink / raw)
To: binutils; +Cc: Khem Raj
gprofng/ChangeLog
2023-07-31 Khem Raj <raj.khem@gmail.com>
* libcollector/iotrace.c: Define open64, fgetpos64, and fsetpos64
only when __USE_LARGEFILE64 and __USE_FILE_OFFSET64 are not
defined.
---
gprofng/libcollector/iotrace.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/gprofng/libcollector/iotrace.c b/gprofng/libcollector/iotrace.c
index c0ea7497b09..81c844048d9 100644
--- a/gprofng/libcollector/iotrace.c
+++ b/gprofng/libcollector/iotrace.c
@@ -1030,8 +1030,9 @@ gprofng_open64 (int(real_open64) (const char *, int, ...),
}
DCL_FUNC_VER (DCL_OPEN64, open64_2_2, open64@GLIBC_2.2)
+#if !defined(__USE_LARGEFILE64)
DCL_OPEN64 (open64)
-
+#endif
#define F_ERROR_ARG 0
#define F_INT_ARG 1
@@ -2989,8 +2990,9 @@ DCL_FUNC_VER (DCL_FGETPOS64, fgetpos64_2_17, fgetpos64@GLIBC_2.17)
DCL_FUNC_VER (DCL_FGETPOS64, fgetpos64_2_2_5, fgetpos64@GLIBC_2.2.5)
DCL_FUNC_VER (DCL_FGETPOS64, fgetpos64_2_2, fgetpos64@GLIBC_2.2)
DCL_FUNC_VER (DCL_FGETPOS64, fgetpos64_2_1, fgetpos64@GLIBC_2.1)
+#if !defined(__USE_LARGEFILE64)
DCL_FGETPOS64 (fgetpos64)
-
+#endif
/*------------------------------------------------------------- fsetpos */
static int
gprofng_fsetpos (int(real_fsetpos) (FILE *, const fpos_t *),
@@ -3087,8 +3089,9 @@ DCL_FUNC_VER (DCL_FSETPOS64, fsetpos64_2_17, fsetpos64@GLIBC_2.17)
DCL_FUNC_VER (DCL_FSETPOS64, fsetpos64_2_2_5, fsetpos64@GLIBC_2.2.5)
DCL_FUNC_VER (DCL_FSETPOS64, fsetpos64_2_2, fsetpos64@GLIBC_2.2)
DCL_FUNC_VER (DCL_FSETPOS64, fsetpos64_2_1, fsetpos64@GLIBC_2.1)
+#if !defined(__USE_LARGEFILE64)
DCL_FSETPOS64 (fsetpos64)
-
+#endif
/*------------------------------------------------------------- fsync */
int
fsync (int fildes)
--
2.41.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] gprofng: Fix build with 64bit file offset on 32bit machines
2023-07-31 22:31 [PATCH] gprofng: Fix build with 64bit file offset on 32bit machines Khem Raj
@ 2023-08-01 18:05 ` Vladimir Mezentsev
2023-08-01 18:10 ` Khem Raj
0 siblings, 1 reply; 4+ messages in thread
From: Vladimir Mezentsev @ 2023-08-01 18:05 UTC (permalink / raw)
To: Khem Raj, binutils
Hi Khem,
Please check it in.
Thank you for the fix gprofng.
-Vladimir
On 7/31/23 15:31, Khem Raj via Binutils wrote:
> gprofng/ChangeLog
> 2023-07-31 Khem Raj <raj.khem@gmail.com>
>
> * libcollector/iotrace.c: Define open64, fgetpos64, and fsetpos64
> only when __USE_LARGEFILE64 and __USE_FILE_OFFSET64 are not
> defined.
> ---
> gprofng/libcollector/iotrace.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/gprofng/libcollector/iotrace.c b/gprofng/libcollector/iotrace.c
> index c0ea7497b09..81c844048d9 100644
> --- a/gprofng/libcollector/iotrace.c
> +++ b/gprofng/libcollector/iotrace.c
> @@ -1030,8 +1030,9 @@ gprofng_open64 (int(real_open64) (const char *, int, ...),
> }
>
> DCL_FUNC_VER (DCL_OPEN64, open64_2_2, open64@GLIBC_2.2)
> +#if !defined(__USE_LARGEFILE64)
> DCL_OPEN64 (open64)
> -
> +#endif
>
> #define F_ERROR_ARG 0
> #define F_INT_ARG 1
> @@ -2989,8 +2990,9 @@ DCL_FUNC_VER (DCL_FGETPOS64, fgetpos64_2_17, fgetpos64@GLIBC_2.17)
> DCL_FUNC_VER (DCL_FGETPOS64, fgetpos64_2_2_5, fgetpos64@GLIBC_2.2.5)
> DCL_FUNC_VER (DCL_FGETPOS64, fgetpos64_2_2, fgetpos64@GLIBC_2.2)
> DCL_FUNC_VER (DCL_FGETPOS64, fgetpos64_2_1, fgetpos64@GLIBC_2.1)
> +#if !defined(__USE_LARGEFILE64)
> DCL_FGETPOS64 (fgetpos64)
> -
> +#endif
> /*------------------------------------------------------------- fsetpos */
> static int
> gprofng_fsetpos (int(real_fsetpos) (FILE *, const fpos_t *),
> @@ -3087,8 +3089,9 @@ DCL_FUNC_VER (DCL_FSETPOS64, fsetpos64_2_17, fsetpos64@GLIBC_2.17)
> DCL_FUNC_VER (DCL_FSETPOS64, fsetpos64_2_2_5, fsetpos64@GLIBC_2.2.5)
> DCL_FUNC_VER (DCL_FSETPOS64, fsetpos64_2_2, fsetpos64@GLIBC_2.2)
> DCL_FUNC_VER (DCL_FSETPOS64, fsetpos64_2_1, fsetpos64@GLIBC_2.1)
> +#if !defined(__USE_LARGEFILE64)
> DCL_FSETPOS64 (fsetpos64)
> -
> +#endif
> /*------------------------------------------------------------- fsync */
> int
> fsync (int fildes)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] gprofng: Fix build with 64bit file offset on 32bit machines
2023-08-01 18:05 ` Vladimir Mezentsev
@ 2023-08-01 18:10 ` Khem Raj
2023-08-02 4:03 ` Vladimir Mezentsev
0 siblings, 1 reply; 4+ messages in thread
From: Khem Raj @ 2023-08-01 18:10 UTC (permalink / raw)
To: Vladimir Mezentsev, binutils
[-- Attachment #1.1.1: Type: text/plain, Size: 2253 bytes --]
On 8/1/23 11:05 AM, Vladimir Mezentsev wrote:
> Hi Khem,
>
> Please check it in.
>
I don't have write access. Someone needs to install it for me.
> Thank you for the fix gprofng.
> -Vladimir
>
> On 7/31/23 15:31, Khem Raj via Binutils wrote:
>> gprofng/ChangeLog
>> 2023-07-31 Khem Raj <raj.khem@gmail.com>
>>
>> * libcollector/iotrace.c: Define open64, fgetpos64, and fsetpos64
>> only when __USE_LARGEFILE64 and __USE_FILE_OFFSET64 are not
>> defined.
>> ---
>> gprofng/libcollector/iotrace.c | 9 ++++++---
>> 1 file changed, 6 insertions(+), 3 deletions(-)
>>
>> diff --git a/gprofng/libcollector/iotrace.c
>> b/gprofng/libcollector/iotrace.c
>> index c0ea7497b09..81c844048d9 100644
>> --- a/gprofng/libcollector/iotrace.c
>> +++ b/gprofng/libcollector/iotrace.c
>> @@ -1030,8 +1030,9 @@ gprofng_open64 (int(real_open64) (const char *,
>> int, ...),
>> }
>> DCL_FUNC_VER (DCL_OPEN64, open64_2_2, open64@GLIBC_2.2)
>> +#if !defined(__USE_LARGEFILE64)
>> DCL_OPEN64 (open64)
>> -
>> +#endif
>> #define F_ERROR_ARG 0
>> #define F_INT_ARG 1
>> @@ -2989,8 +2990,9 @@ DCL_FUNC_VER (DCL_FGETPOS64, fgetpos64_2_17,
>> fgetpos64@GLIBC_2.17)
>> DCL_FUNC_VER (DCL_FGETPOS64, fgetpos64_2_2_5, fgetpos64@GLIBC_2.2.5)
>> DCL_FUNC_VER (DCL_FGETPOS64, fgetpos64_2_2, fgetpos64@GLIBC_2.2)
>> DCL_FUNC_VER (DCL_FGETPOS64, fgetpos64_2_1, fgetpos64@GLIBC_2.1)
>> +#if !defined(__USE_LARGEFILE64)
>> DCL_FGETPOS64 (fgetpos64)
>> -
>> +#endif
>> /*-------------------------------------------------------------
>> fsetpos */
>> static int
>> gprofng_fsetpos (int(real_fsetpos) (FILE *, const fpos_t *),
>> @@ -3087,8 +3089,9 @@ DCL_FUNC_VER (DCL_FSETPOS64, fsetpos64_2_17,
>> fsetpos64@GLIBC_2.17)
>> DCL_FUNC_VER (DCL_FSETPOS64, fsetpos64_2_2_5, fsetpos64@GLIBC_2.2.5)
>> DCL_FUNC_VER (DCL_FSETPOS64, fsetpos64_2_2, fsetpos64@GLIBC_2.2)
>> DCL_FUNC_VER (DCL_FSETPOS64, fsetpos64_2_1, fsetpos64@GLIBC_2.1)
>> +#if !defined(__USE_LARGEFILE64)
>> DCL_FSETPOS64 (fsetpos64)
>> -
>> +#endif
>> /*-------------------------------------------------------------
>> fsync */
>> int
>> fsync (int fildes)
>
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 2613 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 203 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] gprofng: Fix build with 64bit file offset on 32bit machines
2023-08-01 18:10 ` Khem Raj
@ 2023-08-02 4:03 ` Vladimir Mezentsev
0 siblings, 0 replies; 4+ messages in thread
From: Vladimir Mezentsev @ 2023-08-02 4:03 UTC (permalink / raw)
To: Khem Raj, binutils
[-- Attachment #1: Type: text/plain, Size: 211 bytes --]
On 8/1/23 11:10, Khem Raj wrote:
> On 8/1/23 11:05 AM, Vladimir Mezentsev wrote:
>> Hi Khem,
>>
>> Please check it in.
>>
>
> I don't have write access. Someone needs to install it for me.
I did.
-Vladimir
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-08-02 4:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-31 22:31 [PATCH] gprofng: Fix build with 64bit file offset on 32bit machines Khem Raj
2023-08-01 18:05 ` Vladimir Mezentsev
2023-08-01 18:10 ` Khem Raj
2023-08-02 4:03 ` Vladimir Mezentsev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).