public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: vladimir.mezentsev@oracle.com
To: binutils@sourceware.org
Cc: Vladimir Mezentsev <vladimir.mezentsev@oracle.com>
Subject: [PATCH] gprofng: Set LD_LIBRARY_PATH, GPROFNG_SYSCONFDIR for all tests
Date: Fri, 25 Aug 2023 08:07:03 -0700	[thread overview]
Message-ID: <20230825150703.3414527-1-vladimir.mezentsev@oracle.com> (raw)

From: Vladimir Mezentsev <vladimir.mezentsev@oracle.com>

Several gprofng tests failed when we built but didn't install gprofng.
We set LD_LIBRARY_PATH, GPROFNG_SYSCONFDIR to find our libraries and
configuration file.
These variables must be set for all gprofng tests.

gprofng/ChangeLog
2023-08-24  Vladimir Mezentsev  <vladimir.mezentsev@oracle.com>

	* testsuite/config/default.exp: Set LD_LIBRARY_PATH, GPROFNG_SYSCONFDIR.
	* testsuite/lib/Makefile.skel: Move LD_LIBRARY_PATH and
	GPROFNG_SYSCONFDIR setting in testsuite/config/default.exp.
---
 gprofng/testsuite/config/default.exp | 4 ++++
 gprofng/testsuite/lib/Makefile.skel  | 5 -----
 2 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/gprofng/testsuite/config/default.exp b/gprofng/testsuite/config/default.exp
index 1c862d54592..f23cb811fce 100644
--- a/gprofng/testsuite/config/default.exp
+++ b/gprofng/testsuite/config/default.exp
@@ -36,6 +36,10 @@ if { "$CHECK_TARGET" == "check-install" } {
     set ::env(GPROFNG) "$PREFIX/bin/gprofng"
 } else {
     set ::env(GPROFNG) "$BUILDDIR/src/gprofng"
+    set ::env(LD_LIBRARY_PATH) "$BUILDDIR/src"
+
+    # Set GPROFNG_SYSCONFDIR to find out gprofng.rc:
+    set ::env(GPROFNG_SYSCONFDIR) "$srcdir/../src"
 }
 
 set TEST_TIMEOUT 300
diff --git a/gprofng/testsuite/lib/Makefile.skel b/gprofng/testsuite/lib/Makefile.skel
index 5a30966c1cd..9ccc0340c10 100644
--- a/gprofng/testsuite/lib/Makefile.skel
+++ b/gprofng/testsuite/lib/Makefile.skel
@@ -39,11 +39,6 @@ DISPLAY	    = $(GPROFNG) display text
 EXPERIMENT  = test.er
 DISPLAY_LOG = display.log
 
-export LD_LIBRARY_PATH := $(BUILDDIR)/src
-
-# Set GPROFNG_SYSCONFDIR to find out gprofng.rc:
-export GPROFNG_SYSCONFDIR := $(srcdir)/../../../src
-
 .PHONY: all collect compare clobber clean
 
 all: compare
-- 
2.31.1


                 reply	other threads:[~2023-08-25 15:07 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230825150703.3414527-1-vladimir.mezentsev@oracle.com \
    --to=vladimir.mezentsev@oracle.com \
    --cc=binutils@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).