From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by sourceware.org (Postfix) with ESMTP id F0F86385828E for ; Fri, 15 Sep 2023 03:52:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F0F86385828E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=loongson.cn Received: from loongson.cn (unknown [111.9.175.10]) by gateway (Coremail) with SMTP id _____8Ax1fDx1ANl1hMoAA--.11722S3; Fri, 15 Sep 2023 11:52:17 +0800 (CST) Received: from localhost.localdomain (unknown [111.9.175.10]) by localhost.localdomain (Coremail) with SMTP id AQAAf8AxH93v1ANlhGIGAA--.14295S2; Fri, 15 Sep 2023 11:52:15 +0800 (CST) From: Jinyang He To: Chenghua Xu , Zhensong Liu , mengqinggang Cc: WANG Xuerui , Xi Ruoyao , binutils@sourceware.org, Xing Li , Jinyang He Subject: [PATCH] Avoid unused space in .rela.dyn if sec was discarded Date: Fri, 15 Sep 2023 11:52:14 +0800 Message-Id: <20230915035214.29178-1-hejinyang@loongson.cn> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID:AQAAf8AxH93v1ANlhGIGAA--.14295S2 X-CM-SenderInfo: pkhmx0p1dqwqxorr0wxvrqhubq/ X-Coremail-Antispam: 1Uk129KBj93XoWxArykXry8tr4xtw48Xr48Xwc_yoW5uF4Up3 srZFyFk3W8XFnrWr98W3y5Zrn5GrZ7CF1Sva4IgFWI9rnIqryrXw1Fy3y3JF43J3yUtryF vFy0q345uFn5twcCm3ZEXasCq-sJn29KB7ZKAUJUUUU8529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29KBjDU 0xBIdaVrnRJUUUkFb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2 IYs7xG6rWj6s0DM7CIcVAFz4kK6r1Y6r17M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48v e4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Jr0_JF4l84ACjcxK6xIIjxv20xvEc7CjxVAFwI 0_Jr0_Gr1l84ACjcxK6I8E87Iv67AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVCY1x0267AK xVW8Jr0_Cr1UM2AIxVAIcxkEcVAq07x20xvEncxIr21l57IF6xkI12xvs2x26I8E6xACxx 1l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r106r15McIj6I8E87Iv 67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IYc2Ij64vIr41l42xK82IYc2 Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s02 6x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r1q6r43MIIYrxkI7VAKI48JMIIF0x vE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14v26r1j6r4UMIIF0xvE 42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv6x kF7I0E14v26r1j6r4UYxBIdaVFxhVjvjDU0xZFpf9x07jUsqXUUUUU= X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: The relsec size is still increased although sec is discarded, which cause a lot of unused space allocated. Avoid size increased if sec was discarded. bfd/ChangeLog: * bfd/elfnn-loongarch.c: (allocate_dynrelocs): Do not increase sreloc size when discarded_section. ld/ChangeLog: * ld/testsuite/ld-loongarch-elf/ld-loongarch-elf.exp: Add test. * ld/testsuite/ld-loongarch-elf/pie_discard.d: New test. * ld/testsuite/ld-loongarch-elf/pie_discard.s: New test. * ld/testsuite/ld-loongarch-elf/pie_discard.t: New test. --- bfd/elfnn-loongarch.c | 2 ++ ld/testsuite/ld-loongarch-elf/ld-loongarch-elf.exp | 2 ++ ld/testsuite/ld-loongarch-elf/pie_discard.d | 10 ++++++++++ ld/testsuite/ld-loongarch-elf/pie_discard.s | 9 +++++++++ ld/testsuite/ld-loongarch-elf/pie_discard.t | 9 +++++++++ 5 files changed, 32 insertions(+) create mode 100644 ld/testsuite/ld-loongarch-elf/pie_discard.d create mode 100644 ld/testsuite/ld-loongarch-elf/pie_discard.s create mode 100644 ld/testsuite/ld-loongarch-elf/pie_discard.t diff --git a/bfd/elfnn-loongarch.c b/bfd/elfnn-loongarch.c index 70a666283af..5d10fee3560 100644 --- a/bfd/elfnn-loongarch.c +++ b/bfd/elfnn-loongarch.c @@ -1228,6 +1228,8 @@ allocate_dynrelocs (struct elf_link_hash_entry *h, void *inf) for (p = h->dyn_relocs; p != NULL; p = p->next) { + if (discarded_section(p->sec)) + continue; asection *sreloc = elf_section_data (p->sec)->sreloc; sreloc->size += p->count * sizeof (ElfNN_External_Rela); } diff --git a/ld/testsuite/ld-loongarch-elf/ld-loongarch-elf.exp b/ld/testsuite/ld-loongarch-elf/ld-loongarch-elf.exp index b95cc53e597..637e4c3fcff 100644 --- a/ld/testsuite/ld-loongarch-elf/ld-loongarch-elf.exp +++ b/ld/testsuite/ld-loongarch-elf/ld-loongarch-elf.exp @@ -56,3 +56,5 @@ if [istarget "loongarch64-*-*"] { ] \ ] } + +run_dump_test "pie_discard" diff --git a/ld/testsuite/ld-loongarch-elf/pie_discard.d b/ld/testsuite/ld-loongarch-elf/pie_discard.d new file mode 100644 index 00000000000..7b8630912b5 --- /dev/null +++ b/ld/testsuite/ld-loongarch-elf/pie_discard.d @@ -0,0 +1,10 @@ +#source: pie_discard.s +#ld: -pie -e 0 -T pie_discard.t +#readelf: -rW + +#... +Relocation section '\.rela\.dyn' .* 1 .* +#... +.*R_LARCH_RELATIVE.* +#pass + diff --git a/ld/testsuite/ld-loongarch-elf/pie_discard.s b/ld/testsuite/ld-loongarch-elf/pie_discard.s new file mode 100644 index 00000000000..82b88fc1e48 --- /dev/null +++ b/ld/testsuite/ld-loongarch-elf/pie_discard.s @@ -0,0 +1,9 @@ + .text + .global sym +sym: nop + + .section .data,"aw" + .dword sym + + .section .discard,"aw" + .dword sym diff --git a/ld/testsuite/ld-loongarch-elf/pie_discard.t b/ld/testsuite/ld-loongarch-elf/pie_discard.t new file mode 100644 index 00000000000..49e52cdb4b1 --- /dev/null +++ b/ld/testsuite/ld-loongarch-elf/pie_discard.t @@ -0,0 +1,9 @@ +SECTIONS +{ + . = SEGMENT_START("text-segment", 0) + SIZEOF_HEADERS; + .rela.dyn : { *(.rela.*) } + .text : { *(.text) } + . = DATA_SEGMENT_ALIGN (CONSTANT (MAXPAGESIZE), CONSTANT (COMMONPAGESIZE)); + .data : { *(.data) } + /DISCARD/ : { *(.discard) } +} -- 2.41.0