From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id CEC5D3858D1E for ; Wed, 20 Sep 2023 23:04:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CEC5D3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 38KKJ3u6021128 for ; Wed, 20 Sep 2023 23:04:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : content-transfer-encoding : content-type : mime-version; s=corp-2023-03-30; bh=khUoLosnWq3lSfAfiCj4z6inSTYi05Ozzvww4gquudE=; b=K6Owz2MHQIHHcjxlNxhbQsOcZiNIQlqqeGEAzB7OrC7R0ICqfXNpd4X4NmCPrBgc7Qbu l7so0ad5C0YSgNJAbe8pwfixoForBwWG/Cap3dNz+2//OMbHSccXlRRGWyYqfUJ0SyQx V1UucU3zJfbviTDxbdgCBbepPRWpu7BGtlX/JNWNwi4TwWhC0e5XOQIM2l8ENKpkHxp+ wGVLeVsSKROOuGP/DHQi/jBCE66pOCaf3PCXOVJ1kz1+g2GSmJGCQ7C1ySg8d8QzdXjg VS9gUSR9tWZ87ZvP6TTBAKDSdAVpwi1YH9L6SMkVzLy8OFxE93zXQ6WZVEp6+19jiyUq IQ== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3t53yu8gjj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 20 Sep 2023 23:04:29 +0000 Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 38KM5ipu030244 for ; Wed, 20 Sep 2023 23:04:28 GMT Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2045.outbound.protection.outlook.com [104.47.66.45]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3t52t7rd8s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 20 Sep 2023 23:04:28 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cbo5zffGp6zW4AEXJ2BXxv6LYLLPspLvN4M8LwydxHqwdOFj16vuaRA7Kj0685EeMbJjwQ1QQvAVvWCwctizL+KumYNDCSM2zcfuE3snVfQpljCCNY8r6bxukP8w8SV05pQjYJXAmRnxgzlL3uKiLhpSpwkEIFLFzbtwRDKXkVfaUxTBp+dkCInQSqJFpQ6v0cixrOg5uYTjeJqWauNn6igxux8VhQvQAZd7JBz06gn+gXVJCdd8YkUGy1hghNHJrL0Iyscn2ZZGzsNmov+MlyBYItnhN2XF+RLyjzrAciqfdFybbir9ErYPve3vMBNHE+Rpefp02qPNY6kJcyEpoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=khUoLosnWq3lSfAfiCj4z6inSTYi05Ozzvww4gquudE=; b=aCfqGzNbcA4LMCJm5HRnYczi/v2VqSrmPwpzH3t91PcS4j/sC5er2LG3tVBN4SU+lMZ1gxk/jB8s/kSrdGdD2e6eMY0ipUjBdDuMLjdukNOua2qYSLCTTVjsETtXkaZDPPFHcKtigui5dQflGx9ZfJsphwAvNWGPhLOobmubGD2eO3Ia8CvnMrnfQm64Bq+HdW7r5DNK4fQiSUUEYEwCTrYgwkVQnaueyphAysDCO/GbPYwegXmpHjSt27BgodpXT8EUTFwzwY2aQLZ2fF45f1EWvAfgoXGUZlI5Az9YGGkd5ESf/hg9LgB4VTtpu1ngCqX35kPugMxdqO6UnRFbUQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=khUoLosnWq3lSfAfiCj4z6inSTYi05Ozzvww4gquudE=; b=XD2nJzVIMPJn45mDpTuqrnopqMM/3aLBXD5+AXsN3eY3P0QrlzycofWdnIrJaJQiP5+i6GOja+Iu4cG70tJqPr5P/lXkI1eZpN/jPtHmbmZqYYFgmAV7bhkXyq0+dg4TL79dzNW70cOrI1ddme0DLVON1fU6eP21toly2Tr3K0o= Received: from MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) by CO6PR10MB5553.namprd10.prod.outlook.com (2603:10b6:303:140::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6768.38; Wed, 20 Sep 2023 23:04:26 +0000 Received: from MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::44f7:ba76:db28:606e]) by MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::44f7:ba76:db28:606e%3]) with mapi id 15.20.6813.017; Wed, 20 Sep 2023 23:04:26 +0000 From: Indu Bhagat To: binutils@sourceware.org Cc: Indu Bhagat Subject: [PATCH,RFC 1/9] gas: dw2gencfi: minor rejig for cfi_sections_set and all_cfi_sections Date: Wed, 20 Sep 2023 16:03:53 -0700 Message-ID: <20230920230401.1739139-2-indu.bhagat@oracle.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230920230401.1739139-1-indu.bhagat@oracle.com> References: <20230920230401.1739139-1-indu.bhagat@oracle.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: MW4PR04CA0325.namprd04.prod.outlook.com (2603:10b6:303:82::30) To MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2158:EE_|CO6PR10MB5553:EE_ X-MS-Office365-Filtering-Correlation-Id: 8b3da042-75cb-421e-0f85-08dbba2def9b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ja63ZVxeiMwLThFP5Wus+PpTTJEgvjdoZZoxLSjFbR5MAimgDrVaLFNjm/oe1t4bdlyyoGIGdJufQInUO5ob4cBLOLd3z7Uhz+XqZmBGj/r2w76Lv/QwWBy5WVrt75AgQYyLxikmusLy88hTIkh+OhQU+fX6ZkkwVBFcYun5jnlxs+6iFn/orRfD4d+vdUnmohMWyu0BYbCJGObhDdfYwZgrLHbg20UW7O+YoYllzcHCe+K3wMj0XuJpvnSYRxpCwLhgiFj2DnfqOeX+K0qa3Cvx+hgJ4MGTo6F7Z8TppkD/Dn/Ni06/NS7wAiSNDTQifxNsykQ/RSesikKF+N6gmEhze8pc4BHVngsLVLuE3Co2YpImfuv3RzvIwK2CyGOQd3UhYkOzKsXQKD726q9WVh8bopxT/v5N5dCSD0mfTGLjoMaJ91fEzqdcZyaGeRZi1XVFwTzfS3RWIwovpBZTNZykm4Ki9xOcNTIzd/dMAlVViC9Gud6WUznvtJhiaufyVQoEOBY4YWfeQ7gCe+J2YnjR3xG2K2gvO58YO+eiL3aAGcIFoS7u9zzVwjd7+l/A X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2158.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(346002)(376002)(136003)(366004)(39860400002)(396003)(451199024)(186009)(1800799009)(6666004)(41300700001)(8936002)(5660300002)(8676002)(66946007)(2906002)(316002)(6916009)(38100700002)(66556008)(478600001)(66476007)(86362001)(4326008)(44832011)(1076003)(83380400001)(6506007)(2616005)(107886003)(6486002)(36756003)(6512007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?/JsBoiQhkyu7OxtngakqDNZ/z/0R+lBJ6gbE4NwjJeWDucR4K0hvFjVtltf1?= =?us-ascii?Q?wRQ4v8b5M9W1m6wVGKxCDJU+FNjDYWET7RKXskql5p35c+SE0/8VYIGUXR1S?= =?us-ascii?Q?e1OxJ32nN0r2jI4V2R7xssQQcTFrB0778g/mTIoDxmsTBTAWcp2ErUso6gJM?= =?us-ascii?Q?Fo/4zrc7Zb91kcV78cT3q27FfPL6vcXa4hcK2/xInzp+phj3a5XXrZLmjANc?= =?us-ascii?Q?rhNXNkn188qdayRbgnbr4Jb0XLx7owVz/2ANlyrvu9b03XMmcqVrJ/UoQShT?= =?us-ascii?Q?WB2h6ZA+ofhOtYimV863W4iHt9ZQD9cx7xKgt1i356RxQYwRB+q6Dy/RQoX2?= =?us-ascii?Q?EyRhkTEogWUBbUmn9tugBffkdM+Rmx4T68b7rL3wzvi3nqTr58VlUG8Pftx2?= =?us-ascii?Q?oI4vQtKxPWk6r/UlpVCBZOFWxftnuaJ6bquGSUmJ/5qW+FWdSmU4Z5pTsysj?= =?us-ascii?Q?wpPX5r2uFquEFdT/7ihsYRoNFbMB47FAUpo0feIxojKsJ3lbtJOQzXMDSCkR?= =?us-ascii?Q?b6x8DEInwGuKA2iAuCT2aUjNEgvOYqjFzvFcJFyXERrTHFlyRCQ8COR3EP74?= =?us-ascii?Q?pZRXHW4nUNwRWbDwPfz03dj9v1l1DxoJ4ooANfwPg6zXx6sGyyBazpXXhRXv?= =?us-ascii?Q?NdFNpZCLKTKcs56RBNNeji8phDycFJHaC3Dpa9lP2wZ6IIFi2Et7KONtMitP?= =?us-ascii?Q?M9wbQKwYs9zkBvGXlKrUkKiNb21vPAuYQ/Orq23iUdQxfyKdYmeUV0JY55e9?= =?us-ascii?Q?rXFttUjen7KqUUfvMoCZ4ONHwcCP72bG5X98DrvrFi8P6KLAwvcEB+Fx4hvp?= =?us-ascii?Q?I4/aMnIKHtIOeb3nFKTDyBGJhieWOTlj0BxhzkcGzq+rYM5h5kp4Er+x+CXp?= =?us-ascii?Q?tQwL10K/H4udG9yc9zN74V3uaKrxqJFa+pZAYfcQ0O1amzCPoauvWkHdv5EU?= =?us-ascii?Q?pL9koV7iN/QBBJ9ovMuUSByCz2WoKzy1bzVnLFy5V0BIQ5xhFokSOArRl0Rl?= =?us-ascii?Q?A9OzgKXI5zD8vL2+IiGwuGMzIjqeJLjNpzFUF3nR79fTHrzETmK7mLpo6gj8?= =?us-ascii?Q?YXSUovpv7EFES238FnGjGRRScW+Sar9X4glWzqPJBgg5ieRRleUkoVJrtVDZ?= =?us-ascii?Q?yBk6PXpQEOjn86+4Q+enj0ycmYBk7Pjl5l+rFSteqWS8FF/vs/yGn1KNZYVD?= =?us-ascii?Q?ioVeHl7pSI9EqrwgeHIkDlvv7WWh7EVlXRB6K8uyesNEpZGH9ybe3/YzDJFA?= =?us-ascii?Q?9E1UMFqOUv9ePp4HJyBE/X9hPiqL0c38RYP1dHx62a0wtqarERSORS2rQT+W?= =?us-ascii?Q?5CzqizALa6YIEq9YCNuKOWPwk+j3vB2R0CWW/ahkZC1ISVfIXA4fQCj4U8/O?= =?us-ascii?Q?wXipDjRCXAjK2bFlCd/A4eupWa8g0SPLRIBZ0E+28Qa5ZkPXRLLImE9mFH0l?= =?us-ascii?Q?/nFRX/KglP2AZhYr9ZvJhn0NrrK3y4QZmRjnZtNJxio5BTjkRigMgzLmBTsN?= =?us-ascii?Q?89jJvORobvLPR14gz/LUl3sghdITR+tTfZBB7DxqbJ4hf1GN+3wJ/t+lEa1Y?= =?us-ascii?Q?R7JxADq+sn6HkD81iWotv5BrvsG6FMdwJUv95lcsaJu60moAY+m9kfHHLspp?= =?us-ascii?Q?ks4KVnVV3dMIC9thP3w21+Y=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: MMZoxqHuRTd5k28GQQMrVFTYg7AoeW2gqzBdiUzlehFLHmklTd4YAjMx11FGNoyhkiwPcKsYFXyo7PgLWohN+bsJqSSUU6D11FNP7xv9p+CmrTQBplUccz3Ytit7yoG3nCx+nWb8fwQKlYwHFdXpnbJkuQAVMx3qHf1H5Oc8jzGUTZ5QRuIZE5y66WSY3ONbWEYQnTmdl20czJcu09xkfj4r6y5aoGxBLW3Q48xPVqCqC5ZvCvPMiNyMCfXzKbFx/k3FUDCiAdKyWNvJrR9MjydKqnqgaZwjABU3oeuMQ2OfDLT7Y0LZK9hXqgcuE4GdnQdvqeaLcy535nh+Ca3B3m6BbmtQ2b9L8lWmQ7t4EGK1szfBanZ+k3qPSlO6vHT6GAR2jova7iyGEBj1rCjJv8lt85qfyqdxiQUXpAD5yqybySq9N7I73Z5ykHNI6kksJ1oR5Hg/VDg01Q7Awyi7I8FgsgZii0UGCCvZoXqb6LegV9PN48VEtlPr/HtFr0GTtMsvTCJvGPa7QRIMo7xkOFBiS79ZnNza4ifnZdyPLCozFJbhTm9Fti+95BBQ1/e/dUQKGNhU2t210Fyb6jNHHyToYl3cdWS3Q6iJ5vVCxEXDIJ1dbOICjX2zq/0w8iqBdlBcLLgT+wnYXXXjVcxD4dlkneDBIqJR3YDPZGt+wXPJ0yeexMKfnF0T3HM6nwBZZVIc3f38EKFAArcI2iuG/xaqqNR9UgXKBu/p1tKwx5pkr4AvldMAvjrwRFf/IXAeOYoL8srvWmrRG/WcvKtJ/w== X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8b3da042-75cb-421e-0f85-08dbba2def9b X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2158.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Sep 2023 23:04:26.1594 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: y4ZlDO6dlF1zOE7g3vhip6VuYZ/U1JDPtlQ90oKNhgaiQ6/Yh+7H1X7IrEUfeXhcJjWUbIj75IOdsMI9r5kNLQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR10MB5553 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.601,FMLib:17.11.176.26 definitions=2023-09-20_11,2023-09-20_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 adultscore=0 phishscore=0 malwarescore=0 suspectscore=0 spamscore=0 bulkscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2308100000 definitions=main-2309200193 X-Proofpoint-GUID: QbDoCB5STqjAFg_EHrHVhWLIArc2ic8i X-Proofpoint-ORIG-GUID: QbDoCB5STqjAFg_EHrHVhWLIArc2ic8i X-Spam-Status: No, score=-13.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: - cfi_sections_set is best set to true in cfi_dot_startproc (). Setting it to true again in other APIs (dot_cfi_endproc, dot_cfi_fde_data, and cfi_finish) is unnecessary. - move setting the global var all_cfi_sections into cfi_set_sections (). gas/ * dw2gencfi.c (cfi_set_sections): Set cfi_sections_set and cfi_sections here. (dot_cfi_startproc): Remove unnecessarily setting cfi_set_sections to true. (dot_cfi_endproc): Likewise. (dot_cfi_fde_data): Likewise. (cfi_finish): Likewise. --- gas/dw2gencfi.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/gas/dw2gencfi.c b/gas/dw2gencfi.c index f57479457c4..cbfee0a0169 100644 --- a/gas/dw2gencfi.c +++ b/gas/dw2gencfi.c @@ -492,6 +492,7 @@ cfi_set_return_column (unsigned regno) void cfi_set_sections (void) { + all_cfi_sections |= cfi_sections; frchain_now->frch_cfi_data->cur_fde_data->sections = all_cfi_sections; cfi_sections_set = true; } @@ -1309,9 +1310,8 @@ dot_cfi_startproc (int ignored ATTRIBUTE_UNUSED) } demand_empty_rest_of_line (); - cfi_sections_set = true; - all_cfi_sections |= cfi_sections; cfi_set_sections (); + frchain_now->frch_cfi_data->cur_cfa_offset = 0; if (!simple) tc_cfi_frame_initial_instructions (); @@ -1336,7 +1336,6 @@ dot_cfi_endproc (int ignored ATTRIBUTE_UNUSED) demand_empty_rest_of_line (); - cfi_sections_set = true; if ((cfi_sections & CFI_EMIT_target) != 0) tc_cfi_endproc (last_fde); } @@ -1418,7 +1417,6 @@ dot_cfi_fde_data (int ignored ATTRIBUTE_UNUSED) last_fde = frchain_now->frch_cfi_data->cur_fde_data; - cfi_sections_set = true; if ((cfi_sections & CFI_EMIT_target) != 0 || (cfi_sections & CFI_EMIT_eh_frame_compact) != 0) { @@ -2315,7 +2313,6 @@ cfi_finish (void) if (all_fde_data == 0) return; - cfi_sections_set = true; if ((all_cfi_sections & CFI_EMIT_eh_frame) != 0 || (all_cfi_sections & CFI_EMIT_eh_frame_compact) != 0) { @@ -2502,7 +2499,6 @@ cfi_finish (void) flag_traditional_format = save_flag_traditional_format; } - cfi_sections_set = true; /* Generate SFrame section if the user specifies: - the command line option to gas, or - .sframe in the .cfi_sections directive. */ @@ -2524,7 +2520,6 @@ cfi_finish (void) as_bad (_(".sframe not supported for target")); } - cfi_sections_set = true; if ((all_cfi_sections & CFI_EMIT_debug_frame) != 0) { int alignment = ffs (DWARF2_ADDR_SIZE (stdoutput)) - 1; -- 2.41.0