From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 40DBE385828E for ; Tue, 26 Sep 2023 02:13:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 40DBE385828E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695694381; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+ID9cjf/55158aco/Ihh3AtkfB3K3qQSqTWNA53D1jM=; b=Rt0G/2gXIgoG6BhSyE+FbjfNctThuilQtRQgRpb4a2llI7ir2xb4KGhCx7BCGzUlFvPZU2 hN2vMuks96wZ85qaUJ0+UPGYdN8Qyp3+SnAcEEIYRCXsnkIm6aVHPpwtLIEeAHq6f+dBEX /jF8ZgwK1YKHZobtLBGGg/p99hfGq9s= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-367-1MaLboyINHWV5D2KZE3Jkw-1; Mon, 25 Sep 2023 22:12:58 -0400 X-MC-Unique: 1MaLboyINHWV5D2KZE3Jkw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 095A585A5BE; Tue, 26 Sep 2023 02:12:58 +0000 (UTC) Received: from f37-zws-nv (unknown [10.22.32.95]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6083610EE402; Tue, 26 Sep 2023 02:12:57 +0000 (UTC) Date: Mon, 25 Sep 2023 19:12:56 -0700 From: Kevin Buettner To: Arsen =?UTF-8?Q?Arsenovi=C4=87?= via Binutils Cc: Arsen =?UTF-8?Q?Arsenovi=C4=87?= , gdb-patches@sourceware.org, Bruno Haible , Iain Sandoe Subject: Re: [PATCH v2 1/2] *: add modern gettext support Message-ID: <20230925191256.2b11bf4a@f37-zws-nv> In-Reply-To: <20230926004300.1716711-3-arsen@aarsen.me> References: <20230926004300.1716711-2-arsen@aarsen.me> <20230926004300.1716711-3-arsen@aarsen.me> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-10.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, 26 Sep 2023 02:17:33 +0200 Arsen Arsenovi=C4=87 via Binutils wrote: > gdb/acinclude.m4 | 3 +- > gdbsupport/Makefile.am | 5 + [...] > diff --git a/gdb/acinclude.m4 b/gdb/acinclude.m4 > index 173e40b440a..d505fbbb267 100644 > --- a/gdb/acinclude.m4 > +++ b/gdb/acinclude.m4 > @@ -235,7 +235,8 @@ AC_DEFUN([GDB_AC_CHECK_BFD], [ > # always want our bfd. > CFLAGS=3D"-I${srcdir}/../include -I../bfd -I${srcdir}/../bfd $CFLAGS" > LDFLAGS=3D"-L../bfd -L../libiberty $LDFLAGS" > - intl=3D`echo $LIBINTL | sed 's,${top_builddir}/,,g'` > + # LTLIBINTL because we use libtool as CC below. > + intl=3D"$(echo "$LTLIBINTL" | sed 's,\$[[{(]top_builddir[)}]]/,,')" > LIBS=3D"-lbfd -liberty $intl $LIBS" > CC=3D"./libtool --quiet --mode=3Dlink $CC" > AC_CACHE_CHECK( > diff --git a/gdbsupport/Makefile.am b/gdbsupport/Makefile.am > index 00524e9a566..f1a641308fe 100644 > --- a/gdbsupport/Makefile.am > +++ b/gdbsupport/Makefile.am > @@ -20,6 +20,11 @@ > AUTOMAKE_OPTIONS =3D no-dist foreign > ACLOCAL_AMFLAGS =3D -I . -I ../config > =20 > +# Suppress 'configure.ac: error: AM_GNU_GETTEXT used but SUBDIRS not def= ined' > +# from Automake, as gdbsupport uses AM_GNU_GETTEXT through > +# ZW_GNU_GETTEXT_SISTER_DIR, but doesn't have any translations (currentl= y). > +SUBDIRS =3D > + > AM_CPPFLAGS =3D -I$(srcdir)/../include -I$(srcdir)/../gdb \ > -I../gnulib/import -I$(srcdir)/../gnulib/import \ > -I.. -I$(srcdir)/.. $(INCINTL) -I../bfd -I$(srcdir)/../bfd \ The GDB portions look reasonable to me, so those parts are approved. You'l= l still need to get approval for all of the other areas though. Approved-by: Kevin Buettner (GDB portions only.)