From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id 2148A3858C41 for ; Thu, 26 Oct 2023 19:13:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2148A3858C41 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2148A3858C41 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=205.220.177.32 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1698347630; cv=pass; b=bLRFSSvl7Qb+ZuLIVaMP90ewpdDEIU5q3LDbPl5WlXtMG2+DlLftymIrddsFpMpYPA01xdRRfCsOrdMFQYmPTJ3AiGdUOh2dAc9/a8BdtFrEBI1zUDnLwi2ev2Mtb74een9+QfMhURSEyT+a3nhotsGquHkjN0PFEwP1am6xG74= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1698347630; c=relaxed/simple; bh=N6o6SjPONl9uclQ1J/X3G0aOxR7D9yWsy3IPBbV2yIY=; h=DKIM-Signature:DKIM-Signature:From:To:Subject:Date:Message-ID: MIME-Version; b=pCXBZLAIYHlMhwNMWHRWGiTA9qRzR6yaE3tTR7afHsX1oOZQYefqmAIkSU11a32H7/LBEoWczb62arw8g6SUlAA5hqzDwOc7p6y/DUNW5aKczXJ36f0WXP13WQqyWABTGuD3sDCWCgZUm74seS5jqmXhdFEsb4Ag76PcdFPvF08= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 39QJB4TJ019240 for ; Thu, 26 Oct 2023 19:13:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : content-transfer-encoding : content-type : mime-version; s=corp-2023-03-30; bh=PuS+f4NqBLE/e7zc+xKAvVtG6sP2srMI4l0WZogeXwc=; b=wEr214AzpbMIWs/N3FhoKHKzrcW7YdFZGK8rzWLIeWf6vfqHtrleGKVxN0WbugwyeD0r tBSxZ5qfjsDIrMDBPp8VNzVqWD1akm3jLP2rG0YSYQPxU2GcPLDHb0BKDpIkoIGigVTc Vr2Ymngiy8BD5ORDczeElnQnA/Xk6NOCxmKK1Rrhw/ZF8DMg5W+rYcJcIRC9R7SGePsz 9hLYM3NVWEkS8udA3UaJRIOabVkZjPOmHIzASOTzXpadgejg8hSi8lwFeYh8IpHxAsfi muWFhEea7EfHb7wvMJXS/4ckuMwYJOkaFllB3ZkAoR7jAIKOW4IN5zyttlaOoMvUICFA Zw== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3tyx218083-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 26 Oct 2023 19:13:48 +0000 Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 39QImg8O019872 for ; Thu, 26 Oct 2023 19:13:47 GMT Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2041.outbound.protection.outlook.com [104.47.66.41]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3tywqj9062-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 26 Oct 2023 19:13:47 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VZUMZDHrbkuX1VShMWUb0e108HMmsu3LdqO/AO+IRkbyLFu0L2JbdbQY0x+iLQCPybGDflcSCJSVA2bnp2GGCZGBXRfCfZFdn1RxIJKBJuomqh1qrfQrVdYz4IB/gkv0619GH0cwqd9Bz33N9MoWvi+BlaPwjiWVOsTJiDknBnPjE2nzAPbkAoPzHp7nDeJ+uzRUdeMDQ6C2NNPV3ljWTQ71fL12m8mumlB+xCSY46ree+7g2hl/YWeSBWTb8cw9E0CTi7hxumYOXjRjDarT+qGV9HdzfQR5ltWzS0/mjrIBRZNvayCNFf0OTV+5/fZ+LwN78eZ+s5SKBR/kQWEUdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PuS+f4NqBLE/e7zc+xKAvVtG6sP2srMI4l0WZogeXwc=; b=ahp8p1td2LHlkWwcrupCzl1xsS2cUL03xbEXdf8h0rkaioxGW0IrHamWlm7XRR9hre2KcQ6U/8Z3AqWuTCw8j0lA4J2TUZ/jCpe2vL1QZaOOn86Z+wP6sfYVpGFashqRSGr4O0laf2FMN3pKgRGQ8p+SKG/K8mGZNbSwLPpgizSp3vDl7ycfe8qHQcHPgfY1JK+Zyi0Xtffwch6zWvv1GhhEFAm1TIXs/M9r/mB3w98ybrQ7ghUrqe6zUrVWcdq5yJrrHXjvkyrvd1JwSg6WKbW86atGuJzkbkQIXHQ0YuoJo+qOx6ChKO6/UUO4B/h0Uhj1IplBGo73FI6xNaHr/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PuS+f4NqBLE/e7zc+xKAvVtG6sP2srMI4l0WZogeXwc=; b=vAldp7sXub1MH9sF6D54v2TRO/JPsvpMW6EHdOG6UBO+/a2BtlHICGM7d3pwCpnyI3/mif5Xa1XhWqDvHXc1OGIjMWNN7dJFN6ycBVwLhdg+cBbKLMkIMV/wUcqIL8I2kQUGSHl9hcfNS8Qh7d4C39mm2fJOSQIu+M6aSA+KS1I= Received: from MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) by IA1PR10MB6899.namprd10.prod.outlook.com (2603:10b6:208:421::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.33; Thu, 26 Oct 2023 19:13:45 +0000 Received: from MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::7f02:c28d:9802:20fd]) by MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::7f02:c28d:9802:20fd%3]) with mapi id 15.20.6933.019; Thu, 26 Oct 2023 19:13:45 +0000 From: Indu Bhagat To: binutils@sourceware.org Cc: Indu Bhagat Subject: [PATCH,V1 1/9] gas: dw2gencfi: minor rejig for cfi_sections_set and all_cfi_sections Date: Thu, 26 Oct 2023 12:13:29 -0700 Message-ID: <20231026191337.3872149-2-indu.bhagat@oracle.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231026191337.3872149-1-indu.bhagat@oracle.com> References: <20231026191337.3872149-1-indu.bhagat@oracle.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: MW2PR16CA0006.namprd16.prod.outlook.com (2603:10b6:907::19) To MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2158:EE_|IA1PR10MB6899:EE_ X-MS-Office365-Filtering-Correlation-Id: a0c934dd-5d57-4a7b-49a8-08dbd657acd3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Be5WSPLUqcFPoF4P9H9I/cB44F6plREiTVxSCj99ILIfWsgaPRoLG8AS49bXKicjjPbIxUCDN/3aE83mr/fhq4crBok9f2QFqcwanCNctLNuroO4exuUQuS21PMdRFMocY9wfmQNYkK9HKBO5ksnNmucgxSCjHxlqlOtg5xY9KW/k8WTKlhZOGRXmzL/EThMLI7KRfzMPBnAtIUpJZaw48IqdpN40sa1HS+BU2ajrX+2HVrLaO4M6HSq9CqYSdX1HkigjL/plsFVcsCkG5vROGueA5qqLKD8v3bEIqDDdyXEkfLQVlLh9BnK/0hMum8Gvndhbycg7AKeWutrI+Wa+J0bwaV3Q/pcd1s+7klnqpOYNgChuJuhtAK5V1KruO79hXEdTIT9rUFoI+v8Cx4S2qzSium+Eib2EOABR+u0fpWD7XqeTa1y3oM1wwKgAr4k03gjC/p4Aa7QCF5laOhU3tbBnbmwPrJw0yF6TNA7pdMfzeiYKBQjBvIHRiVa/dBQoH7jwUL4g30UDXnl2sxnYEiVi1e4jXAmn4zX0WVitDXkwaduR2ghwQAKG+ZtcifZ X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2158.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(39860400002)(376002)(136003)(366004)(346002)(396003)(230922051799003)(64100799003)(1800799009)(451199024)(186009)(2616005)(66476007)(66556008)(107886003)(1076003)(83380400001)(41300700001)(6506007)(6916009)(316002)(5660300002)(6512007)(478600001)(6666004)(86362001)(66946007)(6486002)(38100700002)(2906002)(36756003)(8936002)(4326008)(44832011)(8676002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?vNNnnxKNP4dMKEf9Ro1sdVTF0Wo2IJ/Ki/GLDYlHnm11+Fi7MctnClBl5sRI?= =?us-ascii?Q?NsgVTDJt51gRoG88gPpcqIdT4JyHW+9wT3lzlBtXas+WoPFLRnKbHKJX7VcD?= =?us-ascii?Q?mbYta3ecJ+anRiAI84xw59suV09bjnWbmHjkziArXsnsufa1hGTm6me+XMHm?= =?us-ascii?Q?wldGsacJlvUkbDY/dDp+JPO1bffvfaXlspd36vu3h1JW3BWBAZbJPV+t4Xnk?= =?us-ascii?Q?3XngyY07Ye31T2d6tkUmR73waeyZ8wTYA63N1NttEgPWbt49fOHXfbEfVdQ+?= =?us-ascii?Q?x/i4Aj3fOTRXX/mkmuCZPJVtHVWhQkDXE/bSL90h8hSK/lksE3NX8a3Ty6HS?= =?us-ascii?Q?t36GhcsoKoyfU6ZK/UzszvT0D5Bsc+L/hNtWZpM1KDc7TNAOAsU3tweXlEVB?= =?us-ascii?Q?rFtK+G4nLCLhDAK2Ofuslnnp2urP6bFzbhyWrSnUxElqmtrDi7Q9X4Cb8kMF?= =?us-ascii?Q?21t1ZqQBCL3/WgR/7bB65og2+jZlJPjZtWSwX4//U6UumWjzBsNXkBLcbxjU?= =?us-ascii?Q?8leXn4yw0iBQ8iz5auI+Bnu0dsolR7FW44G4qriTpKe5kJyaa0qsmoaNVFUD?= =?us-ascii?Q?y8PsCFffy7oXzEoHX0sYYWztYqj6zNLwVRl3rbJSSG7YDw3xsw0LtzduZvUt?= =?us-ascii?Q?ItyerMQx/hNlwn1JdMRadzGsQYnkDlfaU5/ziOakJfJtHLNuLTUz2bhCKx+9?= =?us-ascii?Q?UDj9GOZqNZMsR7/JLLVplhpmAgJ1RJoyoPzrpFHFg6mIxWoUBMhC4NlAJGkp?= =?us-ascii?Q?UjTE8oG0bDbaPoy14LNwgHhhBxU7u45em4Vxrgc/2akrdTb+rCqSO9X2YoK1?= =?us-ascii?Q?Il2+JxixNCfSdgjQ3T1RY0rD8P9veCFo7QgpNz+UcK3rAlMlx3UTYH+atJ9u?= =?us-ascii?Q?TttX6oGjdHYAx68HSTcpi5PxVJ030x6U9P3DEk0/gXghALFILNfgCVCQa4oV?= =?us-ascii?Q?CSnre7Kp54rFXEN2e+KTyoEYnz1BEZo+1aXMHnVhFLoin7BvhRB5y2xKfepB?= =?us-ascii?Q?W4hSEgIb+2SXy6ct9vczwzFGM7Aimnv1iJ9FB2SUwU8C/PQpKZP8/Q/tjcJz?= =?us-ascii?Q?a2GgmIVTtLLgOm+XjHixTbgsmuQ7lM1vD3bwKPmkRRQ2//yc74Ra6ddLuOmI?= =?us-ascii?Q?MPMRpy4WsPI4x6iegYAjhaC0DTP6XKaJmZfgrAOwN1dqRd1fMM/aa5HkSHwL?= =?us-ascii?Q?9eUVEYk+fgTbt/uaGZ7vjcoq7IEehm/SnIBc3yeKLJHCaYylV5wrjMt2M9n9?= =?us-ascii?Q?H415Of/UhjugSMePInCq5MswT4OuF5EBSE+rAzF6iQ8Xnrk0u2CNCDoMaChF?= =?us-ascii?Q?U/OG3Xi6TT7q9PUcSfogATZOMytCNkph4GOlQcHgAev3NalVAkdRD4ybtIii?= =?us-ascii?Q?Er9kRA8xluPqWriYgATadCfn2VLSE6V8w9QEuPREMUJDqHgxoAlCj4/01l7E?= =?us-ascii?Q?j7E/Xwgq7Dyn7GLLMoq6zfb6Tn3iomoxpZLjcDcFhsQIdw4WUbb5VVXP+PRY?= =?us-ascii?Q?Mga0AkQnqZGgAJtVp3KuLTxDZRUzbKFvqODCy8Nz/U2Md40gAo3EiNlEeJze?= =?us-ascii?Q?NoSy7QJq594S3JTUNQ8ZClcxFDS15zak8DWvqpLPRcsoDacZy/uPONIf8wYm?= =?us-ascii?Q?7EH54dINNqFyEhWxoYciKX4=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: pkAGOTJFwsFBUeUH0/upA1xpeWVo5UiUIIdwKZO1VzBrx+g/Fm6imd6pgN1puV6fxquWxC65FER++wA7nKCP0q4rwtrIULoM6/6NFrSD+J5PuXjFy6cqZaQH1m90K2HKTfSyP2+N6vNkYJWPHK4LlFIR/so9TumtZrjbsXNcXtpARoAgNVArH7VjpOQ4Pjk5eysRmu+hZzqIm/DWr7aN0lsjA1fm0gaY88riBASGcBs2Oh7I6IPmGfCKjAEjPNNlfFAsU7Wi+1qAeUKIsNaFyozx8r8jfyjIMEeZzJ1/Z9Decnt6hhRB16obogq9iy1johvjkYHO1J2IK2LvQjeMX1LTEsSRKYRzc1AFVxsxWTE1kyjtGr7vWPYISXIxZdUF0aCyuBMQE2jVji7MjHXYLcBbrxL8pJLunCrNalr02aR5eQMmCwXjPkAYoDI2nE0MVppT+cNMdvHuElKOKkirmaZZN8k/tLJLz0m5f+9nuJe6PptSe+p+6/AgX2eNcIXcf8f/z5nh//3AbHpq5q27u0fhfxGs3WjGqoyKDbYosKx3iPnFMN1cw0rAQVEsyusw2pzDRd+Vchj9yzvCsddRANPXmJWqijByFt75ol4JfFDdrAJ/EK6EAgHSO+L9ghNhTua2jk9WAMfATGQEzgAxPD0nZDLx4ZU2OTwaCEc3zq+7l+pQzJIHnJ6KFcahBTgvQYDUg2gLjwBxW3dax94TovIH9VcqYzqfQ75ws+8TY6sMEQcz/TzHkKyEBjSYzEOvTNL6tVVmUp52vhRyomoGfg== X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: a0c934dd-5d57-4a7b-49a8-08dbd657acd3 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2158.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2023 19:13:45.4100 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: O2XnFctcxZD/Xr1pYvczdy+1Xvu6XnaRjjWwS+ijJxtdCQSeRMGJOcDYEAGk2wU1R2eAXr6C2nV1CccnlcNZNw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR10MB6899 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-10-26_18,2023-10-26_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxscore=0 adultscore=0 phishscore=0 spamscore=0 mlxlogscore=999 bulkscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2310240000 definitions=main-2310260167 X-Proofpoint-ORIG-GUID: yMOI9psStPSxpieMMPHpk3w5CEv03lop X-Proofpoint-GUID: yMOI9psStPSxpieMMPHpk3w5CEv03lop X-Spam-Status: No, score=-13.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: [No changes from the RFC patch set] - cfi_sections_set is best set to true in cfi_dot_startproc (). Setting it to true again in other APIs (dot_cfi_endproc, dot_cfi_fde_data, and cfi_finish) is unnecessary. - move setting the global var all_cfi_sections into cfi_set_sections (). gas/ * dw2gencfi.c (cfi_set_sections): Set cfi_sections_set and cfi_sections here. (dot_cfi_startproc): Remove unnecessarily setting cfi_set_sections to true. (dot_cfi_endproc): Likewise. (dot_cfi_fde_data): Likewise. (cfi_finish): Likewise. --- gas/dw2gencfi.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/gas/dw2gencfi.c b/gas/dw2gencfi.c index f57479457c4..cbfee0a0169 100644 --- a/gas/dw2gencfi.c +++ b/gas/dw2gencfi.c @@ -492,6 +492,7 @@ cfi_set_return_column (unsigned regno) void cfi_set_sections (void) { + all_cfi_sections |= cfi_sections; frchain_now->frch_cfi_data->cur_fde_data->sections = all_cfi_sections; cfi_sections_set = true; } @@ -1309,9 +1310,8 @@ dot_cfi_startproc (int ignored ATTRIBUTE_UNUSED) } demand_empty_rest_of_line (); - cfi_sections_set = true; - all_cfi_sections |= cfi_sections; cfi_set_sections (); + frchain_now->frch_cfi_data->cur_cfa_offset = 0; if (!simple) tc_cfi_frame_initial_instructions (); @@ -1336,7 +1336,6 @@ dot_cfi_endproc (int ignored ATTRIBUTE_UNUSED) demand_empty_rest_of_line (); - cfi_sections_set = true; if ((cfi_sections & CFI_EMIT_target) != 0) tc_cfi_endproc (last_fde); } @@ -1418,7 +1417,6 @@ dot_cfi_fde_data (int ignored ATTRIBUTE_UNUSED) last_fde = frchain_now->frch_cfi_data->cur_fde_data; - cfi_sections_set = true; if ((cfi_sections & CFI_EMIT_target) != 0 || (cfi_sections & CFI_EMIT_eh_frame_compact) != 0) { @@ -2315,7 +2313,6 @@ cfi_finish (void) if (all_fde_data == 0) return; - cfi_sections_set = true; if ((all_cfi_sections & CFI_EMIT_eh_frame) != 0 || (all_cfi_sections & CFI_EMIT_eh_frame_compact) != 0) { @@ -2502,7 +2499,6 @@ cfi_finish (void) flag_traditional_format = save_flag_traditional_format; } - cfi_sections_set = true; /* Generate SFrame section if the user specifies: - the command line option to gas, or - .sframe in the .cfi_sections directive. */ @@ -2524,7 +2520,6 @@ cfi_finish (void) as_bad (_(".sframe not supported for target")); } - cfi_sections_set = true; if ((all_cfi_sections & CFI_EMIT_debug_frame) != 0) { int alignment = ffs (DWARF2_ADDR_SIZE (stdoutput)) - 1; -- 2.40.0