From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id 3A9033858D20 for ; Mon, 30 Oct 2023 16:51:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3A9033858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3A9033858D20 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=205.220.165.32 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1698684715; cv=pass; b=PFCVLRQDApHulpRQ6rjl4XCqQ4Jld/R+VTI4TCFdFKA6CMA37LEv5P2owm/vfAXmrVx7FuvMKqr508N7mKPg9V9BtYU5EHc/cl3MExTNl8GUTphT07rsramycm7g+DJbHav0P4727NOJ1TAwR2nTL4+pWz/wJAUPHILevAOjQ20= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1698684715; c=relaxed/simple; bh=DcupvmyYV9nt+Jcu9nYrB1QcjYayratVrN7dlaRAXU8=; h=DKIM-Signature:DKIM-Signature:From:To:Subject:Date:Message-ID: MIME-Version; b=a/fex7zTTVdvNFlB4R+5nqjVryPUiw+CPc7xxcdfUW63gthdELCrvx/W30OTM6FQIAzOVD1Db7nMg0NaKeJtWBEDUszFWMbsJtoqzWGpRFGdN2Klt4bWicgMllilemLYTXMBzelZ+/3FXANtwGxQMm5LEpqiNRICN++3PrI/fOM= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 39UChxPM021209 for ; Mon, 30 Oct 2023 16:51:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : content-transfer-encoding : content-type : mime-version; s=corp-2023-03-30; bh=bOzzEGM2FgbDvqeC805a2tXZkflN9MFlu+bb237Ur0w=; b=gqf5ACa8BmxLuYEPR5TS4y+1V1b2T0PKg3GbNwOBEiGiblrR3Z42Fvhqgf5CJ0LE89Sz UNpPaDf6h16rRYIcdkqPZdYNzAbkJTCv1Rdtr23FhS+8bKA388VHhbCOOLc9yJLeW/Im D1RZoGyoN38hxaIv4h9QoHNYr7M649Qs5qQ0UEjc3FYpHjEjDIr5r2ymloTKlVkWEN9w 6q6Js/YDfbt+EpaNBf49mHAACzQU9rS+qDyak5w90cPou+q0VPN0Gn2w9pAPWOxaQpEU wEuImplFh7RfNJIXs9VEUQ0pp2ifXh8ZJOL/I2c4pPj0BrJ2jV0ZWsDuLWQeaIgHJ6X7 eQ== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3u0t6b36na-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 30 Oct 2023 16:51:52 +0000 Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 39UFaebE022465 for ; Mon, 30 Oct 2023 16:51:50 GMT Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2168.outbound.protection.outlook.com [104.47.58.168]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3u0rr4hgtq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 30 Oct 2023 16:51:50 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dCch24dB3686yKbsatnm1DI8ozZ4OwP578SFZwMHwXWNWxTqNulSr9vN8g4PnfpD0zkTMBlWMhwc//8ZLcFRLqmmKp2x8z9NwIPeaAjGYKL+udxOzjy0zoPXgQkneU/VAd3a2OhN+3SzxHCeSRjgLerC+YK1ZQhBp3IATGszJ1m652FoUJKlEBofRSrNR2FHaL+T7578cvCC4NctxzBgsQyZ3sAG2JK4iXr1l+DnivvkNVYnfQEM/Unocg42oTG0GCEqMZQwWqei7cIqpw2WaanfnFBGGQXPjucfvjOFbr5LnafwgplJkLTjdj9VPjESx5OhO+3BJx4rR7GujOijIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bOzzEGM2FgbDvqeC805a2tXZkflN9MFlu+bb237Ur0w=; b=mk946qBkSgIRBo7f1XHOwRpla0QVVbmg8e5LIQmUnJGFeLCfbfwDPMOvJi6kjAbUAAhYWPN1nRjb8lc2XI9bfl8Eug+nrt5YoVG4pOApPrMLN8oMAR7wYMroaWPPQ9mjbt2s+4qoSdgbq/us+A195HMqZV84fDuqzVxMfjOs0myDp/FfTw5euAbQtj4wiNsi/KJpoiByB3sxZ7nBLoVIVZvqJ6+bzzpPZmFN0ChPr1QKYxryW7QYv/VVCsVrD9tIfXMIhpZG4KTCiDtqT4RlPTRbBHZr9cdxK5SWbgfB0lytIH5yzdB9TiXBhlVC87heoYWVnI95yOKa0YCjAzmZbg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bOzzEGM2FgbDvqeC805a2tXZkflN9MFlu+bb237Ur0w=; b=Rss2FAAvVmeEmTu4J1ZrEE4LiAaKM4egn8GUlJYmtB4c5o3TCBkHrSipKqrGtV41YiqEKTm9J18o4rvn43fccvltV2iFsFK7itKj2nsKCDZUQUFdGVOBn/fcID8DRqoyC3AWH6HRR4F78+hLyl1Bvsc8QolsXwtxEp1/FRE7w3s= Received: from MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) by IA0PR10MB6818.namprd10.prod.outlook.com (2603:10b6:208:439::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.19; Mon, 30 Oct 2023 16:51:49 +0000 Received: from MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::7f02:c28d:9802:20fd]) by MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::7f02:c28d:9802:20fd%3]) with mapi id 15.20.6933.019; Mon, 30 Oct 2023 16:51:49 +0000 From: Indu Bhagat To: binutils@sourceware.org Cc: Indu Bhagat Subject: [PATCH, V2 01/10] gas: dw2gencfi: minor rejig for cfi_sections_set and all_cfi_sections Date: Mon, 30 Oct 2023 09:51:28 -0700 Message-ID: <20231030165137.2570939-2-indu.bhagat@oracle.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231030165137.2570939-1-indu.bhagat@oracle.com> References: <20231030165137.2570939-1-indu.bhagat@oracle.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: MW2PR16CA0036.namprd16.prod.outlook.com (2603:10b6:907::49) To MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2158:EE_|IA0PR10MB6818:EE_ X-MS-Office365-Filtering-Correlation-Id: e00b02fe-23c7-42a0-19de-08dbd968823f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Whx5FCz6rKZo6jBEdEOY9ytEZaz2OxT4EPC7hRv9GUXFwzqfmTZ1wa1lLQ6MaGPI47El3ldpNS90KsfFtGcC/a9u3UYIU40Ue54otvvq0bI6oGfPnEDbqecUaYFIEgn3Esn+9ArS/uL78g80j+Sibvaq1ZXZanzSAP3piRKNzIRlTjYoTDecqPqJiBBGAQJvmrQTKHAsms4Udejeslb983ClIvTcsGBUqP94v0ljO5Gh34QacNOPagqyyaD5iwTBcbWDIDpKa+1ZNqS10LNbPLM7d++X+mn6gKe4GP9Up1c3xzTWGKAxpOPWbU4ivDousDDyUwHWWlrCQYC2tfGkqRDUybgSplrzqVNZcFUCxBk4cntryHyxydEktCsX4GSvgzpnAUJchiqgay+RWDu+fMSKuFXj507Bz307DexhWKvHOyYMLa3x++JnIBIbXq+ooVZNbiyw3CdVZ1w74isLylIr+zxf4lge+Cbx1WGBAc851UmaHDnN+hyEyGHP177MrzQ2xBbqKzHQUek4g5TMVnwnYQlZqNAgVCEj3Wa0HmoukD0v+/RYJywyueJGiNBA X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2158.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(346002)(396003)(136003)(366004)(376002)(39860400002)(230922051799003)(451199024)(186009)(1800799009)(64100799003)(83380400001)(8676002)(4326008)(8936002)(38100700002)(86362001)(2906002)(36756003)(44832011)(41300700001)(6512007)(6666004)(5660300002)(478600001)(6486002)(2616005)(316002)(6916009)(1076003)(66476007)(107886003)(66556008)(66946007)(6506007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?is+VlnRIMpvQt8gV2xzJf168M7GWAlh3lIQRDqINGtjUzPzn/Pt3ycR3ifYi?= =?us-ascii?Q?hhiAoyJiZ+PGdTh6OsEisMH7BCz/d7twjPXteniHLYg8cbWWxr9lmaDH4eAr?= =?us-ascii?Q?xH5dGE7dBzZPNOhJ/xlNViRi+7SN0xkjQDLrhlg7qC2QaucLsn6DSuF8IZrv?= =?us-ascii?Q?V5ArR5/MnI7ySNV1mcNjuPVh5vJEWbh/Cn2kaOcT2huaQjqMhYeLAY8CJxY4?= =?us-ascii?Q?5ddHSUjMqdjePZAr0ATo2pipoSPvaONKyJwaKSVt/W3bDIKwgDHBvoY1gujB?= =?us-ascii?Q?n6hXU94+wSXKsTskcr468y00MCZQZbSXxt86UjikvGmYXV4GVLqmDnG9DvjX?= =?us-ascii?Q?ozhJ21BgM+xU4bioCFdzHT7JwqWK/t/wD7S6tCEIYlk23VjIHgvmUcMSiAw8?= =?us-ascii?Q?9PV6vPn81DyEJDLK+CQb3cS/BHgq/DL06Nn7h0iU0ijile0fPD4+mCzbo2cu?= =?us-ascii?Q?RP0M+Kbvv2T+dC3BkJUCxBL6YUlee3rZH3azS0C5nmY87tKGvaiPvmwmvUf2?= =?us-ascii?Q?Zaic87al1KGfQMmZgx0tI4xRNb8MEVdQ9ndxNEkdsOQ2D0EkcAhH5JxeOna/?= =?us-ascii?Q?d/OWaEbyxC3gaJMB3mpKV/B62gRKwFe2xksE/p+dDZ3hkOUrParYZR4F2mRo?= =?us-ascii?Q?i6Up3oBqplloGHFIAgA2A1XPKkgZwJlrOTZ3w57/fg4xhoTVO/m3mGgmBFal?= =?us-ascii?Q?tjaJ9ndZ440SeAZ9qChgUQBqjufWDkAnmmhpFlyWVHi4YDltNgT6pBMdxHdt?= =?us-ascii?Q?xfpkM8pZAx/UxjumVq+9iv3+SSyO/BE/nzsvD7quAZaFhhNbCvcSqGvOEExU?= =?us-ascii?Q?xYEOpzsTXtF3j1sJwqcM9M0QkkqRNs+073vOGeht+HvkUPdtWba6LsIa4TMo?= =?us-ascii?Q?04vj/qIBsrzf6B0m1vbRGX4rHBz7LOziFpDOg3gnuxRWdG0JzHFuo/epzP4d?= =?us-ascii?Q?Jp9cdSTd6fcMZLwxxpqhkc2LjVe8A824+rfIGifpBGOzLgbIwNbBKByavl28?= =?us-ascii?Q?poV481ziYJkCftaY1lti7FLF1zgIMinq659ZdXR2txkgVC6j5wBFzWLnhLiy?= =?us-ascii?Q?RjVAO7A86JnC7cr5FhmUYE9d1QkLo835M06xjuAzXtZBOwuddYfjvOXpztsx?= =?us-ascii?Q?xy3Z1SYcL9cQNTcsoZWAb1BKtOm899UnzYrVVCseASpi6afegYX2FtjETBZo?= =?us-ascii?Q?/c5Do/aq/T581AzqE7I5cHZovTqL1Y+lBFtmxLFC2eghq19j+hlkp5vrGX+6?= =?us-ascii?Q?8u0RjdD53KPIPYhXBWtlFw7mZR3+LoOsjjX2QzC9V9EGA3oGEQL/5vcP4vh5?= =?us-ascii?Q?TxqswvLkSlt2Vc7aRluqKQsb2FRKd7Pe9duhGDF2gtiJr3GfsJGUhogfA6J5?= =?us-ascii?Q?pu5KGVX4bjpyIAIRUVIY3EpidqwIrW/M1J31hotrrkQjuAagV6bh1owo70/T?= =?us-ascii?Q?cRrZR/9wMtWZbbFBOeqJ2L/ok/zV1zijIQ5VS2IyceCARACaVhgFJ+5g0NSc?= =?us-ascii?Q?0OOQj64HHxMXpDpXPhdE9FfCcKoo5337NvRCL4prc8IwYgrplXrmAULw2MOb?= =?us-ascii?Q?EEFL4WT1P8JRXgdCjd5xqRjCMxFU8yo1d9z6AEhsoQlD83T4RcYG3P3p4MAZ?= =?us-ascii?Q?acoY1Ybn23Pu6vBlIHJ5PQY=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: HuRB+JyVOYGX3UUhOkJJVd1Ip559U9wBsHVVd1OYA3fF8i3H4zZvGL14DMebBsc6xEBHn/OTQxVmpgNdAuxGm8kPuvkjjD3V/PlkgLkBZ3AnUinpiacQ0CzGvWroVeFghgkodKKMhnpQenYqpIreV3mspoGC6kGd1YjnTRvFt6xmMWPBJ320KwETpFfg3wc7qphSS9OhyvHAinYDnlNaVzkwKH3tH0L0KoFWEZhvnA9CAcUBN62cRfNgUvZZvLzQ7I7rP2HNd47+cmKO9ihtBq4rSzCnQ6bcPchdU3Cp23eCZpvogPS2+9M7ZZ/1XQXGFTkbjhLT6KtuhNNnexDHGzm3/RWp2+eozgoFRThJsjXONC1HMLhAJrOEOcypcLHy8/0Z8pZtqgw6WuumrGdjXXlNiIvyjFekVLiqwqpQ0uorWcAiMvZ9GrEvOlZ+Tkp+jIZiZ5GUuUAkZPOmF4PWSHuKjWMPj4Ybv+O/GUcSpzeL2HEBcpOkkZoRWYZQXqBu4aQWIFbhdjcgAjYX9IKYWPze2t9zF7j4VJrjwNAX7fwnwlna8+L8lbJO06V9e6D3hPb1FlgJ83I8T8l01k3jYbWh1d5Bye6Xty+Ndk5FRK984VCQSobBznhEJ2mgV3V6LPe8p4FGIzsX8JK/tbsBRCeAogUp/fyG6d+f1NZS9wYNJukM40fg4gAATH3dFCvYYEoCMHK9LBqtBSbr4EKhWrE1x2O2hyIlAdphNH8x6m3GJMrTYvfra4QxmlnQraeBHMIgsbZLnh18rmmQT4lngg== X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: e00b02fe-23c7-42a0-19de-08dbd968823f X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2158.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Oct 2023 16:51:49.0286 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5//AtTzsB/n6HLZLFRM0MHz7MKms0L+qWf75yVYoUDHIvCX4bcOY20dYH7Mg5aT2hKAzUkgrvU5epKwgrLigeA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR10MB6818 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-10-30_10,2023-10-27_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 malwarescore=0 mlxscore=0 mlxlogscore=999 adultscore=0 phishscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2310240000 definitions=main-2310300131 X-Proofpoint-GUID: dWlNjvAjxOt1gUMdpONKfiW4BCtBy0l- X-Proofpoint-ORIG-GUID: dWlNjvAjxOt1gUMdpONKfiW4BCtBy0l- X-Spam-Status: No, score=-13.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: [No changes from the RFC patch set] - cfi_sections_set is best set to true in cfi_dot_startproc (). Setting it to true again in other APIs (dot_cfi_endproc, dot_cfi_fde_data, and cfi_finish) is unnecessary. - move setting the global var all_cfi_sections into cfi_set_sections (). gas/ * dw2gencfi.c (cfi_set_sections): Set cfi_sections_set and cfi_sections here. (dot_cfi_startproc): Remove unnecessarily setting cfi_set_sections to true. (dot_cfi_endproc): Likewise. (dot_cfi_fde_data): Likewise. (cfi_finish): Likewise. --- gas/dw2gencfi.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/gas/dw2gencfi.c b/gas/dw2gencfi.c index f57479457c4..cbfee0a0169 100644 --- a/gas/dw2gencfi.c +++ b/gas/dw2gencfi.c @@ -492,6 +492,7 @@ cfi_set_return_column (unsigned regno) void cfi_set_sections (void) { + all_cfi_sections |= cfi_sections; frchain_now->frch_cfi_data->cur_fde_data->sections = all_cfi_sections; cfi_sections_set = true; } @@ -1309,9 +1310,8 @@ dot_cfi_startproc (int ignored ATTRIBUTE_UNUSED) } demand_empty_rest_of_line (); - cfi_sections_set = true; - all_cfi_sections |= cfi_sections; cfi_set_sections (); + frchain_now->frch_cfi_data->cur_cfa_offset = 0; if (!simple) tc_cfi_frame_initial_instructions (); @@ -1336,7 +1336,6 @@ dot_cfi_endproc (int ignored ATTRIBUTE_UNUSED) demand_empty_rest_of_line (); - cfi_sections_set = true; if ((cfi_sections & CFI_EMIT_target) != 0) tc_cfi_endproc (last_fde); } @@ -1418,7 +1417,6 @@ dot_cfi_fde_data (int ignored ATTRIBUTE_UNUSED) last_fde = frchain_now->frch_cfi_data->cur_fde_data; - cfi_sections_set = true; if ((cfi_sections & CFI_EMIT_target) != 0 || (cfi_sections & CFI_EMIT_eh_frame_compact) != 0) { @@ -2315,7 +2313,6 @@ cfi_finish (void) if (all_fde_data == 0) return; - cfi_sections_set = true; if ((all_cfi_sections & CFI_EMIT_eh_frame) != 0 || (all_cfi_sections & CFI_EMIT_eh_frame_compact) != 0) { @@ -2502,7 +2499,6 @@ cfi_finish (void) flag_traditional_format = save_flag_traditional_format; } - cfi_sections_set = true; /* Generate SFrame section if the user specifies: - the command line option to gas, or - .sframe in the .cfi_sections directive. */ @@ -2524,7 +2520,6 @@ cfi_finish (void) as_bad (_(".sframe not supported for target")); } - cfi_sections_set = true; if ((all_cfi_sections & CFI_EMIT_debug_frame) != 0) { int alignment = ffs (DWARF2_ADDR_SIZE (stdoutput)) - 1; -- 2.41.0