From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by sourceware.org (Postfix) with ESMTP id 65D733858D35 for ; Wed, 15 Nov 2023 11:20:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 65D733858D35 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=loongson.cn ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 65D733858D35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=114.242.206.163 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700047259; cv=none; b=TGYv7VqC/cCBJc+y5YFHcquJgxQNz8Sap4QZyr09/HHub0p7f7fyCKp7DfgOEWJDTLLymYkNiAXEGhBif1nLCVAEZRbKmmMzdWhnyEEV2b4NaZhSAvLoKWZ8/BpSl53tk1gRcje/Ee5FgeSmtcNrPuArzWjVvoMY4/RVAvuAYD0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700047259; c=relaxed/simple; bh=K+okrq8EGX5yiCHi8KVCvwLSUSdeWyO/zwY8xbljZ6Q=; h=From:To:Subject:Date:Message-Id:MIME-Version; b=DQurXGEUKYkVPA1vxlgy1SXIcVkI/0zrzwcE6NLN/JX95VCcshYqrolmnd4UIwXZ7UA3/oflATXV4D1z4STsDWlvTnvlnImNag0ah7p8t1hrRO9DlstMKcUR2J9xuuLVZ3qr0nGaJM6NHyxv9T+FRNJr6Xd3klzDDJRJDwRXbcM= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from loongson.cn (unknown [10.2.6.5]) by gateway (Coremail) with SMTP id _____8DxxPCXqVRld0E6AA--.50339S3; Wed, 15 Nov 2023 19:20:55 +0800 (CST) Received: from 5.5.5 (unknown [10.2.6.5]) by localhost.localdomain (Coremail) with SMTP id AQAAf8AxG9yXqVRlBu9CAA--.15483S4; Wed, 15 Nov 2023 19:20:55 +0800 (CST) From: Lulu Cai To: binutils@sourceware.org Cc: xuchenghua@loongson.cn, chenglulu@loongson.cn, liuzhensong@loongson.cn, mengqinggang@loongson.cn, xry111@xry111.site, i.swmail@xen0n.name, maskray@google.com, Lulu Cai Subject: [PATCH] LoongArch: fix internal error when as handling unsupported modifier. Date: Wed, 15 Nov 2023 19:20:53 +0800 Message-Id: <20231115112053.1503541-1-cailulu@loongson.cn> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20231114012809.466953-1-cailulu@loongson.cn> References: <20231114012809.466953-1-cailulu@loongson.cn> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID:AQAAf8AxG9yXqVRlBu9CAA--.15483S4 X-CM-SenderInfo: xfdlz3tox6z05rqj20fqof0/1tbiAQAPB2VRh6kisAAFsE X-Coremail-Antispam: 1Uk129KBj93XoWxJFyfuFy5JF1kKr4kWw17Jwc_yoW5Jw1Upr yxZ3W0kr48CFnrGrWqgFy5ZFn7Jw47Grya9a1SvryI9rWIqry5Zw18tr98XFZ8Ga1qgw4r Xrs5Kw1jvF1UtwcCm3ZEXasCq-sJn29KB7ZKAUJUUUU8529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29KBjDU 0xBIdaVrnRJUUUkFb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2 IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48v e4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_JFI_Gr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI 0_Gr0_Cr1l84ACjcxK6I8E87Iv67AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVCY1x0267AK xVW8Jr0_Cr1UM2AIxVAIcxkEcVAq07x20xvEncxIr21l57IF6xkI12xvs2x26I8E6xACxx 1l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r106r15McIj6I8E87Iv 67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IYc2Ij64vIr41l42xK82IYc2 Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s02 6x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r1q6r43MIIYrxkI7VAKI48JMIIF0x vE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14v26r1j6r4UMIIF0xvE 42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv6x kF7I0E14v26r1j6r4UYxBIdaVFxhVjvjDU0xZFpf9x07UWHqcUUUUU= X-Spam-Status: No, score=-13.6 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --- bfd/elfxx-loongarch.c | 3 --- gas/config/loongarch-parse.y | 6 +++++- gas/testsuite/gas/loongarch/reloc_type.d | 3 +++ gas/testsuite/gas/loongarch/reloc_type.l | 2 ++ gas/testsuite/gas/loongarch/reloc_type.s | 3 +++ 5 files changed, 13 insertions(+), 4 deletions(-) create mode 100644 gas/testsuite/gas/loongarch/reloc_type.d create mode 100644 gas/testsuite/gas/loongarch/reloc_type.l create mode 100644 gas/testsuite/gas/loongarch/reloc_type.s diff --git a/bfd/elfxx-loongarch.c b/bfd/elfxx-loongarch.c index a970a257aa9..7f298c08fd3 100644 --- a/bfd/elfxx-loongarch.c +++ b/bfd/elfxx-loongarch.c @@ -1629,9 +1629,6 @@ loongarch_larch_reloc_name_lookup (bfd *abfd ATTRIBUTE_UNUSED, return lht->bfd_type; } - (*_bfd_error_handler) (_("%pB: unsupported relocation type name %s"), - abfd, l_r_name); - bfd_set_error (bfd_error_bad_value); return BFD_RELOC_NONE; } diff --git a/gas/config/loongarch-parse.y b/gas/config/loongarch-parse.y index f4e1a63b972..f786fdaee5f 100644 --- a/gas/config/loongarch-parse.y +++ b/gas/config/loongarch-parse.y @@ -132,7 +132,11 @@ reloc (const char *op_c_str, const char *id_c_str, offsetT addend) if (0 == strcmp (op_c_str, "plt")) btype = BFD_RELOC_LARCH_B26; else - btype = loongarch_larch_reloc_name_lookup (NULL, op_c_str); + { + btype = loongarch_larch_reloc_name_lookup (NULL, op_c_str); + if (btype == BFD_RELOC_NONE) + as_fatal (_("unsupported modifier %s"), op_c_str); + } if (id_c_str) { diff --git a/gas/testsuite/gas/loongarch/reloc_type.d b/gas/testsuite/gas/loongarch/reloc_type.d new file mode 100644 index 00000000000..0a8f77825a0 --- /dev/null +++ b/gas/testsuite/gas/loongarch/reloc_type.d @@ -0,0 +1,3 @@ +#as: +#source: reloc_type.s +#error_output: reloc_type.l diff --git a/gas/testsuite/gas/loongarch/reloc_type.l b/gas/testsuite/gas/loongarch/reloc_type.l new file mode 100644 index 00000000000..e981f6f2aa5 --- /dev/null +++ b/gas/testsuite/gas/loongarch/reloc_type.l @@ -0,0 +1,2 @@ +.*Assembler messages: +.*Fatal error: unsupported modifier (.*)$ diff --git a/gas/testsuite/gas/loongarch/reloc_type.s b/gas/testsuite/gas/loongarch/reloc_type.s new file mode 100644 index 00000000000..2ce277779db --- /dev/null +++ b/gas/testsuite/gas/loongarch/reloc_type.s @@ -0,0 +1,3 @@ +.L1: + nop + addi.d $a0,$a1,%reloc(x) -- 2.36.0