From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id 79B423858CD1 for ; Mon, 11 Dec 2023 06:04:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 79B423858CD1 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 79B423858CD1 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=205.220.177.32 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1702274701; cv=pass; b=khNdKT47SL338BD499hqVzGthgoceZlNvLFmLriw3JW/Y0Nxt0kAbEXJxL9Q9DKsEs6hDoMzEF2HQVYGHqAY95kBjxSx7bShuOsZrxy0WcLu4EWxMLBM9aj70UciAmuYFSmMz2aVIEP7pFMp7Fu+6OvwKawic31UZrbLipzlIeI= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1702274701; c=relaxed/simple; bh=+WSU1eFmgCUsiwO1BgfxUc045a7jwMuLCl1XOaH0z+U=; h=DKIM-Signature:DKIM-Signature:From:To:Subject:Date:Message-ID: MIME-Version; b=BX45HY+FGBaRzpLD5aPCRL1YMb3UNd2nODFOvBHcjLQ4eYprOQD4H3vxtTqLXd2DCyopG/n4VL5E/HlAyCs+DDWfeq+UNHnF9w24wj7Ke0KPKmv/QzKsY/jQ6kAuusy9oR4oKYSgRN+8Ek6qfh0LO4rIfwEeT53wvLQMfMOLDaA= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from pps.filterd (m0333520.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3BB33LuS002894 for ; Mon, 11 Dec 2023 06:04:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : content-transfer-encoding : content-type : mime-version; s=corp-2023-11-20; bh=nHwqzkXHKaAhv1ENH2PvtZXmauHeSNWptd60q9PG/ZM=; b=YsRnRDxQ5SNUjT61AhzFV0dAWnbgQCODo5bLKxV03e0SZh+mgETblCdwFzsKSp2LtkGG UI7uDliJMBiYyVrG2Vg5ce9FY9QZf0ESFQxjulsaeHqXSu8NLGWQunzdE5SlfvVPRW8j KC3rA95jkXkJaHf2vFqejoE5ALtxCFghekdnz0ukt5W6o/yiIZgD6kvJUN76atbOGEH5 w+bEaclCdkRiEZRWpjGHigNbqtHZLiJxdGOqpMT1HkGZMxzEy8JEdUF4C+b/wvQ7M8I2 I/Ighe+zT4jzOJd4Z1eitwkGh6TZ5rK37f1QYMS9jfhWGstYdxrrJI4V1lW1lvfVleQ7 jg== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3uvg9d24d0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 11 Dec 2023 06:04:57 +0000 Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 3BB5g5J8040874 for ; Mon, 11 Dec 2023 06:04:57 GMT Received: from nam02-sn1-obe.outbound.protection.outlook.com (mail-sn1nam02lp2041.outbound.protection.outlook.com [104.47.57.41]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3uvep4ewch-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 11 Dec 2023 06:04:57 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WIhEc6HJvB+qVx4mHM3nIO+aA+ECsZCnAviSRi3ZcsV8xSfhufbsQ5uMYx6X3BWV9BATaOnkSlol1NYeqQx/PQRcW+/e+xjmJs92nFv9L48yv0HwOgVnOQQv8K4YzKw7CHNYndRuM7mlExcH/RxgFcch5ebOvl+mS8ehWHev/y4IQ8nGVZdwwXNNFV0OY//V4zXHAXw6gkvH3F+Z1fabIfEH5f59XSdwry8x5rN+sYR9S4J3XHl5bz09v1pzG5yTtbSoLcBw2RxO/c9HTgMaU17sK3pHPR0f0c3eCzSbrsw6WdsuVBOEgP92KawJnOQTKlazoZ3pj9iwGUFiCbX9uQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nHwqzkXHKaAhv1ENH2PvtZXmauHeSNWptd60q9PG/ZM=; b=DmcsePd0+QYTRoWoTARB5NnzpE2mg6Fd30sp/60yV1k1bTthu13yidIs2cZqU0DjzjA2bRnbrhHo4Ts7jeOxVhf+DzZmgilytdlMfIsDIKWnmXlXVwoCzdK6Ues/osr57/jR7Hs3hpw5jgVuANM6wfs4ka/JxD/PI4/vyxIBCP3pg49dIdcUThwt2bWZVlezi9gkCHY3U/uitv6YM57T4h3OIhQoxsE0rXiOth2rcQ/RaHMNhYkHFKDpjbhKVfpnb+nPfBhcKdzTfnDTFBl157/obsdlcogJKpUmlVI9cPmsKkXssst9+rA4u/e+Nyj4+Wp8pRq3ZLdD3ZQKPhr+cg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nHwqzkXHKaAhv1ENH2PvtZXmauHeSNWptd60q9PG/ZM=; b=zSvX3fc3RihKjRbNKCqUmOzikuSG3PVllpDbq4kgUPF6Fub8t30VyUYrYAxYgtvgxLvBPDmbm8c7X4ernbPundHXdMh8yEJzyUToD9ZuzuyqF2XETQPVuMVXft7ClXQKd8T6NzuwE5e5nFflGlz4nX11ZhDEwzs4bZMVPBx6t5U= Received: from MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) by CO1PR10MB4610.namprd10.prod.outlook.com (2603:10b6:303:93::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.32; Mon, 11 Dec 2023 06:04:55 +0000 Received: from MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::88e2:4a2e:3111:e04]) by MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::88e2:4a2e:3111:e04%7]) with mapi id 15.20.7068.031; Mon, 11 Dec 2023 06:04:55 +0000 From: Indu Bhagat To: binutils@sourceware.org Cc: Indu Bhagat Subject: [PATCH,V3 01/13] gas: dw2gencfi: minor rejig for cfi_sections_set and all_cfi_sections Date: Sun, 10 Dec 2023 22:03:47 -0800 Message-ID: <20231211060359.3561062-2-indu.bhagat@oracle.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231211060359.3561062-1-indu.bhagat@oracle.com> References: <20231211060359.3561062-1-indu.bhagat@oracle.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: MW4PR04CA0305.namprd04.prod.outlook.com (2603:10b6:303:82::10) To MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2158:EE_|CO1PR10MB4610:EE_ X-MS-Office365-Filtering-Correlation-Id: ba49a62e-ba78-49c5-aeb1-08dbfa0f1900 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lxkhoVOR3S8kzfwtw3tgedlJo8Pgqlkcy9w8lbeBGkbNeyBArlL4B8u4Svb5AT13cAn54MJu7ZjdfnWXBOLyKBj46CDyaGEUOnkdUhBI7cGszLponA0yLCZp1DsTnYznK2jeG3n9eMKr3UzkaMMPBNfEewAjWaRNcjwtN2ftWuNcioyV6l9C1mmJIYIE9Eljd6vmaT23CHZlnxnrHk1l817zL4YVKq0jiNh9jexPgvzmoECmcM27ffWIBD9T0hM33Qm7rJ4PjVg+KaGvJWKml33WTFWWzjV8c7y8gmKbhjLICPFMIz9I/lJDUVh+tjNAZWO7dza8vLt9lrzEtx/IWpg/sDXnJydfysPHVzud89RX7vQ6dAT1Ncp5xNbDLewWdxxus/D8pEdG1vjahecla3gjrUChvbJleAQxwXHS+cPSTZKBSXZNvYh5bgaEZHTaYckijePiRdyGSjMtWr5rgP9pe1dxgJQ+0YXoj1FxIGqX+1nz2pwW1GWYzsphoav0bFJJpvxOoMtJXoXUu9giL9mBf5v6bSwYRagz60g8dTz2r5c9MXHsXD29D4RPenzQ X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2158.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(396003)(366004)(136003)(346002)(39860400002)(376002)(230922051799003)(64100799003)(451199024)(1800799012)(186009)(41300700001)(38100700002)(2906002)(5660300002)(44832011)(316002)(4326008)(8676002)(8936002)(6916009)(66946007)(66476007)(66556008)(2616005)(86362001)(36756003)(83380400001)(6486002)(6666004)(478600001)(1076003)(107886003)(6512007)(6506007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ru6c8zbx7NqPtqu4TV4xM5yQuh5xd3ZYaO9CGFDPiTEfamJmAEHL8M0BeKI0?= =?us-ascii?Q?dgZxz7mN3DDSwYNJGNgDjoFNtZSqMwP3tot1GuEA3rrYi1OuBvKbr+K0GvKe?= =?us-ascii?Q?RREmdnXpx2pOpylkK9JqNV5Fu8kwqvtF/rlxm0BSlwHEPhxpcYUr99c9LriV?= =?us-ascii?Q?qrWz3XEDDiuWpI3kZENE+Meqnax2HYWpCleELaAO3zSKYsw/LhlPAya4RaSZ?= =?us-ascii?Q?AyN+IPnjSxIt2GD7vzk63YQ2ZasHCCtOcxZTVf5iArqfaXHycnhEiUnW37/x?= =?us-ascii?Q?cF5bqb89j/0GvV3L+ApBvUAEHRilB1Yyt9VN7V9mn6/8mpDWlobc1qoC0Lbu?= =?us-ascii?Q?UCLF6/IPVrygSThihv8VBHHKCN9pcihdnXY80rmpSzYE66FW/hfhtMN4A67H?= =?us-ascii?Q?EuQoqwLXH6y7let1iNW4MN1fbjlQBSkrXr+6JyRomINLAbXdEnTRS3EeCXF5?= =?us-ascii?Q?tWBzS679q69ursNd2VTeQ7GadV+iiG/lMEhonZfeRCMcZ+Fk592v1XX9pwau?= =?us-ascii?Q?8fu9ofMB74e9eWFeApqCfv4/BGu+4NXMohTo3NTuwDLG4kFSoxX35hxpIYQy?= =?us-ascii?Q?172Eiq55YcPztDeceGn6DdKAu4rMr5BKwN4EbeKDiGC15R+kaKMFVqwcCPVx?= =?us-ascii?Q?NuXyCTRXLTtVBCRKj8ucSjlE6uzwQ6943Yz4Y3ZcY3BVakP+Sz8oFTrU7vsl?= =?us-ascii?Q?ZEhqy1njLGQ0dwkQB2GGpzJClTogSuGK+aKQbePwlI9nJVdd2N6YWGI8kgvM?= =?us-ascii?Q?0Xp151gGeM1GRlfX/Am4ojy9To8kk4ItL4SjcajaU8R3ZqrEnnGFT+c6PlH9?= =?us-ascii?Q?nr2ZkRw+l+BxE87DBwZk12z2UNpc2tndhNQjRoYnU97RlnB4ie5gtXAgWNNL?= =?us-ascii?Q?caqEfqm4Y/oJ+ifTdvcY12quuaO4S4LZd20THOYeSiaKeeLGLCKbNvbsWU+w?= =?us-ascii?Q?8RhDuQzr5/LsHcD1BWDU2KgMrIDYKBn04hwDJKSd0wF4F3Lgrii7xSHNSZra?= =?us-ascii?Q?okDC1+7dKL/h4TRprWhSsBSj25siK8CwOsVK/QiOh1v0v3PoVwQbU9awEFmP?= =?us-ascii?Q?KHiLPPg+EeQ/YIK9Sne735sjJtnDFhy/4DPOk+32tyDT/X15UE595OwXe3Wi?= =?us-ascii?Q?qxyCIwhg2YmPs1Q3KC6octcLHT4s3L7Xjv9ooV750Dklz6qEKW/C82Ye9Wps?= =?us-ascii?Q?UIPop6LgOdWuqN51o9CNp56Vj0bCLzXNGdqg+h7utJ1be2cFwJ/fJlkfuZAt?= =?us-ascii?Q?PovtCsPXvElIA82epYjZdra2gTWxKm7W53PGTu1LvdejMfLACkL1vZRwfwyY?= =?us-ascii?Q?LYB7GWWTsDPlY6FZJhshpOStRTuAOwFh7TRJ5y/4CO1wV+SsHsphtWEi3JIO?= =?us-ascii?Q?Ve190A8KDsEThUcYfS+1sleQZMt916TOvC6xFIkLPrAtiPRwYn7O61S2LC8G?= =?us-ascii?Q?9BpHhc2O1Pw0Av7NQ4ppW4z3S+c+lLrWMwdXeJWSA4LQbdX/XilYGeJ452lp?= =?us-ascii?Q?r3ZSqXL/NlDq83SW3NT9uMMOGseJkbJ2u1VnYixkPKHLGVtbYOAZ5GJ1gfQ1?= =?us-ascii?Q?RdOnVietWhS7YXw+cGFNi4cSmWDaMkf5x8ZMfJvXmkLlWHURZrYo0T/caq7/?= =?us-ascii?Q?89X8u96vRz6urSbWOqYjLro=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: ggm10SEsMZAS96xFeWX1lDrxzZ61X4mYkIRxBGX1rXPFUcSZP4Nc7pgsaILzzrEsGETRx9fAWbiq9OVD3EAIlkrNhYZ6BJ5zIGkHgs/DPMs7e4YFPPczLe/GFGNAclSxUXw+P/F8+djwreMq3f2MPipJ38cLQMWE6RjpJrlw7E8j806rgNr6nAx2dKsKf98V+4RolVi0hgVg3zVdFxKjY4yFoxfo46Q4C3G4bkdM5XMcFo64CGThu1/tlUIdgWsgObpT9IxVD5kdT3lt5R+c4P+4q5dbBlnkCiwhzfmDg+S6T959MsYdhjbBFztaf4HyceUiYthYcd1g5Uk+/nXC6OG11f4fB/BlWYPoWbnXDgVUTsAYLO1V2SHI7TG9tmMR0fGdZEAkFxQPrQIwTzbvl52Ch21a3ghkDzoDOq98BM2jFCNkxvjP2jZAMSLMmq9+8Qydcin17jGkmSiKqt1mC/gQC31KFkP8DYKRMKm5qy8IRCn8PrwT4QddUbBcy0VFk1Aarn0mqB//uV4ce+uJuM7pmheFmGy+Z+zeOUbX1QDiYqERfNhbS1mAQ024cHJG8mRiBmitLrl8/wGOIubNrWNFR0GrQR1jZxiTkINHA608qYldD8BGRA6vdKRGz89cR4MeelMruIwLzjI3NeNDKBaO9lwS+zcvc6bExYLQXvau+HE/RXZOPRxFhFmP4xSCegHpIT3HbmZ4M3AFY6cvqdcMGHSj8WzV3TT+2p1XfWQFLVN/SsY8cAgmtsLqTtMWQLYi83qUz6WpJgABkWM2hg== X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: ba49a62e-ba78-49c5-aeb1-08dbfa0f1900 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2158.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Dec 2023 06:04:55.4857 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: sbx6qlmhtijDY7QMlRGW0WkvNVx5myu9h+u6gt6eQ5P9uj3dVVcuz9mkm7w46PAGu8plBozMzcciQFK1KFXfgA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4610 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-12-10_16,2023-12-07_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0 spamscore=0 malwarescore=0 mlxscore=0 mlxlogscore=999 adultscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2312110049 X-Proofpoint-GUID: KElKPfWG2fzBTDYSopFyk1Jr0hPpPpaZ X-Proofpoint-ORIG-GUID: KElKPfWG2fzBTDYSopFyk1Jr0hPpPpaZ X-Spam-Status: No, score=-13.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: [No changes from V2] - cfi_sections_set is best set to true in cfi_dot_startproc (). Setting it to true again in other APIs (dot_cfi_endproc, dot_cfi_fde_data, and cfi_finish) is unnecessary. - move setting the global var all_cfi_sections into cfi_set_sections (). gas/ * dw2gencfi.c (cfi_set_sections): Set cfi_sections_set and cfi_sections here. (dot_cfi_startproc): Remove unnecessarily setting cfi_set_sections to true. (dot_cfi_endproc): Likewise. (dot_cfi_fde_data): Likewise. (cfi_finish): Likewise. --- gas/dw2gencfi.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/gas/dw2gencfi.c b/gas/dw2gencfi.c index f57479457c4..cbfee0a0169 100644 --- a/gas/dw2gencfi.c +++ b/gas/dw2gencfi.c @@ -492,6 +492,7 @@ cfi_set_return_column (unsigned regno) void cfi_set_sections (void) { + all_cfi_sections |= cfi_sections; frchain_now->frch_cfi_data->cur_fde_data->sections = all_cfi_sections; cfi_sections_set = true; } @@ -1309,9 +1310,8 @@ dot_cfi_startproc (int ignored ATTRIBUTE_UNUSED) } demand_empty_rest_of_line (); - cfi_sections_set = true; - all_cfi_sections |= cfi_sections; cfi_set_sections (); + frchain_now->frch_cfi_data->cur_cfa_offset = 0; if (!simple) tc_cfi_frame_initial_instructions (); @@ -1336,7 +1336,6 @@ dot_cfi_endproc (int ignored ATTRIBUTE_UNUSED) demand_empty_rest_of_line (); - cfi_sections_set = true; if ((cfi_sections & CFI_EMIT_target) != 0) tc_cfi_endproc (last_fde); } @@ -1418,7 +1417,6 @@ dot_cfi_fde_data (int ignored ATTRIBUTE_UNUSED) last_fde = frchain_now->frch_cfi_data->cur_fde_data; - cfi_sections_set = true; if ((cfi_sections & CFI_EMIT_target) != 0 || (cfi_sections & CFI_EMIT_eh_frame_compact) != 0) { @@ -2315,7 +2313,6 @@ cfi_finish (void) if (all_fde_data == 0) return; - cfi_sections_set = true; if ((all_cfi_sections & CFI_EMIT_eh_frame) != 0 || (all_cfi_sections & CFI_EMIT_eh_frame_compact) != 0) { @@ -2502,7 +2499,6 @@ cfi_finish (void) flag_traditional_format = save_flag_traditional_format; } - cfi_sections_set = true; /* Generate SFrame section if the user specifies: - the command line option to gas, or - .sframe in the .cfi_sections directive. */ @@ -2524,7 +2520,6 @@ cfi_finish (void) as_bad (_(".sframe not supported for target")); } - cfi_sections_set = true; if ((all_cfi_sections & CFI_EMIT_debug_frame) != 0) { int alignment = ffs (DWARF2_ADDR_SIZE (stdoutput)) - 1; -- 2.41.0