Re: Re: [PING^1][PATCH v2] RISC-V: Imply 'Zicntr' and 'Zihpm' implicitly depended on 'Zicsr'

["Xiao Zeng" <zengxiao@eswincomputing.com>]

2023-12-07 16:12  Kito Cheng <kito.cheng@gmail.com> wrote:
>
 
>LGTM 
Thank you for Kito's code review

>
>On Thu, Dec 7, 2023 at 11:13 AM Xiao Zeng <zengxiao@eswincomputing.com> wrote:
>>
>> This commit adds support for ratified extensions:
>> 'Zicntr' and 'Zihpm', Which are all implicitly depend on 'Zicsr'.
>>
>> This is based on:
>> <https://github.com/riscv/riscv-isa-manual/releases/download/riscv-isa-release-056b6ff-2023-10-02/unpriv-isa-asciidoc.pdf>
>>
>> bfd/ChangeLog:
>>
>>         * elfxx-riscv.c:  Add 'Zicntr' and 'Zihpm' -> 'Zicsr'.
>>         (riscv_supported_std_z_ext) Add 'Zicntr' and 'Zihpm' to the list.
>>
>> gas/ChangeLog:
>>
>>         * testsuite/gas/riscv/attribute-15.d: New test.
>>         * testsuite/gas/riscv/attribute-15.s: New test.
>>         * testsuite/gas/riscv/attribute-16.d: New test.
>>         * testsuite/gas/riscv/attribute-16.s: New test.
>> ---
>>  bfd/elfxx-riscv.c                      | 4 ++++
>>  gas/testsuite/gas/riscv/attribute-15.d | 6 ++++++
>>  gas/testsuite/gas/riscv/attribute-15.s | 1 +
>>  gas/testsuite/gas/riscv/attribute-16.d | 6 ++++++
>>  gas/testsuite/gas/riscv/attribute-16.s | 1 +
>>  5 files changed, 18 insertions(+)
>>  create mode 100644 gas/testsuite/gas/riscv/attribute-15.d
>>  create mode 100644 gas/testsuite/gas/riscv/attribute-15.s
>>  create mode 100644 gas/testsuite/gas/riscv/attribute-16.d
>>  create mode 100644 gas/testsuite/gas/riscv/attribute-16.s
>>
>> diff --git a/bfd/elfxx-riscv.c b/bfd/elfxx-riscv.c
>> index 567631e7d96..4c91081acd1 100644
>> --- a/bfd/elfxx-riscv.c
>> +++ b/bfd/elfxx-riscv.c
>> @@ -1144,6 +1144,8 @@ static struct riscv_implicit_subset riscv_implicit_subsets[] =
>>    {"zvl256b", "zvl128b",       check_implicit_always},
>>    {"zvl128b", "zvl64b",                check_implicit_always},
>>    {"zvl64b", "zvl32b",         check_implicit_always},
>> +  {"zicntr", "zicsr",          check_implicit_always},
>> +  {"zihpm", "zicsr",           check_implicit_always},
>>    {"zcd", "d",         check_implicit_always},
>>    {"zcf", "f",         check_implicit_always},
>>    {"zfa", "f",         check_implicit_always},
>> @@ -1260,12 +1262,14 @@ static struct riscv_supported_ext riscv_supported_std_z_ext[] =
>>    {"zicbop",           ISA_SPEC_CLASS_DRAFT,           1, 0,  0 },
>>    {"zicboz",           ISA_SPEC_CLASS_DRAFT,           1, 0,  0 },
>>    {"zicond",           ISA_SPEC_CLASS_DRAFT,           1, 0,  0 },
>> +  {"zicntr",           ISA_SPEC_CLASS_DRAFT,           2, 0,  0 },
>>    {"zicsr",            ISA_SPEC_CLASS_20191213,        2, 0,  0 },
>>    {"zicsr",            ISA_SPEC_CLASS_20190608,        2, 0,  0 },
>>    {"zifencei",         ISA_SPEC_CLASS_20191213,        2, 0,  0 },
>>    {"zifencei",         ISA_SPEC_CLASS_20190608,        2, 0,  0 },
>>    {"zihintntl",                ISA_SPEC_CLASS_DRAFT,           1, 0,  0 },
>>    {"zihintpause",      ISA_SPEC_CLASS_DRAFT,           2, 0,  0 },
>> +  {"zihpm",            ISA_SPEC_CLASS_DRAFT,           2, 0,  0 },
>>    {"zmmul",            ISA_SPEC_CLASS_DRAFT,           1, 0,  0 },
>>    {"zawrs",            ISA_SPEC_CLASS_DRAFT,           1, 0,  0 },
>>    {"zfa",              ISA_SPEC_CLASS_DRAFT,           1, 0,  0 },
>> diff --git a/gas/testsuite/gas/riscv/attribute-15.d b/gas/testsuite/gas/riscv/attribute-15.d
>> new file mode 100644
>> index 00000000000..a17e82c8508
>> --- /dev/null
>> +++ b/gas/testsuite/gas/riscv/attribute-15.d
>> @@ -0,0 +1,6 @@
>> +#as: -march-attr -misa-spec=20191213
>> +#readelf: -A
>> +#source: attribute-15.s
>> +Attribute Section: riscv
>> +File Attributes
>> +  Tag_RISCV_arch: "rv32i2p1_zicntr2p0_zicsr2p0_zihpm2p0"
>> diff --git a/gas/testsuite/gas/riscv/attribute-15.s b/gas/testsuite/gas/riscv/attribute-15.s
>> new file mode 100644
>> index 00000000000..ecb10a298fd
>> --- /dev/null
>> +++ b/gas/testsuite/gas/riscv/attribute-15.s
>> @@ -0,0 +1 @@
>> +       .attribute arch,"rv32i_zicntr_zihpm"
>> diff --git a/gas/testsuite/gas/riscv/attribute-16.d b/gas/testsuite/gas/riscv/attribute-16.d
>> new file mode 100644
>> index 00000000000..6ca3b5351f8
>> --- /dev/null
>> +++ b/gas/testsuite/gas/riscv/attribute-16.d
>> @@ -0,0 +1,6 @@
>> +#as: -march-attr -misa-spec=20191213
>> +#readelf: -A
>> +#source: attribute-16.s
>> +Attribute Section: riscv
>> +File Attributes
>> +  Tag_RISCV_arch: "rv64i2p1_zicntr2p0_zicsr2p0_zihpm2p0"
>> diff --git a/gas/testsuite/gas/riscv/attribute-16.s b/gas/testsuite/gas/riscv/attribute-16.s
>> new file mode 100644
>> index 00000000000..8757bb5181b
>> --- /dev/null
>> +++ b/gas/testsuite/gas/riscv/attribute-16.s
>> @@ -0,0 +1 @@
>> +       .attribute arch,"rv64i_zicntr_zihpm"
>> --
>> 2.17.1
>>
 
Thanks
Xiao Zeng