From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (woodpecker.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id 1E9AC3847738 for ; Sat, 16 Dec 2023 04:02:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1E9AC3847738 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1E9AC3847738 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:ea4a:1:5054:ff:fec7:86e4 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702699379; cv=none; b=dEF8DHPMlhJP9uQX6KPBSAaI1F7zLTQ4yNjuGdJ1edyfom0XlXYiuC54L0scB6C6uZROcRRHhfFcC/zOaz9vTi9pCHf5p411Y+jsAvPsULSXhZo/wbWAas1Dl0qrFvGjhzsysUhBCk9xTnoWP6nndPWRIMMP/vkyD0sJB2NH2Nk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702699379; c=relaxed/simple; bh=oQ+NxnJqUXqvalnWeGmfe/2ZNP6nBB+MxigoOdis0Xo=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=SbLx7efhHb2CPqdTYnxpTwSqVB/lwdOZ8BNOXpih0zJOsxcear1q9HvS0+JrfSe3dfbyEA1OAZgh8QOfJNeY7j86Vk/1gvbZa8Yer7h+YQt+UB2f6to3r+gY+OgeCR+wvsrEaKOp3k+R+2Z/bMHAjwURxGr4S33xcIirxqrOLvI= ARC-Authentication-Results: i=1; server2.sourceware.org From: Sam James To: binutils@sourceware.org Cc: nickc@redhat.com, Sam James Subject: [2.41 PATCH 07/10] ld: ld-lib.exp: log failed dump.out contents for debugging Date: Sat, 16 Dec 2023 04:01:30 +0000 Message-ID: <20231216040239.1981071-8-sam@gentoo.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231216040239.1981071-1-sam@gentoo.org> References: <20231216040239.1981071-1-sam@gentoo.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-10.0 required=5.0 tests=BAYES_00,GIT_PATCH_0,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: If we're using dump_prog in a test which fails, log the dump.out contents to ld.log to aid debugging. This avoids needing to ask reporters to manually run e.g. `objdump` commands when making bug reports. PR30722 * ld/testsuite/lib/ld-lib.exp: Log failed dump.out contents to aid debugging. Approved-by: Nick Clifton Signed-off-by: Sam James (cherry picked from commit 646657284f6b62a71a6869826e951b3def4d73a6) --- ld/testsuite/lib/ld-lib.exp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ld/testsuite/lib/ld-lib.exp b/ld/testsuite/lib/ld-lib.exp index 918464069a9..aca303e0728 100644 --- a/ld/testsuite/lib/ld-lib.exp +++ b/ld/testsuite/lib/ld-lib.exp @@ -640,7 +640,7 @@ proc run_ld_link_tests { ldtests args } { remote_upload host "dump.out" if { [regexp_diff "dump.out" "$srcdir/$subdir/$dumpfile"] } then { - verbose "output is [file_contents "dump.out"]" 2 + verbose -log "output is [file_contents "dump.out"]" 2 set failed 1 remote_file build delete "dump.out" remote_file host delete "dump.out" @@ -1067,7 +1067,7 @@ proc run_cc_link_tests { ldtests } { } if { [regexp_diff "dump.out" "$srcdir/$subdir/$dumpfile"] } then { - verbose "output is [file_contents "dump.out"]" 2 + verbose -log "output is [file_contents "dump.out"]" 2 set failed 1 break } -- 2.43.0