From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id 3C46D3858C2F for ; Wed, 3 Jan 2024 07:15:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3C46D3858C2F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3C46D3858C2F Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=205.220.177.32 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1704266144; cv=pass; b=kS35J6xAFMcgfXeQaLY1bg3Ri6hU17X6Q2E2Ycb3wkqaHHZ/A0oboV4lASHGSZOn6mFj1ykT3CtlB+rwLHxvZC7JiYQ0QGtowVP7FQTH7iwB36ZUieVtL3xn6ENXHzMpFkacMnTEc94VrU4gn8gNj5yLydGEGnx0lzpjEomHvk4= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1704266144; c=relaxed/simple; bh=URxwiU3FzOmxQv/0MN4xe4iWsxOZ9UWnqh4Uuj5H2dE=; h=DKIM-Signature:DKIM-Signature:From:To:Subject:Date:Message-ID: MIME-Version; b=jS/3eomm4v36xyXhrKjPt7mNA1cVNNh/k1Fmw8m9RjrEumylYwlg+Y+wsJi2fhBhnqtBfu4BRIMXHT/IaXFB6GcGfLGwUEIrMJQt4ZfjzSmMIV1/+7vMVvrzOxhbSnB/6g6tMobJBptz3SVx7WFJLAPD+LEoisjJuyL7dLrQSj4= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from pps.filterd (m0333520.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 4030hr1A012111 for ; Wed, 3 Jan 2024 07:15:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : content-transfer-encoding : content-type : mime-version; s=corp-2023-11-20; bh=F/btLiFu18Qgp6A6mHhWtCkLhNShhW+2oWfPVtBz6Gs=; b=K+sdNv2VOSLb78g1nSptXwp1XmfiF8QuZP/zhegQrKlx+YMl6vbSxplpeWotkB8qmRIj W1w81LSvqPpFMwbPykQwa7Jt90AQvHs3XF6B8CZlonbn2UDv6BE9DpHa4isKD0CbnVbI V+qtcVkODM0jQM0o6dv/8CJ8z4Wfcc+BQNUrPFDdO8CeYUsBTQB1VGzhQpnVxS3BBnWS P0ENv/L+5kbKPUpJCZfosO+SKZhzHBd6/1CZtT+YFVa0Ypa5C2/zeUB6oqmSQ4PrxrBb l+pUny07RarkVNcpekmWxeU77KOMZB+N15YdDNUjgZevVwE6SBe0EyfvvjrH2K6b8yhH tg== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3vab8d4ebq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 03 Jan 2024 07:15:39 +0000 Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 40372UOc001700 for ; Wed, 3 Jan 2024 07:15:38 GMT Received: from nam02-sn1-obe.outbound.protection.outlook.com (mail-sn1nam02lp2041.outbound.protection.outlook.com [104.47.57.41]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3va9n8pdee-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 03 Jan 2024 07:15:38 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dSbFcG+vzreQXLGHiYrATlrf6woYDxh9rM+LPAPWZAu6KQin9O6BekNaL0G46Hrkxo6HJpE4Vp1ZToWdndGFyHkXGccOFsNutByTaod4rWweprTFq79iVVDZBdQQwfH9BewuB7UwDk5EmyjqrLnTS6J28ffl5rsGzrNpOfVo1KQGr3Mwt8i4DrhkYD8PpTO9PIgQRKx1g0Aj7UxsALnUhKcUCvMTuKuw/WAYQ9SOn8B7qkeGLrbeXO+//bvMjbkbiC85QO/iJea8xzos6zqTvrvbD1w/IrwIHCG54CfiIzNYsDvIAtn+PHFp6pmRtDlFqs5y0+fjGwtyazlvJmNO3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=F/btLiFu18Qgp6A6mHhWtCkLhNShhW+2oWfPVtBz6Gs=; b=Mm1Hoi/cgJGB0TsMtIv2CXVNXysklHtkwc3OOORQ0n5WSmYF54Lih+sU8sWqQQx1gZz9g+BTqDDXsee4ZK53o/fVgRjqPcHdE6XeB8SERKBeymBzu1BZLSoOUz9evuhpMXh3oCnq4JlNL9Gv2M4NsKCjL8hBncI8Hkg2NdlmfpmfjJcZvahC17tSjHBEEEDkvxxd06xpnu5SPtJwSEBTwTanFwac80FAgLH32Iw9mkCzZ0d09jirmiBxZwYy2kIUupmyJDy84AWgF1lxohCXBVmehWOv+rGXtQIvUMCRfn+zAz35a2Zm3Hgkx6SbUdvkjK1I9jgo9X2vahbYxh+Hpg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F/btLiFu18Qgp6A6mHhWtCkLhNShhW+2oWfPVtBz6Gs=; b=DLvlenpVnqArCm6cEj7mvkXE8mqtL2WU4Mqgl58QmUFgy9idxwRszMKBMNitwzE7fsygAzVf9dLw2SJL+B2MfYeBOm1WhlLEwi9PKTkP71Xn/u5XCcvCvg7cA5FGgVV8x+YQzjA/3roIsItcgQd4FO19RmN+pjXISHtY/CAihLk= Received: from MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) by CY8PR10MB6777.namprd10.prod.outlook.com (2603:10b6:930:98::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7135.25; Wed, 3 Jan 2024 07:15:37 +0000 Received: from MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::fde7:fb92:8ea1:a5ac]) by MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::fde7:fb92:8ea1:a5ac%4]) with mapi id 15.20.7159.013; Wed, 3 Jan 2024 07:15:37 +0000 From: Indu Bhagat To: binutils@sourceware.org Cc: Indu Bhagat Subject: [PATCH,V4 01/14] gas: dw2gencfi: minor rejig for cfi_sections_set and all_cfi_sections Date: Tue, 2 Jan 2024 23:15:13 -0800 Message-ID: <20240103071526.3846985-2-indu.bhagat@oracle.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20240103071526.3846985-1-indu.bhagat@oracle.com> References: <20240103071526.3846985-1-indu.bhagat@oracle.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: MW4PR04CA0342.namprd04.prod.outlook.com (2603:10b6:303:8a::17) To MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2158:EE_|CY8PR10MB6777:EE_ X-MS-Office365-Filtering-Correlation-Id: 2cc5966d-6a28-4072-d12a-08dc0c2bc8d8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: M5sUVgVpsrXh9GE/EpjlO0+i8Yf/tl8TBQFp4jv2Vsr/7P3dS59vbzkKu+uYXlUSj+49gYrvP+UE8CixAH3uamrf7hF1XTm/vZxyKaCII9+SPpnyaod8m0CTPXKfvcEvRpDImTn+UZpCN6m9ZWRefFhWbFsWixN8Tvos0iLVz/7wVFvNRQZ/J9l+5avwEwOs/TgVmjODBv2shQ55X2SN8SXWuB1jCCg2mGJHA7xKYVCodCEryRN+bRF5szQR+aHhI4b91SrWFNFmReM+Ro366UNVye2pLH5y01UobCjCP/Nhiwoc8rf0i0qMckrcDEMYoJ1plN22A7mpJQb+GqrdULd6PyeOVj5QUS7EBsaEddSxiV8nXnJQ+djNazxmKFNuiCwdUz3ca3eVmX9rm/26JURLknqj4jI1DGKtkjJniyIP7KwvmImVUXYmEvaklbtF1z5POU0Ms+xA4x0EBhjdyCK6PoeEZeIm5/o45fv22LDSxo2S/fjVWzsvPcVzaJ3pmD36oxV6e+hViEfybNyTF7/xrQXig5ykftqghU6cXww/yD21Dax2nPfGZVgnsyn7 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2158.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366004)(346002)(396003)(136003)(39860400002)(376002)(230922051799003)(1800799012)(186009)(451199024)(64100799003)(38100700002)(36756003)(86362001)(107886003)(1076003)(2616005)(6506007)(6512007)(6666004)(4326008)(478600001)(6486002)(8936002)(8676002)(316002)(66476007)(83380400001)(66556008)(66946007)(6916009)(41300700001)(2906002)(44832011)(5660300002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Ovoy6cEaJFtux+0B/XrYmrRRDV9zhhg9K2FXij6aovzC3yCujrh/m7jFP0bU?= =?us-ascii?Q?anQE7ltz3ptXXQoSuFP4PgcHVw/l9Ws7bz58LRuc5x2MdC/dkbKgp6jP4SDR?= =?us-ascii?Q?CrgV6EXKuZEXgJ9dZP1uablIHNFdOXP2Jx97tsfV8j1h6aMcdHO48t/fSK5j?= =?us-ascii?Q?+YxGMKOXfNvarwM6eZM6RbOaK6fm2H/n7gUj8SdFBhFtQJx3mYfz4fh5tktg?= =?us-ascii?Q?5CpXlNXYkg68OfYk/yL9Ts0X8wau2vB+CdCStkAHIUdvIKAbjRqhfS4CkQXl?= =?us-ascii?Q?GWyhuI3h/upuaEpOMcv71o4TIoMvgTjPxvuDZP2IfEZ7n7XSKI2vppel01Lv?= =?us-ascii?Q?65bGzs5RYJIwYenM9MdMPUIzbOcQISn4hb+xY4CUYLUKzGiTgWTtoRYtg4pY?= =?us-ascii?Q?LTrNIlLPnDYWlLTSGHyEADov360G6gE2x+zHWC3M5sRjqr+ZUGtvlnE0w4nX?= =?us-ascii?Q?wNfRsoz7qay1LkbY39+0eBrzEtzBBRRAVCPD/YOFfNs2G1Fl3Y60lu5PlBE0?= =?us-ascii?Q?m4oiUplQuS7Vf831d3CnHIRMpbfG4Xs78mLCkNWM15eSXyEDysZKAK4+azuW?= =?us-ascii?Q?qH8p72at7ZzwhXk1RI/AROBikotiBJ/9tpvSHnSwd+FD1ygsE+6/SOh4ifia?= =?us-ascii?Q?LB0MIbtkLSyiSOLlKmdNDuPlTTvV8rC97xJwLhbo6X2vSjfZjOq9O0tu9wgw?= =?us-ascii?Q?kSfO6vX9rhQMXBOCcDDEONEjsaGKdSMJtan5peKoglLdpAASzlyzEUVZyRJ1?= =?us-ascii?Q?wsXgLm9Lu+Ga2c2vkUncOk6Fb09rlNRvVX8eCS39V0JpoRwvxzPwATSfu/Mn?= =?us-ascii?Q?yqiLP3YbLn7FPjsLPzM20ssq4dvx5FTziH4r/UJOQHqxUn9/gVj9c6F7BCMO?= =?us-ascii?Q?IwAlxuJCc2aCD7A6FwSU3G+jaHCxngRLm4PR7bbirtQetD4MhHDrfuEOV/So?= =?us-ascii?Q?sSmDFDSOLVN8jaLzWTHoeUWcOoLPo7WOJ/5jBgKpt48g/C2CIzxw45mZHveN?= =?us-ascii?Q?KY1KIqMswxtLQZQzmzHpxvWiUdkN+hotGQ38t1S1/3ng6KcXqw+t4z8M/NBE?= =?us-ascii?Q?hPfunreNtw9NUhgQkiTEVYXO/WzyTI7YmWJDQMscPGq1dY/Er6LIbwU5AXRL?= =?us-ascii?Q?KtPHej7yCTHeGOcRF2mB8+fNIAhEAFB9sB3bd1tWmqUYXyv8cpVCgr2V+rbH?= =?us-ascii?Q?zQxK7ZmvqMY/oqBA8J75CDZ6qDrjOtcTwfh8trG/N5Dh4w2+RSxJeXkJ3e0+?= =?us-ascii?Q?dFY6Coc5hdnDO6Q5boODrMCULYsGoEfnV2rQvrbV95fKzjbr4ItCna7DXrr7?= =?us-ascii?Q?OncCTB21NC9TF4fcIjUhmis/2sNkmrHQRWD7S9gJ6qkVhKPvuR9XybIo5lAD?= =?us-ascii?Q?YuebJSBZWAE3GjoW70rRIypdZ5+Ksosuxfs70g53K18jQdNevFEolmvrQ4l0?= =?us-ascii?Q?Stz64RaVyQ3qTk25X6dh/zPuwybxEKZacwIUQsa7UBrycZDB1r7pndB0Dj5d?= =?us-ascii?Q?0eh/izbY6ezW9pArzm2lVmH9gFBjuC+W7EJo2++QjpCaIybfPrc2pa+rcVYA?= =?us-ascii?Q?YBrvrA+mpCbpJrQbkn3vBNFCeDHUFjJbxyrQBpETMCzormUBqeshp826q1jr?= =?us-ascii?Q?r8/dkDesMM/TPmOiQ11C/lI=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: g/Dq4PVjyqLxrycuHoRmYQodKgqxjARrGCPP1ESdW1K+SzbKPndU6tDJoPHZtu/cyQaO1hPelcOEGWM6dijdGXFh6y1SySvRhFlj4y25r9Y0yQ3TpWUmbg90Cw/J4qU9G4g0zng9oizgDgQNiG8nDL97hpM79DK1uQVGAI/8ziX+K1f5K51EQGCaq4VNkhQR7x0WSEav6AEjOYrJ9a9JLYNbwLMFobtu8UWS0be+zillMS2g7s3lfXbvju9JCkZDnNUyNsF/E1KHBua7DHPwKwUvfjipUpegnatYGzCD3zg3953sjxo/NmjHbTxXrZ80bS3XjZd4MZBqHW2Lm2M/bFg20EZWF1/HzP04g/j/ViZfZ0ThO5Zs6+ca7W4aYWUlVzdcBBQBmbe05HTihZ4csRrqJLTTwtwIBKZ8Dwd09vtNfNI0nmRvkaXmOUj5hSz2ba2lezjxwSuYcbtQSz1iPQl/tKvTGgNmtzf86sIuvlsZ2003upWQxPqATigORFJl+lFUa5MMsk5J0rRl4bWzBINbmrOqzNHpnZeN0Wr7DS75UU4ACsmkAASMgJC64L2MGKXo4COE/pItFHCPb/F9qTvBTwm4U0oOguH/P6gdsHM= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2cc5966d-6a28-4072-d12a-08dc0c2bc8d8 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2158.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jan 2024 07:15:37.3739 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Hh6unwUh6hHh0prhRHBvRXg41VRutrGGZo2Q5WLVP0/InE6UDvdDdvDiilSTCG2rkZJzUF1tm50ma/gR2LQeMQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR10MB6777 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-01-03_02,2024-01-02_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxscore=0 bulkscore=0 phishscore=0 suspectscore=0 spamscore=0 adultscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2401030059 X-Proofpoint-GUID: LT6ZuGNlgtY9a89ITMORwCLKSl6qwt1W X-Proofpoint-ORIG-GUID: LT6ZuGNlgtY9a89ITMORwCLKSl6qwt1W X-Spam-Status: No, score=-12.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: [No changes since V2] - cfi_sections_set is best set to true in cfi_dot_startproc (). Setting it to true again in other APIs (dot_cfi_endproc, dot_cfi_fde_data, and cfi_finish) is unnecessary. - move setting the global var all_cfi_sections into cfi_set_sections (). gas/ * dw2gencfi.c (cfi_set_sections): Set cfi_sections_set and cfi_sections here. (dot_cfi_startproc): Remove unnecessarily setting cfi_set_sections to true. (dot_cfi_endproc): Likewise. (dot_cfi_fde_data): Likewise. (cfi_finish): Likewise. --- gas/dw2gencfi.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/gas/dw2gencfi.c b/gas/dw2gencfi.c index f57479457c4..cbfee0a0169 100644 --- a/gas/dw2gencfi.c +++ b/gas/dw2gencfi.c @@ -492,6 +492,7 @@ cfi_set_return_column (unsigned regno) void cfi_set_sections (void) { + all_cfi_sections |= cfi_sections; frchain_now->frch_cfi_data->cur_fde_data->sections = all_cfi_sections; cfi_sections_set = true; } @@ -1309,9 +1310,8 @@ dot_cfi_startproc (int ignored ATTRIBUTE_UNUSED) } demand_empty_rest_of_line (); - cfi_sections_set = true; - all_cfi_sections |= cfi_sections; cfi_set_sections (); + frchain_now->frch_cfi_data->cur_cfa_offset = 0; if (!simple) tc_cfi_frame_initial_instructions (); @@ -1336,7 +1336,6 @@ dot_cfi_endproc (int ignored ATTRIBUTE_UNUSED) demand_empty_rest_of_line (); - cfi_sections_set = true; if ((cfi_sections & CFI_EMIT_target) != 0) tc_cfi_endproc (last_fde); } @@ -1418,7 +1417,6 @@ dot_cfi_fde_data (int ignored ATTRIBUTE_UNUSED) last_fde = frchain_now->frch_cfi_data->cur_fde_data; - cfi_sections_set = true; if ((cfi_sections & CFI_EMIT_target) != 0 || (cfi_sections & CFI_EMIT_eh_frame_compact) != 0) { @@ -2315,7 +2313,6 @@ cfi_finish (void) if (all_fde_data == 0) return; - cfi_sections_set = true; if ((all_cfi_sections & CFI_EMIT_eh_frame) != 0 || (all_cfi_sections & CFI_EMIT_eh_frame_compact) != 0) { @@ -2502,7 +2499,6 @@ cfi_finish (void) flag_traditional_format = save_flag_traditional_format; } - cfi_sections_set = true; /* Generate SFrame section if the user specifies: - the command line option to gas, or - .sframe in the .cfi_sections directive. */ @@ -2524,7 +2520,6 @@ cfi_finish (void) as_bad (_(".sframe not supported for target")); } - cfi_sections_set = true; if ((all_cfi_sections & CFI_EMIT_debug_frame) != 0) { int alignment = ffs (DWARF2_ADDR_SIZE (stdoutput)) - 1; -- 2.41.0