From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184]) by sourceware.org (Postfix) with ESMTPS id 415823858286 for ; Thu, 4 Jan 2024 00:31:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 415823858286 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 415823858286 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=45.83.234.184 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704328318; cv=none; b=lKK67mWXJp2V7PIChQCCbzm9ZvGJJmTBBa/Y8hjOTL8vQuR6bSBcxng7xvSBN5Al7/jGEBkFm1vXam0MSb9qOjbEHd73xY1IMxv1LjA6a0ajewQn1+dKyC/j2Hro/QCxwfjXgKt8lwkWrX0dB64+T9rcx5uf4xCcF5bFHoFin4Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704328318; c=relaxed/simple; bh=hOy0Ipo8khvxkvO+1ZgbU3HkhjSvnt4UlopPKBn4Pi8=; h=From:To:Subject:Date:Message-Id:MIME-Version; b=rquYV8IB0nRwN8b/rJDPRVP1//N8oCd/7hpAdzDr2o9lFwhJYmoxH/f0OHt8g8Ivo/wElpxcj4nbT5xdzVJw61r7Yg1WhYzGVerTfEdbE9hGQOLxs6/PJTfogCea+2iJ51koLxXvstVdNXDDFiiOu8O1w5yS4WXwAUjS/Met7a4= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from csb.redhat.com (deer0x03.wildebeest.org [172.31.17.133]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 445AA302BB42; Thu, 4 Jan 2024 01:31:56 +0100 (CET) Received: by csb.redhat.com (Postfix, from userid 10916) id 348EACEF2C; Thu, 4 Jan 2024 01:31:56 +0100 (CET) From: Mark Wielaard To: binutils@sourceware.org Cc: Palmer Dabbelt , David Abdurachmanov , Mark Wielaard Subject: [PATCH] bfd: riscv_maybe_function_sym check _bfd_elf_is_local_label_name Date: Thu, 4 Jan 2024 01:31:31 +0100 Message-Id: <20240104003131.820681-2-mark@klomp.org> X-Mailer: git-send-email 2.39.3 In-Reply-To: <20240104003131.820681-1-mark@klomp.org> References: <20240104003131.820681-1-mark@klomp.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-9.1 required=5.0 tests=BAYES_00,GIT_PATCH_0,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This fixes the ld "Handle no DWARF information" testcase. Which currently fails on riscv because a local label name is assumed to be the current function name. bfd/ChangeLog: * elfnn-riscv.c (riscv_maybe_function_sym): Also check _bfd_elf_is_local_label_name. --- bfd/elfnn-riscv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/bfd/elfnn-riscv.c b/bfd/elfnn-riscv.c index 509d61e5017..15c7fa3f89e 100644 --- a/bfd/elfnn-riscv.c +++ b/bfd/elfnn-riscv.c @@ -5452,7 +5452,8 @@ riscv_maybe_function_sym (const asymbol *sym, bfd_vma *code_off) { if (sym->flags & BSF_LOCAL - && riscv_elf_is_mapping_symbols (sym->name)) + && (riscv_elf_is_mapping_symbols (sym->name) + || _bfd_elf_is_local_label_name (sec->owner, sym->name))) return 0; return _bfd_elf_maybe_function_sym (sym, sec, code_off); -- 2.39.3