From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id 0A8F83857B9D for ; Thu, 11 Jan 2024 07:51:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0A8F83857B9D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0A8F83857B9D Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=205.220.165.32 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1704959484; cv=pass; b=nqfoUVHoviiZfMpzGHNgxd/sg+2a0Tb1aCF5E9sMjh7XsvJEHumvOx/vX2cNQ+iTUVeLh7gbY6L0sFMlATVALggJic10YR4nbLavGgN3yJQ3xM/GO+OAD7ctv0ZeWZRRlCfn88FLriGU0JWD5NdS8w/9luHNuaya8XfB9N4pjfk= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1704959484; c=relaxed/simple; bh=EaC4bQj8VuyMsp9CMn3VPle+LHs4CQutkjwCZCuoEuo=; h=DKIM-Signature:DKIM-Signature:From:To:Subject:Date:Message-ID: MIME-Version; b=KAkdkAJtZ3sUHpAF26leolWJ6NhDY2eTmwjxn/OQFAjelzLIeDL69dBRgGXTR7V4gtzKnbhgzF/g3ZqwllIP6GEpf+FkO1mQkcRsgxlFZAHt2zrkOn+hm4tTfa7pyXE/kz3L6NzcfQ0+qZBo4Zqrs+FT11GHt5tV96UgwWnfUhU= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 40B7iRrJ003609 for ; Thu, 11 Jan 2024 07:51:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : content-transfer-encoding : content-type : mime-version; s=corp-2023-11-20; bh=hOpDtHEZAKP+Lx8zydJ6w9LLVOZ/9XPIGTxpQ6o7Gx0=; b=blbA6mF8jU1T6QUYizhZijVqU3+WirA/paZEycdbYNXVDZ7ijbF82ef/W4mnPbmHOZHC FR373w5C2E9jYaI+tdlVUmPzGl4viIGTxE8SA/AlL/1aWbKRq0Thd9tO9kcX0L8lcDj6 6EdAjg3AjP62vPep83G41dCXbIKIvpiQxWiYwgrK7LalidnoVhJyXio/7hA5AeDm4W7A /7zqOwVy2UhRPQ9G4iEXVx7xjrB1sU+dN7ncYWb4u09oOHuqomJ5JsOUXdJPyhXFVBjR AYYoIBnlbS3vzCp1Kbhc5hkwm6adkImugYxqoc693lEmu0KmshmAF4Aa5nfTlYjLrhh1 hw== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3vj5k9rgsd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 11 Jan 2024 07:51:18 +0000 Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 40B6rWcg012173 for ; Thu, 11 Jan 2024 07:49:11 GMT Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2169.outbound.protection.outlook.com [104.47.57.169]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3vfuwkjsds-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 11 Jan 2024 07:49:11 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=We/cu9vCB1gVqWYqkdSJBUXZa85eA4ikmqRPIpIvxlM40xQ5UvUuDDfXmp799Dp8W3JGOJH6Lgh7+Qb9UU2+ou+s4t17PAd8NRL4lq7fOviy3onQmOciWThcSnVglVFfAF1vDqZ13wdgSQDeEZ9Wx83Jie9DEacY1Qqz4/LM5GvGvsu9roZzdQ8r4h7vELe0s7YAOLuA3I4mn6d6JrLGFdptHS3p/9N5RIRLHoagftbu75LkDFAnpZwCNU0/AmvtIPtSD9/nOJBn/nCPY5U4fR9flB/F+xikMuQUlyIOats/S7EeRwjhew3shQAODgHMeG3IWIgzm7TSVbmyObiRtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hOpDtHEZAKP+Lx8zydJ6w9LLVOZ/9XPIGTxpQ6o7Gx0=; b=XTmIqZaRLtmIILiBPPxkHYkvILkkMNFiVzSziAeyOxmrUHHa1kjbvq7nZRSIG7BI0pj3yyrdWCXeLUexJTsPcH8q6LcTMozYVPCCPlf87k1dWtYsPq2eVLPCbEb/Gu++4l/FIfQpoYs68ROmRa3Tw62St/1+2gLKlggO9Ot5XEOZ+VuBKie2hFBfQpV+5z8iinOej5XbmTlne47EOjjgsSo5TRikpGNn9mzu0YdAYZIqbE6jOEWSYjE/CxMKzFclhKsQv6d5DEduEhbgw6h2QgFS5jFjSsuOWmhoxvdTx8hfhq5TL1UWCLCE07ZAU+KL6Tnk5qi8BUVj1KyaKQQNDA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hOpDtHEZAKP+Lx8zydJ6w9LLVOZ/9XPIGTxpQ6o7Gx0=; b=o033QMOp4g4CPZWdLwt6cscnXt3R+mQ+QXxPNipXnPsfFzdWzjhil7+iaTDe06E2yTmZtVpenBIzTb3G0ANs6r8r4SaWEvNg5OKckOfAMmBE3K6rWu/yokbWRpzYQOu37JUuY4D5n6WJ/pZWXNJo3xcMTeuF+F9vB2xQ95mB1c4= Received: from MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) by BN0PR10MB4901.namprd10.prod.outlook.com (2603:10b6:408:126::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7181.19; Thu, 11 Jan 2024 07:48:33 +0000 Received: from MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::fde7:fb92:8ea1:a5ac]) by MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::fde7:fb92:8ea1:a5ac%4]) with mapi id 15.20.7159.020; Thu, 11 Jan 2024 07:48:33 +0000 From: Indu Bhagat To: binutils@sourceware.org Cc: Indu Bhagat Subject: [PATCH, V5 01/16] gas: dw2gencfi: minor rejig for cfi_sections_set and all_cfi_sections Date: Wed, 10 Jan 2024 23:48:05 -0800 Message-ID: <20240111074820.2677826-2-indu.bhagat@oracle.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20240111074820.2677826-1-indu.bhagat@oracle.com> References: <20240111074820.2677826-1-indu.bhagat@oracle.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: MW4PR04CA0185.namprd04.prod.outlook.com (2603:10b6:303:86::10) To MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2158:EE_|BN0PR10MB4901:EE_ X-MS-Office365-Filtering-Correlation-Id: 42233a5b-e733-44ed-fd91-08dc1279b597 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zoDTdhDw7zjYcimyCjyFKcHjNInq3poSL2eBM9gonz+oRdYOu0bps6D7o7jJz8zf5H2HSZCdoul+zGhhKwF2dEUGrj8RpDgmWA3IVnTAJjk3bk+tPPWBgWXsw3DGEF8nZyxSDuYgfoNFKpx0Ht9sfAU4nrFOMALeO1khogW/Sa2+1GkebZjVXEFoWL4zRb2AkxBPa1DkusAN3V+6K6HwZG8LhoGEAf/BHbbpDi374bU/FSoXBQdwfawoqwi4OVrTU9OVCw1z8ULB6e4pHrd3iQ8+DAAIfKPwr/baKz2FbGNVg9dlcDyqLuWoOoYGhT1nmSidzau/77gB+ferp+7F/Hq8nHiXeDSKPWrDLUbwEwhBl64/7IuOLKDCO1hZrpeTz9RKDuPuLEFpwEZcJTs037g29DeXvs0cVclVz3zj2DBy2nbbnuUmSIeiiC2SKjF+8vcFL63XXCkDRIO2gW5o3m5ll8tJE6xYy0nCmfb6KsbVpKAdhDOdxUHwNGYeALPslWdbS7uPyJE7Gw4kyRh0CRXpHUx16sbXAMkHMs2s7qstL+Gy9r1C2CXpNZwHHtWA X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2158.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(346002)(366004)(376002)(396003)(136003)(39860400002)(230922051799003)(1800799012)(186009)(64100799003)(451199024)(86362001)(1076003)(6512007)(8676002)(8936002)(107886003)(6916009)(478600001)(66946007)(66476007)(6506007)(66556008)(6666004)(6486002)(83380400001)(316002)(2616005)(44832011)(4326008)(2906002)(38100700002)(36756003)(41300700001)(5660300002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?8fvFLK3k7nV6YOJTmUBvhVdHLKIM2cVRkNEYpYnIsviCoVPbgD/C9r8IBGtl?= =?us-ascii?Q?cLpuineQ0WiKTXIaL4xBsD5szGv+9nSFygT8UYyrQ09NXK3Npe03zMTMoacJ?= =?us-ascii?Q?TOPIeLfSsE6DZ96XHrdDqHMUBGKl5RHEQF/xGHufigzdq1uiEpDK1df/wRLU?= =?us-ascii?Q?8iBNNc5Aqs+d2dpi2DT63N3w1nN3JSoNy+dO5Q9cR/o5B9CNqCbT3JaDlY2N?= =?us-ascii?Q?e6Jx/i7aT5qsofKx2gmmLbanx4/yZ7ZDePaaH0Cc3fS1c8/7LvzmiXDe48dM?= =?us-ascii?Q?TVZfpoML3FIxPx88Mrw49BQZ33iombdZ/htlMkkED5vhAivRfafHk+wvrpIt?= =?us-ascii?Q?0ALPsMgi4kwPIzWb8LzFR72fkktIWS07JchRNEqV7LvOUAw3q74BS1iHqTME?= =?us-ascii?Q?6ujm3NT8lhezXTcnARlbpX1nInt0NZ2VPKONva3NOxCLLWj+q2e7tYY5SDlN?= =?us-ascii?Q?9Wr6CrQVrXABHsBfCf2azRMj3HhAj3/4qBNLc2XmAz3F+/nb0+PYb6Wq9jdo?= =?us-ascii?Q?e7EAkIOjCy2/6ldJpymTwyumWiQk1FLZ9KkqJBIbMmu6lDtKkT7sjXKyaGTQ?= =?us-ascii?Q?yQzO2UURw5fe2EwaUulkW8Wtxiv6UficHSTEdYu+j5gmY70bXbdHH6r1bVhw?= =?us-ascii?Q?xwdhg0MY397az93aT2+Q4kxQizSuS3cSdTya3F3s2xYunURU32SbI6GvYIb+?= =?us-ascii?Q?4/50HH29C/CH9QHdOPWsmnflZSSOT4M7/ENMUzqcBiCUhWJbrbsjx69lp9Dq?= =?us-ascii?Q?JAjGb0ZJPPxjL++aEz6C47Thm+PG5ZPEzTQZXQNH+7XQy9f60fXDTxD7jjdn?= =?us-ascii?Q?SNB5AfIyo+mDcRweiShqJJJCZULMEJaGi+lUrUzTNG+e7G8K6Y5AUzdJpCBR?= =?us-ascii?Q?tHHlx8s9aUqBkMUaJ02G+T6H9kzTpnnMVAiW7HQySTN/zyUraOTMv4HY0nUh?= =?us-ascii?Q?XutKK8QpUQk7hEJcvH5aYT8ufaJ3H7kiMhno1oVnh2LwuDn4TqIYBN8cBjji?= =?us-ascii?Q?2VXSqqPURzoqPxCC1tQPw5BZtJ/BsC++YYoWE5SeLIkpezbNKkaMhb6WxRQ6?= =?us-ascii?Q?lTT2s5bK+ijgYSNy+awtfpQCDyAIUPXvm+kh6K/Xvo3oxFzQZO35KQkl0zm9?= =?us-ascii?Q?dokT1vWRhiplkXV32q06S1U2hpxYnFf2wxrddnTogFyrWOEkZgA79evbGA4T?= =?us-ascii?Q?/aOI8ECecQKm20VY/ixMziYu2eex9nkP6RwKnVwKsnbh3Qxz9x1jOwVZ08xv?= =?us-ascii?Q?qrTe/dvaX5mwRoE9NOG0e0q9zkClK56oMPZThDAEV/MDBAiCD5WKH5pKDLVY?= =?us-ascii?Q?VUWuKYtr7MAnWfxSV3ltVVXB+qF0SjU0HTgwNvElBsenM7CNtJzqQqfYbh5r?= =?us-ascii?Q?MLZbAMxzwg87xmbtL5huSObzHic79e97/5wz+GHBuoJuWTRTkBMK5Q2DIv/y?= =?us-ascii?Q?Z4Lhz+nLGRvMzFakFLox5QjpR/17iB5SE57njLZYwVi/jRqPDBMshdVd8/X4?= =?us-ascii?Q?ga3tJq1JNPz5/6xQFZV3uqrci6/31Ptbn6t5Pn3n18DnvekS3wOoHuJSyn59?= =?us-ascii?Q?prbdBWOTWJ3Pu028uzA/lW5bXMTfKQqtZehxy7mPpST3kWlpbEadrIESRIFK?= =?us-ascii?Q?fZtP1nl941dvojesdu9u3UQ=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: U8NDiTM4p/G141ivQLTihRu81g1PG4fb8v+B2Uw2JoaIqE3EDzZsQhkEwKNt2kJ34GE+C2Dy/0hXS7uZ2gEiKXR3+asK+/RQwJbcuwN2tTdLJM4KLxfnbczU6R1nu4eu1qn618fK2ZERl4m0MUYy4bt+eA9upjVx7Iiwt4pHtucLeW/3uehFrtm5V7cNt3FEwfs9ZbLEdMr3cfd4um8gKFgi0YlouZWpnUqL0xoQNMgsrOTE5fmUCc77EwzFKpAiXR6iidmll0VBs4mZN4fUOhKH2MVwUCEjprPZzNZd18AjOCoB+E5mOldaCH5KhPqypN/p2jxQEmSVsO9imbtI40TRanGEeRz53N1931VwqUCtF3aoWSigr+CD7fOfBcgj8vUjT5Frtw68dt7EM2O3Fa9FmFCIEagdAe8+2WVO6xBO11avXuguHGW4IPSK/OGlgw90pHI6UAdJvNpuAg/EvYtqTRAclY1YXiSrMUTkJfGWEAK57xcd8cN/XTa0s1DQaLMTsV+/7TTZznIYyANeT2nlDe9nSUbieMMHWHDvyMdQPpLBigDM0JWdTQYofuabdV5L5v944lH7uGd6gnkYWMMQqq3vgiV7FLZ6XmVPy5E= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 42233a5b-e733-44ed-fd91-08dc1279b597 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2158.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2024 07:48:32.9690 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NsQcE089lXOSrgo2ehz2VtLzuKuMLNvg9crP4Yt5yTZ8WkxgugYrrGzm/Xm8qGh90y180v/jlhNzqW7LhkIKcw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR10MB4901 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-01-11_03,2024-01-10_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxscore=0 bulkscore=0 mlxlogscore=999 adultscore=0 spamscore=0 phishscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2401110062 X-Proofpoint-GUID: cck2JGxwPC1DFkO3MipbFaPlJoFdgh9W X-Proofpoint-ORIG-GUID: cck2JGxwPC1DFkO3MipbFaPlJoFdgh9W X-Spam-Status: No, score=-12.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: [No changes since V2] - cfi_sections_set is best set to true in cfi_dot_startproc (). Setting it to true again in other APIs (dot_cfi_endproc, dot_cfi_fde_data, and cfi_finish) is unnecessary. - move setting the global var all_cfi_sections into cfi_set_sections (). gas/ * dw2gencfi.c (cfi_set_sections): Set cfi_sections_set and cfi_sections here. (dot_cfi_startproc): Remove unnecessarily setting cfi_set_sections to true. (dot_cfi_endproc): Likewise. (dot_cfi_fde_data): Likewise. (cfi_finish): Likewise. --- gas/dw2gencfi.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/gas/dw2gencfi.c b/gas/dw2gencfi.c index 3afb20b11a8..01cde827f63 100644 --- a/gas/dw2gencfi.c +++ b/gas/dw2gencfi.c @@ -492,6 +492,7 @@ cfi_set_return_column (unsigned regno) void cfi_set_sections (void) { + all_cfi_sections |= cfi_sections; frchain_now->frch_cfi_data->cur_fde_data->sections = all_cfi_sections; cfi_sections_set = true; } @@ -1309,9 +1310,8 @@ dot_cfi_startproc (int ignored ATTRIBUTE_UNUSED) } demand_empty_rest_of_line (); - cfi_sections_set = true; - all_cfi_sections |= cfi_sections; cfi_set_sections (); + frchain_now->frch_cfi_data->cur_cfa_offset = 0; if (!simple) tc_cfi_frame_initial_instructions (); @@ -1336,7 +1336,6 @@ dot_cfi_endproc (int ignored ATTRIBUTE_UNUSED) demand_empty_rest_of_line (); - cfi_sections_set = true; if ((cfi_sections & CFI_EMIT_target) != 0) tc_cfi_endproc (last_fde); } @@ -1418,7 +1417,6 @@ dot_cfi_fde_data (int ignored ATTRIBUTE_UNUSED) last_fde = frchain_now->frch_cfi_data->cur_fde_data; - cfi_sections_set = true; if ((cfi_sections & CFI_EMIT_target) != 0 || (cfi_sections & CFI_EMIT_eh_frame_compact) != 0) { @@ -2315,7 +2313,6 @@ cfi_finish (void) if (all_fde_data == 0) return; - cfi_sections_set = true; if ((all_cfi_sections & CFI_EMIT_eh_frame) != 0 || (all_cfi_sections & CFI_EMIT_eh_frame_compact) != 0) { @@ -2502,7 +2499,6 @@ cfi_finish (void) flag_traditional_format = save_flag_traditional_format; } - cfi_sections_set = true; /* Generate SFrame section if the user specifies: - the command line option to gas, or - .sframe in the .cfi_sections directive. */ @@ -2524,7 +2520,6 @@ cfi_finish (void) as_bad (_(".sframe not supported for target")); } - cfi_sections_set = true; if ((all_cfi_sections & CFI_EMIT_debug_frame) != 0) { int alignment = ffs (DWARF2_ADDR_SIZE (stdoutput)) - 1; -- 2.41.0