From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id 75B153858415 for ; Mon, 15 Jan 2024 12:07:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 75B153858415 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 75B153858415 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=205.220.177.32 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1705320476; cv=pass; b=aM/tiym2YAnk7GLsa1UxW4gFi2YFrm7lkKI1Q9CBxqTHIxNdqTEAAWiHS9SHEmhTV4IbsSaMBuqjG7K9li3xC7G3R1nTSuF1XO3WiYBY5r+Ts78yHrfpfhz+J+bawybw5fSMJG8M0tG0rzeRL+H62Rl4m1kmn5RFayLef5ac8FI= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1705320476; c=relaxed/simple; bh=mvN6l4BeFYb0pUeW34Xzx7BtQ8jYC3ggZfD3FggrYvc=; h=DKIM-Signature:DKIM-Signature:From:To:Subject:Date:Message-ID: MIME-Version; b=wI+xiBwJahto0v7RBFjeiXVGrZsWkJMiKLCIaI4ELABRsUqFsx+pyg7FaFimPazIRh7Ayb45CAn4O3bjecfMRewO0xXZnfxjnMEM0QCsDGeR3PPCgHV9OMH/xMT9yCPwobo4aZvB8McaICw7/zoIyvig3QEt0TjT3Chje9ymu/Q= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from pps.filterd (m0333520.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 40F9DtW4005113 for ; Mon, 15 Jan 2024 12:07:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : content-transfer-encoding : content-type : mime-version; s=corp-2023-11-20; bh=5R4eRo82NKU5ehQLQFEvK9s4B5P2Ki6JXFiXf0dFJH4=; b=LedJ4uhYlbGfo/O+96IGZOwVDKRSc22S62u59NtjcCXkit+H1uyHuJhLPVnuAXQ2BPTL 62Rk56tiqgcElc8+0q12irG3I8JLAYuzCigia192IG6hLU9GSOTRm0CZop9k1peD4YJY I99jEVs8CrIX5iYOKkGSGIdKnu1gkLllNuOmb+8dZ7Cfecy8cnYQ3/AaSujqrVcC0Tp9 ifG5xypCbXSOx1ZZ07CFdLVtXP1DiRnuPOgX5yQY8CVRcDJdPlXcnwe9CEdudri1Gsia CkEO4q+k97Gthfenq9SJ7DYnTN74FOKjZtx5dS+n8qsYuykudyQ1Xm9zuLzbPWxD8FUr tQ== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3vkjjea9ce-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 15 Jan 2024 12:07:45 +0000 Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 40FAFmIB005104 for ; Mon, 15 Jan 2024 12:07:44 GMT Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2101.outbound.protection.outlook.com [104.47.58.101]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3vkgyby7wu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 15 Jan 2024 12:07:44 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZXPbXyebCDgs3B448K7AHQkZHn5IjeMpB7cV/fbX/iAKkhLvQBYxyl84m5rBppSqgoG536rJfeTK+mcx7erfTvGs1vDhmMIrix8UMHVQ2FCPHgXCLbyGKF33sxMGvmTWJzemHPlvGm+IyNRDc4iT30YJ8tf7TN6tLQ+yMhZ4BnCB2QL5+oZBYdnJMCKh3jA55vT8tlzClzDWgUDxidd9s3MJNfTU4vZOLLn7GZSrMVzB2NGjB2heM2TyztigM60Y3UnZItsv3LtwGfJ9IJOFdjPWnc6DmemIsjLd5fnqK/trorYRs8XPFT/COJ6mqX7A0pwaP+eGAi/qwCfKNIdWUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5R4eRo82NKU5ehQLQFEvK9s4B5P2Ki6JXFiXf0dFJH4=; b=BS3nC+4vGSbR/urwm7G4RVr1Ws8rhfV3kuNh+yy5WMbu+we9aid3Al3tljadAIE5Lqj26GKFdRU+NVwbNeLtEZu6Mvhd4QpqO1RDs7L0HTyVFvLVqhiOfIbttB9Ps3AF7Q4BkT8f86YEOPuVztFJZEBQ7hyToGjdbZuwLNJU+AsVcrjPZIW3aGYWTcpXHd+OLOZ8gytRLViuDSap5KXbMmFE8yxQDEDbpqcpVMiYeZqoGJQOBGmtVp4OkfYpJDrclg+R28QmfsbYRT0CqFSru+82Vm8RIHv/9qpERDUErsmcehPG8CZlfGeJwaqzqj71/zIkynsQh1hRagzT8kepwA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5R4eRo82NKU5ehQLQFEvK9s4B5P2Ki6JXFiXf0dFJH4=; b=KC4MZPoW1CtqG+NBa4Lmcjj7zD2q9tb67Po4FeZiI632/wnCUXRrtD8jTGw0K7S5TP5d23AvpZqoo0i/om8khsngUYfDpqT+/EisimEILb8CBhaSMZHg0yne3KJQc5R04EFyrihUUu20rK1IT0/PmVOSCKjWD95aI0Uyp6T8sJI= Received: from MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) by SA3PR10MB7094.namprd10.prod.outlook.com (2603:10b6:806:31b::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7181.23; Mon, 15 Jan 2024 12:07:42 +0000 Received: from MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::fde7:fb92:8ea1:a5ac]) by MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::fde7:fb92:8ea1:a5ac%4]) with mapi id 15.20.7181.026; Mon, 15 Jan 2024 12:07:42 +0000 From: Indu Bhagat To: binutils@sourceware.org Cc: Indu Bhagat Subject: [COMMITTED 01/15] gas: dw2gencfi: minor rejig for cfi_sections_set and all_cfi_sections Date: Mon, 15 Jan 2024 04:07:15 -0800 Message-ID: <20240115120729.29771-2-indu.bhagat@oracle.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20240115120729.29771-1-indu.bhagat@oracle.com> References: <20240115120729.29771-1-indu.bhagat@oracle.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: MW4PR03CA0132.namprd03.prod.outlook.com (2603:10b6:303:8c::17) To MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2158:EE_|SA3PR10MB7094:EE_ X-MS-Office365-Filtering-Correlation-Id: 93d11937-24b4-435f-75a5-08dc15c293b9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gXXjPIbhfFDPxPe4vE4Qal2o7WFc51/YpntTJWnKgspji7igi49WFA6wsFzUFvU+aQ9DLmvSbWoOLYYZbj9Aqykl0pKxmAOyMjV95Sn+ZK+7+UTwwFRaSL+UHD4BgidTHgRqfwzg0IhIriExtIzz2KsaPoJ/qFRRqpdiMiqdhXRrFb1qfps7zTtcKGTrKtnwmATLZgU5Ig6Xee+68bfZ4U8jbxjcTpUQqhDcTfGAKRUydM3jymv93HqyM8RkOfSotRVOrLic/wVB3e6fjR9IyAtCFCvwNYoeLQ+531QiLwf8mPdK/xx2aTdGTyukuhdpleykdpwLSmdHgdAFpk3FKMhnFDUCgCCXUyCrPNYO5Jn0qY7ACYp7+N34niglokC8aG6lMONraOlWnaoimXXY/mUW7kNPkHBYT1axfJYMP0wIcn6dh8ZanRwiWBfGyP0zni28qvQBIGj/fG8FBbh4hcZNI0HxwIjguaJzOaYhYljUWPWl9H6O47ZrQEDQuPUiPUoabBzMpKpd3YjHyowHp/bW11i0iH4wcDLgNGVBvm/Xd9jpFcasvi23HTgA9igt X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2158.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376002)(366004)(39860400002)(136003)(396003)(346002)(230922051799003)(1800799012)(186009)(451199024)(64100799003)(8936002)(5660300002)(44832011)(2906002)(6512007)(38100700002)(316002)(4326008)(8676002)(86362001)(66556008)(66476007)(66946007)(6916009)(6506007)(478600001)(6486002)(6666004)(36756003)(1076003)(2616005)(83380400001)(41300700001)(107886003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?mUzGxoz5EyR2xN0x5MKHakTztNVyowRc0n+QpWWVBa8R94NNTt4Fs6DoXwbZ?= =?us-ascii?Q?LoJnJK2/eoPcPoI+h17koCaLxXGsxAwivdfJwjxZOL4eIGvn+0JsvFgU2Ww/?= =?us-ascii?Q?FLir9NZCJdZJ7kSn3wXaE7/2BVO/QYNNzan5J7DBHNudDxyzuhsGygQxrd52?= =?us-ascii?Q?t8waYC2SkmnMLjRlL4pzqWnvI1gQ2+CwLxSqK8EXsFngD/wY0jrx0Eee3oht?= =?us-ascii?Q?HeWee5klFAsUAe8oVvOorgJsrm21RAVbIiN7HtvPUMfZ78tVHnWcMJLhn2BP?= =?us-ascii?Q?4uTPNCnCGVUbW8fwOBqm0b/ugGmUMornUA0MwSXnULyc+S9aM6196e62Bm7e?= =?us-ascii?Q?0cqNblzp/8jabj0PYDWec0y4nbS3JSCHS/GFRDoDL+nQR4bZgXOWMTZwGrvC?= =?us-ascii?Q?EVQ2mpndU+6PlyPMcWUOX+6qicKfVURw62155UCtiKZTp7Wv/mM8flyG90bt?= =?us-ascii?Q?b5tTxlID0H9Kfi+wwUQ86tfgo3FspY0pp9+nmvTE/csSQjdutiPbxLDyuBWw?= =?us-ascii?Q?8d8VG3BAR/xFCraolb/Y1s8kNTBdt+IhIoGj3FIju8zGfFDbv4s3AZmYLxJT?= =?us-ascii?Q?2LvwouG6tCp61iMpqlfl8goJaJEnaB/puZ7tWx0GedYvl6yfvbA/JpMRatKk?= =?us-ascii?Q?swQkbCPmYVuAnTErHJ3+CD7cGWCOg6oQiOnNYDcJ9bfJeEl1xofMtiihPLxc?= =?us-ascii?Q?HFY4IH/tHYudXnwtJdvd4/gmX8T6WeC1XKpTTUlaTlasRc2PBDbCxTc0YphG?= =?us-ascii?Q?Hq8DP0NiKfCYf8EG1JfpwgvkxJ2rtoSJzum3ze/+KuFHUrWIOfSUGgWsUM+/?= =?us-ascii?Q?gE/kYbLu9LymcDm8Pt5qYTvOaUhDPytaBPWuuzbr3RWtE6ljlhMfC2HjJ6iQ?= =?us-ascii?Q?Y9UXQPX/jmLp/lzVsFERjFFwfiMD0abA7Jt9pKmYrmVDUTZJRUm0CNhHZ9b7?= =?us-ascii?Q?RzkxG41CvhnLiulEFXyeZplOvnQPn3FHQ6xDJ0MAYdEQtGgJHBwL+bWpBeyF?= =?us-ascii?Q?sNceiW22yHX8abVdQqXgw7JhaKJwzpKxd2/2EWBygBVl767n6upEXhBvs0Km?= =?us-ascii?Q?NMydIwDBeF/9nbOzeDw3W9YWuTodqFFcAqHCGv2ie+waCaXK+DDB88PNy3F5?= =?us-ascii?Q?rTBjE5uzQpEP89ZZ0d75G4YB8HE/KfoRd4LZo1vMrOXEDar/8yqR4ZzWxH+U?= =?us-ascii?Q?G9FrWu3I7i+G5ZkThFZe6u3R8LX5LwOZNE4x8+4ijUkkM+JMBJazFf6YVyNq?= =?us-ascii?Q?GRZPueCWWE7+XIdR4gCmA8HqWgg950XUJRt5WpF9eDIQQpCsaCjQF59D9SPm?= =?us-ascii?Q?7R7RA7geXzm1nr3Te/iA/UD6keOiVHLgo002FfVGDlc5tbafTZYKnAALinUP?= =?us-ascii?Q?+B9SP1VNumbvX4roeD2AOLqDRAV9aDybnMD1s1H+UjKkJxWo6fsM8qz2p+4b?= =?us-ascii?Q?fH8mlh5x1V+UfjiCv4S9uEVRSyxqfiiTPq0iwQEn+kJN5uyIrMyUBB+VGtOR?= =?us-ascii?Q?jtXb1Z7ibMnXnHR6Qn1cpU2LaSTdNs2gVt6lhwx3V5TX6a0KBvtlHEE5UvwD?= =?us-ascii?Q?a8+Gj3dFb4zeK9vEURYh7aA7m+KGM/Jj1oWIIabJO1WJxOxDnqQXrHrZUk5M?= =?us-ascii?Q?x3kMquAom95zDsLPYVBhs50=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: OXSLhiey3lxY41S7eKn59sUmPO/yBOKovUB6szLe+mzVR4YmPhf4dN4s7bFy7rL3NAe8lrjjcaO2myjNJFfMezkQeEsi59ifvK4I7psswSdhzVRU9XFiXQWzkKwbFlA8AnIO11GZscaVsblTlMpzd0hOnYq9XNZ8id23DX2rEHlqKJ1S68JySDFgpj92/El/qnYyGD7go63KKbCMDEHjLJ54wR5vmutalK2TF7AxgrJd6QxrHyuDkBpKftvmyScy4wooSnaa00TeCPQKRrvfg7si5eIvbTMhkdrucx4wjl3q2YyRc2+EGqupb2mkZsJKdD043FwTveTX/5oez/YZbJ4x8W7wG3YVgDQBxWSlh1+zV0toxl9J4K5G+7vwmDO0nHip611xeXyakqZRieC/V3UAQQKJ4AQTzj2cUUTDGYEy0F5jZuMlavzIyrw6Pqx2mczDhrKdABxY8MGshBftwZJJJdxr6K80U1rNGU2m49ZG8vxiG+NHKAOMeNgKpzARx5iqGXRG4LuOxzCgLQ/cO4L2B3CTWGpASOcGxkOLn6mhN/NfrZM+rAz0CIsxzGmhQFQct0CekFNTPdefympm/Ey+k8X2r4RUo6tJkEhYq2o= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 93d11937-24b4-435f-75a5-08dc15c293b9 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2158.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jan 2024 12:07:42.7802 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: p+WUeYncfe7ds2hFDUr/FYFJg04412hazqvq6yq1vY/7Hi3CwQo8xbzoDjCd8nxKbkD4oNwaO0FslDtYA3UuuA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR10MB7094 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-01-15_06,2024-01-15_03,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 adultscore=0 phishscore=0 suspectscore=0 malwarescore=0 spamscore=0 mlxlogscore=999 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2401150086 X-Proofpoint-ORIG-GUID: 8OmUglAVBbN29YzFvw8-3QdpSrhTT_JT X-Proofpoint-GUID: 8OmUglAVBbN29YzFvw8-3QdpSrhTT_JT X-Spam-Status: No, score=-13.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: cfi_sections_set is best set to true in cfi_dot_startproc (). Setting it to true again in other APIs (dot_cfi_endproc, dot_cfi_fde_data, and cfi_finish) is unnecessary. Also, move setting the global var all_cfi_sections into cfi_set_sections (). gas/ * dw2gencfi.c (cfi_set_sections): Set cfi_sections_set and cfi_sections here. (dot_cfi_startproc): Remove unnecessarily setting cfi_set_sections to true. (dot_cfi_endproc): Likewise. (dot_cfi_fde_data): Likewise. (cfi_finish): Likewise. --- gas/dw2gencfi.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/gas/dw2gencfi.c b/gas/dw2gencfi.c index 3afb20b11a8..01cde827f63 100644 --- a/gas/dw2gencfi.c +++ b/gas/dw2gencfi.c @@ -492,6 +492,7 @@ cfi_set_return_column (unsigned regno) void cfi_set_sections (void) { + all_cfi_sections |= cfi_sections; frchain_now->frch_cfi_data->cur_fde_data->sections = all_cfi_sections; cfi_sections_set = true; } @@ -1309,9 +1310,8 @@ dot_cfi_startproc (int ignored ATTRIBUTE_UNUSED) } demand_empty_rest_of_line (); - cfi_sections_set = true; - all_cfi_sections |= cfi_sections; cfi_set_sections (); + frchain_now->frch_cfi_data->cur_cfa_offset = 0; if (!simple) tc_cfi_frame_initial_instructions (); @@ -1336,7 +1336,6 @@ dot_cfi_endproc (int ignored ATTRIBUTE_UNUSED) demand_empty_rest_of_line (); - cfi_sections_set = true; if ((cfi_sections & CFI_EMIT_target) != 0) tc_cfi_endproc (last_fde); } @@ -1418,7 +1417,6 @@ dot_cfi_fde_data (int ignored ATTRIBUTE_UNUSED) last_fde = frchain_now->frch_cfi_data->cur_fde_data; - cfi_sections_set = true; if ((cfi_sections & CFI_EMIT_target) != 0 || (cfi_sections & CFI_EMIT_eh_frame_compact) != 0) { @@ -2315,7 +2313,6 @@ cfi_finish (void) if (all_fde_data == 0) return; - cfi_sections_set = true; if ((all_cfi_sections & CFI_EMIT_eh_frame) != 0 || (all_cfi_sections & CFI_EMIT_eh_frame_compact) != 0) { @@ -2502,7 +2499,6 @@ cfi_finish (void) flag_traditional_format = save_flag_traditional_format; } - cfi_sections_set = true; /* Generate SFrame section if the user specifies: - the command line option to gas, or - .sframe in the .cfi_sections directive. */ @@ -2524,7 +2520,6 @@ cfi_finish (void) as_bad (_(".sframe not supported for target")); } - cfi_sections_set = true; if ((all_cfi_sections & CFI_EMIT_debug_frame) != 0) { int alignment = ffs (DWARF2_ADDR_SIZE (stdoutput)) - 1; -- 2.41.0