From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 0249E3857828 for ; Thu, 25 Jan 2024 15:52:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0249E3857828 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0249E3857828 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706197981; cv=none; b=eTiPi/o2fXazjfzWJjTvSedkqfPgQsf4bGxWgoou5Vkqh9b1WZnWxp3Wx8WrGlSKCOD9hb7cWu2h4RftmDlHE7rkA6ccKL0IBFYlaxKDGGap+2XNz9q7D2hHgC/zHABjaxTkGLw3BrmG4MMwK5KB78CR0IfEzYyKEm/xmuV2c5o= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706197981; c=relaxed/simple; bh=5p7RenhtxbKHmqTlVvlrMUck7PVLzmOAIQN5Upwd1Ys=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=LzQaCn4yawsh6AiOG+LIOxXrdtQNIi+6EWV8QyHdwWLghlW+mIKA6Si1UC5dLlgBQl1z7lFfe/vX5WVWT6uHAR00dAdQx2bgMvTkzJm9E2NKbr4773I3O3jTiDiV9daejNkwl+leSMEabq+0DPrCYkpRIUBaUaGggQNiunkwmhM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1706197979; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=z3mpZQBzbhJZIkJ0rDdOWgY/zc3Cfmp74s13ZzM20zw=; b=hz9W6QK1NFYUg3dpgVWebhacjbST80e5jpIXgRpNOGcDnFWBquAibU9ibD09PPjtMeXVHC QX0O5f14CtQSMkPTl2KwTji45I22sS95VIWYWMznRFhZOqVR+E3jXSa9L8yUyIl6nf5vDA fC+FufqDOVFJtYIPWDdnFDPQaNofs6I= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-139-Y6Pm1y8hMq6MRIPGUV_NzA-1; Thu, 25 Jan 2024 10:52:57 -0500 X-MC-Unique: Y6Pm1y8hMq6MRIPGUV_NzA-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5C7A83C00113 for ; Thu, 25 Jan 2024 15:52:57 +0000 (UTC) Received: from localhost (unknown [10.42.28.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 25972492BC6; Thu, 25 Jan 2024 15:52:57 +0000 (UTC) Date: Thu, 25 Jan 2024 15:52:56 +0000 From: "Richard W.M. Jones" To: Nick Clifton Cc: binutils@sourceware.org Subject: Re: [PATCH v2] binutils/windmc: Parse input correctly on big endian hosts Message-ID: <20240125155256.GX7636@redhat.com> References: <20240124122523.384659-1-rjones@redhat.com> <20240124122523.384659-2-rjones@redhat.com> <7f6ea227-9a33-4826-adb6-cd1795a56966@redhat.com> MIME-Version: 1.0 In-Reply-To: <7f6ea227-9a33-4826-adb6-cd1795a56966@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Jan 25, 2024 at 03:18:23PM +0000, Nick Clifton wrote: > Hi Richard, > > >The simple fix is to convert the input to UTF-16BE on big endian > >machines (and do the reverse conversion when writing the output). > > Approved - please apply (mainline and if you wish, the 2.42 branch as well). Thanks - I guess I'm not allowed to push the patch though? Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-builder quickly builds VMs from scratch http://libguestfs.org/virt-builder.1.html