From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 1867C38582A6 for ; Fri, 26 Jan 2024 10:12:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1867C38582A6 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1867C38582A6 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706263950; cv=none; b=B/+ogt1yhxd+KdIS+UXqpbnt0UvWRTgEFiNp10yz2lNEl9Y2a39+6JON1QxXMuA98AWI6lyxEM5Qi6yVb0aGLuSGshDl07jbRFf3RKzdPWbJ81aTr3J35OKxKrVcBUqeRLhSxoHeD4ptFasXgwwcIAUz9OkNbe/xDdIUh96XxUI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706263950; c=relaxed/simple; bh=Kub9wqNxk4BISSLjs13eYTgvXQ+COQn4kOLgYruv7Gk=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=ZaZorUd5PGNxllBWd4t747RaBSCaCSkAOfPr3hGdswNIsUBFZKsZIZ5DrhVnsc9/HOFO615hvyuGm5SeSOg1LBMZ7ZZ6TaC3mpgqyPbWDgGoXWKYSe1a11nJRuXdcoTblue6LghP47h1pAJIZ7NBzIZlJNJUjMTPTPMO63vOnCQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1706263948; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=BIOfY2ezJHh3kTpaDzxH3mpmqEendgBf8U2gfRsKhgE=; b=Z5vSmwdCMlKaMkbPSxSIn6YU61tORWUcGs8HKC4AhnrGo2Lqo/df+0oTKKOgkORqqq42GN 2jZIsbjMHs9OWG9BUK7ffsJbbTcNgKErSWNafB3KuccXeytXVwrQYU4X/ZmjVThNfuyFmA XbbA/qJQ60+ZgPwC/vF1wBIKpQzEAE4= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-529-5YsT056TPIWQaGramhklzg-1; Fri, 26 Jan 2024 05:12:27 -0500 X-MC-Unique: 5YsT056TPIWQaGramhklzg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 34EB183BA88 for ; Fri, 26 Jan 2024 10:12:27 +0000 (UTC) Received: from localhost (unknown [10.42.28.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 022BE1C060B1; Fri, 26 Jan 2024 10:12:26 +0000 (UTC) Date: Fri, 26 Jan 2024 10:12:26 +0000 From: "Richard W.M. Jones" To: Nick Clifton Cc: binutils@sourceware.org Subject: Re: [PATCH v2] binutils/windmc: Parse input correctly on big endian hosts Message-ID: <20240126101226.GZ7636@redhat.com> References: <20240124122523.384659-1-rjones@redhat.com> <20240124122523.384659-2-rjones@redhat.com> <7f6ea227-9a33-4826-adb6-cd1795a56966@redhat.com> <20240125155256.GX7636@redhat.com> <44b6e91f-38d4-4d94-972f-408709298ab0@redhat.com> MIME-Version: 1.0 In-Reply-To: <44b6e91f-38d4-4d94-972f-408709298ab0@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, Jan 26, 2024 at 10:08:32AM +0000, Nick Clifton wrote: > Hi Rich, > > >>>The simple fix is to convert the input to UTF-16BE on big endian > >>>machines (and do the reverse conversion when writing the output). > >> > >>Approved - please apply (mainline and if you wish, the 2.42 branch as well). > > > >Thanks - I guess I'm not allowed to push the patch though? > > No you are allowed to push it. > > Sorry for the confusion. By "apply" I actually meant "commit and push". Thanks. Note that someone will need to rerun autoconf for this change to actually have an effect. I didn't include that in the patch as the change is rather large and all in generated code. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com nbdkit - Flexible, fast NBD server with plugins https://gitlab.com/nbdkit/nbdkit