From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by sourceware.org (Postfix) with ESMTP id 46C6A3858D28 for ; Sat, 27 Jan 2024 13:12:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 46C6A3858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=loongson.cn ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 46C6A3858D28 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=114.242.206.163 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706361145; cv=none; b=F6qmU29fxMfmUDQl6Pq3W9PLfAO3PCDuo19KE3sOhAqWQgCo0b1uI0WtSgeEefRovacAEvfpD1FE1wuEYqmXqSoi6d5MaKnobnFwf8ujyo+KzhCgiMXOQyKo1HEN1vupOffJScLLhWLzeY02UykI8/nqzWQp2qK0kE9B1z5zrv4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706361145; c=relaxed/simple; bh=FoEhFR6BnddSmVnrq8OW60AQHPCFyD4XPCMrp59Nbe8=; h=From:To:Subject:Date:Message-Id:MIME-Version; b=FtGBwOWcG5HBYfgELnumg3hBPFj/pePRapF2E4FqIPadXtt7UCAfdthKbXzXP+Xob8Hr9I+OIPqZNG6CkNfhs02E4ngQ6oviFXwguIgj799sFDGMWDtlfnpZToWB+aDpIew01YE330e6/oLkPEKBtDexxWtWQv5MZjk7qm/jkFY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from loongson.cn (unknown [10.2.6.5]) by gateway (Coremail) with SMTP id _____8Ax++guAbVl6AUHAA--.3589S3; Sat, 27 Jan 2024 21:12:14 +0800 (CST) Received: from 5.5.5 (unknown [10.2.6.5]) by localhost.localdomain (Coremail) with SMTP id AQAAf8AxRMwtAbVlVDAfAA--.55959S4; Sat, 27 Jan 2024 21:12:13 +0800 (CST) From: Lulu Cai To: binutils@sourceware.org Cc: xuchenghua@loongson.cn, chenglulu@loongson.cn, liuzhensong@loongson.cn, mengqinggang@loongson.cn, xry111@xry111.site, i.swmail@xen0n.name, maskray@google.com, luweining@loongson.cn, wanglei@loongson.cn, hejinyang@loongson.cn, Lulu Cai Subject: [PATCH 1/2] LoongArch: Fix incorrect type transition under extreme cmodel Date: Sat, 27 Jan 2024 21:12:10 +0800 Message-Id: <20240127131211.795952-1-cailulu@loongson.cn> X-Mailer: git-send-email 2.39.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID:AQAAf8AxRMwtAbVlVDAfAA--.55959S4 X-CM-SenderInfo: xfdlz3tox6z05rqj20fqof0/1tbiAQAJB2WzbWEGcwAJsp X-Coremail-Antispam: 1Uk129KBj93XoW3Jw1kCFyfGr4UCw4fAr4xAFc_yoWfXrWxpr y3Zw43tr48CF17uryqqa45ZF4aqFWxWrWIqFyaqrZYkF4kXryrXFZxKF1kZayjg3WvgrsI vry0934UX3W8A3XCm3ZEXasCq-sJn29KB7ZKAUJUUUU5529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29KBjDU 0xBIdaVrnRJUUUkYb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2 IYs7xG6rWj6s0DM7CIcVAFz4kK6r1Y6r17M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48v e4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Jr0_JF4l84ACjcxK6xIIjxv20xvEc7CjxVAFwI 0_Jr0_Gr1l84ACjcxK6I8E87Iv67AKxVWxJVW8Jr1l84ACjcxK6I8E87Iv6xkF7I0E14v2 6r4j6r4UJwAS0I0E0xvYzxvE52x082IY62kv0487Mc804VCY07AIYIkI8VC2zVCFFI0UMc 02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0I7IYx2IY67AKxVWUXVWUAwAv7VC2z280aVAF wI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r1j6r4UM4x0Y48IcxkI7VAKI48JMxAIw28IcxkI7V AKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCj r7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUtVW8ZwCIc40Y0x0EwIxGrwCI42IY6x IIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVWUJVW8JwCI42IY6xAI w20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Gr0_Cr1lIxAIcVC2z280aVCY1x 0267AKxVW8JVW8JrUvcSsGvfC2KfnxnUUI43ZEXa7IU8zwZ7UUUUU== X-Spam-Status: No, score=-13.2 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This patch mainly fixes the bug of tls type transition when -mcmodel=extreme. Because the first two instructions of normal and extreme use the same relocation, this will cause an incorrect type transition when -mcmodel=extreme, similar to: pcalau12i t0, %ie_pc_hi20(x) li.d t1, %ie_pc_lo12(x) lu32i.d t1, %ie64_pc_lo20(x) lu52i.d t1, t1, %ie64_pc_hi12(x) ldx.d t0, t0, t1 Transition to lu12i.w t0, %le_hi20(x) ori t1, t1, %le_lo12(x) lu32i.d t1, %ie64_pc_lo20(x) lu52i.d t1, t1, %ie64_pc_hi12(x) ldx.d t0, t0, t1 In order to avoid this situation, we only do type transition for normal, and each relocation that can be type transition will be accompanied by an R_LARCH_RELAX, and will not issue R_LARCH_RELAX for TLS instruction sequences of other code models. --- bfd/elfnn-loongarch.c | 67 +++++++++++++++++++++++---------------- gas/config/tc-loongarch.c | 19 +++++++++-- 2 files changed, 56 insertions(+), 30 deletions(-) diff --git a/bfd/elfnn-loongarch.c b/bfd/elfnn-loongarch.c index 1895699af06..d51841e7973 100644 --- a/bfd/elfnn-loongarch.c +++ b/bfd/elfnn-loongarch.c @@ -145,14 +145,12 @@ struct loongarch_elf_link_hash_table #define elf_backend_rela_normal 1 #define elf_backend_default_execstack 0 -#define IS_LOONGARCH_TLS_DESC_RELOC(R_TYPE) \ - ((R_TYPE) == R_LARCH_TLS_DESC_PC_HI20 \ - || (R_TYPE) == R_LARCH_TLS_DESC_PC_LO12 \ - || (R_TYPE) == R_LARCH_TLS_DESC_LD \ - || (R_TYPE) == R_LARCH_TLS_DESC_CALL) - -#define IS_LOONGARCH_TLS_IE_RELOC(R_TYPE) \ - ((R_TYPE) == R_LARCH_TLS_IE_PC_HI20 \ +#define IS_LOONGARCH_TLS_TRANS_RELOC(R_TYPE) \ + ((R_TYPE) == R_LARCH_TLS_DESC_PC_HI20 \ + || (R_TYPE) == R_LARCH_TLS_DESC_PC_LO12 \ + || (R_TYPE) == R_LARCH_TLS_DESC_LD \ + || (R_TYPE) == R_LARCH_TLS_DESC_CALL \ + || (R_TYPE) == R_LARCH_TLS_IE_PC_HI20 \ || (R_TYPE) == R_LARCH_TLS_IE_PC_LO12) /* Generate a PLT header. */ @@ -642,15 +640,20 @@ loongarch_reloc_got_type (unsigned int r_type) /* Return true if tls type transition can be performed. */ static bool -loongarch_can_relax_tls (struct bfd_link_info *info, unsigned int r_type, - struct elf_link_hash_entry *h, bfd *input_bfd, - unsigned long r_symndx) +loongarch_can_trans_tls (bfd *input_bfd, + struct bfd_link_info *info, + struct elf_link_hash_entry *h, + const Elf_Internal_Rela *rel, + unsigned int r_type) { char symbol_tls_type; unsigned int reloc_got_type; + unsigned int r_symndx = ELFNN_R_SYM (rel->r_info); - if (! (IS_LOONGARCH_TLS_DESC_RELOC (r_type) - || IS_LOONGARCH_TLS_IE_RELOC (r_type))) + /* Only TLS DESC/IE in normal code mode will perform type + transition. */ + if (! (IS_LOONGARCH_TLS_TRANS_RELOC (r_type) + && ELFNN_R_TYPE (rel[1].r_info) == R_LARCH_RELAX)) return false; symbol_tls_type = _bfd_loongarch_elf_tls_type (input_bfd, h, r_symndx); @@ -707,11 +710,13 @@ loongarch_tls_transition_without_check (struct bfd_link_info *info, } static unsigned int -loongarch_tls_transition (struct bfd_link_info *info, unsigned int r_type, - struct elf_link_hash_entry *h, bfd *input_bfd, - unsigned long r_symndx) +loongarch_tls_transition (bfd *input_bfd, + struct bfd_link_info *info, + struct elf_link_hash_entry *h, + const Elf_Internal_Rela *rel, + unsigned int r_type) { - if (! loongarch_can_relax_tls (info, r_type, h, input_bfd,r_symndx)) + if (! loongarch_can_trans_tls (input_bfd, info, h, rel, r_type)) return r_type; return loongarch_tls_transition_without_check (info, r_type, h); @@ -818,7 +823,10 @@ loongarch_elf_check_relocs (bfd *abfd, struct bfd_link_info *info, int need_dynreloc = 0; int only_need_pcrel = 0; - r_type = loongarch_tls_transition (info, r_type, h, abfd, r_symndx); + /* Type transitions are only possible with relocations accompanied + by R_LARCH_RELAX. */ + if (rel + 1 != relocs + sec->reloc_count) + r_type = loongarch_tls_transition (abfd, info, h, rel, r_type); switch (r_type) { case R_LARCH_GOT_PC_HI20: @@ -2536,7 +2544,7 @@ loongarch_reloc_is_fatal (struct bfd_link_info *info, /* Transition instruction sequence to relax instruction sequence. */ static bool -loongarch_tls_relax (bfd *abfd, asection *sec, Elf_Internal_Rela *rel, +loongarch_tls_perform_trans (bfd *abfd, asection *sec, Elf_Internal_Rela *rel, int r_type, struct elf_link_hash_entry *h, struct bfd_link_info *info) { @@ -2657,7 +2665,7 @@ loongarch_elf_relocate_section (bfd *output_bfd, struct bfd_link_info *info, const char *name; bfd_reloc_status_type r = bfd_reloc_ok; bool is_ie, is_desc, is_undefweak, unresolved_reloc, defined_local; - unsigned int relaxed_r_type; + unsigned int trans_r_type = r_type; bool resolved_local, resolved_dynly, resolved_to_const; char tls_type; bfd_vma relocation, off, ie_off, desc_off; @@ -2789,14 +2797,17 @@ loongarch_elf_relocate_section (bfd *output_bfd, struct bfd_link_info *info, BFD_ASSERT (!resolved_local || defined_local); - relaxed_r_type = loongarch_tls_transition (info, r_type, h, input_bfd, r_symndx); - if (relaxed_r_type != r_type) + if (rel + 1 != relend) + trans_r_type = loongarch_tls_transition (input_bfd, info, h, + rel, r_type); + if (trans_r_type != r_type) { - howto = loongarch_elf_rtype_to_howto (input_bfd, relaxed_r_type); + howto = loongarch_elf_rtype_to_howto (input_bfd, trans_r_type); BFD_ASSERT (howto != NULL); - if (loongarch_tls_relax (input_bfd, input_section, rel, r_type, h, info)) - r_type = relaxed_r_type; + if (loongarch_tls_perform_trans (input_bfd, input_section, + rel, r_type, h, info)) + r_type = trans_r_type; } is_desc = false; @@ -4551,7 +4562,8 @@ loongarch_elf_relax_section (bfd *abfd, asection *sec, || R_LARCH_TLS_GD_PC_HI20 == r_type || R_LARCH_TLS_DESC_PC_HI20 == r_type) { - if (loongarch_can_relax_tls (info, r_type, h, abfd, r_symndx)) + if (i + 1 != sec->reloc_count + && loongarch_can_trans_tls (abfd, info, h, rel, r_type)) continue; else { @@ -4595,7 +4607,8 @@ loongarch_elf_relax_section (bfd *abfd, asection *sec, || R_LARCH_TLS_GD_PC_HI20 == r_type || R_LARCH_TLS_DESC_PC_HI20 == r_type) { - if (loongarch_can_relax_tls (info, r_type, h, abfd, r_symndx)) + if (i + 1 != sec->reloc_count + && loongarch_can_trans_tls (abfd, info, h, rel, r_type)) continue; else { diff --git a/gas/config/tc-loongarch.c b/gas/config/tc-loongarch.c index e0aff36bbbb..af4426bff94 100644 --- a/gas/config/tc-loongarch.c +++ b/gas/config/tc-loongarch.c @@ -724,8 +724,12 @@ loongarch_args_parser_can_match_arg_helper (char esc_ch1, char esc_ch2, } /* Only one register macros (used in normal code model) - emit R_LARCH_RELAX. */ + emit R_LARCH_RELAX. + LARCH_opts.ase_labs and LARCH_opts.ase_gabs are used + to generate the code model of absolute addresses, and + we do not relax this code model. */ if (LARCH_opts.relax && (ip->expand_from_macro & 1) + && ! (LARCH_opts.ase_labs | LARCH_opts.ase_gabs) && (BFD_RELOC_LARCH_PCALA_HI20 == reloc_type || BFD_RELOC_LARCH_PCALA_LO12 == reloc_type || BFD_RELOC_LARCH_GOT_PC_HI20 == reloc_type @@ -733,7 +737,11 @@ loongarch_args_parser_can_match_arg_helper (char esc_ch1, char esc_ch2, || BFD_RELOC_LARCH_TLS_LD_PC_HI20 == reloc_type || BFD_RELOC_LARCH_TLS_GD_PC_HI20 == reloc_type || BFD_RELOC_LARCH_TLS_DESC_PC_HI20 == reloc_type - || BFD_RELOC_LARCH_TLS_DESC_PC_LO12 == reloc_type)) + || BFD_RELOC_LARCH_TLS_DESC_PC_LO12 == reloc_type + || BFD_RELOC_LARCH_TLS_DESC_LD == reloc_type + || BFD_RELOC_LARCH_TLS_DESC_CALL == reloc_type + || BFD_RELOC_LARCH_TLS_IE_PC_HI20 == reloc_type + || BFD_RELOC_LARCH_TLS_IE_PC_LO12 == reloc_type)) { ip->reloc_info[ip->reloc_num].type = BFD_RELOC_LARCH_RELAX; ip->reloc_info[ip->reloc_num].value = const_0; @@ -1088,7 +1096,12 @@ append_fixp_and_insn (struct loongarch_cl_insn *ip) || BFD_RELOC_LARCH_TLS_LE_ADD_R == reloc_info[0].type || BFD_RELOC_LARCH_TLS_LD_PC_HI20 == reloc_info[0].type || BFD_RELOC_LARCH_TLS_GD_PC_HI20 == reloc_info[0].type - || BFD_RELOC_LARCH_TLS_DESC_PC_HI20 == reloc_info[0].type)) + || BFD_RELOC_LARCH_TLS_DESC_PC_HI20 == reloc_info[0].type + || BFD_RELOC_LARCH_TLS_DESC_PC_LO12 == reloc_info[0].type + || BFD_RELOC_LARCH_TLS_DESC_LD == reloc_info[0].type + || BFD_RELOC_LARCH_TLS_DESC_CALL == reloc_info[0].type + || BFD_RELOC_LARCH_TLS_IE_PC_HI20 == reloc_info[0].type + || BFD_RELOC_LARCH_TLS_IE_PC_LO12 == reloc_info[0].type)) { frag_wane (frag_now); frag_new (0); -- 2.36.0