From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by sourceware.org (Postfix) with ESMTP id 7C9BA3858CDB for ; Mon, 5 Feb 2024 09:32:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7C9BA3858CDB Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=loongson.cn ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7C9BA3858CDB Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=114.242.206.163 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707125558; cv=none; b=VcCLGugPjvUaVYd8nqbQBmJJAtzrN+JO+cjZ99HH5gkkfZfVhRqsGzkMTJPcDcajFIZlSdiTd6GEnKzlDAsWBgqxJJYTIp0T3MKDli84pCuFfqONRmCr1SW5ZCrA03t3E7SnBx+CIoJOfGxfIJ7+RFB2vUmZO2deEvk5s2Ahboo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707125558; c=relaxed/simple; bh=IfabeMk4n3lpOIi8+UmUk2ceRJ1BuqicMEgL1bqHqg8=; h=From:To:Subject:Date:Message-Id:MIME-Version; b=MVOR34aqTgUY8b3raCI6iKH6nWSD0CLrXj7+aBcCas1lWbgDtNe0VM0WJCd3jTRqZJAaLuPDjHU6D4dvrqFYeiJb0X82vHajz0KBxXFp4dNUggLhJkOWmzICWEXaHbZu/I8q9xt9GttuIb+U88L1qN7hg3tFZQ5tIWTeqL2xex8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from loongson.cn (unknown [10.2.6.5]) by gateway (Coremail) with SMTP id _____8CxG+kwq8BlL9UKAA--.12068S3; Mon, 05 Feb 2024 17:32:32 +0800 (CST) Received: from 5.5.5 (unknown [10.2.6.5]) by localhost.localdomain (Coremail) with SMTP id AQAAf8CxrhMwq8BlYhEwAA--.60036S2; Mon, 05 Feb 2024 17:32:32 +0800 (CST) From: mengqinggang To: binutils@sourceware.org Cc: xuchenghua@loongson.cn, chenglulu@loongson.cn, liuzhensong@loongson.cn, cailulu@loongson.cn, xry111@xry111.site, i.swmail@xen0n.name, maskray@google.com, luweining@loongson.cn, wanglei@loongson.cn, hejinyang@loongson.cn, mengqinggang@loongson.cn Subject: [PATCH] LoongArch: gas: Try to avoid R_LARCH_ALIGN associate with a symbol Date: Mon, 5 Feb 2024 17:32:31 +0800 Message-Id: <20240205093231.2817816-1-mengqinggang@loongson.cn> X-Mailer: git-send-email 2.39.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID:AQAAf8CxrhMwq8BlYhEwAA--.60036S2 X-CM-SenderInfo: 5phqw15lqjwttqj6z05rqj20fqof0/ X-Coremail-Antispam: 1Uk129KBj93XoWxAry7KFyUZr1fJr18WFy5KFX_yoW5WF1Dpr y2vF1YyFW8CFn3Ww15A343Zw13Xw1xuFW2qayxtr1xCr4kJryvyw1xGFW5WayDW34qkw4f Xrn293WjqFyvy3cCm3ZEXasCq-sJn29KB7ZKAUJUUUU8529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29KBjDU 0xBIdaVrnRJUUUkFb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2 IYs7xG6rWj6s0DM7CIcVAFz4kK6r106r15M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48v e4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_JFI_Gr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI 0_Gr0_Cr1l84ACjcxK6I8E87Iv67AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVCY1x0267AK xVW8Jr0_Cr1UM2AIxVAIcxkEcVAq07x20xvEncxIr21l57IF6xkI12xvs2x26I8E6xACxx 1l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r1j6r18McIj6I8E87Iv 67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IYc2Ij64vIr41l42xK82IYc2 Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s02 6x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r1q6r43MIIYrxkI7VAKI48JMIIF0x vE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14v26r1j6r4UMIIF0xvE 42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv6x kF7I0E14v26r1j6r4UYxBIdaVFxhVjvjDU0xZFpf9x07j8yCJUUUUU= X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: The R_LARCH_ALIGN need to associated with a symbol if .align has the first and third expressions. If R_LARCH_ALIGN associate with a symbol, the addend can represent the first and third expression of .align. For '.align 3', the addend of R_LARCH_ALIGN only need to represent the alignment and R_LARCH_ALIGN not need to associate with a symbol. --- gas/config/tc-loongarch.c | 23 +++++++++++++++-------- gas/testsuite/gas/loongarch/relax_align.d | 16 ++++++++-------- 2 files changed, 23 insertions(+), 16 deletions(-) diff --git a/gas/config/tc-loongarch.c b/gas/config/tc-loongarch.c index 91f5f1d0681..831a463879b 100644 --- a/gas/config/tc-loongarch.c +++ b/gas/config/tc-loongarch.c @@ -1746,14 +1746,21 @@ loongarch_frag_align_code (int n, int max) nops = frag_more (worst_case_bytes); - s = symbol_find (".Lla-relax-align"); - if (s == NULL) - s = (symbolS *)local_symbol_make (".Lla-relax-align", now_seg, - &zero_address_frag, 0); - - ex.X_add_symbol = s; - ex.X_op = O_symbol; - ex.X_add_number = (max << 8) | n; + if (max) + { + s = symbol_find (".Lla-relax-align"); + if (s == NULL) + s = (symbolS *)local_symbol_make (".Lla-relax-align", now_seg, + &zero_address_frag, 0); + ex.X_add_symbol = s; + ex.X_op = O_symbol; + ex.X_add_number = (max << 8) | n; + } + else + { + ex.X_op = O_constant; + ex.X_add_number = worst_case_bytes; + } loongarch_make_nops (nops, worst_case_bytes); diff --git a/gas/testsuite/gas/loongarch/relax_align.d b/gas/testsuite/gas/loongarch/relax_align.d index 2cc6c86d38a..e86d0d592b6 100644 --- a/gas/testsuite/gas/loongarch/relax_align.d +++ b/gas/testsuite/gas/loongarch/relax_align.d @@ -1,4 +1,4 @@ -#as: --no-warn +#as: #objdump: -dr #skip: loongarch32-*-* @@ -14,20 +14,20 @@ Disassembly of section .text: [ ]+4:[ ]+02c00084[ ]+addi.d[ ]+\$a0, \$a0, 0 [ ]+4: R_LARCH_PCALA_LO12[ ]+L1 [ ]+4: R_LARCH_RELAX[ ]+\*ABS\* -[ ]+8:[ ]+03400000[ ]+nop.* -[ ]+8: R_LARCH_ALIGN[ ]+.Lla-relax-align\+0x4 -[ ]+c:[ ]+03400000[ ]+nop.* -[ ]+10:[ ]+03400000[ ]+nop.* +[ ]+8:[ ]+03400000[ ]+nop +[ ]+8: R_LARCH_ALIGN[ ]+\*ABS\*\+0xc +[ ]+c:[ ]+03400000[ ]+nop +[ ]+10:[ ]+03400000[ ]+nop [ ]+14:[ ]+1a000004[ ]+pcalau12i[ ]+\$a0, 0 [ ]+14: R_LARCH_PCALA_HI20[ ]+L1 [ ]+14: R_LARCH_RELAX[ ]+\*ABS\* [ ]+18:[ ]+02c00084[ ]+addi.d[ ]+\$a0, \$a0, 0 [ ]+18: R_LARCH_PCALA_LO12[ ]+L1 [ ]+18: R_LARCH_RELAX[ ]+\*ABS\* -[ ]+1c:[ ]+03400000[ ]+nop.* +[ ]+1c:[ ]+03400000[ ]+nop [ ]+1c: R_LARCH_ALIGN[ ]+.Lla-relax-align\+0x404 -[ ]+20:[ ]+03400000[ ]+nop.* -[ ]+24:[ ]+03400000[ ]+nop.* +[ ]+20:[ ]+03400000[ ]+nop +[ ]+24:[ ]+03400000[ ]+nop [ ]+28:[ ]+1a000004[ ]+pcalau12i[ ]+\$a0, 0 [ ]+28: R_LARCH_PCALA_HI20[ ]+L1 [ ]+28: R_LARCH_RELAX[ ]+\*ABS\* -- 2.36.0