From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635]) by sourceware.org (Postfix) with ESMTPS id 878763858C29 for ; Mon, 5 Feb 2024 20:00:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 878763858C29 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 878763858C29 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::635 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707163234; cv=none; b=XOIkiPni23WTIw+pc+iMfURd0cLiNn/dw/JUQc+ie/i55LS2luIiSzmK+mH8y6jHFU+veKkFFcPKnVz4qzuNRiodSyciJ5aN/9nKIVOrjAwTc0felvvBOX/VMeLPnKCbqiLMDfqt9i2YyEjLe8YLvKcuavxVmUUM6hkGRFyEgHk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707163234; c=relaxed/simple; bh=pO8rxQADLAnDADEEd43/BICmENMu5XutArDXQKE5Ap8=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=wp0/goZgi2Lqak7qB2+a7EEgWJqiAGbP8yu8Oa7c00DXUKUvFgnaefo3j2p+zxm7xt0q/SlN9TubPLqZeWn+/5OpjN2dR5or9Q4Z4qU4rIy5TCDb5jm1OyfTqjdWcC+FV/1V/2VfwqXjhl6+qfDtvbiROluNOrfPfWnbdNqWo14= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-x635.google.com with SMTP id d9443c01a7336-1d7881b1843so42714535ad.3 for ; Mon, 05 Feb 2024 12:00:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707163231; x=1707768031; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=UOq+ka4RwzodinHRWpDEv6HTBdbsajhcZRlnDX9ZpHY=; b=YBzwP7bLk03KhX65OQFZONcJqPWrM3cTGn3QfMMEAQYiF+WinJx7JxdRJQqvFmOY9g MVIAUC5PssJEhH/d1ZnDCzLiYDnUptS1PYlGoHKTmFQhsMvLoqmV5xk9VcTkEZjkDEf+ NkbjtgSXgDY2XcG8UER0ocB0T7774rhKOaLh9yCamqUvCk7MLXoaZYI3UnO3AhMLeqvg sWHo6m8VKip540QHsZCadr9ObEnij2Iti8lDkJ8/7GGleIekB2IQdsbpJWVE+aLTEljU +L7HNYn060Ir6ONoxN6lRhspmkHTplG3rzWjAzIFfSviBE3CTEtW6CQQpJNYSzV5Y/Bb M55w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707163231; x=1707768031; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UOq+ka4RwzodinHRWpDEv6HTBdbsajhcZRlnDX9ZpHY=; b=jOAmJSYmJHO0pzkzigm3F5mj7FIeP/TwePOTdrHc04IkeGTgG4oDopImYjvoYuuNGt BgA/yKnucLBEw2GDirhRMQ9efI25DYrSx8s0bQRrPOY90FLzhOpMnKw8mRy2i9UzinkO ev4oPv8LPbhHMpFrjWTK6w5sgHaqBwugvTLL3Ikq+lNC5TFfl4ynGEHx69fslClMvCqd IzXovXcNY212YRfA8vr4pkFkU+tNOclSocOdLA7ZRMf0PsDrs4XYg0bCNv5L3gh/CQ5O Xu7/KOhaWN/JGSFHQeG45YRxaMgBsrQPCrwRrwer/3FCubA7I81Xr/nUoMmGdO1FMlkc bEFw== X-Gm-Message-State: AOJu0Yy4pVslKDSHVhPV0GW+Dpv3/GM9gdOMupaX/Lb/CR1kSwkTXvwb T+vFdZ0zo5dRuLIpzdUpAWxERudlvtf12521EtVtwmja+hmYhs7p7zly3+lM X-Google-Smtp-Source: AGHT+IEFVES+EVADNldoGU/pqZGk2maE2RHLDOsgMkzbICgeAOuo4DYubbFlBVoVeLlwMqIrI1JeLQ== X-Received: by 2002:a05:6a20:a318:b0:19c:84ef:a242 with SMTP id x24-20020a056a20a31800b0019c84efa242mr443658pzk.43.1707163231185; Mon, 05 Feb 2024 12:00:31 -0800 (PST) Received: from gnu-cfl-3.localdomain ([172.56.168.224]) by smtp.gmail.com with ESMTPSA id o1-20020a056a001b4100b006e04553a4c5sm256988pfv.52.2024.02.05.12.00.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Feb 2024 12:00:30 -0800 (PST) Received: from gnu-cfl-3.. (localhost [IPv6:::1]) by gnu-cfl-3.localdomain (Postfix) with ESMTP id 602DF7402E3; Mon, 5 Feb 2024 12:00:28 -0800 (PST) From: "H.J. Lu" To: binutils@sourceware.org Cc: JBeulich@suse.com Subject: [PATCH] x86: Warn .insn instruction with length > 15 bytes Date: Mon, 5 Feb 2024 12:00:28 -0800 Message-ID: <20240205200028.219844-1-hjl.tools@gmail.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3023.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Change .insn instruction with length > 15 bytes from error to warning. PR gas/31323 * config/tc-i386.c (output_insn): Issue a warning when .insn instruction length exceeds the limit of 15 bytes. * testsuite/gas/i386/oversized64.s: Add a test for .insn * testsuite/gas/i386/oversized64.l: Updated. --- gas/config/tc-i386.c | 10 ++++++++-- gas/testsuite/gas/i386/oversized64.l | 8 ++++++++ gas/testsuite/gas/i386/oversized64.s | 3 +++ 3 files changed, 19 insertions(+), 2 deletions(-) diff --git a/gas/config/tc-i386.c b/gas/config/tc-i386.c index 8f3a1b6f686..20d17c954f8 100644 --- a/gas/config/tc-i386.c +++ b/gas/config/tc-i386.c @@ -11780,8 +11780,14 @@ output_insn (const struct last_insn *last_insn) { j = encoding_length (insn_start_frag, insn_start_off, frag_more (0)); if (j > 15) - as_bad (_("instruction length of %u bytes exceeds the limit of 15"), - j); + { + if (i.tm.mnem_off == MN__insn) + as_warn (_("instruction length of %u bytes exceeds the limit of 15"), + j); + else + as_bad (_("instruction length of %u bytes exceeds the limit of 15"), + j); + } else if (fragP) { /* NB: Don't add prefix with GOTPC relocation since diff --git a/gas/testsuite/gas/i386/oversized64.l b/gas/testsuite/gas/i386/oversized64.l index ac32c4d8139..f709456c5e5 100644 --- a/gas/testsuite/gas/i386/oversized64.l +++ b/gas/testsuite/gas/i386/oversized64.l @@ -4,6 +4,7 @@ .*:7: Error: instruction length.* .*:9: Error: instruction length.* .*:10: Error: instruction length.* +.*:13: Warning: instruction length.* GAS LISTING .* @@ -37,4 +38,11 @@ GAS LISTING .* [ ]*10[ ]+48812CC5[ ]* [ ]*10[ ]+00000000[ ]* [ ]*10[ ]+44332211[ ]* +[ ]*11[ ]+ +[ ]*12[ ]+\.att_syntax prefix +[ ]*13[ ]+\?\?\?\? 6762F1FC[ ]+.insn EVEX.L0.0f 12/0, \$0x11223344,\(,%eax,8\),%rax +\*\*\*\* Warning: instruction length of 16 bytes exceeds the limit of 15 +[ ]*13[ ]+080C04C5[ ]* +[ ]*13[ ]+00000000[ ]* +[ ]*13[ ]+44332211[ ]* #pass diff --git a/gas/testsuite/gas/i386/oversized64.s b/gas/testsuite/gas/i386/oversized64.s index 9db09af3f15..77a08a9c533 100644 --- a/gas/testsuite/gas/i386/oversized64.s +++ b/gas/testsuite/gas/i386/oversized64.s @@ -8,3 +8,6 @@ long64: xacquire lock add qword ptr gs:[eax*8], 0x11223344 xrelease lock sub qword ptr gs:[eax*8], 0x11223344 + + .att_syntax prefix + .insn EVEX.L0.0f 12/0, $0x11223344,(,%eax,8),%rax -- 2.43.0