public inbox for
 help / color / mirror / Atom feed
From: Will Hawkins <>
Cc: Will Hawkins <>,
Subject: [PATCH v3 0/1] Move callx (nee callr) to v1 ISA variant
Date: Wed, 14 Feb 2024 11:02:59 -0500	[thread overview]
Message-ID: <> (raw)

Thank you for all the feedback on v1 and v2! Thanks to the willingness of
the clang/llvm developers to compromise on their encoding of the callx
instruction, this version of the patch is much more straightforward than v2.
In other words, a special thanks to Yonghong Song!

The only "controversial" piece of this patch is the reworking of the
testsuite code. I refactored the test code slightly to (visually) match
the test code from the clang/llvm test code for the callx instruction.
It made it easier for me to visually confirm that the objdump output matches.
I am more than happy to revert that piece if what I did goes too far.

Of course, I am also happy to change anything about this patch to make
sure that it meets the community's guidelines.

Thank you, again, for all the help!


Will Hawkins (1):
  objdump, as: Add callx support for BPF CPU v1

 gas/testsuite/gas/bpf/indcall-1-pseudoc.d |  8 ++++----
 gas/testsuite/gas/bpf/indcall-1-pseudoc.s |  6 +++---
 gas/testsuite/gas/bpf/indcall-1.d         | 10 +++++-----
 gas/testsuite/gas/bpf/indcall-1.s         |  6 +++---
 include/opcode/bpf.h                      |  2 +-
 opcodes/bpf-opc.c                         |  4 ++--
 6 files changed, 18 insertions(+), 18 deletions(-)


             reply	other threads:[~2024-02-14 16:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-14 16:02 Will Hawkins [this message]
2024-02-14 16:03 ` [PATCH v3 1/1] objdump, as: Add callx support for BPF CPU v1 Will Hawkins
2024-02-14 16:30   ` Jose E. Marchesi
2024-02-14 16:36     ` Will Hawkins
2024-02-14 22:13       ` Will Hawkins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).