From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by sourceware.org (Postfix) with ESMTP id 1E2DE3858D1E for ; Tue, 20 Feb 2024 06:15:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1E2DE3858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=loongson.cn ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1E2DE3858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=114.242.206.163 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708409716; cv=none; b=fLF/gv9q8hLccc0bPqk3MdfJ3b7HLEIFWHDwp1aOGlZSww/ptyf+Fi7fMnViJKSGBH0tM5SdGGmVgZg3pXl/QPjcTrAnJsim0vbh+IMh5XpurJRnzAALQXexGmsnsS0ymaCGP617CcCwafKTlP2dXd55IaZGSUhiW4dlTROBLrY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708409716; c=relaxed/simple; bh=nzHlKjT1UETQ2Mp3GnnYvuUXbBuHP71mVAqxiXQPHA8=; h=From:To:Subject:Date:Message-Id:MIME-Version; b=YxJnOh1TQlE1xK1IYSbh7Nx5Z/6ABj9rTx3y/qBp15s7S2MMjpoTt/Do4pOOX/LyNHv8DbsjhKUKIrYZg8O2rZK+lacdCi4VkqTnLfvjUlthGsW+ZjUyMVOPhH2pwagggqTbY9CtNyYRlZ5H3L0IwYM4F2UJfErmkYdNLE1gNho= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from loongson.cn (unknown [111.9.175.10]) by gateway (Coremail) with SMTP id _____8AxjuttQ9RlAwEPAA--.38966S3; Tue, 20 Feb 2024 14:15:10 +0800 (CST) Received: from loongson.localdomain (unknown [111.9.175.10]) by localhost.localdomain (Coremail) with SMTP id AQAAf8Cx_c5kQ9RlHIE8AA--.24842S2; Tue, 20 Feb 2024 14:15:07 +0800 (CST) From: Peng Fan To: binutils@sourceware.org Cc: mengqinggang@loongson.cn, cailulu@loongson.cn, xry111@xry111.site Subject: [PATCH] LoongArch: Modify inconsistent behavior of ld with --unresolved-symbols=ignore-all Date: Tue, 20 Feb 2024 14:14:59 +0800 Message-Id: <20240220061459.3353898-1-fanpeng@loongson.cn> X-Mailer: git-send-email 2.33.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID:AQAAf8Cx_c5kQ9RlHIE8AA--.24842S2 X-CM-SenderInfo: xidq1vtqj6z05rqj20fqof0/1tbiAQANEmXTEWMEpQAOs1 X-Coremail-Antispam: 1Uk129KBj93XoW7CryUJrW3uFyfCw18Xw15WrX_yoW8Aw4fpF 9xZ34qgrWrJw4fW3W2q345urnIkrZ7Wrs3trZFqanY9FnxZFyxXF15XrW29F4Ut3y8JrZr Zr10y3y5ZFy8AabCm3ZEXasCq-sJn29KB7ZKAUJUUUU5529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29KBjDU 0xBIdaVrnRJUUUkFb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2 IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48v e4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Jr0_JF4l84ACjcxK6xIIjxv20xvEc7CjxVAFwI 0_Jr0_Gr1l84ACjcxK6I8E87Iv67AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVCY1x0267AK xVW8Jr0_Cr1UM2AIxVAIcxkEcVAq07x20xvEncxIr21l57IF6xkI12xvs2x26I8E6xACxx 1l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r1Y6r17McIj6I8E87Iv 67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IYc2Ij64vIr41l42xK82IYc2 Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s02 6x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r126r1DMIIYrxkI7VAKI48JMIIF0x vE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14v26r1j6r4UMIIF0xvE 42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv6x kF7I0E14v26r1j6r4UYxBIdaVFxhVjvjDU0xZFpf9x07UNvtZUUUUU= X-Spam-Status: No, score=-12.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Ignore errors when producing executable files that reference external symbols defined in other files. Testcase is: resolv.c: int main(int argc, char *argv[]) { return argc; } t.c: extern const struct my_struct ms1; static const struct my_struct *ms = &ms1; t.h: typedef struct my_struct { char *str; int i; } my_struct; Compiling and linking command with: gcc t.c -c ; gcc resolv.c -c gcc resolv.o t.o -o resolv -Wl,--unresolved-symbols=ignore-all Got error as: ~/install/usr/bin/ld: t.o:(.data.rel+0x0): undefined reference to `ms1' collect2: error: ld returned 1 exit status --- bfd/elfnn-loongarch.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/bfd/elfnn-loongarch.c b/bfd/elfnn-loongarch.c index 1895699af06..6b2d5a7164d 100644 --- a/bfd/elfnn-loongarch.c +++ b/bfd/elfnn-loongarch.c @@ -2662,6 +2662,7 @@ loongarch_elf_relocate_section (bfd *output_bfd, struct bfd_link_info *info, char tls_type; bfd_vma relocation, off, ie_off, desc_off; int i, j; + bool ignored = false; howto = loongarch_elf_rtype_to_howto (input_bfd, r_type); if (howto == NULL || r_type == R_LARCH_GNU_VTINHERIT @@ -2703,7 +2704,7 @@ loongarch_elf_relocate_section (bfd *output_bfd, struct bfd_link_info *info, } else { - bool warned, ignored; + bool warned; RELOC_FOR_GLOBAL_SYMBOL (info, input_bfd, input_section, rel, r_symndx, symtab_hdr, sym_hashes, @@ -2867,7 +2868,7 @@ loongarch_elf_relocate_section (bfd *output_bfd, struct bfd_link_info *info, { if (h->dynindx == -1) { - if (h->root.type == bfd_link_hash_undefined) + if (h->root.type == bfd_link_hash_undefined && !ignored) (*info->callbacks->undefined_symbol) (info, name, input_bfd, input_section, rel->r_offset, true); -- 2.33.0