From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by sourceware.org (Postfix) with ESMTPS id D1F5C3858C50 for ; Wed, 21 Feb 2024 14:53:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D1F5C3858C50 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gcc.gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D1F5C3858C50 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.85.214.181 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708527190; cv=none; b=MN46VioRhMvJzLNXAYXpJ3XZhHf2alMyImUFoSoBiuyLHXeSZBBNsPVD66N/kLeaxbjTdi7djQl+TII5BVDbDeX7YftQvbymBjZMVeltNGdAhwAwRSbTqGrMDmTHcr2+INivtIt+Hpbg38aGvYS0wUObOltkZjiKfXCm1WftcX0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708527190; c=relaxed/simple; bh=ctDhq7oseQBx0DfIECPBzrvDWwnrufNqiKUxPzMGpJ0=; h=From:To:Subject:Date:Message-Id:MIME-Version; b=RgE3q6/+Qw4s0iRiUawTHrgp/g9JFVvq+MzLs9gEqWsSmc1kF76YluM8iFBKnxJqt/KFQCRWE0y4kQ/orTXpn9RM+6CBlt6e4mJSQEOJUWqs2pSTYaZcFsZPsmutF509+21Mm++UxyKuTNn6MWVAlWfAzO0tnLmqqOy0Wkp7gz8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-1db6e0996ceso49748705ad.2 for ; Wed, 21 Feb 2024 06:53:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708527186; x=1709131986; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SkC89bR+p89gvGaM0JfPa3Tz0Gr4KhkxNDUewni9CFM=; b=XVt2Em/Z8GjbhSquZwHpLRj/q9MTPJDFJoyul+YdL0HHm8WP1ZseLuqQucy4gfRUQS Yem72+DxVgpF94tHPmzxjI/wdptczerLOLxhk3wcfo6vC4BvrULhK/DLpfCvaZgK8TmX HqeO2LgG2D2faag7iIGq6x+aCYCM/9nLPIUbZo2W8Kmzk+w0I0Pit+TT2Q295l8idnv9 ZDdS9FIaB6XiXeCEGpOtNQxdBTh5G9EBFpOWFLubVSLjlIHIzEX0wzw4zKqIeiS4Wl6S 0zS6rGUUyfogffmRPj2riZHYCyG8r/ulRCuV9YXZZbaa406ZXFOwb9F5lievC5tnFSZx J4BQ== X-Gm-Message-State: AOJu0Yxl17CIZxCrnzhutwU1wViChDPS6Byxr5m/ArNUFpTvalsMsTXd 9IybtmmCLnMafHr2hRw6u8K6ogpe0+sspStGYg8Egvora13D+Ziq X-Google-Smtp-Source: AGHT+IGmckhmXJ+tND6AVRo61eNR+OHs18Jpqmq8rdFRYemLe1DNEWF+r2gD8o4YgjFtbpiaJROvqg== X-Received: by 2002:a17:902:6b8b:b0:1db:670d:27d9 with SMTP id p11-20020a1709026b8b00b001db670d27d9mr13066619plk.27.1708527185614; Wed, 21 Feb 2024 06:53:05 -0800 (PST) Received: from localhost.localdomain ([149.248.38.156]) by smtp.gmail.com with ESMTPSA id r9-20020a170903014900b001da105d6a83sm8204127plc.224.2024.02.21.06.53.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Feb 2024 06:53:05 -0800 (PST) From: YunQiang Su To: nickc@redhat.com Cc: binutils@sourceware.org, macro@orcam.me.uk, xry111@xry111.site Subject: [PATCH v6] MIPS: Reject branch absolute relocs for PIC for linking Date: Wed, 21 Feb 2024 22:52:56 +0800 Message-Id: <20240221145256.3118097-1-syq@gcc.gnu.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-10.9 required=5.0 tests=BAYES_00,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,GIT_PATCH_0,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: The asm code like: b 8 will emit absolute relocs like: R_MIPS_PC16 *ABS* If they are included into PIC shared objects or PIE executables, the branch target will be like 0x12340000, which will make the programs crash. --- bfd/elfxx-mips.c | 9 +++++++++ ld/testsuite/ld-mips-elf/mips-elf.exp | 1 + ld/testsuite/ld-mips-elf/pic-reject-abs-reloc.d | 5 +++++ ld/testsuite/ld-mips-elf/pic-reject-abs-reloc.s | 2 ++ 4 files changed, 17 insertions(+) create mode 100644 ld/testsuite/ld-mips-elf/pic-reject-abs-reloc.d create mode 100644 ld/testsuite/ld-mips-elf/pic-reject-abs-reloc.s diff --git a/bfd/elfxx-mips.c b/bfd/elfxx-mips.c index 69dd71419ff..9542250dec4 100644 --- a/bfd/elfxx-mips.c +++ b/bfd/elfxx-mips.c @@ -9258,6 +9258,15 @@ _bfd_mips_elf_check_relocs (bfd *abfd, struct bfd_link_info *info, (h) ? h->root.root.string : "a local symbol"); break; default: + if (branch_reloc_p (r_type) && r_symndx == STN_UNDEF) + { + howto = MIPS_ELF_RTYPE_TO_HOWTO (abfd, r_type, NEWABI_P (abfd)); + info->callbacks->einfo + /* xgettext:c-format */ + (_("%X%H: relocation %s against `*ABS*' cannot be used" + " when making a PIC/PIE object\n"), + abfd, sec, rel->r_offset, howto->name); + } break; } } diff --git a/ld/testsuite/ld-mips-elf/mips-elf.exp b/ld/testsuite/ld-mips-elf/mips-elf.exp index 50af78d1430..a8e1b91b3a1 100644 --- a/ld/testsuite/ld-mips-elf/mips-elf.exp +++ b/ld/testsuite/ld-mips-elf/mips-elf.exp @@ -1678,6 +1678,7 @@ run_dump_test_o32 "pic-reloc-6" run_dump_test_n64 "pic-reloc-7" run_dump_test_n64 "pic-reloc-7" [list [list name (microMIPS)] \ [list as "-mmicromips"]] +run_dump_test "pic-reject-abs-reloc" run_dump_test_o32 "reloc-pcrel-r6" diff --git a/ld/testsuite/ld-mips-elf/pic-reject-abs-reloc.d b/ld/testsuite/ld-mips-elf/pic-reject-abs-reloc.d new file mode 100644 index 00000000000..16d9f4e8553 --- /dev/null +++ b/ld/testsuite/ld-mips-elf/pic-reject-abs-reloc.d @@ -0,0 +1,5 @@ +#name: MIPS PIC rejects branch absolute +#ld: -shared -T pic-reloc-absolute-lo.ld +#target: [check_shared_lib_support] +#error: \A[^\n]*: in function `foo':\n +#error: \(\.text\+0x0\): relocation R_MIPS_PC16 against `\*ABS\*' cannot be used when making a PIC/PIE object diff --git a/ld/testsuite/ld-mips-elf/pic-reject-abs-reloc.s b/ld/testsuite/ld-mips-elf/pic-reject-abs-reloc.s new file mode 100644 index 00000000000..a845fd50a77 --- /dev/null +++ b/ld/testsuite/ld-mips-elf/pic-reject-abs-reloc.s @@ -0,0 +1,2 @@ +foo: + b 8 -- 2.39.2