From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42d.google.com (mail-pf1-x42d.google.com [IPv6:2607:f8b0:4864:20::42d]) by sourceware.org (Postfix) with ESMTPS id 0E6453858C36 for ; Tue, 12 Mar 2024 21:04:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0E6453858C36 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0E6453858C36 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::42d ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710277488; cv=none; b=qt8ZbsYJ7tcgv0iEOOxbozmY6PYUCLgG8GtWF2lxW13VBRYqr6+zqoL4AZkrfFIXZDWfkQzwBLBGtnkr6jWG7W5q7tQy3HEjDZe1hbaXAfBDwiS8g26Xx1Hn0heMjnfoOYgnEejlN1NFVxt5QFwLL4+gZeIAYDFAR27uYDLk1A4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710277488; c=relaxed/simple; bh=wu72vC+ATlhJxq/rZSJuVUl9kocmwZrcZyspTXUppVk=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=c5dYOyzXZPGEZfD9Ko9XOfftRlrF8gP59XHGBXTGb9pi0TRDhJbuA7IMmNcJEugwjTvxgCzon/oJRBfOuHPSwIifqmBQ0J4SrSaHfWwi4x/eXWSes2yNum6GzJQOuFn+32cCSlfcDwSH0Z7TkmhD+jytCeA2X8GZlCiOz2RTvV0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pf1-x42d.google.com with SMTP id d2e1a72fcca58-6e6b6e000a4so65939b3a.0 for ; Tue, 12 Mar 2024 14:04:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710277486; x=1710882286; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=7uwDMQXKlIOZxwCVz2B03hfMUu5elhFp8cE75nA7WOg=; b=fpCN3pSq8m1sJAQgPrRbukAYp3DhOjAhWR9RNYT8EM9uCUQKD9PDZzW+cALjTTTL9P sBhWj5u1f9DMZ1VxqTeIhclet0J8+uZKR2X3jy9/Sa1cV2afvn+++SQT7Ia7Ez48K9nf lsvYYNicGsB7ks8pKjvHk+PBsjNkic7oLVF3iWoh1GQcU7ZmaSA930RvP9V/SBVzsGPj kB9PuUax1NGXCcuksuH4P8wK8SMhK/vUS/e1Q+/7kGH0Z46cVHToFqPFqYR2fphLQbL/ 8vaYIIQGP300/fefn2GMEM1hRhvRqaUf+q+xmdO+OUwFCDvva/u1Ug74byQMy2OcWcC7 qBpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710277486; x=1710882286; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7uwDMQXKlIOZxwCVz2B03hfMUu5elhFp8cE75nA7WOg=; b=g02JaYDfzdeJc3SO15WSt6x4QIhJPE672oSBV8Vbw2itH1o2KofoMPOKwbyjYbT+3R M43+Wd3LSGpt/p4UD+es0r4C4i0+vF/cpTDEQxf8AFJeXhwJaT/FQt8wHIpR5wbHlqZY BkNpYVcrALSa4gdmIj1GwEtB7drxYBpLG9SPqwGAZWWhcfQnunliYdYsKumIxYBgrsx7 90pdjs4NqAT43YErtxkdaiQl7clpj3udPS5X2XHOf6u8nU3+hh1d4yGCDdcQP3VdqJaG SrV/SDS+GK0LJPSSuwhNPCMpD8Wrh05qOyTwPAVH+gJNiYqPR7dT5qdUWYQAMXS2seNB mm4w== X-Gm-Message-State: AOJu0YwsZNUClXj6PoWehTyHb2THwp9fIf4oWQtQh/lkt39ThJEmYmO2 VL06jj9NnLYIkQAo+CBsPwbI0QwaJ+5und4zB0vDf5Qa8UotoFs7lhmouUiN X-Google-Smtp-Source: AGHT+IFUq3/73Yxqj7LXWExtMsdx/jQMcvCqBEr8EQMz9acWu5QDc3DIyPNgH1EVcRS7lKc+bxmlfQ== X-Received: by 2002:a05:6a21:99a2:b0:1a1:5a12:9119 with SMTP id ve34-20020a056a2199a200b001a15a129119mr872366pzb.3.1710277485740; Tue, 12 Mar 2024 14:04:45 -0700 (PDT) Received: from gnu-cfl-3.localdomain ([172.58.89.72]) by smtp.gmail.com with ESMTPSA id x19-20020a63b213000000b005dc87f5dfcfsm6496590pge.78.2024.03.12.14.04.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Mar 2024 14:04:45 -0700 (PDT) Received: from gnu-cfl-3.. (localhost [IPv6:::1]) by gnu-cfl-3.localdomain (Postfix) with ESMTP id AD94C740050; Tue, 12 Mar 2024 14:04:43 -0700 (PDT) From: "H.J. Lu" To: binutils@sourceware.org Cc: jakub@redhat.com Subject: [PATCH] bfd: Don't call bfd_write with 0 size Date: Tue, 12 Mar 2024 14:04:43 -0700 Message-ID: <20240312210443.3825862-1-hjl.tools@gmail.com> X-Mailer: git-send-email 2.44.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3019.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_ABUSEAT,RCVD_IN_DNSWL_NONE,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: There is no need to call bfd_write with 0 size. * elf-strtab.c (_bfd_elf_strtab_emit): Don't call bfd_write with 0 size. --- bfd/elf-strtab.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bfd/elf-strtab.c b/bfd/elf-strtab.c index 5fdfac12bde..b6c62f15fa0 100644 --- a/bfd/elf-strtab.c +++ b/bfd/elf-strtab.c @@ -326,7 +326,7 @@ _bfd_elf_strtab_emit (register bfd *abfd, struct elf_strtab_hash *tab) BFD_ASSERT (tab->array[i]->refcount == 0); len = tab->array[i]->len; - if ((int) len < 0) + if ((int) len <= 0) continue; str = tab->array[i]->root.string; -- 2.44.0