From: "H.J. Lu" <hjl.tools@gmail.com>
To: binutils@sourceware.org
Subject: [PATCH] x86: Fix memory leaks in tc_gen_reloc
Date: Tue, 9 Apr 2024 16:02:17 -0700 [thread overview]
Message-ID: <20240409230217.2463313-1-hjl.tools@gmail.com> (raw)
Replace XNEW with bfd_xalloc to fix memory leaks in tc_gen_reloc.
* config/tc-i386.c (tc_gen_reloc): Replace XNEW with bfd_xalloc.
---
gas/config/tc-i386.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/gas/config/tc-i386.c b/gas/config/tc-i386.c
index 502cc1b6978..122983ece79 100644
--- a/gas/config/tc-i386.c
+++ b/gas/config/tc-i386.c
@@ -17583,8 +17583,8 @@ tc_gen_reloc (asection *section ATTRIBUTE_UNUSED, fixS *fixp)
code = BFD_RELOC_X86_64_GOTPC64;
}
- rel = XNEW (arelent);
- rel->sym_ptr_ptr = XNEW (asymbol *);
+ rel = bfd_xalloc (stdoutput, sizeof (arelent));
+ rel->sym_ptr_ptr = bfd_xalloc (stdoutput, sizeof (asymbol *));
*rel->sym_ptr_ptr = symbol_get_bfdsym (fixp->fx_addsy);
rel->address = fixp->fx_frag->fr_address + fixp->fx_where;
--
2.44.0
reply other threads:[~2024-04-09 23:02 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240409230217.2463313-1-hjl.tools@gmail.com \
--to=hjl.tools@gmail.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).