From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by sourceware.org (Postfix) with ESMTP id 106C93858D20 for ; Wed, 17 Apr 2024 07:00:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 106C93858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=loongson.cn ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 106C93858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=114.242.206.163 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713337229; cv=none; b=kP3lAZ6wROT7tah7P2Wi56OZFpdEcA9rATbtO1JaI8SrKCF9rplGGVkPqWOLlXzdeFRKqqyB+UI/amSOG7JP1+kUE9FxpQcI47CrHJVXKimmmOlu2W1cV+17wa/+eR2NjeOVCA8vK90AUiFwvnXsQwvKu8TzodCEI5LYrQz66K8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713337229; c=relaxed/simple; bh=B5p7Y+61LmVGRNT6LLVTJ0DX1wWpaAjDjY7Cyrd+qhU=; h=From:To:Subject:Date:Message-Id:MIME-Version; b=F2xL3QDdeVNgQXoPTR7eAF7RBBZreysamT3NodYjteuOgdp6LNUzI0nUZTqj2nRl7jdyIWQi7lMCRu8NA1QsMrtE9zccsbHE31h/TMZ9rqo8wQYnAVIfRPlqPn1g+62hlwgnYLRvhI0U0Ou1GiTpKxyRuDEIWa2zKaOzl75mMck= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from loongson.cn (unknown [111.9.175.10]) by gateway (Coremail) with SMTP id _____8CxprmGcx9my6koAA--.11000S3; Wed, 17 Apr 2024 15:00:23 +0800 (CST) Received: from localhost.localdomain (unknown [111.9.175.10]) by localhost.localdomain (Coremail) with SMTP id AQAAf8BxXs2Ecx9mbL99AA--.39529S2; Wed, 17 Apr 2024 15:00:21 +0800 (CST) From: Jinyang He To: Chenghua Xu , Zhensong Liu , mengqinggang Cc: WANG Xuerui , Xi Ruoyao , binutils@sourceware.org, Jinyang He , Lulu Cai Subject: [PATCH v2] LoongArch: gas: Simplify relocations in sections without code flag Date: Wed, 17 Apr 2024 15:00:20 +0800 Message-Id: <20240417070020.9354-1-hejinyang@loongson.cn> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID:AQAAf8BxXs2Ecx9mbL99AA--.39529S2 X-CM-SenderInfo: pkhmx0p1dqwqxorr0wxvrqhubq/ X-Coremail-Antispam: 1Uk129KBj93XoW7WFWDGr1xCFWDKrWkGF47KFX_yoW5Jr4rpr WUuF1jkF4rCFnakFZrZryUXr1fAan7Kr429FWSqr1xurZ3try7Z34vyF9xXFWDX3yDu3Wr Zr4Fq3yjgFn0kacCm3ZEXasCq-sJn29KB7ZKAUJUUUU5529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29KBjDU 0xBIdaVrnRJUUUkFb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2 IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48v e4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_JFI_Gr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI 0_Jr0_Gr1l84ACjcxK6I8E87Iv67AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVCY1x0267AK xVW8Jr0_Cr1UM2AIxVAIcxkEcVAq07x20xvEncxIr21l57IF6xkI12xvs2x26I8E6xACxx 1l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r1Y6r17McIj6I8E87Iv 67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IYc2Ij64vIr41l42xK82IYc2 Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s02 6x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r1q6r43MIIYrxkI7VAKI48JMIIF0x vE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14v26r1j6r4UMIIF0xvE 42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv6x kF7I0E14v26r1j6r4UYxBIdaVFxhVjvjDU0xZFpf9x07UNvtZUUUUU= X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Gas should not emit ADD/SUB relocation pairs for label differences if they are in the same section without code flag even relax enabled. Because the real value is not be affected by relaxation and it can be compute out in assembly stage. Thus, correct the `TC_FORCE_RELOCATION _SUB_SAME` and the label differences in same section without code flag can be resolved in fixup_segment(). --- v2: Improve the commit info. gas/config/tc-loongarch.h | 4 +--- gas/testsuite/gas/loongarch/relax_debug_line.d | 11 +++++++++++ gas/testsuite/gas/loongarch/relax_debug_line.s | 6 ++++++ 3 files changed, 18 insertions(+), 3 deletions(-) create mode 100644 gas/testsuite/gas/loongarch/relax_debug_line.d create mode 100644 gas/testsuite/gas/loongarch/relax_debug_line.s diff --git a/gas/config/tc-loongarch.h b/gas/config/tc-loongarch.h index e0d0962e5f0..e1ef42c1314 100644 --- a/gas/config/tc-loongarch.h +++ b/gas/config/tc-loongarch.h @@ -91,9 +91,7 @@ extern bool loongarch_frag_align_code (int, int); #define TC_FORCE_RELOCATION_SUB_SAME(FIX, SEC) \ (LARCH_opts.relax ? \ (GENERIC_FORCE_RELOCATION_SUB_SAME (FIX, SEC) \ - || ((SEC)->flags & SEC_CODE) != 0 \ - || ((SEC)->flags & SEC_DEBUGGING) != 0 \ - || TC_FORCE_RELOCATION (FIX)) \ + || ((SEC)->flags & SEC_CODE) != 0) \ : (GENERIC_FORCE_RELOCATION_SUB_SAME (FIX, SEC))) \ #define TC_LINKRELAX_FIXUP(seg) ((seg->flags & SEC_CODE) \ diff --git a/gas/testsuite/gas/loongarch/relax_debug_line.d b/gas/testsuite/gas/loongarch/relax_debug_line.d new file mode 100644 index 00000000000..0099eb5b79e --- /dev/null +++ b/gas/testsuite/gas/loongarch/relax_debug_line.d @@ -0,0 +1,11 @@ +#as: --gdwarf-5 +#readelf: -r --wide + +Relocation section '\.rela\.debug_line' at offset .* contains 5 entries: +#... +0+22.*R_LARCH_32[ \t]+[0-9]+.* +0+2c.*R_LARCH_32[ \t]+[0-9]+.* +0+36.*R_LARCH_64[ \t]+[0-9]+.* +0+42.*R_LARCH_ADD16[ \t]+[0-9]+.* +0+42.*R_LARCH_SUB16[ \t]+[0-9]+.* +#pass diff --git a/gas/testsuite/gas/loongarch/relax_debug_line.s b/gas/testsuite/gas/loongarch/relax_debug_line.s new file mode 100644 index 00000000000..d2852bb91e2 --- /dev/null +++ b/gas/testsuite/gas/loongarch/relax_debug_line.s @@ -0,0 +1,6 @@ + .file 0 "test" + .text + .loc 0 10 0 + nop + +.section .debug_line, "", @progbits -- 2.43.0