From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id EEEDC3858408 for ; Wed, 17 Apr 2024 20:21:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EEEDC3858408 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org EEEDC3858408 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=205.220.165.32 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1713385268; cv=pass; b=Nxy0xCjAnivNB2k1qWYNk+zbxK6A6yRSIH2IzrCD+ivDAeQ7Jrq3Vu6hDL/Thp1RyGEtyWuvVFyU1+8/KqZLxDcOPwmWzovOzs6onOH/TWBrr4QqkQO4Ip+ma7rG0RKE6k/Io3mBAMYt09MqPvURhoBCay673oJXezM8f4Wgq/E= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1713385268; c=relaxed/simple; bh=+4NKNT8X6rUGKVEpirZQVX6GG83Cg909e5nnpGhMp7Q=; h=DKIM-Signature:DKIM-Signature:From:To:Subject:Date:Message-ID: MIME-Version; b=CNIbNEEMNwuA4svson5bsGCMOKqV1Fih6NpyW0htO+XTKm529MJfL+Jl2VPlpurkNYMN9DFvE/UpKk6qotz6AtZmMWZn3U7mW4EkQR0Gmrd5iujjc7yu0tTjxyIXvxMOLUVTz0t3EmU9gwHWJpP/f9wpWmj13aq1ttr86KNRF60= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 43HHiVeX006061 for ; Wed, 17 Apr 2024 20:21:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : subject : date : message-id : in-reply-to : references : content-transfer-encoding : content-type : mime-version; s=corp-2023-11-20; bh=srKJl5QcH1onmyEAglWgTlISdce5n4NudyGyq0/hXyY=; b=OJcqbyBlBkUTKQqJHE1edOn4wOPcg6fJsNsP97i/j+K1XGPqkKcZV7DmY+a/xRWXpcSj U4z1tPurTvaJVA2ZKFxFsVcN9pOLFofrh3PBrFtUmwe4JaHWmdqfchd0gubKbQbamQdY Xa4IdHFrCXunwqXDlhvV5Jthmy3lYTfZWX6b2/yzNMIzZzHUi4dOdjNuP9FsAJMTcvS/ bJ6k9AAgleX7qTcUa0k9K15QlHUVQzXDhCaT2sOrpIVKgN0gNV+I5ktN1ncmfbe779BC xyDcrRVg9YKjdYjheWrJXm6TyxXCMo/gf3xMtEp37aoM0I11gkTCfBb9MpwETzDc2xlg Hw== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3xfhxbrrgn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 17 Apr 2024 20:21:02 +0000 Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 43HItXvN021621 for ; Wed, 17 Apr 2024 20:21:01 GMT Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2041.outbound.protection.outlook.com [104.47.66.41]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3xfggfpe94-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 17 Apr 2024 20:21:01 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZdrSCH+/e7wbeHhMUIEALTAJIk6dv2tyiL0t/OBBejhIECxMObsEdxirnB1NQ2Fkx4Db6qeynL3bYei2lqJ7/cMOvBlL2y5oZwlO68AtgExgcieQxMWOfctxB7OILR697N4j7cUq0+DmKxK8YrxhwhwUCceDsvU6TYCpumULcJy0IDtMNMwxKxzg/4bQyRg5AYcV4Yfor6AwWA8pByhjU4KW2Mdk0wNQajXa0wP5rIySMCTW1o0QhYSGFfNgZwhvsMFwGjnpyxbWWSngDM4YL8hrKUkn/glNDQOkRjLMxSdLrWImXpN/vofvOvhoMu6/3Fwcw0HBEv/0WT270/C+Yg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=srKJl5QcH1onmyEAglWgTlISdce5n4NudyGyq0/hXyY=; b=bTjt5mOQBeZC1f+PMJKEiZGuf2rhRleidYAKZQD4J7ecvtZ+ysisP7Kg+Ujsc4k5MV31CmvcSeLhQzuNRj4V84jz2WfyZTPLczjE0ArtkKq7yPSopC1ML+gvqH0hcjiIlYKiW2FOmwdHZ3jUOXQbezbun6Qc1f1NH5+TwjzxN/gqJz7D/yHWaBQH17d7m6BkGNddKPchhlbyzpz8u+2sPZhHM4USY6BXCW1fHiLMCdEituYAzmP1DGp6Qn7dIE78eMzR8p676A+91S+Wa2FBQ6Qu1f036pMVTYV+tobbaKvz66Mu7SrZ+kYkybGW35bHHfc01amOO9AokEbOk0T5Qw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=srKJl5QcH1onmyEAglWgTlISdce5n4NudyGyq0/hXyY=; b=k/dwHgUBFZz37vbNDSl1CZ0IAPEqr3H3YHbKKsd6h//9i2u1NBRRernD91jMAIh+lzl/p9DeUosQQaBklr/D2FveO9EDHsiJMfHuUfkeM6NqA5JsK5jpH1isXg7txH1qm3ixiIgsIppvnbxQfnOOSi/6973TVmbN7QhmpQYwGqs= Received: from MW4PR10MB6608.namprd10.prod.outlook.com (2603:10b6:303:22e::8) by SA1PR10MB5821.namprd10.prod.outlook.com (2603:10b6:806:232::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.50; Wed, 17 Apr 2024 20:20:58 +0000 Received: from MW4PR10MB6608.namprd10.prod.outlook.com ([fe80::67a4:9544:7249:7751]) by MW4PR10MB6608.namprd10.prod.outlook.com ([fe80::67a4:9544:7249:7751%7]) with mapi id 15.20.7472.037; Wed, 17 Apr 2024 20:20:57 +0000 From: Nick Alcock To: binutils@sourceware.org Subject: [PATCH 07/22] libctf: delete LCTF_DIRTY Date: Wed, 17 Apr 2024 21:20:03 +0100 Message-ID: <20240417202018.34966-8-nick.alcock@oracle.com> X-Mailer: git-send-email 2.44.0.273.ge0bd14271f In-Reply-To: <20240417202018.34966-1-nick.alcock@oracle.com> References: <20240417202018.34966-1-nick.alcock@oracle.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: LO2P123CA0026.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600::14) To MW4PR10MB6608.namprd10.prod.outlook.com (2603:10b6:303:22e::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MW4PR10MB6608:EE_|SA1PR10MB5821:EE_ X-MS-Office365-Filtering-Correlation-Id: c986351e-4838-4748-c4e8-08dc5f1be42d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ja1wJEzvapmFeoBnFk4IIPWo0fUbmtTz70fXpFcnbPx3mRZS3vJtW03WUlSy02+8qOZF254UA/srOmywagxEuDEx27uz5ZklBGUBYvfIRH4ybQUrJKPsH8oi9oZCUJcA3WPmrHzauz3mHLkgzZnEkJGRg5KBzXQjGopCn7wEvo0MsOTWsWs2rDcZONmKw30IwH2ArvpOaclxF63cJU3/aR5hnpAvX+UF4y09EsFOZ8njLJrlLyTFQbNJ8MYBxx921MAqiL6z+cab3DTpwfpA0yJKFJw2FJjAxEeoSQSx45JYZ8k1qIlg9mhpRKrjfQQ56I2xHuXPu70d5+z659qaoP+gCnfIbHNO6XlNsy0/a23OWlvIRaPs8SLMFDIKxGhm0mK9KVc4Z+IccVr66wC9MO0QkQC9XoSyfpDsHYg8z4szjxsdzZvCxu22TO6sI999DjJ9GGBhQRMmIVfz1q/Eu0K9Mzp9JleBywAHP48qXmwvo2eoiBzvOII+Dz5lDrAeWz0TlKm2uqBJRcXYircvwV34/XHd8HUSJjfnImfTeM35N+iHeLr9omQjNXNYe0QOLCVDp+uFd9msuWGI0sFj35T36r0YmOqmWbEIlOqOmE/wVWDucjyDMGgwkHNb6UkFWpmvq55IUBPyK0EH6l3SMoojBNOdN7YLTNtzocHL26w= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR10MB6608.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366007)(376005)(1800799015);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?URkfm0AsjOvu5dFv3ZyN7ZVSwQUEzMoqTTzfNj0Fo89ljSDSyycbUQv1PZRf?= =?us-ascii?Q?Nw6jm9taxIC5UtBM4JegeWrzYKEhwsRtrhCnDoyoeyQAwyJDMM9XauUxPw73?= =?us-ascii?Q?Utg91fQxDY9L3TpyrKMgwRtwKuIeoEs58Kt/fzAVffXaGef3QcwxCwl6CY+Z?= =?us-ascii?Q?nWAOnrf9ShBajZG8kFN4oxRzOuqShWy3MrvthQ3sQo5K2vEj5bhZGDqY+dkP?= =?us-ascii?Q?ImRVtoXRz8noj2rR5WpQZ8FBbpa8hcAxxMlSE8qdQf4EglYIaDKPLk+xicu0?= =?us-ascii?Q?q2r8+QZtNh1epIG/aXxAbuAfnqzZdj1mcpiI6movl4yeV6K13+lyiEVJMZEG?= =?us-ascii?Q?q5eIz2c4Mj8vJiTVvN6q2ZTjOVWgfav9ntZIBRsIOziWUZSZZqHlMlcBZg18?= =?us-ascii?Q?NckLDtw3XLw+fCkfyHuLZhM49FMmulRlCqed5oxcUB51dXoFGiiJtvr1YSRC?= =?us-ascii?Q?xlOSZxilM/9ekDQxGhs5wcKMPfvyzMz4LId0k3WzH0Cd+mr1j8ltKEkFRmq/?= =?us-ascii?Q?OADOSsj2wyVU6IK7Odyfy5Urns91LFkZJTPHUwHRFVIjeuOeKbawNMSuJtSk?= =?us-ascii?Q?FKZgjOmmVpwivZedEpn2ttHGemEFp7nM5IV7R2MEkJinxLpQNu4NxkQcKcHT?= =?us-ascii?Q?3i1BuQTR5kew6CgEpMLOSGYiwujE3AHey70I8fcv6JdKUnzJXDglwn3eKDa7?= =?us-ascii?Q?UtlO2uHmkHlUWEQgQDBJ51/sFwuRAB6uqFphiQZ30ZWp+zRaNlTFf3sW9IkT?= =?us-ascii?Q?f83PGGFZzSM5w4hrRUUXrPM1F/tR/Ytuawor/8GKN41JCUZ/7uXJ8nHz3M70?= =?us-ascii?Q?T71I6B4sRxDJfzcCJ7CxveZaAOPUHkpFftdJFNk2Dr1pGGXsZXBDrfH//6py?= =?us-ascii?Q?tV+/fXZlZf9yb+v9qS+7EOnDG8FMrikeVlKHUxqVfxt6P/5m5+QIblM5OBd7?= =?us-ascii?Q?ZWXiQHTgPEykTOECAwE0i2cut1K7Vx/FBHIjaqu6bLIGyTH0vBUgXJFMgJxq?= =?us-ascii?Q?1oEMpTpyENHSXBak+UvRjC4PC7wIsRL0AnqgPE9tTzjsJi0m1eQee7tZDBFX?= =?us-ascii?Q?0EOHuMkl8Z4GMEfjDASIR8OBd3a1I4DbPEjWSQDvW+U/TIoIbtRPFtTKjXTd?= =?us-ascii?Q?jpmonsGkh35OJMAy0kz26JCuHUevpRf30rCp+NeArmk/1nrkVVEakH+UBYMN?= =?us-ascii?Q?+/7R+Jrbd9wQzlpkl+4N6+TxovdYamz4Bokd/wraZw0s6yCAwWvXbBt7FJSJ?= =?us-ascii?Q?VhlI0nEg7C/Tc7FQYRL+gs4oPhVHzBLOy/pvTnpBXfaprEV6xaB6OWvi+t+E?= =?us-ascii?Q?VV+a/KQqdVuOG0hn9GVgxBE5Jb6r9Rmhs8LKb1/EFURZz2ojzF2kd4OD8eFx?= =?us-ascii?Q?raLdcAHRZHFRI8VMtEVRCvKjuKs1tRL2a5LweNQDYJdCayhBbZdTj+UXElXE?= =?us-ascii?Q?/v3BoYLGhnlVAN5pQRLQV271mpUATEC27x8E/iw+lErvnaZ2qtlJq0AOm5pI?= =?us-ascii?Q?ZypGNLB4l1ZDCiyjJP8/A4hdUfl8C3FcxmSZchWvOm5Zi4ORsAxtDPDjMUNO?= =?us-ascii?Q?TfBIsN+RYVOXlwOavs5EPDC7woMTu09McQ/ndSceVbdfuJQhN2EKJpS8cNrF?= =?us-ascii?Q?Mw=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: XwwQk6HSS7AW/LXqry3wX78z2HPp0+wC5duF9lc6PPnhR1Nu/PKmCdtEzpE1nWyh7w0TkFjQf9z9kW+Jq+O7HMyEq4JDC+ISkWxiY1UGCM1jgzfN4Ji4OmZnWUaqs2sSujvw1NepViOZGIDQIK6N+lJnvhlOfc/8DsvrLetHt0SdYjZUZpv43JrQzslJey6JenlJ9MSS6KQtFmuLSrDXsHbtbSh75m54U0RnhYYQ2oi91K1CIrqWmWR2j1vl0vb7nA+ExldOaYcFE/D5TUQdz4vL7pvKdQo4b4mWVgrJ5BBATlua+QtASdxIZKSregtxFNCYXPNmD+Pw36GsklpockUix142bep6WKJHpcGxV72etk1i3OUoABkSsUdYORr7lE6xDoaUyk9NY5Kj/b3DudyhKrqILWfT9f2TN+uPy+x3JjRgaivnZpBUgUjZ+Q6LTDgaALOuAxfgShriQP+78alhK5HmafyJyOIAz7DicaoE9A9qS5wekE2sZMZRJUki/Q+cfeJmm+uylcrcstTp/22U/uFs0sqQYPwCZMNnX80inCpWvINAe/1O0iFlwITbAPE0SscBEVZYtwcvMF+zcAjV6mXrvdiHZW85coJEzJQ= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: c986351e-4838-4748-c4e8-08dc5f1be42d X-MS-Exchange-CrossTenant-AuthSource: MW4PR10MB6608.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Apr 2024 20:20:57.8954 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6dkKkEuyywAHR9J8CxD3/MkeWM/N8B0MdMvW8bU6TQo5pTHRKqz8PaT0WNC2vaiK8bBX6v2n2XCXjn3bJfbfig== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR10MB5821 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-04-17_17,2024-04-17_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxscore=0 mlxlogscore=999 suspectscore=0 adultscore=0 phishscore=0 bulkscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2404010000 definitions=main-2404170143 X-Proofpoint-ORIG-GUID: R34vUgOomlodg8MAW1Bm05DLReu7imyE X-Proofpoint-GUID: R34vUgOomlodg8MAW1Bm05DLReu7imyE X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This flag was meant as an optimization to avoid reserializing dicts unnecessarily. It was critically necessary back when serialization was done by ctf_update() and you had to call that every time you wanted any new modifications to the type table to be usable by other types, but that has been unnecessary for years now, and serialization is only done once when writing out, which one would naturally assume would always serialize the dict. Worse, it never really worked: it only tracked newly-added types, not things like added symbols which might equally well require reserialization, and it gets in the way of an upcoming change. Delete entirely. libctf/ * ctf-create.c (ctf_create): Drop LCTF_DIRTY. (ctf_discard): Likewise. (ctf_rollback): Likewise. (ctf_add_generic): Likewise. (ctf_set_array): Likewise. (ctf_add_enumerator): Likewise. (ctf_add_member_offset): Likewise. (ctf_add_variable_forced): Likewise. * ctf-link.c (ctf_link_intern_extern_string): Likewise. (ctf_link_add_strtab): Likewise. * ctf-serialize.c (ctf_serialize): Likewise. * ctf-impl.h (LCTF_DIRTY): Likewise. (LCTF_LINKING): Renumber. --- libctf/ctf-create.c | 15 --------------- libctf/ctf-impl.h | 3 +-- libctf/ctf-link.c | 2 -- libctf/ctf-serialize.c | 5 ----- 4 files changed, 1 insertion(+), 24 deletions(-) diff --git a/libctf/ctf-create.c b/libctf/ctf-create.c index 7aa244e5ec7..23bbf92ff1a 100644 --- a/libctf/ctf-create.c +++ b/libctf/ctf-create.c @@ -148,7 +148,6 @@ ctf_create (int *errp) fp->ctf_names = names; fp->ctf_dtoldid = 0; fp->ctf_snapshot_lu = 0; - fp->ctf_flags |= LCTF_DIRTY; /* Make sure the ptrtab starts out at a reasonable size. */ @@ -347,10 +346,6 @@ ctf_discard (ctf_dict_t *fp) { fp->ctf_dtoldid, fp->ctf_snapshot_lu + 1 }; - /* Update required? */ - if (!(fp->ctf_flags & LCTF_DIRTY)) - return 0; - return (ctf_rollback (fp, last_update)); } @@ -415,9 +410,6 @@ ctf_rollback (ctf_dict_t *fp, ctf_snapshot_id_t id) fp->ctf_typemax = id.dtd_id; fp->ctf_snapshots = id.snapshot_id; - if (fp->ctf_snapshots == fp->ctf_snapshot_lu) - fp->ctf_flags &= ~LCTF_DIRTY; - return 0; } @@ -482,8 +474,6 @@ ctf_add_generic (ctf_dict_t *fp, uint32_t flag, const char *name, int kind, if (ctf_dtd_insert (fp, dtd, flag, kind) < 0) goto err; /* errno is set for us. */ - fp->ctf_flags |= LCTF_DIRTY; - *rp = dtd; return type; @@ -729,7 +719,6 @@ ctf_set_array (ctf_dict_t *fp, ctf_id_t type, const ctf_arinfo_t *arp) return (ctf_set_errno (ofp, ECTF_BADID)); vlen = (ctf_array_t *) dtd->dtd_vlen; - fp->ctf_flags |= LCTF_DIRTY; vlen->cta_contents = (uint32_t) arp->ctr_contents; vlen->cta_index = (uint32_t) arp->ctr_index; vlen->cta_nelems = arp->ctr_nelems; @@ -1113,8 +1102,6 @@ ctf_add_enumerator (ctf_dict_t *fp, ctf_id_t enid, const char *name, dtd->dtd_data.ctt_info = CTF_TYPE_INFO (kind, root, vlen + 1); - fp->ctf_flags |= LCTF_DIRTY; - return 0; } @@ -1296,7 +1283,6 @@ ctf_add_member_offset (ctf_dict_t *fp, ctf_id_t souid, const char *name, dtd->dtd_data.ctt_lsizelo = CTF_SIZE_TO_LSIZE_LO (ssize); dtd->dtd_data.ctt_info = CTF_TYPE_INFO (kind, root, vlen + 1); - fp->ctf_flags |= LCTF_DIRTY; return 0; } @@ -1365,7 +1351,6 @@ ctf_add_variable_forced (ctf_dict_t *fp, const char *name, ctf_id_t ref) return -1; /* errno is set for us. */ } - fp->ctf_flags |= LCTF_DIRTY; return 0; } diff --git a/libctf/ctf-impl.h b/libctf/ctf-impl.h index f4fa3234681..dc57d6f64c7 100644 --- a/libctf/ctf-impl.h +++ b/libctf/ctf-impl.h @@ -589,8 +589,7 @@ struct ctf_next ((fp)->ctf_dictops->ctfo_get_vbytes(fp, kind, size, vlen)) #define LCTF_CHILD 0x0001 /* CTF dict is a child. */ -#define LCTF_DIRTY 0x0002 /* CTF dict has been modified. */ -#define LCTF_LINKING 0x0004 /* CTF link is underway: respect ctf_link_flags. */ +#define LCTF_LINKING 0x0002 /* CTF link is underway: respect ctf_link_flags. */ extern ctf_dynhash_t *ctf_name_table (ctf_dict_t *, int); extern const ctf_type_t *ctf_lookup_by_id (ctf_dict_t **, ctf_id_t); diff --git a/libctf/ctf-link.c b/libctf/ctf-link.c index 9d2d29416d3..44d4e496f6a 100644 --- a/libctf/ctf-link.c +++ b/libctf/ctf-link.c @@ -1568,7 +1568,6 @@ ctf_link_intern_extern_string (void *key _libctf_unused_, void *value, ctf_dict_t *fp = (ctf_dict_t *) value; ctf_link_out_string_cb_arg_t *arg = (ctf_link_out_string_cb_arg_t *) arg_; - fp->ctf_flags |= LCTF_DIRTY; if (!ctf_str_add_external (fp, arg->str, arg->offset)) arg->err = ENOMEM; } @@ -1596,7 +1595,6 @@ ctf_link_add_strtab (ctf_dict_t *fp, ctf_link_strtab_string_f *add_string, { ctf_link_out_string_cb_arg_t iter_arg = { str, offset, 0 }; - fp->ctf_flags |= LCTF_DIRTY; if (!ctf_str_add_external (fp, str, offset)) err = ENOMEM; diff --git a/libctf/ctf-serialize.c b/libctf/ctf-serialize.c index 7092264f446..9dd7fbda285 100644 --- a/libctf/ctf-serialize.c +++ b/libctf/ctf-serialize.c @@ -980,10 +980,6 @@ ctf_serialize (ctf_dict_t *fp) if (fp->ctf_stypes > 0) return (ctf_set_errno (fp, ECTF_RDONLY)); - /* Update required? */ - if (!(fp->ctf_flags & LCTF_DIRTY)) - return 0; - /* The strtab refs table must be empty at this stage. Any refs already added will be corrupted by any modifications, including reserialization, after strtab finalization is complete. Only this function, and functions it @@ -1156,7 +1152,6 @@ ctf_serialize (ctf_dict_t *fp) nfp->ctf_parent = fp->ctf_parent; nfp->ctf_parent_unreffed = fp->ctf_parent_unreffed; nfp->ctf_refcnt = fp->ctf_refcnt; - nfp->ctf_flags |= fp->ctf_flags & ~LCTF_DIRTY; if (nfp->ctf_dynbase == NULL) nfp->ctf_dynbase = buf; /* Make sure buf is freed on close. */ nfp->ctf_dthash = fp->ctf_dthash; -- 2.44.0.273.ge0bd14271f