From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by sourceware.org (Postfix) with ESMTP id 866FB3849AF2 for ; Fri, 19 Apr 2024 09:58:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 866FB3849AF2 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=loongson.cn ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 866FB3849AF2 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=114.242.206.163 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713520711; cv=none; b=jc6psg3HH+IwW1OxGzWQ53zmg2y7QFd+0RGesROSAJkdpXLaHGCteqQv5mblXgIvGQAm8aCPieqYLs6++h1DSAeYkJTiTUTJL0JKJJVoYiQhRtRxhnR6IiZFT5cP4ZmF1Kbw4obmTV0i0Bz+jAGSzUKiQ+e8VtRdcYpCyTihPsY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713520711; c=relaxed/simple; bh=CNuaqcFsFb8h5ut9F1abMoooPx6S5a67vtNJGvODJxk=; h=From:To:Subject:Date:Message-Id:MIME-Version; b=f9SbK8cNVEcMB3ClByR4J3xv4YhT5EvVL2wI1YL2H2BaFSYHE84TcUucQXNjkFlTt9LcbVp3QBc5Mlu0p/NsLEqYPn+SUKocwdJyWyXkUfBZmSALeGbv6MIqrEh+4gnN4mLCDjKqL/kCW3uGAoq44y/pJZ7u+O0wAQDTMafFx3Q= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from loongson.cn (unknown [10.2.6.5]) by gateway (Coremail) with SMTP id _____8AxirpAQCJmlr4pAA--.13251S3; Fri, 19 Apr 2024 17:58:24 +0800 (CST) Received: from 5.5.5 (unknown [10.2.6.5]) by localhost.localdomain (Coremail) with SMTP id AQAAf8Bx8OQ_QCJmzBqAAA--.47175S4; Fri, 19 Apr 2024 17:58:23 +0800 (CST) From: Lulu Cai To: binutils@sourceware.org Cc: xuchenghua@loongson.cn, chenglulu@loongson.cn, liuzhensong@loongson.cn, mengqinggang@loongson.cn, xry111@xry111.site, i.swmail@xen0n.name, maskray@google.com, luweining@loongson.cn, hejinyang@loongson.cn, Lulu Cai Subject: [PATCH v1] LoongArch: The symbol got type can only be obtained after initialization Date: Fri, 19 Apr 2024 17:58:21 +0800 Message-Id: <20240419095821.2466105-1-cailulu@loongson.cn> X-Mailer: git-send-email 2.39.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID:AQAAf8Bx8OQ_QCJmzBqAAA--.47175S4 X-CM-SenderInfo: xfdlz3tox6z05rqj20fqof0/1tbiAQAMB2Yg2esQGAAPs5 X-Coremail-Antispam: 1Uk129KBj93XoW7ZrykXFW7Ar1fur4rtr1DArc_yoW8Jw4Upr y3Zw1agw1UCrW3Aw1jqa45ZrsxCayxurW2qFsIgr929Fs5Zry8XFy8tr4ava18JayDJa4j qayFya15Z3WDA3XCm3ZEXasCq-sJn29KB7ZKAUJUUUU8529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29KBjDU 0xBIdaVrnRJUUUkYb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2 IYs7xG6rWj6s0DM7CIcVAFz4kK6r106r15M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48v e4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Xr0_Ar1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI 0_Gr0_Cr1l84ACjcxK6I8E87Iv67AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVCY1x0267AK xVWxJr0_GcWle2I262IYc4CY6c8Ij28IcVAaY2xG8wAqjxCEc2xF0cIa020Ex4CE44I27w Aqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_Jrv_JF1lYx0Ex4A2jsIE 14v26r1j6r4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvY0x0EwIxGrwCF04k20xvY0x 0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E 7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_Jw0_GFylIxkGc2Ij64vIr41lIxAIcV C0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Jr0_Gr1lIxAIcVCF 04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7 CjxVAFwI0_Jr0_GrUvcSsGvfC2KfnxnUUI43ZEXa7IU8r9N3UUUUU== X-Spam-Status: No, score=-13.1 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: When scanning relocations and determining whether TLS type transition is possible, it will try to obtain the symbol got type. If the symbol got type record has not yet been allocated space and initialized, it will cause ld to crash. So when uninitialized, the symbol is set to GOT_UNKNOWN. --- bfd/elfnn-loongarch.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/bfd/elfnn-loongarch.c b/bfd/elfnn-loongarch.c index 7b493f6f05b..fe780e39610 100644 --- a/bfd/elfnn-loongarch.c +++ b/bfd/elfnn-loongarch.c @@ -683,7 +683,14 @@ loongarch_can_trans_tls (bfd *input_bfd, if (! IS_LOONGARCH_TLS_TRANS_RELOC (r_type)) return false; - symbol_tls_type = _bfd_loongarch_elf_tls_type (input_bfd, h, r_symndx); + /* Obtaining tls got type here may occur before + loongarch_elf_record_tls_and_got_reference, so it is necessary + to ensure that tls got type has been initialized, otherwise it + is set to GOT_UNKNOWN. */ + symbol_tls_type = GOT_UNKNOWN; + if (_bfd_loongarch_elf_local_got_tls_type (input_bfd) || h) + symbol_tls_type = _bfd_loongarch_elf_tls_type (input_bfd, h, r_symndx); + reloc_got_type = loongarch_reloc_got_type (r_type); if (symbol_tls_type == GOT_TLS_IE && GOT_TLS_GD_ANY_P (reloc_got_type)) -- 2.36.0