From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by sourceware.org (Postfix) with ESMTP id A0E7D3858D35 for ; Mon, 22 Apr 2024 09:49:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A0E7D3858D35 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=loongson.cn ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A0E7D3858D35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=114.242.206.163 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713779401; cv=none; b=vVFk2h1JzT4hroI/LIipU4yr93WjXnKCMd2Bbef/rvpFiNRz0G0IXfOrZtjQIHEdQJLZJ8G8RMUH2LGC9GhLGAJQk9mtuOB/gXc1KtL+dkT0RmycUhXXzxUZx+EA/zVWVj5h3yz895aEYmUOF3lQG75Jlp4+bISsfVs1eRNez4U= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713779401; c=relaxed/simple; bh=4hgO30MbAI2US8o9AmGh+CU8c8LelpnJ/u14Y+fC1SQ=; h=From:To:Subject:Date:Message-Id:MIME-Version; b=lxeZqWoHw1hIINfqboCpA8ogwP/FwCxoHtV9pBykNwpUqquj9neFwK8ITY03mTnUjbdRa05uTNbO++cRJ1gf5XZ1MD6BSII7tCs5FVy3W4VW3p9A14GJN75k/s+cys2e/2f9w8cMmBLHHjJgv1JCkViJmJ/5q8BU0GC4yq6Jh6w= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from loongson.cn (unknown [111.9.175.10]) by gateway (Coremail) with SMTP id _____8BxmPDBMiZmbb0AAA--.4352S3; Mon, 22 Apr 2024 17:49:54 +0800 (CST) Received: from localhost.localdomain (unknown [111.9.175.10]) by localhost.localdomain (Coremail) with SMTP id AQAAf8CxTN6+MiZmqDQBAA--.5392S2; Mon, 22 Apr 2024 17:49:52 +0800 (CST) From: Jinyang He To: Chenghua Xu , Zhensong Liu , mengqinggang Cc: WANG Xuerui , Xi Ruoyao , binutils@sourceware.org, Jinyang He , Lulu Cai Subject: [PATCH v3] LoongArch: gas: Simplify relocations in sections without code flag Date: Mon, 22 Apr 2024 17:49:50 +0800 Message-Id: <20240422094950.17383-1-hejinyang@loongson.cn> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID:AQAAf8CxTN6+MiZmqDQBAA--.5392S2 X-CM-SenderInfo: pkhmx0p1dqwqxorr0wxvrqhubq/ X-Coremail-Antispam: 1Uk129KBj93XoW7WFWDGr1xCFWDKrWkXFyxJFc_yoW5JF4xpr WUuF1jkF4rCFnIya9rA34UXr1fAa1xKr429FySqr1xurZ7try7Z34vyF9xXFWDX3yDu3Wr Zr48J3yj9Fn0kacCm3ZEXasCq-sJn29KB7ZKAUJUUUUr529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29KBjDU 0xBIdaVrnRJUUU9Yb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2 IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48v e4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Gr0_Xr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI 0_Gr0_Cr1l84ACjcxK6I8E87Iv67AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVCY1x0267AK xVW8Jr0_Cr1UM2kKe7AKxVWUXVWUAwAS0I0E0xvYzxvE52x082IY62kv0487Mc804VCY07 AIYIkI8VC2zVCFFI0UMc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0I7IYx2IY67AKxVWU XVWUAwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r1j6r4UM4x0Y48IcxkI7V AKI48JMxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMxCIbckI1I0E14v2 6r1Y6r17MI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17 CEb7AF67AKxVWUtVW8ZwCIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF 0xvE2Ix0cI8IcVCY1x0267AKxVWUJVW8JwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIx AIcVC2z280aVAFwI0_Jr0_Gr1lIxAIcVC2z280aVCY1x0267AKxVWUJVW8JbIYCTnIWIev Ja73UjIFyTuYvjxU74lkDUUUU X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Gas should not emit ADD/SUB relocation pairs for label differences if they are in the same section without code flag even relax enabled. Because the real value is not be affected by relaxation and it can be compute out in assembly stage. Thus, correct the `TC_FORCE_RELOCATION _SUB_SAME` and the label differences in same section without code flag can be resolved in fixup_segment(). --- v2: Improve the commit info. v3: Skip loongarch32. gas/config/tc-loongarch.h | 4 +--- gas/testsuite/gas/loongarch/relax_debug_line.d | 12 ++++++++++++ gas/testsuite/gas/loongarch/relax_debug_line.s | 6 ++++++ 3 files changed, 19 insertions(+), 3 deletions(-) create mode 100644 gas/testsuite/gas/loongarch/relax_debug_line.d create mode 100644 gas/testsuite/gas/loongarch/relax_debug_line.s diff --git a/gas/config/tc-loongarch.h b/gas/config/tc-loongarch.h index e0d0962e5f0..e1ef42c1314 100644 --- a/gas/config/tc-loongarch.h +++ b/gas/config/tc-loongarch.h @@ -91,9 +91,7 @@ extern bool loongarch_frag_align_code (int, int); #define TC_FORCE_RELOCATION_SUB_SAME(FIX, SEC) \ (LARCH_opts.relax ? \ (GENERIC_FORCE_RELOCATION_SUB_SAME (FIX, SEC) \ - || ((SEC)->flags & SEC_CODE) != 0 \ - || ((SEC)->flags & SEC_DEBUGGING) != 0 \ - || TC_FORCE_RELOCATION (FIX)) \ + || ((SEC)->flags & SEC_CODE) != 0) \ : (GENERIC_FORCE_RELOCATION_SUB_SAME (FIX, SEC))) \ #define TC_LINKRELAX_FIXUP(seg) ((seg->flags & SEC_CODE) \ diff --git a/gas/testsuite/gas/loongarch/relax_debug_line.d b/gas/testsuite/gas/loongarch/relax_debug_line.d new file mode 100644 index 00000000000..c17813c20ed --- /dev/null +++ b/gas/testsuite/gas/loongarch/relax_debug_line.d @@ -0,0 +1,12 @@ +#as: --gdwarf-5 +#readelf: -r --wide +#skip: loongarch32-*-* + +Relocation section '\.rela\.debug_line' at offset .* contains 5 entries: +#... +0+22.*R_LARCH_32[ \t]+[0-9]+.* +0+2c.*R_LARCH_32[ \t]+[0-9]+.* +0+36.*R_LARCH_64[ \t]+[0-9]+.* +0+42.*R_LARCH_ADD16[ \t]+[0-9]+.* +0+42.*R_LARCH_SUB16[ \t]+[0-9]+.* +#pass diff --git a/gas/testsuite/gas/loongarch/relax_debug_line.s b/gas/testsuite/gas/loongarch/relax_debug_line.s new file mode 100644 index 00000000000..d2852bb91e2 --- /dev/null +++ b/gas/testsuite/gas/loongarch/relax_debug_line.s @@ -0,0 +1,6 @@ + .file 0 "test" + .text + .loc 0 10 0 + nop + +.section .debug_line, "", @progbits -- 2.43.0