From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x12a.google.com (mail-il1-x12a.google.com [IPv6:2607:f8b0:4864:20::12a]) by sourceware.org (Postfix) with ESMTPS id 1EE0E3858C50 for ; Tue, 23 Apr 2024 14:13:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1EE0E3858C50 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1EE0E3858C50 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::12a ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713881608; cv=none; b=YoeFTqIutE4QjFWLPT6bxxdOYofmRwue7VAGnomJLmI7b/ChfGnnLu2RkHDDX7wSvWaNMAG3F7H9rwbHf/OReTSBjtGC0rTzBq922NN6yMjCK3Ocs7hm0KNythgLG1/2XQLnJr67fIzaT1VxVEfhAtiZjxI+a91C8qEtF+unWIE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713881608; c=relaxed/simple; bh=P6BhuLndtbH+Sb9rfEnMLvG2bUG6sl/TeqCWBWVsPac=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=LHwvpeimNkOa9fPtpEnDRwBYV1Oz2TYPd/UoWqKe1t+PM9Cs9S/WCP+Q/hfezTDsmORga5gRCyAv4bU2cV0eG4Hhuk8z/SPjXh2soeJTIkDL60iDCSoARG2ULOopQOvkd1qHObf+VDaa6MeYmc4y/PYMd+W0hvakL0Qj/pnPAcg= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-il1-x12a.google.com with SMTP id e9e14a558f8ab-36a0d09e6ffso25917845ab.0 for ; Tue, 23 Apr 2024 07:13:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713881606; x=1714486406; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=kmBnAFKoOhyonr5VMfSnwJGveSwO6D2+5Dly3iBRZ1c=; b=RU/eP1KWQraPg1qLCZ3qTjcoOCVKSftkA9MVwI3YbH8SuxMX2LSFNg4LUnt8J+f+WD 6Fb67ufiBYyN0B4nv4uxS8ffnAkKJqXXfmDXuw+i7qaxP4Ct8GX5YxKxipMiUqtYSmrE Ad/j0wbC73aCvbgFDe2lrJ80Cft/jRdxjbJELMmXvHuFgEMRQ/5YkTDM8ZJ0mxTLv9tY qxrvuud+HOmQjO1OR70DgdYLUHn5eyTHw7wUAmiQ7dpBS3+J7eju1/87SOj/6HyLrfPB feWxdWAhOuCkEWK9qUpNUXsMgXAZ9pU3gc2YY1sbJpQ9C67u7yjcTr8j4IyMM3xHCR16 IEkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713881606; x=1714486406; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=kmBnAFKoOhyonr5VMfSnwJGveSwO6D2+5Dly3iBRZ1c=; b=eSOt61L7qxZCXA0dqWd4ofeevLy5m12BADoeT2JZmjblxYR9ED4poB6ibVVHu1u1B7 lHWFpV9zHzc40UgGKwlASsHwfJj607zy5DlE28QpAadGvnnAa9jbTyh+qwONTprpXVtX DgCrRQ0+wSyhgr39azjjLnvkRcSL+i/HVY1EJAsOGaeCGtHKE58wAUEdz63DQaDSlZMA /eRVAiMqPLe6LMMBJRs+WuGf7TCVH35o1X3Q3tk7x268OonYsNf0Jb8vnpRfsCaZ5Wop dxnORfrp3xX4RwJzmCqgBCSf/jOr9eAdNf2VH11HkaAKHKWwVotjg7aXze4atnBVVy8D 1arQ== X-Gm-Message-State: AOJu0Yw0bh8jNDHaxljysTot4/QjTNYiIJsaYZwgIMksIw4OSu0UzJTg hH/+uz9CxYMLb8euyAWIyMqUceoHz+VYHN13sU/Wz1p7Ljx1AGfc7SOOmw== X-Google-Smtp-Source: AGHT+IGQfBTUmHs11+FaxLWTBeiycviIHeuEab31J3NF1I5TkYq1yzEB52iUAc70SNg1Ka8XY/t3iQ== X-Received: by 2002:a05:6e02:1c02:b0:36c:be3:9674 with SMTP id l2-20020a056e021c0200b0036c0be39674mr9739064ilh.31.1713881606281; Tue, 23 Apr 2024 07:13:26 -0700 (PDT) Received: from gnu-cfl-3.localdomain ([172.56.168.158]) by smtp.gmail.com with ESMTPSA id c3-20020a634e03000000b005cd835182c5sm9372716pgb.79.2024.04.23.07.13.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Apr 2024 07:13:25 -0700 (PDT) Received: from gnu-cfl-3.. (localhost [IPv6:::1]) by gnu-cfl-3.localdomain (Postfix) with ESMTP id 867E874035D; Tue, 23 Apr 2024 07:13:24 -0700 (PDT) From: "H.J. Lu" To: binutils@sourceware.org Cc: amodra@gmail.com Subject: [PATCH] objcopy.c: Fix bfd_copy_private_symbol_data on 32-bit hosts Date: Tue, 23 Apr 2024 07:13:24 -0700 Message-ID: <20240423141324.1156583-1-hjl.tools@gmail.com> X-Mailer: git-send-email 2.44.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3022.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Use long with bfd_copy_private_symbol_data to fix .../binutils/objcopy.c: In function ‘copy_object’: .../binutils/objcopy.c:3383:17: error: comparison of integer expressions of different signedness: ‘unsigned int’ and ‘long int’ [-Werror=sign-compare] 3383 | for (i = 0; i < symcount; i++) | ^ on 32-bit hosts. PR binutils/14493 * objcopy.c (copy_object): Use long with bfd_copy_private_symbol_data. --- binutils/objcopy.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/binutils/objcopy.c b/binutils/objcopy.c index 634ebae3fc3..e8ca1374935 100644 --- a/binutils/objcopy.c +++ b/binutils/objcopy.c @@ -3380,8 +3380,8 @@ copy_object (bfd *ibfd, bfd *obfd, const bfd_arch_info_type *input_arch) symcount = filter_symbols (ibfd, obfd, osympp, isympp, symcount); } - for (i = 0; i < symcount; i++) - if (!bfd_copy_private_symbol_data (ibfd, osympp[i], obfd, osympp[i])) + for (long s = 0; s < symcount; s++) + if (!bfd_copy_private_symbol_data (ibfd, osympp[s], obfd, osympp[s])) { status = 1; return false; -- 2.44.0