From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id F09583858CD1 for ; Fri, 26 Apr 2024 20:20:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F09583858CD1 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org F09583858CD1 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=205.220.165.32 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1714162836; cv=pass; b=OTLKzNgJKOHIo2xrtG+azAjreRGC/2wlDb7VbnnxzrhEVCy1B1oc6VpMalzPtH2pxMM7q4OZ342rQdliYFTNwqsPRrtaBayFOqAZ+CQlIP6niDmar4u2Al0vNaOI6e/Et0OoTmms8UVC0Xa+POfwnYNFJSkxRoLDKXDIQ00QQj0= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1714162836; c=relaxed/simple; bh=Q9WPCwvt7LtW/BQkz/wPP8vFMrj/sWOxk9jjh8W383I=; h=DKIM-Signature:DKIM-Signature:From:To:Subject:Date:Message-ID: MIME-Version; b=MW8jbM5nVyTAaEi6Fo/ucUNP2Xj53/XeF9KlWiOdGVJQKTkr5x1CRT/XW8uZQ/volvDVtktzGohKU/CLb5DeGkJBWvna1gyX86WHyy0ONGSKS9U7JoXkL+wp6bVkOHuGXBTVn2Ok5Dus/OOV2hiPs4B4r7Oh18eoh0htzcCTK2Q= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 43QKAIXp006915 for ; Fri, 26 Apr 2024 20:20:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : subject : date : message-id : content-transfer-encoding : content-type : mime-version; s=corp-2023-11-20; bh=YBPzVOVmI8gg/4JKqpmDnZdJ7ffgnjZcDYG7QLxa0UY=; b=GAE28LKm6YjP+/QViAxXUggeuhVnqRZXcTv5v+gHiOXf2BuZ8M8DVjYOJ5UVY+0NuLrW EKT0bJWc25baIBuhNvcVBwtKEJbWpXk9zdGtVv5QIqDWumgiuYStORvJWlq9sQuh8E34 LBY0gwseFJPq5IaBhNpboMxXSudOjel4DQN0AtkQhShLp7UpvoPDqLgjvicshE2CvrfO IEu2iytWwCTuVkWjlMEjO9xJ1seGQue+0VciYIbm2W4KYwjOJuqf9/wkserfllrEHx8c ZMX3auMyObK2BSiCRVBOZJ3Uj2RO/mGGEZ1uyOeHrlUTX21UM7oHD8WhPdt3lIi/PrQu /Q== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3xm4a2pv3j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 26 Apr 2024 20:20:33 +0000 Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 43QIN48t030835 for ; Fri, 26 Apr 2024 20:20:32 GMT Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2101.outbound.protection.outlook.com [104.47.70.101]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3xm45c3tc8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 26 Apr 2024 20:20:32 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZhUhstVvRmtNdU1xHs3Nu2cZll5PMJ1KA0FekORGwmKm8lG7o6giRitBNdsusV63zSOkJoFD1NtnlvTmfRTMZ9OXuGQeGuBi6AEAHhvnJxAm5Nw4o2aDG3EtNkhbIzrCZWY58UtqJIMws4lugqW0m/QH1yJA1VNGC7LM12iDlvj0tHbFL8bc94yGM5iIXXHwcuLfP7Y54fnstw3HBaSWwu/i2vgEpOHEUDhMuVXwHDHSvoNYreG4TtmBgsZ58VDcTTBc7OgwaBRchhln8FiWelq2wIiuffssil1PFGLWXmcoiM/u1jMpo4COCsUCU1aFfzGTJF1xpQlK90/XsedPYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YBPzVOVmI8gg/4JKqpmDnZdJ7ffgnjZcDYG7QLxa0UY=; b=COUGtb93Umr5punehKYmTcRjEUmCjewVlcje4a3E3rKOl9TWlr/n4UhVoL6JLK3NfT8q3l4mJv5uwtxVadhPZ7OMHSguZThXSdmgW2zupPtVfsjFtwANqAZXHrspPJ+QinXbevDP+W/NtrqOxnJRZYSg1eutih7WZCTEJ+nvcilumKLBnNt4ewdE+kIDpxA+fus8HWgl3Dsjqs4CySBFn8ZiY4k3tYGjGQ6ee3/r/BJ4gxMM6nYU0edGX5FmrsfHDe1JFSkVLqVEHgvLIP+ljy29notxf729Cgky+zbadFqf1ZhpmME1sc6s2HKtaEMUonWEdzRfHnQWBeq3qby7tA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YBPzVOVmI8gg/4JKqpmDnZdJ7ffgnjZcDYG7QLxa0UY=; b=PpPJCP2Rm/NAQ1GsKCrnd+7njIwJnfit923xeAWcBrGPLGcSvmgHt/Cvfq0Yz+SA47nzmHQYF36HuGj+VRPoyawQAEpn1GXDk3p21ApdDbF3PFrh1DdNTBXVQcITHT39nzqtJxvoMIeVfEZO+4BfDntj37Sg1xLexkCQWlbXrcY= Received: from MW4PR10MB6608.namprd10.prod.outlook.com (2603:10b6:303:22e::8) by SA1PR10MB7791.namprd10.prod.outlook.com (2603:10b6:806:3a9::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.31; Fri, 26 Apr 2024 20:20:30 +0000 Received: from MW4PR10MB6608.namprd10.prod.outlook.com ([fe80::67a4:9544:7249:7751]) by MW4PR10MB6608.namprd10.prod.outlook.com ([fe80::67a4:9544:7249:7751%7]) with mapi id 15.20.7472.044; Fri, 26 Apr 2024 20:20:30 +0000 From: Nick Alcock To: binutils@sourceware.org Subject: [PATCH 0/7] libctf: leak-adjacent fixes Date: Fri, 26 Apr 2024 21:20:16 +0100 Message-ID: <20240426202023.423064-1-nick.alcock@oracle.com> X-Mailer: git-send-email 2.44.0.273.ge0bd14271f Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: LO4P123CA0502.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1ab::21) To MW4PR10MB6608.namprd10.prod.outlook.com (2603:10b6:303:22e::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MW4PR10MB6608:EE_|SA1PR10MB7791:EE_ X-MS-Office365-Filtering-Correlation-Id: 58475cef-1a09-4e2c-2660-08dc662e5170 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|366007|376005|1800799015; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?iPHtvOB7hu1b1Blo09Uh4D2owxU9a+pWBIYsIpwy1GBVgAhcigIbLxxUG939?= =?us-ascii?Q?3jouKTbroQ/IBVdg5nKIIf4ppxEQ8B2D4fRhO+p6N2j2aw+VW/PIYqPgXi7x?= =?us-ascii?Q?S+nYRV2/c9nZCqw3894WqrNk2nAk2kBPn0+e6IkqQ/SweZxlq0G5mIdEcvAR?= =?us-ascii?Q?qr1/bbVsK9kZsmLsJsGhJ0MZ2zkqwspMQ6IDyZCr/W0uA1CnxjL8e/YkGQjm?= =?us-ascii?Q?XVmadyMZOOF7evoGeENGojQGmHzOMeaVfoWUXuPsgaUnUa64Jjv9bzNNnqZf?= =?us-ascii?Q?atw3B9v4iahkNAKnLiuvTkq+uadI7ZnrPI9AhCoLHHfTuzBCZWegPsf/huiT?= =?us-ascii?Q?Wnn/cQoRAAYHxmlUW70mFzWjE9heMpvGMqZM868ukkPOmIWTFKP4nDs/gvi+?= =?us-ascii?Q?ZxOMOqAYKYRc7gVahCniQEJaG8SNBBrx9OiUsvCsOsTXqWMQ1uFFqAnVjbq+?= =?us-ascii?Q?qYaoOJ5u4bO0KwYfFRlgCBiNcCGDPD5E8ZoNMlG0xBMFbCfPSGPRHpXrG/39?= =?us-ascii?Q?yuQTy793zo13rv/x3ftyPMoc2nGARtcil/sPjb5f1cPfBw6ALBQ51INu/6sz?= =?us-ascii?Q?TuJSdzOadlU7XcvNzADsFqE/mlekAIcl4DhPtWjljZlPX03rLuU2UHlSXAtV?= =?us-ascii?Q?opGtIadFv+pC2ifvpT4Uvs1WffoPY7adYQlaD7Lkh7lM7NCDlBee4iecYB6V?= =?us-ascii?Q?DZK835J23Ilz4Pi+Qe5SC74puGZtxq6k0k9yj+7R1XS+OWBn13SdvQpGIXpi?= =?us-ascii?Q?xfRgGXk5QCgu34RfdXqEae8S1eN6TpW0ZwYqwmPUAWflY6KalYCHnY99SN8c?= =?us-ascii?Q?cZyO2ygqwJDZg8GVEDX0og/utFWoOgFn4aJtX787yqUtcSLdL9U3zSyelxVO?= =?us-ascii?Q?ncJX7rnmlWKP/ZCDOiP+B07eypc097cVJ3JseRvtuvUfR6NBYx3GFgyp4Rxw?= =?us-ascii?Q?gX5ArjrNwecwg1ytQ4w/PXE4qgH62hUDFQROTr8MWKMF/NN0Wl1Wr5cvS7k6?= =?us-ascii?Q?7h9x6IS9o1Lxhwxe6IzpCfKxGVDpPKG+uR2W6xn0SAvFwkFnfMHBXWkGmRKk?= =?us-ascii?Q?ljPlHNPIuyXjq0cy165iPA0U6cN0MGia5grJYC2WwAjnnmsGdZYvEz+58zem?= =?us-ascii?Q?4D8wP7KLFTLoxwEETKYvO0xlFx8uJeBGROLDqiPMH2FQiscvmFGBHB93KrN/?= =?us-ascii?Q?Ec/FOqE3B1s9SGKnCQEbMNymuA21OEGZjfKJ9BEpseZjHMxdjWj+2TinU+0/?= =?us-ascii?Q?lFRSW40gsCAwdoz49TQx+M1jM9V2G2VgJaQFCoqvxg=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR10MB6608.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366007)(376005)(1800799015);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?caxhDgTvNLNfHrsxblSmzEgn8tkt4x6/E7KHDC5mSX4VVpVwdMsC+eyCsiTn?= =?us-ascii?Q?+SV4zT3PjH8yrPDHJQGqIa7RkzthHRp9UmoIXyMIV96d3hcMZ9IaPL1aMq0a?= =?us-ascii?Q?//8ng6J/LH2A0f0GICmVNkEOLmEGWIM5t+hPhkmVevubBSnvSe/VDINcLTGr?= =?us-ascii?Q?LG6kZeYT9xzA6b2X42q/d1/EmYqEmpwLtVFX7jh156pe0bVqZfXCtGgYkRBu?= =?us-ascii?Q?OY6HcOaYe+tlnn997hljjngUnA+rSpgrD8BlJiRyZ90ErbBl59NknOyQT7AW?= =?us-ascii?Q?hpaEhJZkzqoYDcg6i7TBiZBUBwumc0QRyEViD8iMP0OU5S1t8ZxQB01Mnzc9?= =?us-ascii?Q?tNIUcQ8OaRf9ZJRaZaYJFLENbRyq3KlHKq2N7gT4Y2uhw/zItdxRmNWjCAsz?= =?us-ascii?Q?fzWPWyx2xyXEYJD1jZ9Cm6sazCvRNnVXD2cLfMllJppuscKN2PqqRGE6nVb9?= =?us-ascii?Q?moQP19s+LNXgsOaysVBJlDbdZ9aBLxQFaf7wBANtSSsUk+XS96PLLzPx8p52?= =?us-ascii?Q?ggI0U4ToBri9XbPaOqxqUoLW0Ov+cP04ePeRpu6mCNvx3AJooSFXSDwcMTd/?= =?us-ascii?Q?Hkv0wI4o0G1IWD9lsqM2dgHKsY0vFrndtq5L2O8+RACqwwKlXFaqx58mH/le?= =?us-ascii?Q?2NOhfxD2ZmHkIIoxAcwns6ZI1Kj9+FPuMI1DmCnL2LcHUs4zYnfz4yrkEbwh?= =?us-ascii?Q?Uy+iRgOxLL393X0KT7RcTzf0YQ9ixVlIaKc0DKPt3mLxavGPMXBqoOwxoKPg?= =?us-ascii?Q?3onyKO36QZxppILA+aMQ0cMDGdxQnWrkDsrrIp0XGy8f8dsvkSO3LwLQT4p1?= =?us-ascii?Q?tn3wNJMBZKBGRp1xEYxPfyQin5aE1WCAV+HRZ8tvLFLYCsLZxRJ2ULim7+UG?= =?us-ascii?Q?0NS+IMsx4rnAEkL9cloktPr7/UahmNGg+/iW/B2I4i98AjJH/A9UjgO4aE/V?= =?us-ascii?Q?f8HK9m7nQcc6oKk/7PJ1k7+ZcfG84t7dNqSjVRQYen+TxeUiQNItwO26asQF?= =?us-ascii?Q?b11WgJvw02pcvtNORnLZgfd1w32vNplTAX+Jm7sU/vdON8YHQ/Jr5fMa71BO?= =?us-ascii?Q?m63Meb0NffqWnRASfa8z8nCMOUbDeh5gmCeazfxQV5puMiANRMePiV9wFPwE?= =?us-ascii?Q?ULIRo0UPqQcABOUOivM1eDgHZBldsdsl1WoLZ5iGyX9PDv63GM+aSgWV/VPG?= =?us-ascii?Q?6E0FbAyeddXgJFKh3lJDLcTAZY03RXDzuoiqoip8ypJciqfVNKeusSW0fYaK?= =?us-ascii?Q?oHO7xvxDKLZXPOx69KlRYwTvKmvany9ZNCcGO+YgD1eOiaxIHm+XPTEuMzDt?= =?us-ascii?Q?xFyyftEeMqdxWXgROf3AhMaOifgBgTN+S5wZPbKZn+R8p1ixt0bZ7tjnyHMq?= =?us-ascii?Q?VqJhDvSZB1IarCEjxooJRHB8DuoD6uxLMjs+0Po7xCUjTdajyfKjy2GY2ZtO?= =?us-ascii?Q?oUf01hBaML1YZkcupR1sSg/qX1WWtgufzzDylS5asdLoHmcZIx99m388o5lM?= =?us-ascii?Q?8fiuBXkKsbutIjIcDRkk9pgSJ9ZTBmnYNeQe0JYriqCqUlFGdzC1juhBsuzM?= =?us-ascii?Q?+3zqUa7AIKHwUXhprUidOC0vAU6+qistw6WuPsDlWZQ4KPDS5S32QYaRtL3M?= =?us-ascii?Q?dw=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: fUtSGIZEWZRNe+5dZL8J1XDBBMwYeJwSwCXwyVBnsvhMbUwowpRkxUFcZsIXaxE9LJFqsEnm7mu9unTfrSswPga6B5cR1DT+yKe/FDiv45ZIbRNbAc5F/vaFkrpghXBgLivsx3u8v4HVtpPjyRMI0F8XdtxvMtu2lF0hh67jVU4rcP9rIBLBaQcRYdUj+JwNzX7qMlpj/DzMJI32ihvKX+E9LbpF1s5xujrO2qbYvJourv4LO1vSWHhSWGtWfXoaT0FTp2atECzNuGt/BMCnWlpI8WIe53eqiQ04EtwW2jo5/QgQtMAVgo/RjnaT8F7R6+AGLXJLAHw2ArBbPUBT+R7nYimyYpbGI3xaLx/4e2jrc2G5IFwMDxjibWPH5QtBWaPzPpJmCxKBSi0Rk/e5EMIYmMD67+z9UpE6qg/jkVn0Qv8pm9MOPeWO4ONfPGcbpwUvE2ymX3KOC0iY8vgQmFRhdhyNo4gQypWbkEqzTYy8UiUaby+/mpMq51lZp6u88j5LuXw32aJ4uruaTMzM1dRCkZHif+4GPPWVMR1Z7Zf5+kU+NNnNwqihzk179Mcj4MJ8dFKQOBaA0vgwsI9/2si4E04Q+MVHPW/w8lL5P0E= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 58475cef-1a09-4e2c-2660-08dc662e5170 X-MS-Exchange-CrossTenant-AuthSource: MW4PR10MB6608.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2024 20:20:30.1640 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NSH7B+9YtUW4wGInaxQgrNwu6d9Oslq+/Kr/Z/fbdGJRzH/oBOBuDAZ5PV0ENXa3OWcEuilKKI1z0F0afjGUnw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR10MB7791 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1011,Hydra:6.0.650,FMLib:17.11.176.26 definitions=2024-04-26_17,2024-04-26_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 suspectscore=0 mlxscore=0 mlxlogscore=923 bulkscore=0 malwarescore=0 spamscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2404010000 definitions=main-2404260141 X-Proofpoint-GUID: pZQleAInJL5lt7lb0lPyyAOGURWvz5ky X-Proofpoint-ORIG-GUID: pZQleAInJL5lt7lb0lPyyAOGURWvz5ky X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This series fixes a bad memory leak on a libctf error path, fixes a couple of smaller problems on the way, and soups up the testsuite a bit to make it easier to write the rather nasty test that should prevent this leak from recurring. I likely won't be committing it for a couple of weeks, and probably not until I've added more to the series, but this is posted now anyway in case anyone wants to take a look and e.g. perhaps tell me that my malloc interposition skills are simply dreadful :) Nick Alcock (7): libctf: typos libctf: failure to open parent dicts that exist should be an error libctf: ctf_archive_iter: fix tiny leak libctf: test: add lookup_link libctf: test: add host libctf: test: add wrapper libctf: fix leak of entire dict when dict opening fails libctf/ctf-archive.c | 29 ++- libctf/ctf-open.c | 8 +- libctf/testsuite/lib/ctf-lib.exp | 28 ++- .../libctf-regression/open-error-free.c | 185 ++++++++++++++++++ .../libctf-regression/open-error-free.lk | 5 + 5 files changed, 244 insertions(+), 11 deletions(-) create mode 100644 libctf/testsuite/libctf-regression/open-error-free.c create mode 100644 libctf/testsuite/libctf-regression/open-error-free.lk -- 2.44.0.273.ge0bd14271f