From: Hans-Peter Nilsson <hp@axis.com>
To: Nick Clifton <nickc@redhat.com>
Cc: <binutils@sourceware.org>
Subject: Re: RFC: Maintaining a per-macro invocation count
Date: Tue, 14 May 2024 03:12:04 +0200 [thread overview]
Message-ID: <20240514011204.7F65920408@pchp3.se.axis.com> (raw)
In-Reply-To: <87pltw9qku.fsf@redhat.com> (message from Nick Clifton on Wed, 08 May 2024 18:11:13 +0100)
> From: Nick Clifton <nickc@redhat.com>
> Date: Wed, 08 May 2024 18:11:13 +0100
Hi! Sorry for bringing bad news:
> Comments, suggestions ?
Sounds great except it appears you forgot to run this past
all targets. The new gas test doesn't work if the target
has '@' in line_separator_chars[] or tc_symbol_chars[], like
for cris-elf and mmix respectively:
Running /x/src/gas/testsuite/gas/macros/macros.exp ...
FAIL: macros count
A glance at gas.log for these targets shows that gas gets
confused and loses track, in different ways. Probably
fixable rather than requiring target-skipping for the test,
since the @ is "\-escaped", but I think I'd better leave
that to you.
brgds, H-P
next prev parent reply other threads:[~2024-05-14 1:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-08 17:11 Nick Clifton
2024-05-14 1:12 ` Hans-Peter Nilsson [this message]
2024-05-15 9:42 ` Nick Clifton
2024-05-15 5:59 ` Fangrui Song
2024-05-15 9:45 ` Nick Clifton
2024-05-17 17:54 ` Fangrui Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240514011204.7F65920408@pchp3.se.axis.com \
--to=hp@axis.com \
--cc=binutils@sourceware.org \
--cc=nickc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).