* [PATCH] ld: pru: Increase the default memory region sizes
@ 2024-05-21 17:07 Dimitar Dimitrov
2024-05-28 15:21 ` Nick Clifton
0 siblings, 1 reply; 2+ messages in thread
From: Dimitar Dimitrov @ 2024-05-21 17:07 UTC (permalink / raw)
To: binutils; +Cc: Dimitar Dimitrov
The default memory region sizes for PRU were set somewhat arbitrarily to
the sizes of the most popular BeagleBone board with AM33x SoC. But the
PRU toolchain documentation has always instructed to use SoC-specific
spec files to override the defaults and set the correct memory sizes [1].
The small default memory sizes can cause IMEM memory region overflow
even for simple printf("Hello world") programs, as usually done by
Autotools checks. The stdio is simply too big to fit in 8K
instruction memory. This can confuse the check and lead to wrong
feature selection during configure [2].
Fix by bumping the default DMEM and IMEM memory sizes.
There is no need to backport this patch. Issue was caught with a
feature-rich newlib build used for daily CI. The release builds of the
PRU toolchain use stripped newlib configuration, which does not overflow
the IMEM region, even for 8K.
Ok for master?
[1] https://github.com/dinuxbg/gnuprumcu
[2] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115158
Signed-off-by: Dimitar Dimitrov <dimitar@dinux.eu>
---
ld/emulparams/pruelf.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ld/emulparams/pruelf.sh b/ld/emulparams/pruelf.sh
index 48e9a3a3bea..7ed5d33bcb6 100644
--- a/ld/emulparams/pruelf.sh
+++ b/ld/emulparams/pruelf.sh
@@ -11,9 +11,9 @@ COMMONPAGESIZE="CONSTANT (COMMONPAGESIZE)"
EMBEDDED=yes
TEXT_ORIGIN=0x20000000
-TEXT_LENGTH=8K
+TEXT_LENGTH=256K
DATA_ORIGIN=0x0
-DATA_LENGTH=8K
+DATA_LENGTH=256K
ENTRY=_start
EXTRA_EM_FILE=pruelf
--
2.45.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ld: pru: Increase the default memory region sizes
2024-05-21 17:07 [PATCH] ld: pru: Increase the default memory region sizes Dimitar Dimitrov
@ 2024-05-28 15:21 ` Nick Clifton
0 siblings, 0 replies; 2+ messages in thread
From: Nick Clifton @ 2024-05-28 15:21 UTC (permalink / raw)
To: Dimitar Dimitrov, binutils
Hi Dimitar,
> Fix by bumping the default DMEM and IMEM memory sizes.
> Ok for master?
Approved - please apply.
Cheers
Nick
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-05-28 15:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-05-21 17:07 [PATCH] ld: pru: Increase the default memory region sizes Dimitar Dimitrov
2024-05-28 15:21 ` Nick Clifton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).