public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
* [PATCH v0 00/10] Fix obsolescence warnings when regenerating build scripts with autoreconf-2.72
@ 2024-05-28  9:49 Matthieu Longo
  2024-05-28  9:49 ` [PATCH v0 01/10] autoupdate: replace obsolete macros AC_HELP_STRING Matthieu Longo
                   ` (10 more replies)
  0 siblings, 11 replies; 13+ messages in thread
From: Matthieu Longo @ 2024-05-28  9:49 UTC (permalink / raw)
  To: binutils; +Cc: Richard Earnshaw, Nick Clifton, Matthieu Longo

This patch series replaces obsolete macros that are warned on by autoreconf-2.72.
It aims at removing noise from a future upgrade to autoreconf-2.72 or later.
This is in no way a complete patch set allowing the upgrade to autoreconf-2.72.

Please find here below the list of changes along the doc links.
- AC_HELP_STRING by AS_HELP_STRING
  https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.72/autoconf.html#index-AC_005fHELP_005fSTRING-1
- AC_AIX, AC_MINIX, and AC_GNU_SOURCE by AC_USE_SYSTEM_EXTENSIONS
  https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.72/autoconf.html#index-AC_005fAIX
  https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.72/autoconf.html#index-AC_005fMINIX-1
  https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.72/autoconf.html#index-AC_005fGNU_005fSOURCE-1
- AC_PROG_LIBTOOL by LT_INIT
  https://www.gnu.org/software/libtool/manual/html_node/LT_005fINIT.html#index-LT_005fINIT
- AC_CANONICAL_SYSTEM by AC_CANONICAL_TARGET
  https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.72/autoconf.html#index-AC_005fCANONICAL_005fTARGET-1
- AC_CONFIG_HEADER by AC_CONFIG_HEADERS
  https://www.gnu.org/software/automake/manual/1.12.2/html_node/Obsolete-Macros.html#index-AM_005fCONFIG_005fHEADER
- old AC_INIT by AC_INIT + AC_CONFIG_SRC_DIR
  https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.72/autoconf.html#index-AC_005fINIT-3
- add square brackets around argument of AC_PREREQ
  https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.72/autoconf.html#index-AC_005fPREREQ-1
- add square brackets around arguments of AC_INIT
  https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.72/autoconf.html#index-AC_005fINIT-2
- delete obsolete unused m4 file config/uintmax_t.m4

I splitted the diff of the generated files in the last commit of the patch series so that it is easier to review.

I regenerated the build files using the contrib/autoregen.py script mentioned in https://sourceware.org/pipermail/binutils/2024-April/133731.html with the following configuration:
+ autoconf --version
autoconf (GNU Autoconf) 2.69
+ automake --version
automake (GNU automake) 1.15.1
+ aclocal --version
aclocal (GNU automake) 1.15.1
+ autoheader --version
autoheader (GNU Autoconf) 2.69


Ok for binutils-master? I don't have commit access so I need someone to commit on my behalf.

Regards,
Matthieu


Matthieu Longo (10):
  autoupdate: replace obsolete macros AC_HELP_STRING
  autoupdate: replace obsolete macros AC_AIX, AC_MINIX, and AC_GNU_SOURCE
  autoupdate: replace obsolete macros AC_PROG_LIBTOOL
  autoupdate: replace obsolete macros AC_CANONICAL_SYSTEM
  autoupdate: replace obsolete macros AC_CONFIG_HEADER
  autoupdate: replace old version of AC_INIT by the new one
  autoupdate: add square brackets around argument of AC_PREREQ
  autoupdate: add square brackets around arguments of AC_INIT
  autoconf: delete obsolete unused m4 file
  autoupdate: diff after replacing obsolete macros with previous patches

 bfd/configure                     |  6 ++----
 bfd/configure.ac                  |  3 +--
 binutils/configure                |  6 ++----
 binutils/configure.ac             |  5 ++---
 config/acx.m4                     |  4 ++--
 config/debuginfod.m4              |  2 +-
 config/enable.m4                  |  2 +-
 config/lib-prefix.m4              |  2 +-
 config/lthostflags.m4             |  2 +-
 config/uintmax_t.m4               | 32 -------------------------------
 configure                         |  2 +-
 configure.ac                      |  7 ++++---
 gas/configure                     |  6 ++----
 gas/configure.ac                  |  3 +--
 gdbsupport/configure.ac           |  4 ++--
 gnulib/configure.ac               |  4 ++--
 gold/configure                    |  2 --
 gold/configure.ac                 |  4 +---
 gprof/configure                   |  6 ++----
 gprof/configure.ac                |  3 +--
 gprofng/configure.ac              |  2 +-
 gprofng/libcollector/configure.ac |  2 +-
 ld/configure                      |  6 ++----
 ld/configure.ac                   |  5 ++---
 libbacktrace/configure            |  5 ++---
 libbacktrace/configure.ac         |  7 ++++---
 libctf/configure.ac               |  4 ++--
 libiberty/configure               |  1 -
 libiberty/configure.ac            |  4 ++--
 libsframe/configure.ac            |  2 +-
 opcodes/configure                 |  6 ++----
 opcodes/configure.ac              |  3 +--
 readline/readline/configure.ac    | 19 +++++++++---------
 sim/configure.ac                  |  2 +-
 zlib/configure                    |  5 ++---
 zlib/configure.ac                 |  4 ++--
 36 files changed, 63 insertions(+), 119 deletions(-)
 delete mode 100644 config/uintmax_t.m4

-- 
2.45.0


^ permalink raw reply	[flat|nested] 13+ messages in thread

* [PATCH v0 01/10] autoupdate: replace obsolete macros AC_HELP_STRING
  2024-05-28  9:49 [PATCH v0 00/10] Fix obsolescence warnings when regenerating build scripts with autoreconf-2.72 Matthieu Longo
@ 2024-05-28  9:49 ` Matthieu Longo
  2024-05-28  9:49 ` [PATCH v0 02/10] autoupdate: replace obsolete macros AC_AIX, AC_MINIX, and AC_GNU_SOURCE Matthieu Longo
                   ` (9 subsequent siblings)
  10 siblings, 0 replies; 13+ messages in thread
From: Matthieu Longo @ 2024-05-28  9:49 UTC (permalink / raw)
  To: binutils; +Cc: Richard Earnshaw, Nick Clifton, Matthieu Longo

[-- Attachment #1: Type: text/plain, Size: 503 bytes --]


- AC_HELP_STRING by AS_HELP_STRING
  https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.72/autoconf.html#index-AC_005fHELP_005fSTRING-1
---
 binutils/configure.ac          |  2 +-
 config/debuginfod.m4           |  2 +-
 config/enable.m4               |  2 +-
 config/lib-prefix.m4           |  2 +-
 ld/configure.ac                |  2 +-
 readline/readline/configure.ac | 12 ++++++------
 sim/configure.ac               |  2 +-
 7 files changed, 12 insertions(+), 12 deletions(-)


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: v0-0001-autoupdate-replace-obsolete-macros-AC_HELP_STRING.patch --]
[-- Type: text/x-patch; name="v0-0001-autoupdate-replace-obsolete-macros-AC_HELP_STRING.patch", Size: 5384 bytes --]

diff --git a/binutils/configure.ac b/binutils/configure.ac
index ac3e418392f..19c5d7d7c34 100644
--- a/binutils/configure.ac
+++ b/binutils/configure.ac
@@ -292,7 +292,7 @@ BFD_BINARY_FOPEN
 
 # Support for the msgpack C library.
 AC_ARG_WITH([msgpack],
-	    AC_HELP_STRING([--with-msgpack], [Enable msgpack support (auto/yes/no)]),
+	    AS_HELP_STRING([--with-msgpack], [Enable msgpack support (auto/yes/no)]),
 	    [],
 	    [with_msgpack=auto])
 
diff --git a/config/debuginfod.m4 b/config/debuginfod.m4
index c5077acb4c3..a32cf2c845f 100644
--- a/config/debuginfod.m4
+++ b/config/debuginfod.m4
@@ -15,7 +15,7 @@ AC_DEFUN([AC_DEBUGINFOD],
 # Define HAVE_LIBDEBUGINFOD_FIND_SECTION if libdebuginfod is found with
 # version >= 0.188.
 AC_ARG_WITH([debuginfod],
-  AC_HELP_STRING([--with-debuginfod], [Enable debuginfo lookups with debuginfod (auto/yes/no)]),
+  AS_HELP_STRING([--with-debuginfod], [Enable debuginfo lookups with debuginfod (auto/yes/no)]),
   [], [with_debuginfod=auto])
 AC_MSG_CHECKING([whether to use debuginfod])
 AC_MSG_RESULT([$with_debuginfod])
diff --git a/config/enable.m4 b/config/enable.m4
index 88b29b8aa7f..119c3701095 100644
--- a/config/enable.m4
+++ b/config/enable.m4
@@ -11,7 +11,7 @@ dnl See docs/html/17_intro/configury.html#enable for documentation.
 dnl
 AC_DEFUN([GCC_ENABLE],[dnl
 m4_define([_g_switch],[--enable-$1])dnl
-m4_define([_g_help],[AC_HELP_STRING(_g_switch$3,[$4 @<:@default=$2@:>@])])dnl
+m4_define([_g_help],[AS_HELP_STRING([_g_switch$3],[$4 @<:@default=$2@:>@])])dnl
  AC_ARG_ENABLE($1,_g_help,
   m4_bmatch([$5],
    [^permit ],
diff --git a/config/lib-prefix.m4 b/config/lib-prefix.m4
index c719bc80900..e4d3bfbe400 100644
--- a/config/lib-prefix.m4
+++ b/config/lib-prefix.m4
@@ -11,7 +11,7 @@ dnl From Bruno Haible.
 dnl AC_LIB_ARG_WITH is synonymous to AC_ARG_WITH in autoconf-2.13, and
 dnl similar to AC_ARG_WITH in autoconf 2.52...2.57 except that is doesn't
 dnl require excessive bracketing.
-ifdef([AC_HELP_STRING],
+ifdef([AS_HELP_STRING],
 [AC_DEFUN([AC_LIB_ARG_WITH], [AC_ARG_WITH([$1],[[$2]],[$3],[$4])])],
 [AC_DEFUN([AC_LIB_ARG_WITH], [AC_ARG_WITH([$1],[$2],[$3],[$4])])])
 
diff --git a/ld/configure.ac b/ld/configure.ac
index 0d4aa4c2373..84f4044d5fc 100644
--- a/ld/configure.ac
+++ b/ld/configure.ac
@@ -197,7 +197,7 @@ esac])dnl
 # Decide if DT_TEXTREL check should be enabled in ELF linker.
 ac_default_ld_textrel_check=unset
 AC_ARG_ENABLE([textrel-check],
-	      AC_HELP_STRING([--enable-textrel-check=@<:@yes|no|warning|error@:>@],
+	      AS_HELP_STRING([--enable-textrel-check=@<:@yes|no|warning|error@:>@],
 			     [enable DT_TEXTREL check in ELF linker]),
 [case "${enableval}" in
   yes|no|warning|error) ac_default_ld_textrel_check=${enableval} ;;
diff --git a/readline/readline/configure.ac b/readline/readline/configure.ac
index 912c99b6575..c800f1c8667 100644
--- a/readline/readline/configure.ac
+++ b/readline/readline/configure.ac
@@ -45,7 +45,7 @@ dnl configure defaults
 opt_curses=no
 
 dnl arguments to configure
-AC_ARG_WITH(curses, AC_HELP_STRING([--with-curses], [use the curses library instead of the termcap library]), opt_curses=$withval)
+AC_ARG_WITH(curses, AS_HELP_STRING([--with-curses], [use the curses library instead of the termcap library]), opt_curses=$withval)
 
 if test "$opt_curses" = "yes"; then
 	prefer_curses=yes
@@ -58,12 +58,12 @@ opt_shared_libs=no
 opt_install_examples=no
 opt_bracketed_paste_default=yes
 
-AC_ARG_ENABLE(multibyte, AC_HELP_STRING([--enable-multibyte], [enable multibyte characters if OS supports them]), opt_multibyte=$enableval)
-dnl AC_ARG_ENABLE(shared, AC_HELP_STRING([--enable-shared], [build shared libraries [[default=YES]]]), opt_shared_libs=$enableval)
-AC_ARG_ENABLE(static, AC_HELP_STRING([--enable-static], [build static libraries [[default=YES]]]), opt_static_libs=$enableval)
-AC_ARG_ENABLE(install-examples, AC_HELP_STRING([--disable-install-examples], [don't install examples [[default=install]]]), opt_install_examples=$enableval)
+AC_ARG_ENABLE(multibyte, AS_HELP_STRING([--enable-multibyte], [enable multibyte characters if OS supports them]), opt_multibyte=$enableval)
+dnl AC_ARG_ENABLE(shared, AS_HELP_STRING([--enable-shared], [build shared libraries [[default=YES]]]), opt_shared_libs=$enableval)
+AC_ARG_ENABLE(static, AS_HELP_STRING([--enable-static], [build static libraries [[default=YES]]]), opt_static_libs=$enableval)
+AC_ARG_ENABLE(install-examples, AS_HELP_STRING([--disable-install-examples], [don't install examples [[default=install]]]), opt_install_examples=$enableval)
 
-AC_ARG_ENABLE(bracketed-paste-default, AC_HELP_STRING([--disable-bracketed-paste-default], [disable bracketed paste by default [[default=enable]]]), opt_bracketed_paste_default=$enableval)
+AC_ARG_ENABLE(bracketed-paste-default, AS_HELP_STRING([--disable-bracketed-paste-default], [disable bracketed paste by default [[default=enable]]]), opt_bracketed_paste_default=$enableval)
 
 if test $opt_multibyte = no; then
 AC_DEFINE(NO_MULTIBYTE_SUPPORT)
diff --git a/sim/configure.ac b/sim/configure.ac
index 125eaa5ea31..fad5b71ee59 100644
--- a/sim/configure.ac
+++ b/sim/configure.ac
@@ -37,7 +37,7 @@ yes | no) ;;
 esac])
 
 AC_ARG_ENABLE([example-sims],
-	      [AC_HELP_STRING([--enable-example-sims],
+	      [AS_HELP_STRING([--enable-example-sims],
 			      [enable example GNU simulators])])
 
 AC_ARG_ENABLE(targets,

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [PATCH v0 02/10] autoupdate: replace obsolete macros AC_AIX, AC_MINIX, and AC_GNU_SOURCE
  2024-05-28  9:49 [PATCH v0 00/10] Fix obsolescence warnings when regenerating build scripts with autoreconf-2.72 Matthieu Longo
  2024-05-28  9:49 ` [PATCH v0 01/10] autoupdate: replace obsolete macros AC_HELP_STRING Matthieu Longo
@ 2024-05-28  9:49 ` Matthieu Longo
  2024-05-28  9:49 ` [PATCH v0 03/10] autoupdate: replace obsolete macros AC_PROG_LIBTOOL Matthieu Longo
                   ` (8 subsequent siblings)
  10 siblings, 0 replies; 13+ messages in thread
From: Matthieu Longo @ 2024-05-28  9:49 UTC (permalink / raw)
  To: binutils; +Cc: Richard Earnshaw, Nick Clifton, Matthieu Longo

[-- Attachment #1: Type: text/plain, Size: 804 bytes --]


- AC_AIX, AC_MINIX, and AC_GNU_SOURCE by AC_USE_SYSTEM_EXTENSIONS
  https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.72/autoconf.html#index-AC_005fAIX
  https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.72/autoconf.html#index-AC_005fMINIX-1
  https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.72/autoconf.html#index-AC_005fGNU_005fSOURCE-1
---
 bfd/configure.ac               | 1 -
 binutils/configure.ac          | 1 -
 gas/configure.ac               | 1 -
 gold/configure.ac              | 2 --
 gprof/configure.ac             | 1 -
 ld/configure.ac                | 1 -
 libiberty/configure.ac         | 2 +-
 opcodes/configure.ac           | 1 -
 readline/readline/configure.ac | 3 +--
 9 files changed, 2 insertions(+), 11 deletions(-)


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: v0-0002-autoupdate-replace-obsolete-macros-AC_AIX-AC_MINI.patch --]
[-- Type: text/x-patch; name="v0-0002-autoupdate-replace-obsolete-macros-AC_AIX-AC_MINI.patch", Size: 2845 bytes --]

diff --git a/bfd/configure.ac b/bfd/configure.ac
index 29ede92b993..3b65d8fed4a 100644
--- a/bfd/configure.ac
+++ b/bfd/configure.ac
@@ -36,7 +36,6 @@ dnl configure option --enable-shared.
 AC_DISABLE_SHARED
 
 AC_PROG_CC
-AC_GNU_SOURCE
 AC_USE_SYSTEM_EXTENSIONS
 
 LT_INIT([dlopen])
diff --git a/binutils/configure.ac b/binutils/configure.ac
index 19c5d7d7c34..0373a426495 100644
--- a/binutils/configure.ac
+++ b/binutils/configure.ac
@@ -28,7 +28,6 @@ AM_INIT_AUTOMAKE
 AM_SILENT_RULES([yes])
 
 AC_PROG_CC
-AC_GNU_SOURCE
 AC_USE_SYSTEM_EXTENSIONS
 
 AC_C_BIGENDIAN
diff --git a/gas/configure.ac b/gas/configure.ac
index 7403ec71cd0..503635072cf 100644
--- a/gas/configure.ac
+++ b/gas/configure.ac
@@ -34,7 +34,6 @@ AM_INIT_AUTOMAKE
 AM_SILENT_RULES([yes])
 
 AC_PROG_CC
-AC_GNU_SOURCE
 AC_USE_SYSTEM_EXTENSIONS
 
 LT_INIT
diff --git a/gold/configure.ac b/gold/configure.ac
index 2c7a969b97f..0e622c7405a 100644
--- a/gold/configure.ac
+++ b/gold/configure.ac
@@ -313,8 +313,6 @@ AC_PROG_RANLIB
 AC_PROG_INSTALL
 AC_PROG_LN_S
 
-AC_GNU_SOURCE
-
 ZW_GNU_GETTEXT_SISTER_DIR
 AM_PO_SUBDIRS
 
diff --git a/gprof/configure.ac b/gprof/configure.ac
index 3202303e9fc..b2635680c15 100644
--- a/gprof/configure.ac
+++ b/gprof/configure.ac
@@ -32,7 +32,6 @@ dnl config.h, to avoid any possible confusion with the bfd config.h.
 AC_CONFIG_HEADERS([gconfig.h:gconfig.in])
 
 AC_PROG_CC
-AC_GNU_SOURCE
 AC_USE_SYSTEM_EXTENSIONS
 AC_PROG_INSTALL
 
diff --git a/ld/configure.ac b/ld/configure.ac
index 84f4044d5fc..cce094380de 100644
--- a/ld/configure.ac
+++ b/ld/configure.ac
@@ -31,7 +31,6 @@ AM_MAINTAINER_MODE
 AC_PROG_CC
 AC_PROG_CXX
 AC_PROG_GREP
-AC_GNU_SOURCE
 AC_USE_SYSTEM_EXTENSIONS
 AC_PROG_INSTALL
 PKG_PROG_PKG_CONFIG
diff --git a/libiberty/configure.ac b/libiberty/configure.ac
index 0888e638896..4f76b62fcfd 100644
--- a/libiberty/configure.ac
+++ b/libiberty/configure.ac
@@ -172,7 +172,7 @@ AC_MSG_NOTICE([target_header_dir = $target_header_dir])
 
 GCC_NO_EXECUTABLES
 AC_PROG_CC
-AC_GNU_SOURCE
+AC_USE_SYSTEM_EXTENSIONS
 AC_SYS_LARGEFILE
 AC_PROG_CPP_WERROR
 
diff --git a/opcodes/configure.ac b/opcodes/configure.ac
index d812ff54a95..31ab922440e 100644
--- a/opcodes/configure.ac
+++ b/opcodes/configure.ac
@@ -27,7 +27,6 @@ AM_INIT_AUTOMAKE
 AM_SILENT_RULES([yes])
 
 AC_PROG_CC
-AC_GNU_SOURCE
 AC_USE_SYSTEM_EXTENSIONS
 
 dnl These must be called before LT_INIT, because it may want
diff --git a/readline/readline/configure.ac b/readline/readline/configure.ac
index c800f1c8667..9ea2a6b4b5e 100644
--- a/readline/readline/configure.ac
+++ b/readline/readline/configure.ac
@@ -115,8 +115,7 @@ test -z "$CFLAGS" && want_auto_cflags=1
 
 AC_PROG_MAKE_SET
 AC_PROG_CC
-dnl AC_AIX
-AC_MINIX
+AC_USE_SYSTEM_EXTENSIONS
 
 # If we're using gcc and the user hasn't specified CFLAGS, add -O2 to CFLAGS
 if test -n "$want_auto_cflags" ; then

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [PATCH v0 03/10] autoupdate: replace obsolete macros AC_PROG_LIBTOOL
  2024-05-28  9:49 [PATCH v0 00/10] Fix obsolescence warnings when regenerating build scripts with autoreconf-2.72 Matthieu Longo
  2024-05-28  9:49 ` [PATCH v0 01/10] autoupdate: replace obsolete macros AC_HELP_STRING Matthieu Longo
  2024-05-28  9:49 ` [PATCH v0 02/10] autoupdate: replace obsolete macros AC_AIX, AC_MINIX, and AC_GNU_SOURCE Matthieu Longo
@ 2024-05-28  9:49 ` Matthieu Longo
  2024-05-28  9:49 ` [PATCH v0 04/10] autoupdate: replace obsolete macros AC_CANONICAL_SYSTEM Matthieu Longo
                   ` (7 subsequent siblings)
  10 siblings, 0 replies; 13+ messages in thread
From: Matthieu Longo @ 2024-05-28  9:49 UTC (permalink / raw)
  To: binutils; +Cc: Richard Earnshaw, Nick Clifton, Matthieu Longo

[-- Attachment #1: Type: text/plain, Size: 199 bytes --]


- AC_PROG_LIBTOOL by LT_INIT
  https://www.gnu.org/software/libtool/manual/html_node/LT_005fINIT.html#index-LT_005fINIT
---
 zlib/configure.ac | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: v0-0003-autoupdate-replace-obsolete-macros-AC_PROG_LIBTOO.patch --]
[-- Type: text/x-patch; name="v0-0003-autoupdate-replace-obsolete-macros-AC_PROG_LIBTOO.patch", Size: 384 bytes --]

diff --git a/zlib/configure.ac b/zlib/configure.ac
index b50b9c7b426..fa1c8fedd6b 100644
--- a/zlib/configure.ac
+++ b/zlib/configure.ac
@@ -60,7 +60,7 @@ m4_rename_force([real_PRECIOUS],[_AC_ARG_VAR_PRECIOUS])
 
 AC_SUBST(CFLAGS)
 
-AC_PROG_LIBTOOL
+LT_INIT
 
 # Find CPP now so that any conditional tests below won't do it and
 # thereby make the resulting definitions conditional.

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [PATCH v0 04/10] autoupdate: replace obsolete macros AC_CANONICAL_SYSTEM
  2024-05-28  9:49 [PATCH v0 00/10] Fix obsolescence warnings when regenerating build scripts with autoreconf-2.72 Matthieu Longo
                   ` (2 preceding siblings ...)
  2024-05-28  9:49 ` [PATCH v0 03/10] autoupdate: replace obsolete macros AC_PROG_LIBTOOL Matthieu Longo
@ 2024-05-28  9:49 ` Matthieu Longo
  2024-05-28  9:49 ` [PATCH v0 05/10] autoupdate: replace obsolete macros AC_CONFIG_HEADER Matthieu Longo
                   ` (6 subsequent siblings)
  10 siblings, 0 replies; 13+ messages in thread
From: Matthieu Longo @ 2024-05-28  9:49 UTC (permalink / raw)
  To: binutils; +Cc: Richard Earnshaw, Nick Clifton, Matthieu Longo

[-- Attachment #1: Type: text/plain, Size: 533 bytes --]


- AC_CANONICAL_SYSTEM by:
    * AC_CANONICAL_HOST where host, and host_alias are needed
    * AC_CANONICAL_TARGET where target_alias is needed
  https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.72/autoconf.html#index-AC_005fCANONICAL_005fTARGET-1
---
 config/acx.m4             | 4 ++--
 config/lthostflags.m4     | 2 +-
 configure.ac              | 4 ++--
 gnulib/configure.ac       | 2 +-
 libbacktrace/configure.ac | 3 ++-
 zlib/configure.ac         | 2 +-
 6 files changed, 9 insertions(+), 8 deletions(-)


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: v0-0004-autoupdate-replace-obsolete-macros-AC_CANONICAL_S.patch --]
[-- Type: text/x-patch; name="v0-0004-autoupdate-replace-obsolete-macros-AC_CANONICAL_S.patch", Size: 2741 bytes --]

diff --git a/config/acx.m4 b/config/acx.m4
index 7efe98aaf96..69f4bfa4d76 100644
--- a/config/acx.m4
+++ b/config/acx.m4
@@ -107,9 +107,9 @@ AC_SUBST([target_subdir]) []dnl
 
 
 ####
-# _NCN_TOOL_PREFIXES:  Some stuff that oughtta be done in AC_CANONICAL_SYSTEM 
+# _NCN_TOOL_PREFIXES:  Some stuff that oughtta be done in AC_CANONICAL_TARGET
 # or AC_INIT.
-# These demand that AC_CANONICAL_SYSTEM be called beforehand.
+# These demand that AC_CANONICAL_HOST and AC_CANONICAL_TARGET be called beforehand.
 AC_DEFUN([_NCN_TOOL_PREFIXES],
 [ncn_tool_prefix=
 test -n "$host_alias" && ncn_tool_prefix=$host_alias-
diff --git a/config/lthostflags.m4 b/config/lthostflags.m4
index bc0f59ee79e..4a389a75ea8 100644
--- a/config/lthostflags.m4
+++ b/config/lthostflags.m4
@@ -10,7 +10,7 @@ dnl Defines and AC_SUBSTs lt_host_flags
 
 
 AC_DEFUN([ACX_LT_HOST_FLAGS], [
-AC_REQUIRE([AC_CANONICAL_SYSTEM])
+AC_REQUIRE([AC_CANONICAL_HOST])
 
 case $host in
   *-cygwin* | *-mingw*)
diff --git a/configure.ac b/configure.ac
index 1300a805fd8..9f69d46e324 100644
--- a/configure.ac
+++ b/configure.ac
@@ -70,14 +70,14 @@ ACX_NONCANONICAL_TARGET
 
 dnl Autoconf 2.5x and later will set a default program prefix if
 dnl --target was used, even if it was the same as --host.  Disable
-dnl that behavior.  This must be done before AC_CANONICAL_SYSTEM
+dnl that behavior.  This must be done before AC_CANONICAL_TARGET
 dnl to take effect.
 test "$host_noncanonical" = "$target_noncanonical" &&
   test "$program_prefix$program_suffix$program_transform_name" = \
     NONENONEs,x,x, &&
   program_transform_name=s,y,y,
 
-AC_CANONICAL_SYSTEM
+AC_CANONICAL_TARGET
 AC_ARG_PROGRAM
 
 m4_pattern_allow([^AS_FOR_TARGET$])dnl
diff --git a/gnulib/configure.ac b/gnulib/configure.ac
index 716e1c8eb70..66a35911bca 100644
--- a/gnulib/configure.ac
+++ b/gnulib/configure.ac
@@ -34,7 +34,7 @@ gl_EARLY
 AM_PROG_CC_STDC
 
 AC_CONFIG_AUX_DIR(..)
-AC_CANONICAL_SYSTEM
+AC_CANONICAL_TARGET
 
 gl_INIT
 
diff --git a/libbacktrace/configure.ac b/libbacktrace/configure.ac
index da61eff0e56..c5d84f77358 100644
--- a/libbacktrace/configure.ac
+++ b/libbacktrace/configure.ac
@@ -37,7 +37,8 @@ if test -n "${with_target_subdir}"; then
   AM_ENABLE_MULTILIB(, ..)
 fi
 
-AC_CANONICAL_SYSTEM
+AC_CANONICAL_HOST
+AC_CANONICAL_TARGET
 target_alias=${target_alias-$host_alias}
 
 AC_USE_SYSTEM_EXTENSIONS
diff --git a/zlib/configure.ac b/zlib/configure.ac
index fa1c8fedd6b..3fa379fb82a 100644
--- a/zlib/configure.ac
+++ b/zlib/configure.ac
@@ -7,7 +7,7 @@ if test -n "${with_target_subdir}"; then
   AM_ENABLE_MULTILIB(, ..)
 fi
 
-AC_CANONICAL_SYSTEM
+AC_CANONICAL_TARGET
 
 # This works around an automake problem.
 mkinstalldirs="`cd $ac_aux_dir && ${PWDCMD-pwd}`/mkinstalldirs"

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [PATCH v0 05/10] autoupdate: replace obsolete macros AC_CONFIG_HEADER
  2024-05-28  9:49 [PATCH v0 00/10] Fix obsolescence warnings when regenerating build scripts with autoreconf-2.72 Matthieu Longo
                   ` (3 preceding siblings ...)
  2024-05-28  9:49 ` [PATCH v0 04/10] autoupdate: replace obsolete macros AC_CANONICAL_SYSTEM Matthieu Longo
@ 2024-05-28  9:49 ` Matthieu Longo
  2024-05-28  9:49 ` [PATCH v0 06/10] autoupdate: replace old version of AC_INIT by the new one Matthieu Longo
                   ` (5 subsequent siblings)
  10 siblings, 0 replies; 13+ messages in thread
From: Matthieu Longo @ 2024-05-28  9:49 UTC (permalink / raw)
  To: binutils; +Cc: Richard Earnshaw, Nick Clifton, Matthieu Longo

[-- Attachment #1: Type: text/plain, Size: 348 bytes --]


- AC_CONFIG_HEADER by AC_CONFIG_HEADERS
  https://www.gnu.org/software/automake/manual/1.12.2/html_node/Obsolete-Macros.html#index-AM_005fCONFIG_005fHEADER
---
 gdbsupport/configure.ac   | 2 +-
 gnulib/configure.ac       | 2 +-
 libbacktrace/configure.ac | 2 +-
 libiberty/configure.ac    | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: v0-0005-autoupdate-replace-obsolete-macros-AC_CONFIG_HEAD.patch --]
[-- Type: text/x-patch; name="v0-0005-autoupdate-replace-obsolete-macros-AC_CONFIG_HEAD.patch", Size: 1760 bytes --]

diff --git a/gdbsupport/configure.ac b/gdbsupport/configure.ac
index 80e24eac479..d0187f84d12 100644
--- a/gdbsupport/configure.ac
+++ b/gdbsupport/configure.ac
@@ -18,7 +18,7 @@ dnl Process this file with autoconf to produce a configure script.
 
 AC_INIT([gdbsupport], 1.0)
 AC_CONFIG_SRCDIR(common-defs.h)
-AC_CONFIG_HEADER(config.h:config.in)
+AC_CONFIG_HEADERS([config.h:config.in])
 
 # Set build, build_cpu, build_vendor and build_os.
 AC_CANONICAL_BUILD
diff --git a/gnulib/configure.ac b/gnulib/configure.ac
index 66a35911bca..8ee8689a9f0 100644
--- a/gnulib/configure.ac
+++ b/gnulib/configure.ac
@@ -20,7 +20,7 @@ dnl Process this file with autoconf to produce a configure script.
 
 AC_INIT([libgnu], [UNUSED-VERSION])
 AC_CONFIG_SRCDIR([import/memmem.c])
-AC_CONFIG_HEADER(config.h:config.in)
+AC_CONFIG_HEADERS([config.h:config.in])
 AC_CONFIG_MACRO_DIRS([import/m4])
 AC_CONFIG_MACRO_DIRS([../config])
 AM_MAINTAINER_MODE
diff --git a/libbacktrace/configure.ac b/libbacktrace/configure.ac
index c5d84f77358..6aa3ceb360b 100644
--- a/libbacktrace/configure.ac
+++ b/libbacktrace/configure.ac
@@ -31,7 +31,7 @@
 
 AC_INIT(package-unused, version-unused,, libbacktrace)
 AC_CONFIG_SRCDIR(backtrace.h)
-AC_CONFIG_HEADER(config.h)
+AC_CONFIG_HEADERS([config.h])
 
 if test -n "${with_target_subdir}"; then
   AM_ENABLE_MULTILIB(, ..)
diff --git a/libiberty/configure.ac b/libiberty/configure.ac
index 4f76b62fcfd..c27e08e1428 100644
--- a/libiberty/configure.ac
+++ b/libiberty/configure.ac
@@ -205,7 +205,7 @@ dnl AM_PROG_LIBTOOL
 
 dnl When we start using automake:
 dnl AM_CONFIG_HEADER(config.h:config.in)
-AC_CONFIG_HEADER(config.h:config.in)
+AC_CONFIG_HEADERS([config.h:config.in])
 
 dnl When we start using automake:
 dnl AM_MAINTAINER_MODE

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [PATCH v0 06/10] autoupdate: replace old version of AC_INIT by the new one
  2024-05-28  9:49 [PATCH v0 00/10] Fix obsolescence warnings when regenerating build scripts with autoreconf-2.72 Matthieu Longo
                   ` (4 preceding siblings ...)
  2024-05-28  9:49 ` [PATCH v0 05/10] autoupdate: replace obsolete macros AC_CONFIG_HEADER Matthieu Longo
@ 2024-05-28  9:49 ` Matthieu Longo
  2024-05-28  9:49 ` [PATCH v0 07/10] autoupdate: add square brackets around argument of AC_PREREQ Matthieu Longo
                   ` (4 subsequent siblings)
  10 siblings, 0 replies; 13+ messages in thread
From: Matthieu Longo @ 2024-05-28  9:49 UTC (permalink / raw)
  To: binutils; +Cc: Richard Earnshaw, Nick Clifton, Matthieu Longo

[-- Attachment #1: Type: text/plain, Size: 230 bytes --]


- old AC_INIT by AC_INIT + AC_CONFIG_SRC_DIR
  https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.72/autoconf.html#index-AC_005fINIT-3
---
 configure.ac | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: v0-0006-autoupdate-replace-old-version-of-AC_INIT-by-the-.patch --]
[-- Type: text/x-patch; name="v0-0006-autoupdate-replace-old-version-of-AC_INIT-by-the-.patch", Size: 336 bytes --]

diff --git a/configure.ac b/configure.ac
index 9f69d46e324..326d469c0c6 100644
--- a/configure.ac
+++ b/configure.ac
@@ -32,7 +32,8 @@ m4_include([ltversion.m4])
 m4_include([lt~obsolete.m4])
 m4_include([config/isl.m4])
 
-AC_INIT(move-if-change)
+AC_INIT
+AC_CONFIG_SRCDIR([move-if-change])
 AC_DISABLE_OPTION_CHECKING
 
 progname=$0

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [PATCH v0 07/10] autoupdate: add square brackets around argument of AC_PREREQ
  2024-05-28  9:49 [PATCH v0 00/10] Fix obsolescence warnings when regenerating build scripts with autoreconf-2.72 Matthieu Longo
                   ` (5 preceding siblings ...)
  2024-05-28  9:49 ` [PATCH v0 06/10] autoupdate: replace old version of AC_INIT by the new one Matthieu Longo
@ 2024-05-28  9:49 ` Matthieu Longo
  2024-05-28  9:49 ` [PATCH v0 08/10] autoupdate: add square brackets around arguments of AC_INIT Matthieu Longo
                   ` (3 subsequent siblings)
  10 siblings, 0 replies; 13+ messages in thread
From: Matthieu Longo @ 2024-05-28  9:49 UTC (permalink / raw)
  To: binutils; +Cc: Richard Earnshaw, Nick Clifton, Matthieu Longo

[-- Attachment #1: Type: text/plain, Size: 243 bytes --]


https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.72/autoconf.html#index-AC_005fPREREQ-1
---
 libctf/configure.ac            | 2 +-
 readline/readline/configure.ac | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: v0-0007-autoupdate-add-square-brackets-around-argument-of.patch --]
[-- Type: text/x-patch; name="v0-0007-autoupdate-add-square-brackets-around-argument-of.patch", Size: 813 bytes --]

diff --git a/libctf/configure.ac b/libctf/configure.ac
index ced1aeb7ccf..51ad76e9755 100644
--- a/libctf/configure.ac
+++ b/libctf/configure.ac
@@ -18,7 +18,7 @@ dnl along with this program; see the file COPYING.  If not see
 dnl <http://www.gnu.org/licenses/>.
 dnl
 
-AC_PREREQ(2.64)
+AC_PREREQ([2.64])
 AC_INIT([libctf], 1.2.0)
 AC_CONFIG_SRCDIR(ctf-impl.h)
 AC_CANONICAL_BUILD
diff --git a/readline/readline/configure.ac b/readline/readline/configure.ac
index 9ea2a6b4b5e..6a9d77f0c51 100644
--- a/readline/readline/configure.ac
+++ b/readline/readline/configure.ac
@@ -27,7 +27,7 @@ m4_include([../../config/override.m4])
 AC_INIT(readline, 8.1, bug-readline@gnu.org)
 
 dnl make sure we are using a recent autoconf version
-AC_PREREQ(2.50)
+AC_PREREQ([2.50])
 
 AC_CONFIG_SRCDIR(readline.h)
 dnl GDB LOCAL

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [PATCH v0 08/10] autoupdate: add square brackets around arguments of AC_INIT
  2024-05-28  9:49 [PATCH v0 00/10] Fix obsolescence warnings when regenerating build scripts with autoreconf-2.72 Matthieu Longo
                   ` (6 preceding siblings ...)
  2024-05-28  9:49 ` [PATCH v0 07/10] autoupdate: add square brackets around argument of AC_PREREQ Matthieu Longo
@ 2024-05-28  9:49 ` Matthieu Longo
  2024-05-28  9:49 ` [PATCH v0 09/10] autoconf: delete obsolete unused m4 file Matthieu Longo
                   ` (2 subsequent siblings)
  10 siblings, 0 replies; 13+ messages in thread
From: Matthieu Longo @ 2024-05-28  9:49 UTC (permalink / raw)
  To: binutils; +Cc: Richard Earnshaw, Nick Clifton, Matthieu Longo

[-- Attachment #1: Type: text/plain, Size: 754 bytes --]


https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.72/autoconf.html#index-AC_005fINIT-2
---
 bfd/configure.ac                  | 2 +-
 binutils/configure.ac             | 2 +-
 gas/configure.ac                  | 2 +-
 gdbsupport/configure.ac           | 2 +-
 gold/configure.ac                 | 2 +-
 gprof/configure.ac                | 2 +-
 gprofng/configure.ac              | 2 +-
 gprofng/libcollector/configure.ac | 2 +-
 ld/configure.ac                   | 2 +-
 libbacktrace/configure.ac         | 2 +-
 libctf/configure.ac               | 2 +-
 libsframe/configure.ac            | 2 +-
 opcodes/configure.ac              | 2 +-
 readline/readline/configure.ac    | 2 +-
 14 files changed, 14 insertions(+), 14 deletions(-)


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: v0-0008-autoupdate-add-square-brackets-around-arguments-o.patch --]
[-- Type: text/x-patch; name="v0-0008-autoupdate-add-square-brackets-around-arguments-o.patch", Size: 5701 bytes --]

diff --git a/bfd/configure.ac b/bfd/configure.ac
index 3b65d8fed4a..6bcfd1b7368 100644
--- a/bfd/configure.ac
+++ b/bfd/configure.ac
@@ -18,7 +18,7 @@ dnl <http://www.gnu.org/licenses/>.
 dnl
 
 m4_include([version.m4])
-AC_INIT([bfd], BFD_VERSION)
+AC_INIT([bfd], [BFD_VERSION])
 AC_CONFIG_SRCDIR([libbfd.c])
 
 AC_CANONICAL_TARGET
diff --git a/binutils/configure.ac b/binutils/configure.ac
index 0373a426495..06c88e0048c 100644
--- a/binutils/configure.ac
+++ b/binutils/configure.ac
@@ -19,7 +19,7 @@ dnl
 
 m4_include([../bfd/version.m4])
 m4_include([../config/debuginfod.m4])
-AC_INIT([binutils], BFD_VERSION)
+AC_INIT([binutils], [BFD_VERSION])
 AC_CONFIG_SRCDIR(ar.c)
 
 AC_CANONICAL_TARGET
diff --git a/gas/configure.ac b/gas/configure.ac
index 503635072cf..6b978aae3f7 100644
--- a/gas/configure.ac
+++ b/gas/configure.ac
@@ -21,7 +21,7 @@ dnl <http://www.gnu.org/licenses/>.
 dnl
 dnl v2.5 needed for --bindir et al
 m4_include([../bfd/version.m4])
-AC_INIT([gas], BFD_VERSION)
+AC_INIT([gas], [BFD_VERSION])
 AC_CONFIG_SRCDIR(as.h)
 
 dnl Autoconf 2.57 will find the aux dir without this.  However, unless
diff --git a/gdbsupport/configure.ac b/gdbsupport/configure.ac
index d0187f84d12..b30b4365f53 100644
--- a/gdbsupport/configure.ac
+++ b/gdbsupport/configure.ac
@@ -16,7 +16,7 @@ dnl along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
 dnl Process this file with autoconf to produce a configure script.
 
-AC_INIT([gdbsupport], 1.0)
+AC_INIT([gdbsupport], [1.0])
 AC_CONFIG_SRCDIR(common-defs.h)
 AC_CONFIG_HEADERS([config.h:config.in])
 
diff --git a/gold/configure.ac b/gold/configure.ac
index 0e622c7405a..52f7a701128 100644
--- a/gold/configure.ac
+++ b/gold/configure.ac
@@ -17,7 +17,7 @@ dnl along with this program; see the file COPYING3.  If not see
 dnl <http://www.gnu.org/licenses/>.
 dnl
 
-AC_INIT(gold, 0.1)
+AC_INIT([gold], [0.1])
 AC_CONFIG_SRCDIR(gold.cc)
 
 AC_CANONICAL_TARGET
diff --git a/gprof/configure.ac b/gprof/configure.ac
index b2635680c15..1f0c5943357 100644
--- a/gprof/configure.ac
+++ b/gprof/configure.ac
@@ -17,7 +17,7 @@ dnl along with this program; see the file COPYING3.  If not see
 dnl <http://www.gnu.org/licenses/>.
 dnl
 m4_include([../bfd/version.m4])
-AC_INIT([gprof], BFD_VERSION)
+AC_INIT([gprof], [BFD_VERSION])
 AC_CONFIG_SRCDIR([gprof.c])
 
 AC_CANONICAL_TARGET([])
diff --git a/gprofng/configure.ac b/gprofng/configure.ac
index 794e95793fc..691d6c9815a 100644
--- a/gprofng/configure.ac
+++ b/gprofng/configure.ac
@@ -18,7 +18,7 @@ dnl <http://www.gnu.org/licenses/>.
 
 m4_include([../bfd/version.m4])
 m4_include([../config/zlib.m4])
-AC_INIT([gprofng], BFD_VERSION)
+AC_INIT([gprofng], [BFD_VERSION])
 AC_CANONICAL_TARGET
 AM_INIT_AUTOMAKE([subdir-objects])
 AM_MAINTAINER_MODE
diff --git a/gprofng/libcollector/configure.ac b/gprofng/libcollector/configure.ac
index b0ef678305d..b923645c730 100644
--- a/gprofng/libcollector/configure.ac
+++ b/gprofng/libcollector/configure.ac
@@ -17,7 +17,7 @@ dnl along with this program; see the file COPYING3.  If not see
 dnl <http://www.gnu.org/licenses/>.
 
 m4_include([../../bfd/version.m4])
-AC_INIT([gprofng], BFD_VERSION)
+AC_INIT([gprofng], [BFD_VERSION])
 AC_CONFIG_MACRO_DIRS([../../config ../..])
 AC_CONFIG_AUX_DIR(../..)
 AC_CANONICAL_TARGET
diff --git a/ld/configure.ac b/ld/configure.ac
index cce094380de..8ba6cf9edfb 100644
--- a/ld/configure.ac
+++ b/ld/configure.ac
@@ -18,7 +18,7 @@ dnl <http://www.gnu.org/licenses/>.
 dnl
 
 m4_include([../bfd/version.m4])
-AC_INIT([ld], BFD_VERSION)
+AC_INIT([ld], [BFD_VERSION])
 AC_CONFIG_SRCDIR(ldmain.c)
 
 AC_CANONICAL_TARGET
diff --git a/libbacktrace/configure.ac b/libbacktrace/configure.ac
index 6aa3ceb360b..1d7aedc74b1 100644
--- a/libbacktrace/configure.ac
+++ b/libbacktrace/configure.ac
@@ -29,7 +29,7 @@
 # IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
 # POSSIBILITY OF SUCH DAMAGE.
 
-AC_INIT(package-unused, version-unused,, libbacktrace)
+AC_INIT([package-unused], [version-unused], [], [libbacktrace])
 AC_CONFIG_SRCDIR(backtrace.h)
 AC_CONFIG_HEADERS([config.h])
 
diff --git a/libctf/configure.ac b/libctf/configure.ac
index 51ad76e9755..cf0e988f7fb 100644
--- a/libctf/configure.ac
+++ b/libctf/configure.ac
@@ -19,7 +19,7 @@ dnl <http://www.gnu.org/licenses/>.
 dnl
 
 AC_PREREQ([2.64])
-AC_INIT([libctf], 1.2.0)
+AC_INIT([libctf], [1.2.0])
 AC_CONFIG_SRCDIR(ctf-impl.h)
 AC_CANONICAL_BUILD
 AC_CANONICAL_HOST
diff --git a/libsframe/configure.ac b/libsframe/configure.ac
index d63f27070eb..8cbd3cde14f 100644
--- a/libsframe/configure.ac
+++ b/libsframe/configure.ac
@@ -18,7 +18,7 @@ dnl along with this program; see the file COPYING.  If not see
 dnl <http://www.gnu.org/licenses/>.
 dnl
 
-AC_INIT([libsframe], BFD_VERSION)
+AC_INIT([libsframe], [BFD_VERSION])
 AC_CONFIG_SRCDIR(sframe.c)
 AC_USE_SYSTEM_EXTENSIONS
 AM_INIT_AUTOMAKE
diff --git a/opcodes/configure.ac b/opcodes/configure.ac
index 31ab922440e..4d918e3ef9b 100644
--- a/opcodes/configure.ac
+++ b/opcodes/configure.ac
@@ -18,7 +18,7 @@ dnl <http://www.gnu.org/licenses/>.
 dnl
 
 m4_include([../bfd/version.m4])
-AC_INIT([opcodes], BFD_VERSION)
+AC_INIT([opcodes], [BFD_VERSION])
 AC_CONFIG_SRCDIR([z8k-dis.c])
 
 AC_CANONICAL_TARGET
diff --git a/readline/readline/configure.ac b/readline/readline/configure.ac
index 6a9d77f0c51..f2900752e8d 100644
--- a/readline/readline/configure.ac
+++ b/readline/readline/configure.ac
@@ -24,7 +24,7 @@ AC_REVISION([for Readline 8.1, version 2.90])
 
 m4_include([../../config/override.m4])
 
-AC_INIT(readline, 8.1, bug-readline@gnu.org)
+AC_INIT([readline], [8.1], [bug-readline@gnu.org])
 
 dnl make sure we are using a recent autoconf version
 AC_PREREQ([2.50])

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [PATCH v0 09/10] autoconf: delete obsolete unused m4 file
  2024-05-28  9:49 [PATCH v0 00/10] Fix obsolescence warnings when regenerating build scripts with autoreconf-2.72 Matthieu Longo
                   ` (7 preceding siblings ...)
  2024-05-28  9:49 ` [PATCH v0 08/10] autoupdate: add square brackets around arguments of AC_INIT Matthieu Longo
@ 2024-05-28  9:49 ` Matthieu Longo
  2024-05-28  9:49 ` [PATCH v0 10/10] autoupdate: diff after replacing obsolete macros with previous patches Matthieu Longo
  2024-06-07  1:48 ` [PATCH v0 00/10] Fix obsolescence warnings when regenerating build scripts with autoreconf-2.72 Alan Modra
  10 siblings, 0 replies; 13+ messages in thread
From: Matthieu Longo @ 2024-05-28  9:49 UTC (permalink / raw)
  To: binutils; +Cc: Richard Earnshaw, Nick Clifton, Matthieu Longo

[-- Attachment #1: Type: text/plain, Size: 1015 bytes --]


config/uintmax_t.m4 contains only one function: jm_AC_TYPE_UINTMAX_T.
After a grep, I could not find any usage of it.

jm_AC_TYPE_UINTMAX_T seems to be an old implementation of the officially
suppported AC_TYPE_UINTMAX_T.
Doc: https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/
     autoconf-2.72/autoconf.html#index-AC_005fTYPE_005fUINTMAX_005fT-1

config/stdint.m4 seems to have taken over. The usage of
AC_REQUIRE([AC_TYPE_UINTMAX_T]) is not garded or inside a function, so it
will also automatically be run for the configure.ac files using
AC_CONFIG_MACRO_DIRS([../config]) instead of m4_include([../config/stdint.m4]).

It seems that people replaced jm_AC_TYPE_UINTMAX_T occurences by
AC_TYPE_UINTMAX_T, and forgot to delete uintmax_t.m4.
Deleting the file and regenerating the build scripts results in no diff,
so it looks safe to delete it from the repository.
---
 config/uintmax_t.m4 | 32 --------------------------------
 1 file changed, 32 deletions(-)
 delete mode 100644 config/uintmax_t.m4


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: v0-0009-autoconf-delete-obsolete-unused-m4-file.patch --]
[-- Type: text/x-patch; name="v0-0009-autoconf-delete-obsolete-unused-m4-file.patch", Size: 1456 bytes --]

diff --git a/config/uintmax_t.m4 b/config/uintmax_t.m4
deleted file mode 100644
index b5f28d4404a..00000000000
--- a/config/uintmax_t.m4
+++ /dev/null
@@ -1,32 +0,0 @@
-# uintmax_t.m4 serial 7 (gettext-0.12)
-dnl Copyright (C) 1997-2003 Free Software Foundation, Inc.
-dnl This file is free software, distributed under the terms of the GNU
-dnl General Public License.  As a special exception to the GNU General
-dnl Public License, this file may be distributed as part of a program
-dnl that contains a configuration script generated by Autoconf, under
-dnl the same distribution terms as the rest of that program.
-
-dnl From Paul Eggert.
-
-AC_PREREQ(2.13)
-
-# Define uintmax_t to 'unsigned long' or 'unsigned long long'
-# if it is not already defined in <stdint.h> or <inttypes.h>.
-
-AC_DEFUN([jm_AC_TYPE_UINTMAX_T],
-[
-  AC_REQUIRE([jm_AC_HEADER_INTTYPES_H])
-  AC_REQUIRE([jm_AC_HEADER_STDINT_H])
-  if test $jm_ac_cv_header_inttypes_h = no && test $jm_ac_cv_header_stdint_h = no; then
-    AC_REQUIRE([jm_AC_TYPE_UNSIGNED_LONG_LONG])
-    test $ac_cv_type_unsigned_long_long = yes \
-      && ac_type='unsigned long long' \
-      || ac_type='unsigned long'
-    AC_DEFINE_UNQUOTED(uintmax_t, $ac_type,
-      [Define to unsigned long or unsigned long long
-       if <stdint.h> and <inttypes.h> don't define.])
-  else
-    AC_DEFINE(HAVE_UINTMAX_T, 1,
-      [Define if you have the 'uintmax_t' type in <stdint.h> or <inttypes.h>.])
-  fi
-])

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [PATCH v0 10/10] autoupdate: diff after replacing obsolete macros with previous patches
  2024-05-28  9:49 [PATCH v0 00/10] Fix obsolescence warnings when regenerating build scripts with autoreconf-2.72 Matthieu Longo
                   ` (8 preceding siblings ...)
  2024-05-28  9:49 ` [PATCH v0 09/10] autoconf: delete obsolete unused m4 file Matthieu Longo
@ 2024-05-28  9:49 ` Matthieu Longo
  2024-06-07  1:48 ` [PATCH v0 00/10] Fix obsolescence warnings when regenerating build scripts with autoreconf-2.72 Alan Modra
  10 siblings, 0 replies; 13+ messages in thread
From: Matthieu Longo @ 2024-05-28  9:49 UTC (permalink / raw)
  To: binutils; +Cc: Richard Earnshaw, Nick Clifton, Matthieu Longo

[-- Attachment #1: Type: text/plain, Size: 428 bytes --]

---
 bfd/configure          | 6 ++----
 binutils/configure     | 6 ++----
 configure              | 2 +-
 gas/configure          | 6 ++----
 gold/configure         | 2 --
 gprof/configure        | 6 ++----
 ld/configure           | 6 ++----
 libbacktrace/configure | 5 ++---
 libiberty/configure    | 1 -
 opcodes/configure      | 6 ++----
 zlib/configure         | 5 ++---
 11 files changed, 17 insertions(+), 34 deletions(-)


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: v0-0010-autoupdate-diff-after-replacing-obsolete-macros-w.patch --]
[-- Type: text/x-patch; name="v0-0010-autoupdate-diff-after-replacing-obsolete-macros-w.patch", Size: 8176 bytes --]

diff --git a/bfd/configure b/bfd/configure
index 89fe4388171..6458974951e 100755
--- a/bfd/configure
+++ b/bfd/configure
@@ -5053,8 +5053,6 @@ $as_echo "$ac_cv_safe_to_define___extensions__" >&6; }
 
 
 
-
-
 case `pwd` in
   *\ * | *\	*)
     { $as_echo "$as_me:${as_lineno-$LINENO}: WARNING: Libtool does not cope well with whitespace in \`pwd\`" >&5
@@ -11157,7 +11155,7 @@ else
   lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2
   lt_status=$lt_dlunknown
   cat > conftest.$ac_ext <<_LT_EOF
-#line 11160 "configure"
+#line 11158 "configure"
 #include "confdefs.h"
 
 #if HAVE_DLFCN_H
@@ -11263,7 +11261,7 @@ else
   lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2
   lt_status=$lt_dlunknown
   cat > conftest.$ac_ext <<_LT_EOF
-#line 11266 "configure"
+#line 11264 "configure"
 #include "confdefs.h"
 
 #if HAVE_DLFCN_H
diff --git a/binutils/configure b/binutils/configure
index 5d87b6b3e66..c948b85abd7 100755
--- a/binutils/configure
+++ b/binutils/configure
@@ -4723,8 +4723,6 @@ $as_echo "$ac_cv_safe_to_define___extensions__" >&6; }
 
 
 
-
-
  { $as_echo "$as_me:${as_lineno-$LINENO}: checking whether byte ordering is bigendian" >&5
 $as_echo_n "checking whether byte ordering is bigendian... " >&6; }
 if ${ac_cv_c_bigendian+:} false; then :
@@ -11083,7 +11081,7 @@ else
   lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2
   lt_status=$lt_dlunknown
   cat > conftest.$ac_ext <<_LT_EOF
-#line 11086 "configure"
+#line 11084 "configure"
 #include "confdefs.h"
 
 #if HAVE_DLFCN_H
@@ -11189,7 +11187,7 @@ else
   lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2
   lt_status=$lt_dlunknown
   cat > conftest.$ac_ext <<_LT_EOF
-#line 11192 "configure"
+#line 11190 "configure"
 #include "confdefs.h"
 
 #if HAVE_DLFCN_H
diff --git a/configure b/configure
index 6466b97f3ec..d8cb423cd56 100755
--- a/configure
+++ b/configure
@@ -2335,6 +2335,7 @@ ac_compiler_gnu=$ac_cv_c_compiler_gnu
 
 
 
+
 progname=$0
 # if PWD already has a value, it is probably wrong.
 if test -n "$PWD" ; then PWD=`${PWDCMD-pwd}`; fi
@@ -2530,7 +2531,6 @@ test -n "$target_alias" &&
   test "$program_prefix$program_suffix$program_transform_name" = \
     NONENONEs,x,x, &&
   program_prefix=${target_alias}-
-
 test "$program_prefix" != NONE &&
   program_transform_name="s&^&$program_prefix&;$program_transform_name"
 # Use a double $ so make ignores it.
diff --git a/gas/configure b/gas/configure
index e6811fe73bd..0cebc4e0fa9 100755
--- a/gas/configure
+++ b/gas/configure
@@ -4642,8 +4642,6 @@ $as_echo "$ac_cv_safe_to_define___extensions__" >&6; }
 
 
 
-
-
 case `pwd` in
   *\ * | *\	*)
     { $as_echo "$as_me:${as_lineno-$LINENO}: WARNING: Libtool does not cope well with whitespace in \`pwd\`" >&5
@@ -10777,7 +10775,7 @@ else
   lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2
   lt_status=$lt_dlunknown
   cat > conftest.$ac_ext <<_LT_EOF
-#line 10780 "configure"
+#line 10778 "configure"
 #include "confdefs.h"
 
 #if HAVE_DLFCN_H
@@ -10883,7 +10881,7 @@ else
   lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2
   lt_status=$lt_dlunknown
   cat > conftest.$ac_ext <<_LT_EOF
-#line 10886 "configure"
+#line 10884 "configure"
 #include "confdefs.h"
 
 #if HAVE_DLFCN_H
diff --git a/gold/configure b/gold/configure
index c92f4478776..a2674d6ecbb 100755
--- a/gold/configure
+++ b/gold/configure
@@ -6853,8 +6853,6 @@ fi
 
 
 
-
-
         MKINSTALLDIRS=
   if test -n "$ac_aux_dir"; then
     case "$ac_aux_dir" in
diff --git a/gprof/configure b/gprof/configure
index 6c9d8701c48..64f14fa0de7 100755
--- a/gprof/configure
+++ b/gprof/configure
@@ -4520,8 +4520,6 @@ $as_echo "$ac_cv_safe_to_define___extensions__" >&6; }
 
 
 
-
-
 case `pwd` in
   *\ * | *\	*)
     { $as_echo "$as_me:${as_lineno-$LINENO}: WARNING: Libtool does not cope well with whitespace in \`pwd\`" >&5
@@ -10655,7 +10653,7 @@ else
   lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2
   lt_status=$lt_dlunknown
   cat > conftest.$ac_ext <<_LT_EOF
-#line 10658 "configure"
+#line 10656 "configure"
 #include "confdefs.h"
 
 #if HAVE_DLFCN_H
@@ -10761,7 +10759,7 @@ else
   lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2
   lt_status=$lt_dlunknown
   cat > conftest.$ac_ext <<_LT_EOF
-#line 10764 "configure"
+#line 10762 "configure"
 #include "confdefs.h"
 
 #if HAVE_DLFCN_H
diff --git a/ld/configure b/ld/configure
index ba0024699d4..9151640ca60 100755
--- a/ld/configure
+++ b/ld/configure
@@ -5433,8 +5433,6 @@ $as_echo "$ac_cv_safe_to_define___extensions__" >&6; }
 
 
 
-
-
 if test "x$ac_cv_env_PKG_CONFIG_set" != "xset"; then
 	if test -n "$ac_tool_prefix"; then
   # Extract the first word of "${ac_tool_prefix}pkg-config", so it can be a program name with args.
@@ -11683,7 +11681,7 @@ else
   lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2
   lt_status=$lt_dlunknown
   cat > conftest.$ac_ext <<_LT_EOF
-#line 11686 "configure"
+#line 11684 "configure"
 #include "confdefs.h"
 
 #if HAVE_DLFCN_H
@@ -11789,7 +11787,7 @@ else
   lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2
   lt_status=$lt_dlunknown
   cat > conftest.$ac_ext <<_LT_EOF
-#line 11792 "configure"
+#line 11790 "configure"
 #include "confdefs.h"
 
 #if HAVE_DLFCN_H
diff --git a/libbacktrace/configure b/libbacktrace/configure
index 9d22b74ba32..4ab612dc780 100755
--- a/libbacktrace/configure
+++ b/libbacktrace/configure
@@ -2729,7 +2729,6 @@ test -n "$target_alias" &&
   test "$program_prefix$program_suffix$program_transform_name" = \
     NONENONEs,x,x, &&
   program_prefix=${target_alias}-
-
 target_alias=${target_alias-$host_alias}
 
 # Expand $ac_aux_dir to an absolute path.
@@ -11579,7 +11578,7 @@ else
   lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2
   lt_status=$lt_dlunknown
   cat > conftest.$ac_ext <<_LT_EOF
-#line 11582 "configure"
+#line 11581 "configure"
 #include "confdefs.h"
 
 #if HAVE_DLFCN_H
@@ -11685,7 +11684,7 @@ else
   lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2
   lt_status=$lt_dlunknown
   cat > conftest.$ac_ext <<_LT_EOF
-#line 11688 "configure"
+#line 11687 "configure"
 #include "confdefs.h"
 
 #if HAVE_DLFCN_H
diff --git a/libiberty/configure b/libiberty/configure
index 18e98b84bb5..f83b42fb0d5 100755
--- a/libiberty/configure
+++ b/libiberty/configure
@@ -4413,7 +4413,6 @@ $as_echo "$ac_cv_safe_to_define___extensions__" >&6; }
   $as_echo "#define _TANDEM_SOURCE 1" >>confdefs.h
 
 
-
 # Check whether --enable-largefile was given.
 if test "${enable_largefile+set}" = set; then :
   enableval=$enable_largefile;
diff --git a/opcodes/configure b/opcodes/configure
index 9b3cc5ce4a1..050fd5ff0ff 100755
--- a/opcodes/configure
+++ b/opcodes/configure
@@ -4770,8 +4770,6 @@ $as_echo "$ac_cv_safe_to_define___extensions__" >&6; }
 
 
 
-
-
 if test -n "$ac_tool_prefix"; then
   # Extract the first word of "${ac_tool_prefix}ar", so it can be a program name with args.
 set dummy ${ac_tool_prefix}ar; ac_word=$2
@@ -11092,7 +11090,7 @@ else
   lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2
   lt_status=$lt_dlunknown
   cat > conftest.$ac_ext <<_LT_EOF
-#line 11095 "configure"
+#line 11093 "configure"
 #include "confdefs.h"
 
 #if HAVE_DLFCN_H
@@ -11198,7 +11196,7 @@ else
   lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2
   lt_status=$lt_dlunknown
   cat > conftest.$ac_ext <<_LT_EOF
-#line 11201 "configure"
+#line 11199 "configure"
 #include "confdefs.h"
 
 #if HAVE_DLFCN_H
diff --git a/zlib/configure b/zlib/configure
index 0e8a28a09a8..cae55c5ca49 100755
--- a/zlib/configure
+++ b/zlib/configure
@@ -2413,7 +2413,6 @@ test -n "$target_alias" &&
     NONENONEs,x,x, &&
   program_prefix=${target_alias}-
 
-
 # This works around an automake problem.
 mkinstalldirs="`cd $ac_aux_dir && ${PWDCMD-pwd}`/mkinstalldirs"
 
@@ -10746,7 +10745,7 @@ else
   lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2
   lt_status=$lt_dlunknown
   cat > conftest.$ac_ext <<_LT_EOF
-#line 10749 "configure"
+#line 10748 "configure"
 #include "confdefs.h"
 
 #if HAVE_DLFCN_H
@@ -10852,7 +10851,7 @@ else
   lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2
   lt_status=$lt_dlunknown
   cat > conftest.$ac_ext <<_LT_EOF
-#line 10855 "configure"
+#line 10854 "configure"
 #include "confdefs.h"
 
 #if HAVE_DLFCN_H

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH v0 00/10] Fix obsolescence warnings when regenerating build scripts with autoreconf-2.72
  2024-05-28  9:49 [PATCH v0 00/10] Fix obsolescence warnings when regenerating build scripts with autoreconf-2.72 Matthieu Longo
                   ` (9 preceding siblings ...)
  2024-05-28  9:49 ` [PATCH v0 10/10] autoupdate: diff after replacing obsolete macros with previous patches Matthieu Longo
@ 2024-06-07  1:48 ` Alan Modra
       [not found]   ` <87sexolp6t.fsf@tromey.com>
  10 siblings, 1 reply; 13+ messages in thread
From: Alan Modra @ 2024-06-07  1:48 UTC (permalink / raw)
  To: Matthieu Longo; +Cc: binutils, gdb-patches, Richard Earnshaw, Nick Clifton

On Tue, May 28, 2024 at 10:49:39AM +0100, Matthieu Longo wrote:
> This patch series replaces obsolete macros that are warned on by autoreconf-2.72.
> It aims at removing noise from a future upgrade to autoreconf-2.72 or later.
> This is in no way a complete patch set allowing the upgrade to autoreconf-2.72.

I'm going to commit this for you with two changes, unless I hear a NACK
from gdb developers:
- The ifdef on AC_HELP_STRING in lib-prefix.m4 does not get replaced
  with AS_HELP_STRING, instead the idfef disappears.
- No changes are made to gnulib/ since this is an imported directory
  with a check in update-gnulib.sh that no one has been tweaking the
  source.

I'll note that your patches to other imported dirs will likely
disappear unless you also submit them to the upstream projects.

-- 
Alan Modra

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH v0 00/10] Fix obsolescence warnings when regenerating build scripts with autoreconf-2.72
       [not found]   ` <87sexolp6t.fsf@tromey.com>
@ 2024-06-07 22:42     ` Alan Modra
  0 siblings, 0 replies; 13+ messages in thread
From: Alan Modra @ 2024-06-07 22:42 UTC (permalink / raw)
  To: Tom Tromey
  Cc: Matthieu Longo, binutils, gdb-patches, Richard Earnshaw, Nick Clifton

On Fri, Jun 07, 2024 at 09:58:50AM -0600, Tom Tromey wrote:
> >>>>> Alan Modra <amodra@gmail.com> writes:
> 
> > - No changes are made to gnulib/ since this is an imported directory
> >   with a check in update-gnulib.sh that no one has been tweaking the
> >   source.
> 
> I think changes to gnulib itself (e.g., gnulib/configure.ac) are ok but
> subdirs of gnulib come direct from upstream.

I completely misunderstood update-gnulib.sh.  (I think I have it
figured out now, not that it matters.)  I'll put back the
gnulib/configure.ac changes.

> > I'll note that your patches to other imported dirs will likely
> > disappear unless you also submit them to the upstream projects.
> 
> There were a bunch of these in the series: readline, gnulib, several
> from gcc...
> 
> Tom

-- 
Alan Modra

^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2024-06-07 22:42 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-05-28  9:49 [PATCH v0 00/10] Fix obsolescence warnings when regenerating build scripts with autoreconf-2.72 Matthieu Longo
2024-05-28  9:49 ` [PATCH v0 01/10] autoupdate: replace obsolete macros AC_HELP_STRING Matthieu Longo
2024-05-28  9:49 ` [PATCH v0 02/10] autoupdate: replace obsolete macros AC_AIX, AC_MINIX, and AC_GNU_SOURCE Matthieu Longo
2024-05-28  9:49 ` [PATCH v0 03/10] autoupdate: replace obsolete macros AC_PROG_LIBTOOL Matthieu Longo
2024-05-28  9:49 ` [PATCH v0 04/10] autoupdate: replace obsolete macros AC_CANONICAL_SYSTEM Matthieu Longo
2024-05-28  9:49 ` [PATCH v0 05/10] autoupdate: replace obsolete macros AC_CONFIG_HEADER Matthieu Longo
2024-05-28  9:49 ` [PATCH v0 06/10] autoupdate: replace old version of AC_INIT by the new one Matthieu Longo
2024-05-28  9:49 ` [PATCH v0 07/10] autoupdate: add square brackets around argument of AC_PREREQ Matthieu Longo
2024-05-28  9:49 ` [PATCH v0 08/10] autoupdate: add square brackets around arguments of AC_INIT Matthieu Longo
2024-05-28  9:49 ` [PATCH v0 09/10] autoconf: delete obsolete unused m4 file Matthieu Longo
2024-05-28  9:49 ` [PATCH v0 10/10] autoupdate: diff after replacing obsolete macros with previous patches Matthieu Longo
2024-06-07  1:48 ` [PATCH v0 00/10] Fix obsolescence warnings when regenerating build scripts with autoreconf-2.72 Alan Modra
     [not found]   ` <87sexolp6t.fsf@tromey.com>
2024-06-07 22:42     ` Alan Modra

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).