From: "Luke T. Shumaker" <lukeshu@lukeshu.com>
To: binutils@sourceware.org, gdb-patches@sourceware.org
Cc: "Ralf Wildenhues" <Ralf.Wildenhues@gmx.de>,
"Alfred M. Szmidt" <ams@gnu.org>,
"Tom Tromey" <tromey@adacore.com>,
"Maciej W. Rozycki" <macro@orcam.me.uk>,
Jan Beulich <jbeulich@suse.com>,
Joseph Myers <josmyers@redhat.com>,
"Luke T. Shumaker" <lukeshu@lukeshu.com>
Subject: [PATCH v2 3/5] zlib: Remove files that should certainly not be checked in
Date: Sun, 9 Jun 2024 21:08:31 -0600 [thread overview]
Message-ID: <20240610030833.472301-4-lukeshu@lukeshu.com> (raw)
In-Reply-To: <20240606201145.1747021-1-lukeshu@lukeshu.com>
The *.obj files are compiled binaries that should have been
.gitignore'd (and so also add an `*.obj` entry to .gitignore).
zlib/example.c and zlib/minigzip.c are outdated duplicates of
zlib/test/example.c and zlib/test/minigzip.c
My justification believing that the *.obj files should be removed and
ignored is as follows:
- AFAICT, these files are not used by binutils-gdb.
- As shown in the final commit of this patch series, the zlib
directory is perfectly re-created *except for these files* by
extracting zlib-1.2.12.tar over zlib-1.2.10.tar. Neither of those
tarballs include any .obj files.
- These files were first added to binutils-gdb.git from gcc.git in
5ca28f79288 (Import zlib from GCC, H.J. Lu, 2015-03-13), which is
is a faithful (except for some $Id$ mangling) of zlib-1.2.7.tar.
That tarball does not include any .obj files either.
- However, zlib tarballs did include some .obj files in the
v1.2.[0-3] range.
- And whadayaknow, the .obj files were first added to gcc.git in
303ae446cf2a (Initial revision, Tom Tromey, 2005-09-12), which
bundled zlib-1.2.1.tar (which as I just said is indeed one of the
archives that includes .obj files).
- Ever since being first checked in to gcc.git/binutils-gdb.git, the
.obj files have never once been updated, even though the associated
assembly source code has had substantial revisions.
---
v2:
- Add *.obj to .gitignore.
- Add justification for my beliefs to the commit message.
---
.gitignore | 1 +
zlib/contrib/masmx64/gvmat64.obj | Bin 4119 -> 0 bytes
zlib/contrib/masmx64/inffasx64.obj | Bin 5913 -> 0 bytes
zlib/contrib/masmx86/gvmat32.obj | Bin 10241 -> 0 bytes
zlib/contrib/masmx86/inffas32.obj | Bin 14893 -> 0 bytes
zlib/example.c | 565 -----------------------------
zlib/minigzip.c | 440 ----------------------
7 files changed, 1 insertion(+), 1005 deletions(-)
delete mode 100644 zlib/contrib/masmx64/gvmat64.obj
delete mode 100644 zlib/contrib/masmx64/inffasx64.obj
delete mode 100644 zlib/contrib/masmx86/gvmat32.obj
delete mode 100644 zlib/contrib/masmx86/inffas32.obj
delete mode 100644 zlib/example.c
delete mode 100644 zlib/minigzip.c
diff --git a/.gitignore b/.gitignore
index 0a40764c958..ae229bc574e 100644
--- a/.gitignore
+++ b/.gitignore
@@ -13,6 +13,7 @@
*.la
*.lo
*.o
+*.obj
*.pyc
*.tmp
*.a
diff --git a/zlib/contrib/masmx64/gvmat64.obj b/zlib/contrib/masmx64/gvmat64.obj
deleted file mode 100644
index a49ca029c63e24f907d7cd5d6eaa25f016c9aea5..0000000000000000000000000000000000000000
diff --git a/zlib/contrib/masmx64/inffasx64.obj b/zlib/contrib/masmx64/inffasx64.obj
deleted file mode 100644
index 8df5d82616098e1f791526c3cd9875b24f5ad8c0..0000000000000000000000000000000000000000
diff --git a/zlib/contrib/masmx86/gvmat32.obj b/zlib/contrib/masmx86/gvmat32.obj
deleted file mode 100644
index ebb326238aed552f381eacbfa69f9ed48d3eb1a3..0000000000000000000000000000000000000000
diff --git a/zlib/contrib/masmx86/inffas32.obj b/zlib/contrib/masmx86/inffas32.obj
deleted file mode 100644
index bd6664d111d573b4aa7a4d4a182d33b90d705700..0000000000000000000000000000000000000000
diff --git a/zlib/example.c b/zlib/example.c
deleted file mode 100644
index e30389750b2..00000000000
diff --git a/zlib/minigzip.c b/zlib/minigzip.c
deleted file mode 100644
index 7aa1c0f4ddd..00000000000
--
2.45.1
next prev parent reply other threads:[~2024-06-10 3:09 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-06 20:11 [PATCH 0/4] Add a ./bootstrap script to automate bundling and generating files Luke T. Shumaker
2024-06-06 20:11 ` [PATCH 1/4] readline: Fix examples/rlfe/configure.ac Luke T. Shumaker
2024-06-08 18:25 ` Maciej W. Rozycki
2024-06-08 18:28 ` Maciej W. Rozycki
2024-06-10 3:01 ` Luke T. Shumaker
2024-06-10 16:51 ` Simon Marchi
2024-06-06 20:11 ` [PATCH 2/4] Update COPYING files from gnu.org Luke T. Shumaker
2024-06-06 20:11 ` [PATCH 3/4] zlib: Remove files that should certainly not be checked in Luke T. Shumaker
2024-06-07 6:24 ` Jan Beulich
2024-06-07 7:53 ` Luke T. Shumaker
2024-06-10 3:04 ` Luke T. Shumaker
2024-06-08 0:35 ` Luke T. Shumaker
2024-06-06 20:11 ` [PATCH 4/4] Add a ./bootstrap script to automate bundling and generating files Luke T. Shumaker
2024-06-06 20:53 ` Luke T. Shumaker
2024-06-06 20:57 ` Joseph Myers
2024-06-07 8:23 ` Luke T. Shumaker
2024-06-10 19:27 ` Joseph Myers
2024-06-12 7:02 ` Luke T. Shumaker
2024-06-12 12:58 ` Tom Tromey
2024-06-06 20:55 ` [PATCH 0/4] " Luke T. Shumaker
2024-06-10 3:08 ` [PATCH v2 0/5] " Luke T. Shumaker
2024-06-10 3:08 ` [PATCH v2 1/5] readline: Fix examples/rlfe/configure.in Luke T. Shumaker
2024-06-10 22:49 ` Hans-Peter Nilsson
2024-06-10 3:08 ` [PATCH v2 2/5] Update COPYING files from gnu.org Luke T. Shumaker
2024-06-10 3:08 ` Luke T. Shumaker [this message]
2024-06-10 3:08 ` [PATCH v2 4/5] readline: Re-generate configure Luke T. Shumaker
2024-06-10 3:08 ` [PATCH v2 5/5] Add a ./bootstrap script to automate bundling and generating files Luke T. Shumaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240610030833.472301-4-lukeshu@lukeshu.com \
--to=lukeshu@lukeshu.com \
--cc=Ralf.Wildenhues@gmx.de \
--cc=ams@gnu.org \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=jbeulich@suse.com \
--cc=josmyers@redhat.com \
--cc=macro@orcam.me.uk \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).