From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id 3CB043AAA056 for ; Thu, 8 Dec 2022 17:44:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3CB043AAA056 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2B8HhgsI013186; Thu, 8 Dec 2022 17:44:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2022-7-12; bh=rEjOVu410DCnckvlwUnlUd8qYPda9OD8hrIG43LxIGY=; b=dUJWmHEUsmLXQ5XWf49B+o3t08PlhuP6Qtf9JK1svYf3b4aVhIfsnlhSHoUg47OrDWag +YKJJHHyA9BJhcaLqLhu88egbwN1gp2LGPnFL/2XIHYxiezIClcfveL6ZbYy2VZN67sh 9iY1U+P7k7WIUm4rbYWlOKrBD00LNKPphOfQ//wQhkctM3UgX9DOA6Wf7ZEbl3ZHmE1g DuEdLsl3rgN/95GxvFWFocGzHpvJqWkRC2sZq8KqirUvRpuofOqpjqgx2mWiOYTZXAaX XNyUcto8ChdigE5d5Z4lgexvRzEMTGxrls4W6+EXMMMLWhWh5AtCrzaJHby6cmwAR8S/ XQ== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3mauduub82-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 08 Dec 2022 17:44:00 +0000 Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 2B8GmnYe033761; Thu, 8 Dec 2022 17:43:59 GMT Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2173.outbound.protection.outlook.com [104.47.59.173]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3maa6b9qdq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 08 Dec 2022 17:43:59 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Mx5eZyad0UO5SIXPU+adHzLpi4P6VlJP/oFbdBmMGq3SEkYMM+KQ9HuViRQR1Bn6Zy/TJ24WzlPg5kSK2ngnsnzEa3h1hepxWFPJRtVcYzN0y/FXIGaDEOg21Vdy4pdutXw9XvDo94WAChtZNiOxiJbAZ2SfO/i+jjYw3zqIqsGIlEZofUKStUdRODvY7BoHMpB0Cy92QtSf2csFCQQyQEFzv00RKzs8nqbabO4CrypdbS0ls2KQpmHJ4leTKLm6SLj0+gEbNhRpvBGxd71rhEmCsTjwwNdRktmNePJVCGWzNL9+1YjHVAfZq0pvUiGOimWTfSt1odAzTxzgzD7dYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rEjOVu410DCnckvlwUnlUd8qYPda9OD8hrIG43LxIGY=; b=fihEYW5pcWoe/VNcVvywbPQZwf7zqTZMhv1gJzaJI8p7jHy+8VaqhKcCIbjg4T8+w1QpZmfkHFelmqkbFRWbUIWyDmMzpR64CrGs1EMac3iOQb3EC1jlLl1lc3iorm2Uug8DWU1WP9n1KqPkkx85OzY3owFh0zNjTpwGCaXzt/bPSodrp2feB6xRFY0yupMxU6Kw9ilt24h1GCyd2wNkw+m4GihAYgdTvXaJ8/iEysR2myt2OIxI3mfE8XEcdh+DNpZMJNJZYf0X9ygLb1/0JpFHW1SknFWt73bR4AJ7nnrsVHfy+w+tY4UC81DBMWvJrz2aXbBW8disuJOa4IEv9w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rEjOVu410DCnckvlwUnlUd8qYPda9OD8hrIG43LxIGY=; b=hCrd1bkt8nSfWAu8qoyWeUo9V0bca7tEMIsWB1xj0ANk334RhLFkE5dVLQmcigwNmTn45e7YXBkmTJAcQeWvwnQr7wAVS/Qgzfb3dww3aIXGNXQdX+OwJZHPvEav6DZy6i1uL7wFZnsH+gCuqHXSRHUuSTF8Y2EnmWgf3yPLGAQ= Received: from MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) by DM4PR10MB6014.namprd10.prod.outlook.com (2603:10b6:8:ad::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.13; Thu, 8 Dec 2022 17:43:58 +0000 Received: from MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::ee70:1952:4416:1bdc]) by MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::ee70:1952:4416:1bdc%5]) with mapi id 15.20.5880.014; Thu, 8 Dec 2022 17:43:58 +0000 Message-ID: <20345278-1db0-d176-d51f-59723a757225@oracle.com> Date: Thu, 8 Dec 2022 09:43:50 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH 3/6] sframe: gas: libsframe: define constants and remove magic numbers Content-Language: en-US To: Nick Clifton , binutils@sourceware.org Cc: weimin.pan@oracle.com References: <20221207195222.1182788-1-indu.bhagat@oracle.com> <20221207195222.1182788-4-indu.bhagat@oracle.com> <3f2c38f1-e08c-1584-2e4c-77b4eb50351d@redhat.com> From: Indu Bhagat In-Reply-To: <3f2c38f1-e08c-1584-2e4c-77b4eb50351d@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MW4PR04CA0263.namprd04.prod.outlook.com (2603:10b6:303:88::28) To MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2158:EE_|DM4PR10MB6014:EE_ X-MS-Office365-Filtering-Correlation-Id: 93c4f0fd-4937-4141-a8a1-08dad943c894 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: j9vYQN2SVmWM4oVY/zxIYf/vXrIF+rezQo7Q9zEzWd4lkDpgijvTCpHV8S/tkCaj5/vzZxKHBf4YW67z4RQfNt6+lOqL3rz8MHBFWULZJruBa+IL80MuzXntWI29b7Pg0kt81U5pdJjy5j8FI0qsHytK11sl2ax7gMEFbU/LHlDlGmVOYjOkYWzIpdqbb4/uTIfUBo1/ugbpZs/ueqE5jNYiIAEiqTYijYemXuwbKIU4o16RWKTxet22KhjhCnRT9nSMzKKM0ZdbUEaydU70+vUACSUDLGud7rUm/0UfVdkvYTbYSvy8eDqObV829pW7+SK16yoytojP9gNeMDMEGhdmitM8e/lvkQI5rDD2vQT1iNDDSFXjuzeyWwxW2DysMN9ZMHGl2FkS8XcYqQhQlvvhCyTguTqVkAzE29piX/AGwrXIhNKHvbuoF824e/anyeHcOMnR31TCslXUIPb7L2wNAFQ9jUnEjf8Mavf9KJ2Cx/4iXBMhRPF4OjUoEag3qxHssJU6LM33PJvOK+DYxOyg7WKkLYPye78qf5iSgKS5VTa+ZeAFcLfku+xwg85CKuBQ1fnaZEqwdCsnRBYyNZrOrtAX/qOao4A7oX6cmSBXdd/sIJQJbPRX0uGjSc8sqkqvnq2hcNHXLntRZe+9h/OLdXQ8QKFWhfYCwr1X/eDSxViB0KSMAUxw1E4tBJTo92HKbWI0MGVZaapvll9KMZJzXUy1y/8pYMlNdrp+W/4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2158.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(346002)(396003)(136003)(39860400002)(376002)(451199015)(36756003)(5660300002)(316002)(41300700001)(478600001)(83380400001)(107886003)(38100700002)(53546011)(86362001)(6666004)(31696002)(2616005)(8936002)(186003)(6512007)(6486002)(6506007)(2906002)(31686004)(66476007)(66556008)(4326008)(66946007)(8676002)(44832011)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bnE1RndBV2QxT3R4dTZYWk9GMVJ6TDJFY250M1VWajc5RWJob29hbDU3Sy9n?= =?utf-8?B?YUlwazhmNk5ONXJXT05CLzlvM0tGLy9nNGRuemVRcTFCOVlZcVNiWjJhZ29y?= =?utf-8?B?eTZNb3NCWWg0ZFBub0hvUGVQQmMxdWhBTUhNZlljUU1ZL0J2aVF4Z1FQcEJG?= =?utf-8?B?U05PQ25RV2JnYmhJeTlmZ084RGdpQ3hMSXU4RlJzbjV3WHdwRzVJWlVkYi9j?= =?utf-8?B?UzloYkhRQ0dyUzQxenZvVUtrWksvcW9EVVZEeE5DR0RDYmU0TWxmdEdNSjFn?= =?utf-8?B?UDlVZmp5MXFTekZpS0ZBWUJwVG9JbUFrQm9sUGQrQjY5aEJFSVAyV1ZaUkY0?= =?utf-8?B?MEZMK0dpSk1vQ2lIdWUxbmtJL25YQWRYcmJ3eW94R25jWUdDN0licDNjU20w?= =?utf-8?B?S3c1NnZGN0lYS1pKckFqV3RtaWR3dXl0bWk2YXphSDQrVm1KbkxIOUJ5b2Fx?= =?utf-8?B?UE5vU3o1Vy9oYTdJWVN0R1lzakV4dEkvNmx6T2ZJVFp5SjhoVjFveFN4eTZt?= =?utf-8?B?MzBrMnF2WkhSZmVoTkk2QWtnUjAvS2c2bEUweXdvSTRaQk01c3VpQjRxa0Z2?= =?utf-8?B?eHg5N3d2b29ZQTl3bWROcjVBcHRDYjBPc0w5NE1uL1ZZMWVrQ1QwWHVaU2la?= =?utf-8?B?SkJlaTZ6UDR0V1lWOTFnb0hLblF2bnB4TWtnb0dWdzdWbzhRSjNSa2E3ZXdl?= =?utf-8?B?WjA3YkRxeSttNDYvQjdYZ2JpWkYzN1RqaVFPMDFJTlNhY2NNTTJGNklsdmsw?= =?utf-8?B?RW5wM2ZHdmNZVkhhRmlzVnFHNTVIOXhYSkFxdHg3UW1LeXR0eHpidGZ3L2Zy?= =?utf-8?B?aFJVd0wvVlF4SWE4NnAxVlJFU0VuZ3FiMFU0cDdIVENxUWMvdTdtclYzRFlu?= =?utf-8?B?aEx4SWxjaU51V2NRWmlyQ3M3VHFDV041QmVjdWpZWm16eXErUVdTSjNpNmlm?= =?utf-8?B?RWdsRnErSkRPOFhocnBrVExRdWgrK1ZPcDZKTDh1eFdhWlZCYzQzN0k4NHpv?= =?utf-8?B?bUhlNitsZlFzTTcxdFBlak4rUThDT2RwVzlOZVA3aW1MbzdhZWNaTlF3VGtz?= =?utf-8?B?Ty9XSnhCWXR5Y21DdUlQeWloVU4vSnQwQUM2cWNzbVp4czNadWZCMU5LMzJD?= =?utf-8?B?QkFQVU5GM1Fwa01wb3NGQzR6ODZKcHdZNDRYbUQ1eTFCOFJ4UGN5Vnk1dHk0?= =?utf-8?B?ZWJUNWhCWlFKQzdWdTVPMHJxRTd4S0lmcXI4OS9TSFdrblFFUk80SmhHM3lF?= =?utf-8?B?Zm9MQ1FwdzdGcjNOL2h4R1lPZzJYZXZPK2Y1UGlSaldvREpZdG9EYmlvMVNt?= =?utf-8?B?NEtLcytDTHlQNXlRQ0xlY0w0MXZHdTNvK3pMQzJOd3ViZzdiR1lMTlFxM1hG?= =?utf-8?B?K2szOUczY1craE1oczhEdTJFaXdqU2ludVBBemN5RTJXdFFnOHFHM09CODBP?= =?utf-8?B?QzZRbDRuMkpvckcvSnFDMXFiZFdmcmRsU2JlMVd6SlVpbFRiRENUM0VWN1B4?= =?utf-8?B?bXdMeDI5RTVFRWRQMy9nOC9qVlpRMHZWL0F4YXZtRkpFYXVLcUJ0cDdjaHBk?= =?utf-8?B?REdaUUxtU0JVWjRtMk1SMXZrS0FTK20xdFl3YWUvcmFYTWpVa2l4N0MyUFJN?= =?utf-8?B?MzZOVHZWZHc0ZmlEQzN4WUpzbW5HN1hWc0s1OXBsTXRrK1h5ZHp3SWNmWFFY?= =?utf-8?B?TmJ3RnhINzUrSWdQRGo4di9XdWx4SExjS25FMmJzb3R6QTV0SE9KYjRMdlBy?= =?utf-8?B?b1JKbEpmMElKSW9PWHhhbElPQkwrOCs4N2dMaDUveU11cjRKdlAwbHMxRzRq?= =?utf-8?B?eGZReW5pKzBjWUxwN0xYdE9xMXRGa3VGNXVPQ1RoQitJL0FMNmxtYlBnK09m?= =?utf-8?B?aEc3MCtKNHlISVp1S25MT0hzKzdxZWNGc1p5U0ExaUt5Y0EzMGtJeDU5Zy9P?= =?utf-8?B?d1VrVllXRnc2R0VVVjJKSWZFWkM2dzd5VkRZbDcyNzhxL3lTNTQvV1Q1dGdw?= =?utf-8?B?b0ZkbXpsMXp3d2Zva1pOU1d0S1ZycTE5VHpWbVpTN1NyOFF3TjZVbENDZG92?= =?utf-8?B?eFZFNlVyZmJvSUlZMmNaTzRhR05SVEljdDNIWlU4c25iTC94anlzQzh1UXk4?= =?utf-8?B?VEZ4b1ZmYnArcnMrSnBodjdaYVZ4VnkvdXQxalRncjRGa29kcWZFTWRtTWI0?= =?utf-8?B?RWc9PQ==?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 93c4f0fd-4937-4141-a8a1-08dad943c894 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2158.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Dec 2022 17:43:57.9599 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7LCR0MeVCQGJOJ12qXni+Jsm6jr+OhlupYY8J5PuMOyg5xD2Nh0Cuec41Q786vSvxUb/NZCazAbzvxGEtlXHig== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR10MB6014 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-12-08_11,2022-12-08_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 suspectscore=0 malwarescore=0 phishscore=0 mlxlogscore=999 spamscore=0 adultscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2212080149 X-Proofpoint-ORIG-GUID: TEkggqiOCOPQz_w-faiWHoDulyha9UNA X-Proofpoint-GUID: TEkggqiOCOPQz_w-faiWHoDulyha9UNA X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/8/22 03:10, Nick Clifton wrote: > Hi Indu, > >> +#define SFRAME_FRE_TYPE_ADDR1_LIMIT  ((SFRAME_FRE_TYPE_ADDR1+1)*8) > > For readabilities sake, I would recommend adding whitespace around > arithmetic > operations.  For example in the define above a quick glance would > suggest that > the definition is for a symbol called ...ADDR11 rather than ...ADDR1 + 1. > So: > > #define SFRAME_FRE_TYPE_ADDR1_LIMIT  ((SFRAME_FRE_TYPE_ADDR1 + 1) * 8) > > Is better IMHO. > Yes, I agree. I will fix it. >> +#define SFRAME_FRE_TYPE_ADDR2_LIMIT  ((SFRAME_FRE_TYPE_ADDR2*2)*8) >> +#define SFRAME_FRE_TYPE_ADDR4_LIMIT  ((SFRAME_FRE_TYPE_ADDR4*2)*8) > > The same goes for these two definitions as well. > > Patch approved with these changes. > > Cheers >   Nick > > PS.  Just checking, since I am not actually familiar with the sframe > format:  Is it correct that SFRAME_FRE_TYPE_ADDR1_LIMIT is defined > as "(...ADDR1 + 1) * 8" rather than "(...ADDR1 * 2) * 8)" ?  It is > just that the other two limits are defined using the second formula > and it seems slightly odd that it is not used for the first. > Yes, it does appear unpleasing to the eye. But it is the way it is because the constants are defined as following: #define SFRAME_FRE_TYPE_ADDR1 0 #define SFRAME_FRE_TYPE_ADDR2 1 #define SFRAME_FRE_TYPE_ADDR4 2 All this scrambling because keeping 3-bits was deemed sufficient to encode 3 different values (size of 1 byte, 2 byte and 4 bytes respectively), and the rest of the bits were provisioned for other information. Thanks for reviewing, Indu