From: John Baldwin <jhb@freebsd.org>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
binutils@sourceware.org
Subject: Re: [PATCH 5/8] Detect a frameless frame by comparing the FP register to -1.
Date: Tue, 14 Jun 2016 19:08:00 -0000 [thread overview]
Message-ID: <2059915.yo7jaW82vP@ralph.baldwin.cx> (raw)
In-Reply-To: <CAH=s-PPAjOdQkctdxcOWXoBeNNhcyT=4iR4k=9RRKFy0jb+_LA@mail.gmail.com>
On Monday, June 13, 2016 12:22:41 PM Yao Qi wrote:
> On Sat, Jun 11, 2016 at 9:48 PM, John Baldwin <jhb@freebsd.org> wrote:
> >
> > - if (cache->saved_regs[MEDIA_FP_REGNUM] >= 0)
> > + if (cache->saved_regs[MEDIA_FP_REGNUM] == -1)
> > cache->uses_fp = 1;
>
> I suspect it should be " != -1". saved_regs[MEDIA_FP_REGNUM] is initialized
> to -1, so if it is not the initialized value (-1), FP should be set in
> the prologue, and mark the flag uses_fp.
Yes, you are correct. Alternatively, we could change this code to explicitly
set 'cache->uses_fp' in the cases earlier in this function where it sets
MEDIA_FP_REGNUM to a value. sh-tdep.c follows this model, but it only needs
to set uses_fp in a few places.
--
John Baldwin
next prev parent reply other threads:[~2016-06-14 19:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-11 20:49 [PATCH 0/8] Fix various warnings from clang 3.8.0 John Baldwin
2016-06-11 20:49 ` [PATCH 2/8] Change the size field of MSP430_Opcode_Decoded to a plain integer John Baldwin
2016-06-13 1:48 ` Alan Modra
2016-06-11 20:49 ` [PATCH 1/8] Use correct enum type for do_elf_stt_common John Baldwin
2016-06-13 1:48 ` Alan Modra
2016-06-11 20:49 ` [PATCH 3/8] Initialize 'ra' to zero to avoid uninitialized use John Baldwin
2016-06-13 11:04 ` Yao Qi
2016-06-11 20:49 ` [PATCH 7/8] Remove unneeded checks on type lengths John Baldwin
2016-06-13 10:47 ` Yao Qi
2016-06-11 20:49 ` [PATCH 8/8] Use unsigned integer constant with left shifts John Baldwin
2016-06-11 20:49 ` [PATCH 5/8] Detect a frameless frame by comparing the FP register to -1 John Baldwin
2016-06-13 11:22 ` Yao Qi
2016-06-14 19:08 ` John Baldwin [this message]
2016-06-15 8:44 ` Yao Qi
2016-06-11 20:56 ` [PATCH 4/8] Remove check for negative size John Baldwin
2016-06-11 20:56 ` [PATCH 6/8] Pass a NULL pointer as the last argument to find_pc_partial_function John Baldwin
2016-06-13 10:49 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2059915.yo7jaW82vP@ralph.baldwin.cx \
--to=jhb@freebsd.org \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=qiyaoltc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).