public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Tristan Gingold <gingold@adacore.com>
To: Alan Modra <amodra@gmail.com>
Cc: "H.J. Lu" <hjl.tools@gmail.com>, binutils <binutils@sourceware.org>
Subject: Re: [Patch] ld: check for address space overflow
Date: Tue, 14 Mar 2017 13:56:00 -0000	[thread overview]
Message-ID: <205F4E12-577B-47D7-B382-E33F1F1173AB@adacore.com> (raw)
In-Reply-To: <20170314121729.GM4983@bubble.grove.modra.org>


> On 14 Mar 2017, at 13:17, Alan Modra <amodra@gmail.com> wrote:
> 
> On Tue, Mar 14, 2017 at 11:50:27AM +0100, Tristan Gingold wrote:
>> 
>>> On 14 Mar 2017, at 11:19, Alan Modra <amodra@gmail.com> wrote:
>>> The new testcases need some tweaking too.  Even after applying the
>>> above I'm left with:
>>> 
>>> arm-aout  +FAIL: section size overflow
>>> arm-coff  +FAIL: section size overflow
>>> arm-epoc-pe  +FAIL: section size overflow
>>> arm-pe  +FAIL: section size overflow
>>> arm-symbianelf  +FAIL: section size overflow
>>> arm-wince-pe  +FAIL: section size overflow
>>> i386-linuxaout  +FAIL: section size overflow
>>> i386-linuxaout  +FAIL: section size overflow
>>> i386-lynxos  +FAIL: section size overflow
>>> i386-netware  +FAIL: section size overflow
>>> i586-aout  +FAIL: section size overflow
>>> i686-pe  +FAIL: section size overflow
>> 
>> What is the host ?  32 bit or 64 bit ?
> 
> 64 bit.  x86_64-linux.

Would that be ok ?
(No need to bother with additional sections).

Tristan.

commit 6e31e599777fb6a9e09f06b2fc957201b2c7eb4f
Author: Tristan Gingold <gingold@adacore.com>
Date:   Tue Mar 14 14:54:37 2017 +0100

    ld-checks: tweak overflow checks.
    
    	* testsuite/ld-checks/checks.exp (overflow_check): Disable for
    	non-elf targets.

diff --git a/ld/ChangeLog b/ld/ChangeLog
index c164710..c988c3b 100644
--- a/ld/ChangeLog
+++ b/ld/ChangeLog
@@ -1,3 +1,8 @@
+2017-03-14  Tristan Gingold  <gingold@adacore.com>
+
+	* testsuite/ld-checks/checks.exp (overflow_check): Disable for
+	non-elf targets.
+
 2017-03-13  Tristan Gingold  <gingold@adacore.com>
 
 	* ldlang.c (lang_check_section_addresses): Check for address space
diff --git a/ld/testsuite/ld-checks/checks.exp b/ld/testsuite/ld-checks/checks.exp
index 782f50a..e411d03 100644
--- a/ld/testsuite/ld-checks/checks.exp
+++ b/ld/testsuite/ld-checks/checks.exp
@@ -85,6 +85,9 @@ proc overflow_check {} {
 	 && ![istarget arm*-*-*] } {
 	return
     }
+    if ![is_elf_format] {
+	return
+    }
 
     run_dump_test "over"
     run_dump_test "over2"

  reply	other threads:[~2017-03-14 13:56 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-10 14:29 Tristan Gingold
2017-03-11  1:14 ` Alan Modra
2017-03-13  9:47   ` Tristan Gingold
2017-03-13 17:52     ` H.J. Lu
2017-03-13 19:06 ` H.J. Lu
2017-03-13 19:27   ` H.J. Lu
2017-03-14  8:15     ` Tristan Gingold
2017-03-14 10:20       ` Alan Modra
2017-03-14 10:50         ` Tristan Gingold
2017-03-14 12:17           ` Alan Modra
2017-03-14 13:56             ` Tristan Gingold [this message]
2017-03-15  1:11               ` Alan Modra
2017-03-15  9:26                 ` Tristan Gingold
2017-03-14 16:13       ` H.J. Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=205F4E12-577B-47D7-B382-E33F1F1173AB@adacore.com \
    --to=gingold@adacore.com \
    --cc=amodra@gmail.com \
    --cc=binutils@sourceware.org \
    --cc=hjl.tools@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).