* [PATCH] RISC-V: Zicbo{m,p,z} adjustments to riscv_multi_subset_supports_ext()
@ 2022-10-04 13:56 Jan Beulich
2022-10-04 16:08 ` Tsukasa OI
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Jan Beulich @ 2022-10-04 13:56 UTC (permalink / raw)
To: Binutils; +Cc: Palmer Dabbelt, Andrew Waterman, Jim Wilson, Nelson Chu
The lack thereof did caused gas to issue "internal: unreachable
INSN_CLASS_*" errors when trying to assemble respective insns without
the feature(s) enabled via e.g. ".option arch, ...". Of course a proper
hint towards the missing extension then wasn't given either.
--- a/bfd/elfxx-riscv.c
+++ b/bfd/elfxx-riscv.c
@@ -2440,6 +2440,12 @@ riscv_multi_subset_supports_ext (riscv_p
{
case INSN_CLASS_I:
return "i";
+ case INSN_CLASS_ZICBOM:
+ return "zicbom";
+ case INSN_CLASS_ZICBOP:
+ return "zicbop";
+ case INSN_CLASS_ZICBOZ:
+ return "zicboz";
case INSN_CLASS_ZICSR:
return "zicsr";
case INSN_CLASS_ZIFENCEI:
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] RISC-V: Zicbo{m,p,z} adjustments to riscv_multi_subset_supports_ext()
2022-10-04 13:56 [PATCH] RISC-V: Zicbo{m,p,z} adjustments to riscv_multi_subset_supports_ext() Jan Beulich
@ 2022-10-04 16:08 ` Tsukasa OI
2022-10-06 4:50 ` Tsukasa OI
2022-10-14 1:19 ` Nelson Chu
2 siblings, 0 replies; 4+ messages in thread
From: Tsukasa OI @ 2022-10-04 16:08 UTC (permalink / raw)
To: Jan Beulich, Binutils
On 2022/10/04 22:56, Jan Beulich via Binutils wrote:
> The lack thereof did caused gas to issue "internal: unreachable
> INSN_CLASS_*" errors when trying to assemble respective insns without
> the feature(s) enabled via e.g. ".option arch, ...". Of course a proper
> hint towards the missing extension then wasn't given either.
>
> --- a/bfd/elfxx-riscv.c
> +++ b/bfd/elfxx-riscv.c
> @@ -2440,6 +2440,12 @@ riscv_multi_subset_supports_ext (riscv_p
> {
> case INSN_CLASS_I:
> return "i";
> + case INSN_CLASS_ZICBOM:
> + return "zicbom";
> + case INSN_CLASS_ZICBOP:
> + return "zicbop";
> + case INSN_CLASS_ZICBOZ:
> + return "zicboz";
> case INSN_CLASS_ZICSR:
> return "zicsr";
> case INSN_CLASS_ZIFENCEI:
>
LGTM.
Thanks!
Tsukasa
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] RISC-V: Zicbo{m,p,z} adjustments to riscv_multi_subset_supports_ext()
2022-10-04 13:56 [PATCH] RISC-V: Zicbo{m,p,z} adjustments to riscv_multi_subset_supports_ext() Jan Beulich
2022-10-04 16:08 ` Tsukasa OI
@ 2022-10-06 4:50 ` Tsukasa OI
2022-10-14 1:19 ` Nelson Chu
2 siblings, 0 replies; 4+ messages in thread
From: Tsukasa OI @ 2022-10-06 4:50 UTC (permalink / raw)
To: Jan Beulich, Binutils
On 2022/10/04 22:56, Jan Beulich via Binutils wrote:
> The lack thereof did caused gas to issue "internal: unreachable
> INSN_CLASS_*" errors when trying to assemble respective insns without
> the feature(s) enabled via e.g. ".option arch, ...". Of course a proper
> hint towards the missing extension then wasn't given either.
>
> --- a/bfd/elfxx-riscv.c
> +++ b/bfd/elfxx-riscv.c
> @@ -2440,6 +2440,12 @@ riscv_multi_subset_supports_ext (riscv_p
> {
> case INSN_CLASS_I:
> return "i";
> + case INSN_CLASS_ZICBOM:
> + return "zicbom";
> + case INSN_CLASS_ZICBOP:
> + return "zicbop";
> + case INSN_CLASS_ZICBOZ:
> + return "zicboz";
I confirmed that those three are the last ones to be added to this
function. Thanks!
> case INSN_CLASS_ZICSR:
> return "zicsr";
> case INSN_CLASS_ZIFENCEI:
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] RISC-V: Zicbo{m,p,z} adjustments to riscv_multi_subset_supports_ext()
2022-10-04 13:56 [PATCH] RISC-V: Zicbo{m,p,z} adjustments to riscv_multi_subset_supports_ext() Jan Beulich
2022-10-04 16:08 ` Tsukasa OI
2022-10-06 4:50 ` Tsukasa OI
@ 2022-10-14 1:19 ` Nelson Chu
2 siblings, 0 replies; 4+ messages in thread
From: Nelson Chu @ 2022-10-14 1:19 UTC (permalink / raw)
To: Jan Beulich; +Cc: Binutils, Palmer Dabbelt, Andrew Waterman, Jim Wilson
Looks reasonable, please commit, thanks.
Nelson
On Tue, Oct 4, 2022 at 9:56 PM Jan Beulich <jbeulich@suse.com> wrote:
>
> The lack thereof did caused gas to issue "internal: unreachable
> INSN_CLASS_*" errors when trying to assemble respective insns without
> the feature(s) enabled via e.g. ".option arch, ...". Of course a proper
> hint towards the missing extension then wasn't given either.
>
> --- a/bfd/elfxx-riscv.c
> +++ b/bfd/elfxx-riscv.c
> @@ -2440,6 +2440,12 @@ riscv_multi_subset_supports_ext (riscv_p
> {
> case INSN_CLASS_I:
> return "i";
> + case INSN_CLASS_ZICBOM:
> + return "zicbom";
> + case INSN_CLASS_ZICBOP:
> + return "zicbop";
> + case INSN_CLASS_ZICBOZ:
> + return "zicboz";
> case INSN_CLASS_ZICSR:
> return "zicsr";
> case INSN_CLASS_ZIFENCEI:
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-10-14 1:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-04 13:56 [PATCH] RISC-V: Zicbo{m,p,z} adjustments to riscv_multi_subset_supports_ext() Jan Beulich
2022-10-04 16:08 ` Tsukasa OI
2022-10-06 4:50 ` Tsukasa OI
2022-10-14 1:19 ` Nelson Chu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).