From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id E3D9C3861904 for ; Sat, 30 Sep 2023 06:14:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E3D9C3861904 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 38U4O8iM012253; Sat, 30 Sep 2023 06:14:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2023-03-30; bh=BRhy+vyjXt6WyEKf9xp6s+YjdmrZ5aNvHGxJFWsLRcg=; b=3xr4KpQCRSLTLVstaAGlV+81lEgD9fmkt1BVuXKKbj2k9unH7Ytta4J+oce1WM1jg1qf BP7jjYusQs06QEQO1z0ObmMfNxyJM/Co3izMQy9BdwSNUXD87qAzbE7DVsSHa59TSTUa krgEl2NrSsIoOFx7ogz4OnkEiWpnyeq1/9pmf63VUBUPjKTfkHepNCDj0JeDFd9okv5+ j0OCqGTcG5+YBahMjTv7ABNk979SrTnTvJ6IJB90+3gUhJoCv4XZcgtz1yDPCVjepi7q KAb5XvSPNNibk0Swzp/jnuwQ9uvD/HuHohV68XqUdttcADNuSKHQrpWUhiJvITO/TJYe Aw== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3tebjbr3es-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 30 Sep 2023 06:14:04 +0000 Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 38U5MkS8011632; Sat, 30 Sep 2023 06:14:03 GMT Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2173.outbound.protection.outlook.com [104.47.59.173]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3tea42e9gy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 30 Sep 2023 06:14:03 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JA/6wUa2wC2FsIsXKIoFmRnprV5dqB8vwbbIywaec2K4aJhJ0h9pqFEbfUvAcOE7LBbyV1cJHc2jLETObq+KZuf8VyOzZwcVo9yI1RQkrSbzoiCeRLlOTOxF23y29iIl0ZI/fYdzaY8uuwdHB9iq+FcjBuCw64QfDdUTyOoBA5gCu5ztuSJZkKTluTbSmiwaUmZDnnz3srYlCDdyPWURt56IT5WZTiXAipR5rOm0TXxNjjt6KIDG4X3n3bN5YbRtlCb7vzjpH7IaDUj+EbaQN3QD5rEiGi3riPx2ZTT1koxSv/DOJbQDkSlJ2c5Lv3YT6zcen+xJLISWlKmrwjYHzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BRhy+vyjXt6WyEKf9xp6s+YjdmrZ5aNvHGxJFWsLRcg=; b=UtNL95cej6NzboxF9MJtIQutufC2pS4HftLxhsQsIfRW8uQYWqIujXdv1CFWHZbLU9ahtCEDtCLW8Jf2AoH2F1qVUDeQcadoVbDejgcE2G7QR/OeoOvQWCfeLAWXDaSFFPZaXPdWx/Ne3gOOOaBvxILMfTCvcbONmkP1L76Nfl+a9QUKELpVnWolZjYil0WOF2yyzv7beqn5BC6KMI2636GY+7xU60mL8bG9SaY2ASD+3xCy0OMk7HtddYNn/f76rQCETy6ZxBznJz0pe8lhts2Cr5ZoRwYs3aJR8v5Sogz8WCQYCQ195KPt14DP5TDZXhoK2HQvoaqUEHpOJfvfCg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BRhy+vyjXt6WyEKf9xp6s+YjdmrZ5aNvHGxJFWsLRcg=; b=yx7NLXK3bGjFD01wVBfS4hQ6JHneNLn/w2zCJqe/muaAINwdoXUvpmwMmqVMaomWrMpIE613nOTkCklGxXX1ATQlpXPE1KZWujApsDObqO5/r3HSHyEDglk49TYc7RyvfwyHzpOa0wk4LnycIC7D8WncyVc5tCIm1J+tuf/prkg= Received: from MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) by PH0PR10MB7100.namprd10.prod.outlook.com (2603:10b6:510:28b::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.28; Sat, 30 Sep 2023 06:14:01 +0000 Received: from MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::44f7:ba76:db28:606e]) by MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::44f7:ba76:db28:606e%3]) with mapi id 15.20.6813.027; Sat, 30 Sep 2023 06:14:01 +0000 Message-ID: <210aae11-825a-4699-f09b-5696bd26b652@oracle.com> Date: Fri, 29 Sep 2023 23:13:57 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH,RFC 5/9] gas: add new command line option --scfi[=all,none] Content-Language: en-US To: Nick Clifton , binutils@sourceware.org References: <20230920230401.1739139-1-indu.bhagat@oracle.com> <20230920230401.1739139-6-indu.bhagat@oracle.com> <6582d489-7ac5-6c4d-cfc2-8e5ca7e399e4@redhat.com> From: Indu Bhagat In-Reply-To: <6582d489-7ac5-6c4d-cfc2-8e5ca7e399e4@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MW4PR04CA0137.namprd04.prod.outlook.com (2603:10b6:303:84::22) To MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2158:EE_|PH0PR10MB7100:EE_ X-MS-Office365-Filtering-Correlation-Id: 37608897-6603-4323-0dd7-08dbc17c6f4e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: deMffjStaXeC3JLxhQuB45WKjXnJY0TF6ORBDi18WEYzpttNRoMREJ7DjDJzvAdHIFPOZwNVmyI8jL4BBvmzQgcllS6JexchO1Y5Qz2mq1j3rtdS+AgSGYbL0Mf01crFLyj1+5U2H0ObA7IOz4/kCspfY5K9xv9PUAM0EVWSAzS4QPYI9/UKoTCPkE+FhXU+3valE/excHyOcCTgZqsx8MnU8lC60FDGrHQTH+weu3cH5DyoVhNx1zp0AIMtbpYy9njJrQrq0Ujny3UePDc7q2FNyNAlVX2mfO8ixuM6aUz0LAMLMnpbd88eXVWXaX4twmj4WOYP2S9E3mkpuoT+OFj5QXtHFN1NJV6kv/4uegtUGLK8Dz8oQZACxrZdG/kwQ1v4RyVeuvCeeqwuLVSKyNcXrSNT5OqdhH/W9ejkNAU8ELmvU5R5zuhp5avujTpn6LlSmlvz5mtwSWs0mwCsXwhPQfRmH0V7ROf2cwOG/KCMj39nOXj64lJs1dno4UXXQDpyKCdzIx9vdDPchbRZovuaNiH/LIqHzo4kFGCY0jgEtt+lNwY/qqovTCx72N/KZhAfwlwOArfI5osa/Rzv1NMU+aj1k0CDoRiFmBcOvxnH7b2NGN4G70Jg9YcK9KWvw8H2g49XJx/qzolsM6UQ8A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2158.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366004)(396003)(346002)(39860400002)(136003)(376002)(230922051799003)(186009)(1800799009)(64100799003)(451199024)(66476007)(66556008)(316002)(66946007)(2616005)(6512007)(83380400001)(36756003)(6506007)(53546011)(6666004)(86362001)(31696002)(38100700002)(6486002)(478600001)(2906002)(31686004)(41300700001)(8676002)(8936002)(5660300002)(44832011)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UHpzTy9SQUR2V1BrcWVnc2FpMFFRMHlxZWM5YVlkTStDREgxNHVKQkY1TWps?= =?utf-8?B?V3MyL3NUMnlDM0x5bEdLc2QwVkltR2dPeFBvalRvTnFsSGw4M0FzV1BqMVlQ?= =?utf-8?B?QWR6TFVLUmo2T2E0U09ESXVkNm9jb3RLdGFkd0dIUmx2MHJvczN1aEZCWUxH?= =?utf-8?B?azBoWmYwclNrZFE1YUVNeE1wcmk2T2RwK3pJc1R3VjFUZ3dyMWloM0M0c3lX?= =?utf-8?B?UTBMa3JhaG8zcU55SjAwVzdhN2pLdjdrV1VLa1RQR2xOVUNkRkJjRlE5dmZU?= =?utf-8?B?dEJjN3hWM3E0c2tQaVR2cGxQZksxc0JOS1BYWkVlM0djK1BNYjlVTmRtL1FJ?= =?utf-8?B?d0FHRm52VGVXTEo4MmZueHU2M3grMjdLdFlFSlNMY255Y0h0NUpnd0RtQVlq?= =?utf-8?B?TTkwYUJSdlk4MVF4emtkMU5jcE91cTRWVEF0MHNyb3FJdDhuVnRvY3RWTWRU?= =?utf-8?B?a2lmcHMwTjNNZm04S3FKb0ZCSi8xR1pwSUZyRjVSZEhlcHltRERZVHZtS3Jt?= =?utf-8?B?MzZ1N1c1eUlnV0ZoblNtSzc3RFN5eU9yUktjaEFtU0xQMXEwQml0T2RUclBW?= =?utf-8?B?RDdaUzJMbk5Zei9Lb1UzUHVPUDVHOTExc2FjNjhwcUtTTVNSbnBzODlmWkwr?= =?utf-8?B?R3ZXelZXVVhVRCs1djlmbW41L0NuaGFyczY2cWZpdkE5a0JIekk3dDluclQ4?= =?utf-8?B?NjBMZFdvckdVWDFUODBONDN1WUJaZGFaTEdNdVpBNGlLRUl0biszbnhTL0lF?= =?utf-8?B?NzlKL2JFNTNwVldkT2R5cmllTTRvREdTYlI5SHRxc0t3QXhOWHorTmdKUFFu?= =?utf-8?B?dDFSK2dkcDUwU0JvUnREVTZrdUtJcHZOV2hZUTlrQmJVY1dkeXZ4NlA5NGti?= =?utf-8?B?RkVjOG4xWno0MUVZdkZnRkEra3pnRVV1aWFEZjZYdG50UStLeS93YXR0QVBQ?= =?utf-8?B?d3pDMUtDR3hGdHRKZ0NuNkZGcXgyek5ITXNKNFhpeThhcWFuRHJYVzRRbzNv?= =?utf-8?B?U0pDZndIejZwSmhwVEhYTFl5d3hvVVN6Mk9EUnY0UEtCNktLN3VBSjNRVkd1?= =?utf-8?B?aXBtV1JYSTNSdjhLWkVYZ29OZnVqRXVndDY1T2xrc3FTUTdOZXVPRjlJbHFW?= =?utf-8?B?NlhVbFAzTlhzdWpuVVJiQ21LZnpDYmppbnhBVHRMSG9BMSt1aCtqVTdTSC9M?= =?utf-8?B?R3Y2Mm1uWWgyeXRpemRYUUhzdUswaFBjd0c0a0N3RTJRM2llUVEvaEZ6NlIx?= =?utf-8?B?NlFOaXcrWjZpMzFvemk0cVJ2MDZiTjFEV01scHdsS3g5ejNaUTlVOWFBUEZD?= =?utf-8?B?SHY2eUkrOVN5WldIc1IwS2FaS2JrZTlQOWd3N2pCUU9LdGM4ZzZ1Q3czNnpp?= =?utf-8?B?d3lJc29iNFpiaWZ2SUgrYm14eENmZjFNWVZIWWpMOC84YURLRlBoS3pyQXZF?= =?utf-8?B?L09mREdlZTlzRGdCTXovcTh2UlpXOUsxaU1uVnE5cktmaFJBYzNMWjh1OVZw?= =?utf-8?B?M0Q2ajY0a2Z6VTdIQXBJeTdtMmdvK1VyWXA3SytZTTBoSGtqRVJ2dFArR3dG?= =?utf-8?B?cHVMdWp4U0U5enJJSjh4YkhteDh0NHdRcm5TcGluNy9tMXRKL3hNYkRPNnVU?= =?utf-8?B?aFE1MmdkYWNYcWtyQzMxZjhpSWNQMDQwZ0ZqL2dMdFk2TjZ1UTJxVnVKMFFn?= =?utf-8?B?L1A0c2lHSGd2a2FERnN3WlBnWkVzclVMbDBQY1R2Y3J2Q3RvM2s1YjdNWVRa?= =?utf-8?B?RFN5MVdXcnVqdkNRd3krYVU0NUdQM2tPRTBWNmgvRG51TUcxdzBzc25ONVVP?= =?utf-8?B?eVA2NUNQZEdPanZJWHl4SmQrcXJ1RnBmcnFLKzBVQmlJbEpydWhHYVQvODJz?= =?utf-8?B?NWlMaEdjYzJRVTRuakhwczZLcWx1Y3ZreVJuZk9RSitsT28wWGg5RlNjcnFq?= =?utf-8?B?a0FQbnp4N3cxQktzM3hwU3ZYWHV1SkVKdXZhT0xzajVDbW9TaTNFUlRGdmd2?= =?utf-8?B?cFk2R3d0T1NiTGptejB1Snd2UUtYMHBtaThUK2liR1ZXbnVsLzVvMkRQRjZ2?= =?utf-8?B?RGs0VzNIa0ZvTitkOGFVaXZRM1lzT1htTU9WREhucm1ackd6d1pYQ0RIWWNM?= =?utf-8?B?RlFkZ3VKWmxhVVo5QWVkd01ZcVJOLzBNVDJqVTNRRWJ4bjF5K1RhUzE1RlY4?= =?utf-8?Q?B4OKU4BVVXqIuCVf1mTrYKI=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: kjd9pPsdT2xd9OXYLJWANLN6dX3OAqQH+v2U+R7A3e57DlKwABwn0uFN9IRKZ4SGZ5Hkq8yGLmccZ7HINtFHAsMHR7dIliEr5iPGek2Vpqh+XRtvwh4FUjWMK86Jf6XO9Shcc0U9GDnV4k0k161k91sndQKfS5dt6z5z80b1KXoX8eaOSjQNzQdEFse0O6pQWAGYcxwPWBiMT7P+2iY+cgNQtjjCtVEkhMqXjuFsCZ/6eAYe65tmgKKnxdtVQYN5Nt1aJsV/5aAD+DH2YyV2KxlZZ++5+6hGuuzCjWJIDRV42LSThnc8/6bkSMJ3N7Zx247otbubevetzXYnaxDGaRgl806hqTNlC7IEywBCMGNBjYrHU6Cdqg9ebSVmun6Acvv63jIVcqq0UzAF6kbgihKarNUboSreqeNGJq4cvNnnsF8N18WkfjkLpL7uGpJoTquGu0rxOGQ9PGutmLlfXZNjPVd7yNdP2J/aB96l53SBpLUn7EYb8gYPJ8AXR91z8VLFHGQEx1w2CtPWjlUeDn+wA5vTOOVa5hn/AXLwpvzMNFYRe9Ob6qzFfEw4s2l/S9ALdVLKHcRcTWUItHhtKnmUD9uxuKk4vDzptvklOlnvkeK+A1iDPtb6IQH7Xq0MWry+ReWwSxz37RRxf3CHZTQl/qQMwKJ8HP++g0hXVqQ4K2nXRBypxsp48iZvF4TeMIlJ0jSuIrBjtd3cfWuQjtpAPUxGcRqZUdTPOrTg+IWE81rIQr1hFagSUMfFVLWti14N7M9IlOKOlBlrY7V/AFcaOy4ScaDM9wpyFca+xak= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 37608897-6603-4323-0dd7-08dbc17c6f4e X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2158.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2023 06:13:59.2011 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2oBwmrFe4x1qc2lfTqji19XYTm1jdCwleeKQfJZ5rjy4pxadg60QBSXyfA9B1AxmClZ6s58gMZpDOsMELeqOYQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB7100 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-09-30_04,2023-09-28_03,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 malwarescore=0 adultscore=0 suspectscore=0 mlxlogscore=999 bulkscore=0 mlxscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2309180000 definitions=main-2309300050 X-Proofpoint-GUID: fsBGv-Bg8JLEOxC2t65rfOl__e4aqh0B X-Proofpoint-ORIG-GUID: fsBGv-Bg8JLEOxC2t65rfOl__e4aqh0B X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 9/28/23 07:04, Nick Clifton wrote: > Hi Indu, > >> When the command line option --scfi (default is --scfi=all) is passed to >> the GNU assembler, it will synthesize DWARF call frame information (CFI) >> for the assembly. > >> Also document the option. > > Please could you also add an entry in the gas/NEWS file about this new > feature. > OK. >> +# ifdef TARGET_USE_SCFI >> +  fprintf (stream, _("\ >> +  --scfi=[all,none]      synthesize DWARF CFI for hand-written asm >> (not inline)\n\ >> +              (default --scfi=all)\n")); >> +# endif > > I was wondering how the code would detect inline assembler. > Presumably it looks for the #NOAPP preprocessor directive ? Yes. > Or is the point of the comment in the above delta that the > user should not use this new option in conjunction with actual > compiled code ?  Either way I think that you need to extend > the documentation to include describing what happens when > compiled code and this option are used together. > The intent was to convey to user that they must use: --scfi=all for hand-written asm, --scfi=inline if they have functions with inline asm. I agree this is not currently reflected clearly in documentation. I will update it. If --scfi=all is used for inline asm, this means SCFI machinery is being fed the compiler generated assembly. When --scfi=all is specified, most of the existing CFI directives are ignored. Now, with using --scfi=all for inline asm, there is risk that SCFI machinery is not able to generate CFI, as compiler generated code may be "too complex" for SCFI to handle (like indirect jumps, jump table, DRAP register to realign stack etc, ...), and no CFI is synthesized (and the compiler generated CFI for the compiler generated asm also gets thrown away). Hence the recommendation to use --scfi=inline for inline asm, where the assembler will not ignore the already existing CFI and will only generate CFI for the inline asm stubs. > Also - I have not checked this yet - if this option is enabled > and no CFI statements are generated (or maybe if an incomplete > sequence is generated) - presumably because of badly written > code - will there be an error message generated ? > Yes, I intend to cover all cases where SCFI fails to synthesize CFI and issue an appropriate warning/error to user for each function. Thanks Indu