From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from isrv.corpit.ru (isrv.corpit.ru [86.62.121.231]) by sourceware.org (Postfix) with ESMTPS id 0403A385696E for ; Mon, 31 Oct 2022 09:24:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0403A385696E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tls.msk.ru Authentication-Results: sourceware.org; spf=none smtp.mailfrom=tls.msk.ru Received: from tsrv.corpit.ru (tsrv.tls.msk.ru [192.168.177.2]) by isrv.corpit.ru (Postfix) with ESMTP id 8DC45403EE; Mon, 31 Oct 2022 12:24:22 +0300 (MSK) Received: from [192.168.177.130] (mjt.wg.tls.msk.ru [192.168.177.130]) by tsrv.corpit.ru (Postfix) with ESMTP id 777AD13A; Mon, 31 Oct 2022 12:24:26 +0300 (MSK) Message-ID: <21691094-d184-2eef-8bcc-7eb6d355d7e8@msgid.tls.msk.ru> Date: Mon, 31 Oct 2022 12:24:21 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: Fix small objcopy memory leak Content-Language: en-US To: Alan Modra , binutils@sourceware.org References: From: Michael Tokarev In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.2 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,NICE_REPLY_A,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: 29.10.2022 07:52, Alan Modra via Binutils wrote: > * objcopy.c (copy_archive): Free l->name. > > diff --git a/binutils/objcopy.c b/binutils/objcopy.c > index d20aaef9f4f..03350babb69 100644 > --- a/binutils/objcopy.c > +++ b/binutils/objcopy.c > @@ -3744,6 +3744,7 @@ copy_archive (bfd *ibfd, bfd *obfd, const char *output_target, > bfd_close (l->obfd); > unlink (l->name); > } > + free ((char *) l->name); btw, why you cast it to char* ? Thanks, /mjt