From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id C5D213858D35 for ; Thu, 29 Jun 2023 06:42:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C5D213858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0333520.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 35T6Ith5005234; Thu, 29 Jun 2023 06:42:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2023-03-30; bh=0pTEPTjYgmrp4ac5sSFFK7cp7HGcaPR5kmCVOrkcNb8=; b=bqrCSh/D0m81XsBo3ff1pIy+S/hDaRQm0G7m7KE7FMCLw9M6YTzUyWDXy2v3VK7tycNp I8rpuGnHfa50rZCeGv9NEaGw2eNd7hGpIVisUc/3yFVbmf1km4japdl0OJP4cfkl/0VV tHQTA6CwDbEHeRiD19l4aSIZXNgh4VQIIfoBwOZuuN9MUh+/Up1rN+PVFFqLJ8S++2A/ a1XsSZUJ6EvsYfkRC1IUOYi6EMsQEJc2kVs248D/x32QgOikoaQorNX5eflp24TgG24q aUv6BCwMzNzmEgTUrPtpNtpZz2adqtiZl19YmCq1t/WhKj5GDJlgN1dAW0qPvBWlA0BP Tw== Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3rdrhctyme-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 29 Jun 2023 06:42:00 +0000 Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 35T4WClc013186; Thu, 29 Jun 2023 06:41:59 GMT Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2101.outbound.protection.outlook.com [104.47.70.101]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3rdpx78m46-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 29 Jun 2023 06:41:59 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XwAt+PB7EeqLRCf5MTme45aV3kL5EDe9T+fw+YjFnRe4qpWG/DrC4zYju0xjDO3mHeoGRUfGQHYNjSm2vJTcN9M59n8efE6krgdv7TZlU1NTxaCgy2EU1TkOi4OpKhattuJ92s4oSwSg+vBCJrsKkK+5G2+R9GLWdYEaGkxjLQCjGhmoJuGmxX+4qw8K/aYolmWWKUCCn3jvI2cpcRhOeyQobJXze7CoHz2NHCxlyPyy8krspPWPG8DCG95EKcbgfryMDXJQ6cVZgRE/MCNk7uZH7psDj4w71BGM2nLDOfVzHHtSM6mSiP09HeOzl50W7RdH6C4wUXGJOfziVnHZUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0pTEPTjYgmrp4ac5sSFFK7cp7HGcaPR5kmCVOrkcNb8=; b=dxM9CmbunRDgPgROVK4CTQG2520Cx4wfQ+TUrsUpUZ462Vdt+VNcoChpqyAcGE7b/cogImiJEjgM1tam4TVeRh6kXOiAoTqmgwE9jnN6CkR/WCJu+x2GPyRQrupPIyNCkEpi2p76JPumyArjW5d9hfWTwfWl//xGtCuWUfnEYMER8UUrrEdTYdylxiefJa1lPL395IOeHaH2tmKty8ukXQsg0mMvnEmx0782LyD5OzALR9GFfZ++KGGd0G7O5n2/m6Sd8sDcsjHnqBa9vjlYr7oi1fxt4/+lbbEjIlJCNMwubr6nBSvJfSIzz8BdKUtLV0CmTFrxe5s0XW4U+mT8mA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0pTEPTjYgmrp4ac5sSFFK7cp7HGcaPR5kmCVOrkcNb8=; b=Hh09dx2Ttmrh8xdhCGoNONhyHGNDQwqWdTdTvWj2wOf10waEtclALqYknf2vnToN/AEaTGbRqjGpWoinUcF1Dcuu/PQLQ8FnDsAHIIdG1LiSU/RGQq5aWcs+eeVCqN9E3cWONpklrc1Snkel1e6syEnIZZWoswVTa2hOOQ1GAzI= Received: from MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) by BN0PR10MB5334.namprd10.prod.outlook.com (2603:10b6:408:12f::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.15; Thu, 29 Jun 2023 06:41:57 +0000 Received: from MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::fdbb:b921:1ef:2d44]) by MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::fdbb:b921:1ef:2d44%4]) with mapi id 15.20.6521.026; Thu, 29 Jun 2023 06:41:57 +0000 Message-ID: <218128be-4db7-95c5-b3a5-c3bb30b13fad@oracle.com> Date: Wed, 28 Jun 2023 23:41:54 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 09/12] objdump/readelf: adjust for SFRAME_VERSION_2 Content-Language: en-US To: Hans-Peter Nilsson Cc: binutils@sourceware.org References: <20230627212028.2138604-1-indu.bhagat@oracle.com> <20230627212028.2138604-10-indu.bhagat@oracle.com> From: Indu Bhagat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MW4PR02CA0019.namprd02.prod.outlook.com (2603:10b6:303:16d::23) To MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2158:EE_|BN0PR10MB5334:EE_ X-MS-Office365-Filtering-Correlation-Id: dab3fa04-4a3d-4ea3-5c67-08db786bef01 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Pbjwt20EYuJD9SN4xw2DHndc3JVR6UwFoZbAEv0xPo3WahMKuxaCpJOSHVgKs3aLQceSvNrYc6B1LD8CbHb/GZlWB4enfO4SEcBh0VQ8g1JOfVrfxcAP8fU9SURdSKRu0uP0K0InfQjxHxZP+i0lktukjyinYU4KP24wo6kB4Wyb5aFKg564/OC2GSMe32VZwTX6rHuvGPY9269PJDap9CVF5BzbTMEKNmy0XZ4JGr7q6IfSX7IpcyKYlm8LiNoOTDwpmkYQji+5+u80zFc/eM8NDdPSDldWT8Int7u6z3L/vXPOj34KppJPredclPOePkw5eFq9nGsEhRyCltfzE7T33Vpe+BxTwifqDvJxCBmDfd63j6x36et1GZNz4gsOin0cVuEFrHbvqGYPcuFFxzbSdH6TBndV3xinH2NZ4iYZjvLOvV05UPUi/01LPin4j1dW+EztY5KPethE2IYiamuqUeIYWFsg3A8Xy8u2GAvRTBe4u5i8dwXPoZH+OkSWG5stOJckptOFVwoH7j2bZ80z0b6DE2G64p8cgkc52scDkhY9Q7RtwpieXcXCp+4az83qrSoCcs+WIU1CwV9lbXRGIa9pLK4GvSb4++jhjS9z7sKl8ct2lwOIqsWe5k+8aq3xVfDc4piVj9eg6/UIbA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2158.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(39860400002)(346002)(396003)(136003)(376002)(451199021)(44832011)(5660300002)(66476007)(66556008)(6916009)(66946007)(316002)(2906002)(36756003)(31686004)(4326008)(66899021)(8676002)(8936002)(478600001)(6512007)(41300700001)(86362001)(31696002)(38100700002)(6486002)(186003)(6506007)(26005)(53546011)(6666004)(83380400001)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OCt6bHhHaCtlMzB5TEt5LzVubVRRVFFRNU5XWjZhL3Rna0dlaGJZandTQnkz?= =?utf-8?B?bTVGT2pPVUx6Umdoa3d1YnZ1LzhDUjJYaTludEJRa0Q3cWZuRDNCYThwcEly?= =?utf-8?B?SnF6WUg4YlpTa0UxMThSZERHMk1rRlpJQzRwNE0yVTBtT05wTG9LaVJEVFQ4?= =?utf-8?B?RWJVdHZtTVFYd2M3OHZoVitSWmpONW9QeGgwdE1sRzZGWTBtK3lsWXZSYVNx?= =?utf-8?B?c25jSkF0UUo2MjZoWVZodWVXbVBISXBHWHFRZUx0OGdadlVFeTZpWFhLTmRu?= =?utf-8?B?SlRmSW9ITVBmWFNnUlZlenRKYUo2YldoT3h0cVZ2NkhXdnhoSGZ1Wi9HQTEv?= =?utf-8?B?UmhmTjhDTmFVUHFwWG9QVXF5cFVoZkk0STYxQXc3NkV6NzVkVm1pdCtpblQw?= =?utf-8?B?WkorWVBuOVpFeGQ5V0xJeWJkVHNRbHJBYnlMaHdGSktuREdKM21RYnBiL2ZO?= =?utf-8?B?dmhIV3kvdDVSeUJmVnhtWW9XaFBOVFhqdFRCa1hwRU5XR29Ua3NjdVFKd3RW?= =?utf-8?B?V3ZxZzB3ZzFIbXpLVDZLVXdQc2R5aEw0VjdiUlBialpaZE5FblJQVkNFOUFH?= =?utf-8?B?Unh5SWxEODJ6ckFLUnVYaXNjNUNHTFlRaDNRNXR6MmZxN0tTUk1kd3d2MU0y?= =?utf-8?B?ZUVicWVuc2lIbjRCWmtoTDJYWGNJbDdISU84NFE4R21KejA1UWhGUWhLcDN4?= =?utf-8?B?Q1VtdnJFZVRWblgyQXZCR0xzOHIzYk9Ua3QzYzd1QlJOQjk1cEFDenZyRFlI?= =?utf-8?B?cFVnM3FYVVZURGVpVlNaMXJzM3MrTS9MZ2c2M09PQXdHSEx6dENRRUR2YTBw?= =?utf-8?B?aTZLNjlsWUdFWUhaVE9UMFVQVFlmVjV2VlNrWUQzUXFveHBjVnJsWlJvamVn?= =?utf-8?B?RkZXWHBpYi9MU1RSOFNpOFhDRkhnRlEwc1lTUk1jVDYxMEhYQk5pMFdBVHhV?= =?utf-8?B?NXlLK2c5eCtMRVlQM3VzUloyOVF0dWFsOE5GNEVDT2tuaHFkUS9lV3orR0dE?= =?utf-8?B?ZUJSZjQxUHJ3RUZHbjdRSHBDeXJHQzE3VktFelV3TEFJUnZaRzhCeDZkMCt4?= =?utf-8?B?M3pJYTN4SnhMUG00RTJjdTg4dTRpZ0VxWHJXY0dKRVRITkNFWHUrRHRkMzNC?= =?utf-8?B?QkZ0Ty9yMTh0aFBEdjZ5ajlxQ0VwZGVrU09pZ20xK1d1cUlkMzU4MUJ6ZWZC?= =?utf-8?B?V2lrWWNDMGUwSjk5cllCTy9xbmkxZGtGYmlzVk9WazBrd3NQakNDM0h1M0VC?= =?utf-8?B?TUltTU9RRzVHbWdjenlPczgzTDdkdjNnSFpQTGo3cGNmU25yK0NvdHNodzdo?= =?utf-8?B?NTZ2dDZkRGdpekRWUjBja1hFaDlBK0F1NkNYa2lXR2tHRWJxK01ISGw4SVQ0?= =?utf-8?B?WUdmSFBrWXNOYTFjcjJSWVkvNGdRTEtsVDRQeHlETk94M3hoWndRVVp0RW04?= =?utf-8?B?VnhDN01zNzhPdmdPbGdqVml4UzlqZkhyYUlHWGEycnpjTk9WcjlsdTBHb0gy?= =?utf-8?B?QmVoaGJUbkpNMjJuZHRkL0QzNWJra2JwbzNDclRHZzF6RTNsMEx3V0RLeE1s?= =?utf-8?B?M1luRC96NERJZnZjTlVzVnppWkYyM0IvbFE2bkd0NUxKUTFYMkhObkJSUlNv?= =?utf-8?B?Zks1RVBvSGxnVENzNnl2dExmOWp0MTh2M0FnV3Qrc01pNDRKRTAzTWxvazUy?= =?utf-8?B?ZE1teVpOaHNIYzlCOHVWTFQrWFBkN3RFQjhMWTBwVWIyUFFpN01SeWMwMUM5?= =?utf-8?B?UDVjM0JrRjMwODhiQ3g5dmszYXNzV2NVcGZYSS9PUDJIS2RPV01QOUpyZ0Fy?= =?utf-8?B?aHQ5a1ZmUU1rT2N4MkZPL2plUHFTbFJrWE9QdndGRXBGeW9Ndmd5d0R0NEZn?= =?utf-8?B?STFmcEgyUmlGR1dhWGZVWkZlWkoxUTRZSWpHZzVZaTFmL1VuYXFEaVQwY09o?= =?utf-8?B?WlEyK3VEb2grTUlpOXlHUmxoeVp1RDRjTExHMVR0TE51QlNXYUo1Q1F6ajRm?= =?utf-8?B?dE45TXZMa1duWFUxK0RTR2ZBOExlS1hWN3B5MUNDV1FMc2hmV05ldGNteTl0?= =?utf-8?B?MG1GZ0U2cU5YMllsK0IvWlo4UlRuT2w2NlFNZ2JCLzNiTGg5ZUdFZ0xiRi8x?= =?utf-8?Q?sF/FZLf5c4K4mFFQM7aAyQTM+?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: lY1FyGF8pLyCEdfSbXvPLHGxB9u9YL86erLXcWUhTgiCgeVDawLyBI5lIxt4fRqJtlx6gL2wN8zgv20tW8vWgI4mM2cKjRp/RIk2dR6eYAujrlJpSEzG2m3kp8TTyMdmldL8yPUv+cZxNFI3QSAzEKSdcpttn3roTKC1n6T+JfGIZfQ+pyEPrvn6vPnLXqEewgf+GmXKMVcvtq/T7FoggM7UyXovEtP17czvMkQtZGuqAPgRXi9BY3a5jl3r5EMYiC+eLtQtRRFwxWJoNwLQUWCm1zXQT4CnpZPlHYQvIYGuJj0X17Y616vEPc1Bf+IZag4yfbYLkm6kjLPQP8SkHFpdtm0d1YVv4o8cW8dcDJRyMs5SJJXzjDOtZR1MnfZO0RU/1ietvF7roJ0N0Gb7uvqqXyE9waDMAjrfmymIn6bUZbIIfg74vShrjVgbAruMOESJaEY+1l0QqmTe2ibhc8t9jNm03fCo3PtTJ+96uYbPo0H42p2oes6s0c9d5DFXWk2paJ+rbp6wOQ2TtSzqVvnn3Ysq8lMcrYAeliScVnhqEJmkVv9BH5ugM8i3/VS/++RWzgybc9HUNSSVSiYgSnf1vM9+K9QQAJXDo7CNUXK207g4BboxkNYt2pTeAhOt/AyTbA3+4nS2GRxN/o5jAZoSJ5V/3lAQ8reI+lNq0CIODKHfBV77uqO1GOeQZvmoaGycMJXNa4uBVMFewKS+0u1KbOtrky3KaAfes+oo2eg+QBTWpzSL9HfFXHbAFDYvaHJFMf7jua7dpJsuhJ5LngnA/+XwHPJgIXNw7ZdN78Q= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: dab3fa04-4a3d-4ea3-5c67-08db786bef01 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2158.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jun 2023 06:41:57.1725 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: uBZC1f++WtA/GxJu14L8laVl1DmNNC7VigN6ElpMSRHF0b9O16nPX7GY5iNGd5KvGKoD7AlpxPnfysB0OPSzXQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR10MB5334 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-06-28_14,2023-06-27_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 adultscore=0 bulkscore=0 suspectscore=0 mlxscore=0 phishscore=0 malwarescore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2306290058 X-Proofpoint-GUID: j3Ksn3Jv6B_kDxHDJ5deQKAwtvQWfRB5 X-Proofpoint-ORIG-GUID: j3Ksn3Jv6B_kDxHDJ5deQKAwtvQWfRB5 X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_NUMSUBJECT,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 6/28/23 16:04, Hans-Peter Nilsson wrote: > On Tue, 27 Jun 2023, Indu Bhagat via Binutils wrote: >> Make adjustments to account for a new format version and its name. >> Also shuffle some code to make it more readable and use the available >> APIs rather than direct access. >> >> objdump/readelf will show the following message to the user if .sframe >> section in SFRAME_VERSION_1 format is seen: >> >> "No further information can be displayed. SFrame version not >> supported." >> >> In other words, like the rest of the binutils, only the current SFrame >> format version, i.e., SFRAME_VERSION_2 is supported by the textual dump >> facilities. > > A decision that IMHO is counter to binutils philosophy (AFAIU), > unless version 1 is actually generated by nobody nowhere. > > If there are object files out there generated with version 1, > support should be kept, at the very least for inspection tools. > SFrame Version 1 format definition had issues related to unaligned accesses. In most cases of when there are version 1 .sframe sections out there, those applications should ideally be rebuilt to switch to using SFRAME_VERSION_2. When other assemblers and linkers begin to add support for SFrame format, SFRAME_VERSION_2 should be used as it is the latest - there is little incentive to implement SFRAME_VERSION_1 there. The trouble with supporting both SFRAME_VERSION_1 and SFRAME_VERSION_2 in readelf/objdump is that the abstraction sframe_func_desc_entry used in libsframe is the same as the binary representation defined in include/sframe.h. This means that to support two versions of SFrame FDE, libsframe will need to revisit some of its APIs and will be a bit of rejig. I tried to do some of this, but it looked very clunky to me. The choice to keep libsframe's internal representation for SFrame FDE to be the same as the on-disk representation has the advantage that an unwinder does not need to do any copy operations at run time. It could simply read the SFrame FDE from memory. Thanks Indu