From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id CADFF3858C53 for ; Wed, 13 Apr 2022 16:32:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CADFF3858C53 Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-633-NDwmQu99PJerBM-sXv-BuQ-1; Wed, 13 Apr 2022 12:32:54 -0400 X-MC-Unique: NDwmQu99PJerBM-sXv-BuQ-1 Received: by mail-wm1-f72.google.com with SMTP id v191-20020a1cacc8000000b0038ce818d2efso1110911wme.1 for ; Wed, 13 Apr 2022 09:32:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=VKWhzMtoruNcEqZGnuA8szIVBfqJBD+G37BuLuZCLp4=; b=pMu9DGSeiTi521YNerBFPNKTaga+xRAn6kKLuTdrvwld4WwgDZkLmZLehZzY3y+Rv3 PJYnPRx9Y/DsdMxDBaioIKUjjwPVqjqGG25IOl8lcpKX0OrIEVuH4VuhO+A3o04Y+GS5 aSFQ08i9a6sm4RmsnxltsNIYCDU7zTOxAwUEZTu7y2+3Mrm8fF9sZHrMWViOSaMZLYsA kkvgDWaUUz6NXgeqfTOYvminwpOh3cAIwZpvsoX1qmH2+fcopGyRYXMfL32Gezuraumg 4GStyyzD8h8y2MoMFgN6DSeJ6VPHSR9WjHwtmm85ve0ZM4DFow+b8tk7ly2BykowVQsj hHcg== X-Gm-Message-State: AOAM53384DQzXwkQmrAwanzsDE8IbuAaSNFBy6DfzHWtjIwA+zKzfr98 uAnbLXJqJrb4BpTwyGGI9wqDijlHOAu83eaxxZxfvmEo7/DC+soLTRHssKo7g23HGlxqcKp7WSp MeQAYA3qjFmfgfqDTig== X-Received: by 2002:adf:eb4d:0:b0:1ed:c1f7:a951 with SMTP id u13-20020adfeb4d000000b001edc1f7a951mr32897889wrn.454.1649867573364; Wed, 13 Apr 2022 09:32:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwfh1UTBF9ajRytVMDdaexGH1hHk/SfD+3FUj64R259nFGWT7Pa8IWkyWqh6G56pR68U2O33g== X-Received: by 2002:adf:eb4d:0:b0:1ed:c1f7:a951 with SMTP id u13-20020adfeb4d000000b001edc1f7a951mr32897877wrn.454.1649867573199; Wed, 13 Apr 2022 09:32:53 -0700 (PDT) Received: from [192.168.1.6] (adsl-2-solo-173-39.claranet.co.uk. [80.168.173.39]) by smtp.gmail.com with ESMTPSA id 7-20020adf8287000000b00207a864fbb5sm7630840wrc.103.2022.04.13.09.32.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Apr 2022 09:32:52 -0700 (PDT) Message-ID: <21cd3a89-945b-25b6-fc14-1b9120ab2057@redhat.com> Date: Wed, 13 Apr 2022 17:32:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 2/2] xcoff: implement linker relaxation To: "CHIGOT, CLEMENT" , "binutils@sourceware.org" Cc: "pro@helflym.eu" , Kavana N Bhat , Ayappan P2 References: From: Nick Clifton In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Apr 2022 16:32:57 -0000 Hi Clement, This patch generates a compile time error (using gcc 11.2.1): bfd/xcofflink.c: In function 'xcoff_stub_get_csect_in_range': bfd/xcofflink.c:4332:20: error: 'sprintf' may write a terminating nul past the end of the destination [-Werror=format-overflow=] 4332 | sprintf (buf, "%d", n); | ^ bfd/xcofflink.c:4332:3: note: 'sprintf' output between 2 and 7 bytes into a destination of size 6 4332 | sprintf (buf, "%d", n); | ^~~~~~~~~~~~~~~~~~~~~~ I suggest increasing the size of "buf" to at least 8. In addition if you are feeling paranoid, you could use snprintf instead of sprintf. Other than that though the patch looks good to me, so approved, once that above problem has been fixed. Cheers Nick