From: msnyder@sonic.net
To: binutils@sourceware.org
Subject: [patch] coff-i386, guard against null
Date: Thu, 26 Jul 2007 00:54:00 -0000 [thread overview]
Message-ID: <22002.12.7.175.2.1185409273.squirrel@webmail.sonic.net> (raw)
[-- Attachment #1: Type: text/plain, Size: 90 bytes --]
Other code in this function checks to see if sym is null.
If it's null here, it'll fail.
[-- Attachment #2: howto.txt --]
[-- Type: text/plain, Size: 821 bytes --]
2007-07-25 Michael Snyder <msnyder@access-company.com>
* coff-i386.c (coff_i386_rtype_to_howto): Guard against null.
Index: coff-i386.c
===================================================================
RCS file: /cvs/src/src/bfd/coff-i386.c,v
retrieving revision 1.26
diff -p -r1.26 coff-i386.c
*** coff-i386.c 3 Jul 2007 14:26:39 -0000 1.26
--- coff-i386.c 26 Jul 2007 00:18:04 -0000
*************** coff_i386_rtype_to_howto (abfd, sec, rel
*** 518,524 ****
*addendp -= pe_data(sec->output_section->owner)->pe_opthdr.ImageBase;
}
! if (rel->r_type == R_SECREL32)
{
bfd_vma osect_vma;
--- 518,524 ----
*addendp -= pe_data(sec->output_section->owner)->pe_opthdr.ImageBase;
}
! if (rel->r_type == R_SECREL32 && sym != NULL)
{
bfd_vma osect_vma;
next reply other threads:[~2007-07-26 0:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-26 0:54 msnyder [this message]
2007-07-26 2:20 ` H.J. Lu
2007-07-26 12:34 ` Daniel Jacobowitz
2007-07-26 13:46 ` H.J. Lu
2007-07-26 18:54 ` msnyder
2007-07-26 20:01 ` H.J. Lu
2007-07-26 23:52 ` msnyder
2007-07-27 1:04 ` H.J. Lu
2007-07-27 1:42 ` msnyder
2007-07-26 13:08 ` Alan Modra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22002.12.7.175.2.1185409273.squirrel@webmail.sonic.net \
--to=msnyder@sonic.net \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).