* [PATCH] aout_link_add_symbols, count == zero
@ 2007-07-27 22:04 msnyder
2007-08-01 7:14 ` Alan Modra
0 siblings, 1 reply; 3+ messages in thread
From: msnyder @ 2007-07-27 22:04 UTC (permalink / raw)
To: binutils
[-- Attachment #1: Type: text/plain, Size: 0 bytes --]
[-- Attachment #2: aoutx3.txt --]
[-- Type: text/plain, Size: 771 bytes --]
2007-07-27 Michael Snyder <msnyder@access-company.com>
* aoutx.h (aout_link_add_symbols): Return if count is zero.
Index: aoutx.h
===================================================================
RCS file: /cvs/src/src/bfd/aoutx.h,v
retrieving revision 1.68
diff -p -r1.68 aoutx.h
*** aoutx.h 27 Jul 2007 19:04:39 -0000 1.68
--- aoutx.h 27 Jul 2007 21:59:03 -0000
*************** aout_link_add_symbols (bfd *abfd, struct
*** 2951,2956 ****
--- 2951,2959 ----
return FALSE;
}
+ if (sym_count == 0)
+ return TRUE; /* Nothing to do. */
+
/* We keep a list of the linker hash table entries that correspond
to particular symbols. We could just look them up in the hash
table, but keeping the list is more efficient. Perhaps this
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] aout_link_add_symbols, count == zero
2007-07-27 22:04 [PATCH] aout_link_add_symbols, count == zero msnyder
@ 2007-08-01 7:14 ` Alan Modra
2007-08-01 19:59 ` msnyder
0 siblings, 1 reply; 3+ messages in thread
From: Alan Modra @ 2007-08-01 7:14 UTC (permalink / raw)
To: msnyder; +Cc: binutils
On Fri, Jul 27, 2007 at 03:01:17PM -0700, msnyder@sonic.net wrote:
> * aoutx.h (aout_link_add_symbols): Return if count is zero.
OK. Please also remove "&& sym_count != 0" a few lines down.
--
Alan Modra
Australia Development Lab, IBM
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] aout_link_add_symbols, count == zero
2007-08-01 7:14 ` Alan Modra
@ 2007-08-01 19:59 ` msnyder
0 siblings, 0 replies; 3+ messages in thread
From: msnyder @ 2007-08-01 19:59 UTC (permalink / raw)
To: binutils
> On Fri, Jul 27, 2007 at 03:01:17PM -0700, msnyder@sonic.net wrote:
>> * aoutx.h (aout_link_add_symbols): Return if count is zero.
>
> OK. Please also remove "&& sym_count != 0" a few lines down.
Done and committed, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-08-01 19:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-07-27 22:04 [PATCH] aout_link_add_symbols, count == zero msnyder
2007-08-01 7:14 ` Alan Modra
2007-08-01 19:59 ` msnyder
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).