From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2055.outbound.protection.outlook.com [40.107.21.55]) by sourceware.org (Postfix) with ESMTPS id CCD8F385741D; Tue, 4 Oct 2022 09:07:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CCD8F385741D Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H+3ok5u+fUwkNWpwjcVN6RCMagg96/G7BcneS5RxAdPkmyTxzGLouE0YOXgczgRgBaJtbCnfbQu/hp7iBzPgFI6+Lhm2tpcktkpKjrXZ27DixT87hj1WB5nukWj4c6UPJomAuoWWN8qw8Zd4W0ZJi1YGiZLtkM43TpZjVM6ICdfoJxO50IYytPY8NiCJ8aGDNJVcS0c9wWdvLBaekLaKqmdgmUxz0Aq/2M63JYhS4rbZampRg5gtlhG891+nhqmzBPruX1Jwa6d+DZSH39AhBAkAmm389rDtRcJME/LuMbhs+2FuhIecpOzMq+SjOw9H7HrV1ZMDzGxmmHNd9riOHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LgEQLPJo9Vq80e0yUxW93GXe5ig3CQOREeCqtfIcDBU=; b=jJ3DcKIAPVIghXzdLssxxJ7pStyvxaRMSdsKc9oAaLwsdfpbSIIDH2D0GvjJJERu4IyOpJQLHLqNiKrAOu6rqJP576gU+G2ljeEUUc2Ji+LEr3WZTod5zWeo9W6Cq7KPMCz4r/3ZeDKn+IIN/6XZR4Z1LtAE9I3DbERVQl92N2v7trntiXbKGK0JBS/rTPxBFw8uLBWgQjVBbpeRv3NbQ5wW+b/Q8VEHvCUb74iIJpispZxuyeJ7srC+ts5DDqqOPQLhXVX9Uj/u8WWQGJD2lHmdVaY7OlL7QX8LIbkiHalkTg3VPEXdUUMjcw4gemVchOOoqpmdR0wkMimShMhQ1A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LgEQLPJo9Vq80e0yUxW93GXe5ig3CQOREeCqtfIcDBU=; b=EmyTlUpIKu7vA4OWluI+i6lTmA+1TGOQoi/6wp0ivUErHPJgl8mFkQUzXvnpQgeq4nBOEkIO01wKKfmIk1lI7idzcK1EaQFX1iRjuoXDWUTQkI8YixNX1jXk92nNDIqTiohGF/SGIKPuAnEVvj7ZgHUKpyPouyoOkt98Yjmx9qFVNE7JamrnkrSB6W3uIWEKaofnMaXctKjkNK5RXFXk/vss/Xc6KhJdpGnLC34OMutQ12wpfg3I6mWr/XZZmbUAczgkXVzm6HAl+6t5mtVOcyM86Tk4l1R3pWwJaPuTOJGQb0CxLfFpwiftyO9pm/Hvi0ceJ5dJJCIiaf06/2YMkQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VE1PR04MB7341.eurprd04.prod.outlook.com (2603:10a6:800:1a6::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.31; Tue, 4 Oct 2022 09:07:37 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.031; Tue, 4 Oct 2022 09:07:37 +0000 Message-ID: <227e9854-f0bf-566a-42ef-5f14a145c6dc@suse.com> Date: Tue, 4 Oct 2022 11:07:39 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH 0/2] RISC-V: Fix buffer overflow after long instruction support Content-Language: en-US To: Tsukasa OI Cc: binutils@sourceware.org, gdb-patches@sourceware.org, Nelson Chu , Kito Cheng , Palmer Dabbelt , Andrew Burgess References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0651.eurprd06.prod.outlook.com (2603:10a6:20b:46f::24) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|VE1PR04MB7341:EE_ X-MS-Office365-Filtering-Correlation-Id: 08f45a67-48b4-4474-5ccc-08daa5e7e221 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: r+SAKkGzwbSpGB08p+2m7VmcvSUsZY0CITAyeqdSpj3ngzMlpxAFqVbcDPG6n0xCtA9fVsfs5Bo2WvYQbjZtzh+W233g/q6GxA84n7DjMfArbj2Uk99C0Q61Il74NK0CsLNF6n0/tdH+pM5P0C/sr0kbJkcbsH3j4RLyaaAL4Sg0cLfww6NbGY3O3uvzma+y7wfzHk/Fb5UrnkR9+4c9xjpoPVNfz439y71sYc4sC75nuSuNd5c9rCpOl6NfUtpDB9FC+sMHQrPWixv0LLBzIz8vRcaVHzQvlJVTanlfH25kJzaRjRAHtS01OXQFc351uvCJ3iiYPHioGP71U9P7ER7Nll9nn8UXaXxsWQyR8ZC4yfAPCEh6WIXZHKwVbNWORoK0wdBuKvmJ3Uap7oT0Ra3aV3//SCST6qMJpFIk5LudIsLEslxEjtPX4DnfBupO+PgMXA+jlzan85QyqZtW8Wqn9A3CPHdfgdBUO5EBt+rh/cDkz/rzX4NXqGWF6qyjpPejDyxZkd5N1Jg9hkWvjCmh52YypfymuP5zySNVqJjdSrgGN/nM+ZikXepyI+0l7WFwi6Ym2bCZIeKtLulBpHmnBA2v6LdJqByQwe+mu5jnW5vRFQSJ0EuUH4p6+IPLASr1T0vZEp6cvwwq6NtCuonq1ypVzLrqEi5GBrcSgKFoZT6D1LdS3bips+hglcxYdkqMvwcFZ2/XlQMO0kIgoYjZjBgFX1NeG4pOn5GmuklOLLyflDfIp/GeAjfAtf1D0Od0x6hu10PWLzJh6jXc/8t5cehJsmfB8Visb0nB+PY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(396003)(376002)(136003)(39850400004)(346002)(451199015)(83380400001)(86362001)(31696002)(38100700002)(186003)(8936002)(6916009)(5660300002)(41300700001)(54906003)(8676002)(66946007)(66556008)(66476007)(4326008)(53546011)(26005)(6512007)(6506007)(2616005)(316002)(2906002)(478600001)(6486002)(31686004)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z0xzdXFHRkxoZE9TWW5qOFhXUUUvMnZLZzMyNlkydUVpa3RWRENjZ0hPeGhr?= =?utf-8?B?bGJUN1I4SzgrV1Q4WHdCSFcxS3llN01EUVdqMUZsRGYvRE1HZFVjUS9PS1Va?= =?utf-8?B?M2pRdnJnMWF6UGl6bnU3THdUTVFZcCt4cyt2Q0xhWlRvNzFRSmEya0UvR0Yz?= =?utf-8?B?VG1XTGlPckNkdDJCSGxhazRjdEU4QmJiT0NLNVdmV3gwT3l5RmUxSjdPMmhY?= =?utf-8?B?SkpYN0FKR2FYTWtlaCtMN1EwM1B5cXEzcU9lS29QZ0hwZ0NEejFSWHF1TjdD?= =?utf-8?B?UWNpQUF0TEpIczNGT3pvUm9pS3VpUzRYTVAyM05oeGdqSi8wMDF5ZGdEb1hC?= =?utf-8?B?Kys0VjlpY3U3aXMwYmNwUERyMk03QkNLcWtBcEx4WWlrdFl5QnR6VEU2Skc3?= =?utf-8?B?czVNWlhWb3FuV0ROczczT2NNeENKdkkvNVhYQmcvbnFiRGswS1dwcjM3R290?= =?utf-8?B?SGcxdjVNRDQ2Y3V5b3FGaHh0dUEyNlQ0MHB1SFlSRHBKUzBIVXp2RDZVVUlz?= =?utf-8?B?UERuYVJST3NjbVYzRERLdmtRVnpnWUtLay90Z1pmbjN0OStuNFBlaGJQVkQx?= =?utf-8?B?N0pUbVR5Wk5ha1U1L2hCbG9vMlplU1QzKy9CYUZXaGJUTUxpUXBUbG9UR1Bq?= =?utf-8?B?Q0NxY1U3d090QWYvZDJtdUxlQnI1SHM2VlZPa29RMnVDQ1QvTVlTOEJZL0Vx?= =?utf-8?B?bE1WVW8xaFJYWXZCVEw3VzkxSVNkeU1DMEgvWUxDeGVaemRHR05WbjVKbkNw?= =?utf-8?B?MFhxUjh6TVg2a1BJWU94QTBNeXB5ZHJzdUxlbDlYTzVZdWRsSGVBTWFCYlNX?= =?utf-8?B?S2EwRkpFV1pxbVAxNTFLbDhUQWpNN1RJRTE2YS93ZWVVaHUyNWlRSFQraUF6?= =?utf-8?B?eWdWYWg1V0d1V0Fzb0tLVlFZdDZabFFMZlN0S1hzU2JtbzIwUms5VGV6S2lu?= =?utf-8?B?K3Q1RlJaKy9CdTJmeDZ0VUZ5UitUTjlDaFB2VThPMmFMMUl4S0Y4Y2RCcUpw?= =?utf-8?B?NUVUSEVTbGZNRC9xQmZ1b1RDMW1vaVRibHpkVW9uVTd4MVJFOE0wYnNhWVdJ?= =?utf-8?B?cTJTK2t3N3JZYXluN3VjRXZoNmNSeThIalU0MWN4V3FnM2tlWTdCVHdweEhr?= =?utf-8?B?UGlWalUwNUpqOTRSVUdBUkl0L21YVDQ3cDA3U1U1bE90TFhCT3FlazB6V3M2?= =?utf-8?B?ZUl6VUc4a1l0ZDQ2UkYxZWo1TXpJRE5hd0czZDUxemsxL0doQzFSUDBBajVh?= =?utf-8?B?QS9PSngxZ0RiVnlnekw3RDlkNGIwWGdZSEJ0cnJPV3FDZUZCYnNBTWlqczE2?= =?utf-8?B?OXdoOW91dzJ5R3F4eHhUenY5bTAwTXhPc1UvWmpvaEEzMU8wdUd3Qjc1cmVZ?= =?utf-8?B?RzVQVHN2aHUzQjBmR0xuajJEdCtBZk1LRzBKQk9ZSmlsMEJZYXhKWmxldWV1?= =?utf-8?B?SENOWk0ycjVUWkYwajhVYmdlS0lyck9va1VpOUwyeGVmcm1DNEpJMk02eFh1?= =?utf-8?B?NWNNb3dKWHFHV3Z2VVh3MHlZaFlLUHZQcytLSEttTU5mcGVTV3NxOGVIT1M0?= =?utf-8?B?VS9DSVRqZUc3UlEyKzVDTzZEQTQvTCszRzNGSUIrNHQvbzg4WktORXJ1QXUy?= =?utf-8?B?R24yT2p6QzBXd1hQemZmQUVKeHVaKzRQOG5UenJjaUpmcVR4VnZSQ3pNMGVw?= =?utf-8?B?eVkvZGV0WnFrUUlRUmtGZjhCd29wSkJFQVh3aXY3NmkwbXQ4bHpvUkxTeUhF?= =?utf-8?B?cGo0TGxaNFJLbXhhbGdKOU9mVEpPRHUza0hLNk9va0oxdmlOZ2h4bko1UkZ6?= =?utf-8?B?NzFxWURvSHF5Tjd3N053VHdpcGN4TjgzT2Ercjl6cDFhelF5cTZ4YmNTRXVD?= =?utf-8?B?dWVlVEl4VXU5RG10TUJEMVBpaU9UVlJRODRySnUyQkNLdlRiUXFtUFZxM3Jv?= =?utf-8?B?RjFZeWh1SDlIbHRoVzBBMC8vQ1M2WGVFK2d2Y2k2QWJTdE1hQk1DWUprN20r?= =?utf-8?B?VEk1bzVNZUZYV3ZZd3hQZy8xQ3p2aEdLN0R1MDc1ZVoyUGNIOFNFYW55WVlQ?= =?utf-8?B?ZWk0VWpvYlp0dWYyZXhKT2tWYUlSVW9jQldiNUg0VUQzNExLNUFFekMvbmZT?= =?utf-8?Q?cjJ/cu6TTweewtTeekD4NsK6r?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 08f45a67-48b4-4474-5ccc-08daa5e7e221 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2022 09:07:37.7462 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /+h6XMKDK0jSviF9TmogHRSXJ5DKJvuUGuIr6QMXsmBUtma6Ujotfu4Spj4iTF/Xv0EFLlNNMSaNLVpzoRif3w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7341 X-Spam-Status: No, score=-3031.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 04.10.2022 10:59, Tsukasa OI wrote: > After commit bb996692bd9 "RISC-V/gas: allow generating up to 176-bit > instructions with .insn", I started to see some crashes while running > "make check-gas". Hmm, I'm puzzled why things worked correctly for me. The extra size needed is quite significant, so chances should be rather slim for things to work correctly. > The cause was simple. Some functions depended on the fact that maximum > length returned by riscv_insn_length is 8. But since the commit above > increased that upper limit from 64-bits (8 bytes) to 176-bits (22 bytes), > we need to increase two buffer sizes to avoid crashes. > > But note that this change doesn't really support over 64-bit instructions. > It can be said on riscv_insn::fetch_instruction because it now may return > only a part of instruction. > Instead of merging this, reverting that commit (for now) might be an option. Please let's try to avoid reverting - the ability to emit wide instructions via .insn helps testsuites beyond binutils' / gas'es. In any event - thanks for the quick fixing of the issue. I wonder though whether a connection (at least by way of comments) should be established so that the same oversight won't happen again (e.g. once the spec spells out how even wider insns would be encoded). Jan