From: Jeffrey A Law <law@cygnus.com>
To: Ian Lance Taylor <ian@zembu.com>
Cc: geoffk@ozemail.com.au, binutils@sourceware.cygnus.com
Subject: Re: elf32.em
Date: Wed, 27 Oct 1999 23:27:00 -0000 [thread overview]
Message-ID: <23263.941091413@upchuck> (raw)
In-Reply-To: <19991027234806.10154.qmail@daffy.airs.com>
In message < 19991027234806.10154.qmail@daffy.airs.com >you write:
> if (bfd_check_format (entry->the_bfd, bfd_object)
> && (entry->the_bfd->flags & DYNAMIC) != 0)
> {
> char *filname, *needed_name;
>
> ASSERT (entry->is_archive && entry->search_dirs_flag);
>
> /* Rather than duplicating the logic above. Just use the
> filename we recorded earlier.o
>
> First strip off everything before the last '/'. */
> filename = strrchr (entry->filename, '/');
>
> Shouldn't the variable be called 'filename'?
>
> Actually, I think the uses of it should be filname, to avoid
> shadowing. Or we should just remove the declaration of filname, and
> use the existing filename local.
>
> Jeff, I'm not sure it's a good idea to try for the .sl extension on
> every system type, given that it is only meaningful on HP/UX. If
> there is a long search path, it is a waste of time. It is also
> incorrect in principle. You can test for a particular emulation using
> #ifdef TARGET_IS_xxx.
I didn't know we could use TARGET_IS_xxx to do this stuff. I'll certainly
change it. I'm no fan of the current behavior applying to all targets.
Thanks for pointing it out.
jeff
next prev parent reply other threads:[~1999-10-27 23:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
1999-10-27 16:33 elf32.em Geoff Keating
1999-10-27 16:48 ` elf32.em Ian Lance Taylor
1999-10-27 23:27 ` Jeffrey A Law [this message]
1999-11-03 7:49 ` elf32.em Jeffrey A Law
1999-11-03 7:49 ` elf32.em Jeffrey A Law
1999-11-03 8:24 ` elf32.em Jeffrey A Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23263.941091413@upchuck \
--to=law@cygnus.com \
--cc=binutils@sourceware.cygnus.com \
--cc=geoffk@ozemail.com.au \
--cc=ian@zembu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).