From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id D6522385DC0B for ; Fri, 5 Jan 2024 22:29:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D6522385DC0B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D6522385DC0B Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=205.220.165.32 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1704493754; cv=pass; b=jzmuvHDvnpJ53Bj3KYFLRsP//cxy4VlqarbncVha4xEqd7BWF6GwMjl0cWIg6tbosvlMHbbZ8/cx9OOmZFm10Gy5jaPqamFK0Wl6RG0spAxrRSKu4batjodAbk1Oc0O8UUtqK+wDF9kg+jUCL3HA5z4FB4pXmY6ihzR9rBwp3ps= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1704493754; c=relaxed/simple; bh=O8Qc9ccACs5aXZAfo4brbJCgFOPfXYGSMO3/a+DO3vQ=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:Subject:To:From: MIME-Version; b=g8sU2jZdaOHcAj8hp9dHnVzMp3lj3MioGg16E4QKv/0LdN7t7KdwMkPQf02zuI3/QsZm3hofXdNmrtTAwXA8xnkt9NOU5LjKYquuN/nv/pjTIk/VVEitZEw+0oD2lqwD1vHkh1SR+wVlsp9n1rqpCZD7zOsrdD6cWPTZf6TXZCY= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 405MHvx3006200; Fri, 5 Jan 2024 22:29:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2023-11-20; bh=r/YtT9L+Ipi4qSmkwWShJu4Jdp8ZNUMFG8Rh0g2teBk=; b=NWeooDQPIpyCV7gEnFYg5Outr3aKaZgtgNQS1gbM5SFMJ7lcfPcr2ewWBpnZdBnMEPnW Zxlq6OYkTBmQw3xFt6RibS3e4PDUIA0lGCnQxD2xsem4+WPS9mHmVrv7FGLBKqOUcVJs 6guD32yQcKA+nfytBiDGK+bPD/N4oN060iBE/9q5OGv//EQU4R0vQUbLJ5KaPy1ExNqs AVoF19I+rEt0ZG+YUFnATwbnhEJq9cGD2bb0DC4M1yqpCb+B+kuyZ/k2b3iebUN+z2TL 2TjbkQqLa0/RxiFrR+hxwCQqEVwIOISBlD6pJrWZ7KWbmsVWg64f9DHf1YiCy3Lvl6Pk aw== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3vetem80dj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 05 Jan 2024 22:29:10 +0000 Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 405L6Uvc023296; Fri, 5 Jan 2024 22:29:10 GMT Received: from nam04-bn8-obe.outbound.protection.outlook.com (mail-bn8nam04lp2041.outbound.protection.outlook.com [104.47.74.41]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3ve1n80sda-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 05 Jan 2024 22:29:10 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dzfroKnj8Y1nCqF9VEfgZCUjQNhZyu1YBXzMfe0ZzEntkqmraMlrayVeS2PuvIAL1Vwfij+sEmYk3aUMnEeFaY/1KI8OTvf8L/ilzpIroBJXZc67eIhjlOu+0e89IqCCcAN7BwkItW2++3Vy9EedxzXPsa0EP+a93Q3g3D/OqmZAnXjrUPXjof+wwa7weNEpT+N7kDuS6aGlox1VRjhx95NjdYoDaAucvHB53RdryiKwliVss4XjLUjSwEhncMQ6ZLFV1PTKysNXt1J14Jgrhu12MHb7q42TdQMJ0CjDssU84nVybF74pcfLfrHrvJvgANTlNgfJ3hAXKvNb80DgIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=r/YtT9L+Ipi4qSmkwWShJu4Jdp8ZNUMFG8Rh0g2teBk=; b=Sa3QXoq0jP+IbklcAacBpfn6N67Y6bLYhfY31O+bnqaEh7cXgWZ04vHG1kK6DoWJDOma0jqMy/AyqRcJN2+ojeDca9N2OKZo5uM4vWCN9Q7qAxcoDx5qxT+hw9tDZw3PN2Vm0Oq/V1zWk2Neq51C4ZFBtkm785NEUw/4SoGo7Le27isxSVFYCxQKVUz9yyzl6H6ojoBfzgz0hNyAHua/GnndrDVqIoOZ1ioT8Wp9dL8HLz5Eq0m/naLWwhShruPHeGmpELozG/UaZjMx7+Z8iu76j8UngiuwyNAO3062Vvuqfsmy7rwd3bs+QdXJqky0MDmRm634i1KXHwwjyFJW9g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=r/YtT9L+Ipi4qSmkwWShJu4Jdp8ZNUMFG8Rh0g2teBk=; b=C92lAIHVlamKWtAEG23ZpAm/DClBOmNJN4882nFdWvCBTC1zNIaRb++YxCTnfWceD3gT7kOpWUOwzlbJZ/Hi5Y3sS64rB0f/YCaTwlftTu+uiKc5S/4ePsnjv1khIpaJCfX2kNZpjERevG0ZixXzxPX6UZFvS6WueiuNZyOj73c= Received: from MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) by PH0PR10MB5818.namprd10.prod.outlook.com (2603:10b6:510:140::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.17; Fri, 5 Jan 2024 22:29:07 +0000 Received: from MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::fde7:fb92:8ea1:a5ac]) by MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::fde7:fb92:8ea1:a5ac%4]) with mapi id 15.20.7159.013; Fri, 5 Jan 2024 22:29:07 +0000 Message-ID: <238fa812-8a31-4fe8-b12b-2f7a55220352@oracle.com> Date: Fri, 5 Jan 2024 14:29:06 -0800 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH,V4 13/14] gas: testsuite: add a x86_64 testsuite for SCFI Content-Language: en-US To: Jan Beulich Cc: binutils@sourceware.org References: <20240103071526.3846985-1-indu.bhagat@oracle.com> <20240103071526.3846985-14-indu.bhagat@oracle.com> <1c9e7d28-1bef-4d1d-9b51-b1725c8b2f07@suse.com> From: Indu Bhagat In-Reply-To: <1c9e7d28-1bef-4d1d-9b51-b1725c8b2f07@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MW4P223CA0011.NAMP223.PROD.OUTLOOK.COM (2603:10b6:303:80::16) To MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2158:EE_|PH0PR10MB5818:EE_ X-MS-Office365-Filtering-Correlation-Id: e6da2fc6-5d13-4c03-a3ed-08dc0e3dbb08 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TRG29bLq0Ng7eX3CvCsEmlNlW0ZuUUUtGnzUV3v2ay5Vpg66wLjrkBN5KpceRfOsajey5HG/eKYYnkQItuae3UTTj/kV+3fVnY7O0epgNveU9uXU2+H0A0YWvgN7ZOyZBj+bQnrPQ3xPDy6ZHTwKzyLehzwyZTeA2EQMRom/fVVP6IpdtuLFGc9KI54vkPujIM/ygQteZGMyCH8HHexn+1NHSL3j+x0LAne3SPSybS0dOlcHB3Wf7ZqrboBIpAmVZCP9CJaiGH3B/7dtJ46F7dZ5ze3VohsXaePhbWKdS734hqdbM37f7RzTDt0CwcXa+kb7vd4NzxraX3g16WUVEZfYHUDVDKnVekPTeDSwwUzMAkfq0/E5ZZXsljPaCUaJhCLML6e/uYl154SJrZMisxpDVLVMhBwx6yyqDuAlopIPexU4oZsnJSsQOjniFWQRXFDGrCfx4UA4VKW3ED0bKAMLMguxcFe3kLmHa2C4A6+G4UgtKJQx9TevjiFQFJJEeK4EzDOE/fiDqcbIgnvIZSmTW3Z/fTPEyq4pOPB5yjtzn3Lcl3ZMqwkmzRhrqfNKhuN5pPiAgKOXMIGZ1HqU9kytLT/Ff0v2/DWbtsutCDvv1ROxOTqyXhhMGAROqwdfscsXD+eQjifIkJrDSnHj/yPC7EfgThAxFVODlP/LpuEYtv0UEsQ6B4fmn0BX2ISZS0w+AP7D9CJezsCgS8LvoQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2158.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(39860400002)(136003)(396003)(376002)(366004)(346002)(230273577357003)(230173577357003)(230922051799003)(186009)(64100799003)(451199024)(1800799012)(66946007)(6916009)(66556008)(66476007)(38100700002)(31686004)(31696002)(6512007)(6506007)(53546011)(86362001)(2616005)(44832011)(5660300002)(36756003)(2906002)(478600001)(6486002)(316002)(8936002)(8676002)(83380400001)(4326008)(41300700001)(2004002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UUE0akFWMzlTOW8rSktrM3JkWlZMNEl0cksxUk14L3RYSGhIL0Q2bEh2NWR5?= =?utf-8?B?QUhOdjhETmhlVEhCaVE0Rys5cWRKRWFVVS90RDRBWStLQ1Zkd0x0LzFHVVA0?= =?utf-8?B?V2JScE5DSk5FNFRKUExtaVQ3VEc4Sk9Ucmo4eGhUZFE3QURLZ1FBUEoveVJB?= =?utf-8?B?MkhxZXNyM1hKU2pmcllWeTExeDllTEQ2RE9kaHpYbHYvQ0duaWhYVDFDdVNr?= =?utf-8?B?YXR4OVdaZFVobk4rNWZWS1FWTWJ5OEw1ZDJoUmF3TjJ4ZWU3ekJSQkZHTHd0?= =?utf-8?B?bkc1ZlZBRE8yWlk0RStGczZmOTI3aDlLd0VENlo1a0ZJYTdwenZWdEE4Y2h3?= =?utf-8?B?MGViN2NVSXRralA5Z2thWFlIbjJBR1hNT2UxTlNFL3F5a3BlaVlZbDVFUzEv?= =?utf-8?B?VVR2N1ZoVHczVW1mR3lsbFp1cVFVQkZDQ2dERllSZFF1U3h3VEE0SFNDQlUz?= =?utf-8?B?KzhodUpoaW80RGFXcjl1R2pvVnZJM3p0eHBZcnV2RHlpbnhqSDhydnROQTJ4?= =?utf-8?B?Qi9KUW1hNWRiMzNCL1dPeWxlMlpKajR5ZG81RmZlVE5oYm9OYzVEdVVvNGZD?= =?utf-8?B?Uk1QYW5mWkV5VDRnUXY0QS9tOGtaMkNZSHFHbWthT1FrUkRLbHFxVXhUSHZj?= =?utf-8?B?R2k4RTZkT0NzU3p5RFRsYzdaVzVTTnVqbmlkaEpCb2I0WE04VnQ4WDA0YXkw?= =?utf-8?B?WDROZkxhWm5FTjhvWGFYaXkxSHk4NXY4ZllsOUZIS0xBTzV5d2dqb0duRDFl?= =?utf-8?B?Ni8yZ1JVbTMwc2lCbGdIcjJ3eHdnTFJLYmorRHVmbmZyUEk1bjVTTkVNVTlG?= =?utf-8?B?STJNaXpCUDRwNG44VFFwT2NoaGxTbmhoSm9LR0lDNjIzcnBBMXRnQ2dPR0Fo?= =?utf-8?B?MFFhRjViUFp5dXRnRExVZHcvOUcyVThlQU4zekVqamJucHRMekptdmw0R2gr?= =?utf-8?B?S0I3bXdrODRJSTVxazNIbXdrY1lyRko3ajg1Sk9BZy9ZMEVDN294TGdhZCtk?= =?utf-8?B?QXorZ2dOZi91VVMzS083bjZpeUk2WjU4R3lTUWkxSlN4UFZzRXlCTkIvdndI?= =?utf-8?B?T1dlS2JwMDJrT2diR1NVV3FyQkxBRHdSdWFSR1FSNlNGYVBSb1hHUXYzUk40?= =?utf-8?B?dGo1RlBBNTZQZ3JiSHBHclF3YjdLV05SemdveXpVTTlzL0FxVURZZ2JEQ01E?= =?utf-8?B?MENJNFN6ZUZWRkVGWDhnclhaU0l3QzhrWGc3Ny9GVzhneTVrOU5tcXhoelZn?= =?utf-8?B?MWt3a21wT3JiSjRmVnY0amtQT214OS9CTTFRa2pSQ2Y2NkY0Vnl6WnVzaGFv?= =?utf-8?B?c1gxbzdTbUlvbzVWYVBzVVA5N3RhbUVGMThCbTVSQzQxbEUxTDFpRnFsMHNQ?= =?utf-8?B?dTdWYnNFcis5c29rWTczaXY4MXZJa2VYeGY5dDNLYzRJNmkyMnNzZitIdDlM?= =?utf-8?B?TDY0eUtDK3hnclVCWlBxWjJwelM1eDg4UlRPbnl6MTZqOFJwc0d5MUVHSFBm?= =?utf-8?B?T1lVOWROUUUrOS9LcTY1cXFIYk5sUTM2dis5UlhGMnlPZHl3eG5xTm5seEVp?= =?utf-8?B?UEZUeUExNFIrYnAzT2VhSkFZRU9YMWpmR3paV2pTbll4K3UraGRBOGxuR1pL?= =?utf-8?B?azMyRmlKRjNJOVdPdzQ4YVNXOEtGNXFXS0ZDZVRsWnViWWNZY0pYRUdxd1pu?= =?utf-8?B?QTBNbm1BU2ltU2huUkkyZDlFc0F1Z21TNTVPL2RIMUErMlQrWWdDeGZPc2xH?= =?utf-8?B?ZGl4SGZPYmhRNXdjWkZSREhxZXN2VHRKQXNWUEFNMzdmdkIvdFVkVHpkK3VR?= =?utf-8?B?T2NZbUFMWGZab2dFc2dSVEl2Tk1vTFhxcTErRyt0czBMRWFKV2d4OVBVV2RD?= =?utf-8?B?dTVzaTYxWHdYK3BpVXF2UXpIOWMwS3UzUVR2NTlzdStuSHlUSWVieXVobExq?= =?utf-8?B?OVdXcEdzaVhpZ1RTSGsrNjcvOTZTVmRTa05pU1NKZ3RhbWg4K2pTKy84Wm12?= =?utf-8?B?SGJmMWdFLzZSWG9EQzlLMmVWUDh5bW5mZTJrRFB1Yi82VUNyY0dGV3RFV2VF?= =?utf-8?B?S2s3cXV3RXRJUE5haEdiMFc3OW9IRU1jKy9OdXA2MVhZZlFLb2VWd2s5c0tX?= =?utf-8?B?QlFoamhIWDRuS0RvaEM1bDh1N3ZTVWVHNGlTNlZXK3M0blBrSmRvSWd6SDQ1?= =?utf-8?Q?ZZRFfFZs+DonwrS+DIy546g=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: h026eZePeNVUTUFYgJ0noAwlXzFedSBhjSxw4pE20GD/8ZqICbGpp0Hhg5XU9puafoYMk78YfY5oZDYLFnsg/Slz4rsk4Dcv2xldi8sFPsQos3jr6XepO1JPZSA2WNvCG1TpSgUxiKlaS8QKulqPHiBIFVWa1el1LAkhg3voB00Ul/xbxtDORF0TRIXEzDhwd0ENQd1N8+ouce4J2G7nqWmMTxNMy8AqNL37lAkxEWKtRaEr6a+rACqtGDMfmJCEiVOyj4mDzF4wQg8z3VKglS9uwdZ2QnmEYFrqqeASsKzpLGkE3ag85VV1iGVPMyUQiSFvYgdqcjbQ03B89jJooq+LQGeCbJfysY/zFx29M3j7vw4HyeuYjccL01C7hmcNNG5u5BEqRHsLjD/gYpcQrZDDvXSwDupmlG/ozDS3Bg0U7qj3B2kHyZRK27giy9Fov3Xl99D5fcHLvgrrhYRWzZTV9ht/D/hrKfyvbnTMX0oR7E1q+xI1jfTMQ0EPSd5tfjjDRCpNlsT4lgdrdNBKiwz404IJ0HbQ4tdHDNkdMGKv+UBeFUekuxwosop+A8oTpVW2JLR9tLOHKGVjpxsy89zq/o/9igbZl4s44dqCjLU= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: e6da2fc6-5d13-4c03-a3ed-08dc0e3dbb08 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2158.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2024 22:29:07.4763 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2amqiG8AazsqawJycsYMQ8Q7rT3T4vKZfGUnpw7yNI4B5yHk5Vx+Bx25NTzAkXkwmZ/OpTPdKVBRF8fh8y9kTA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB5818 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-01-05_08,2024-01-05_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 phishscore=0 spamscore=0 mlxlogscore=999 malwarescore=0 suspectscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2401050174 X-Proofpoint-GUID: Wl6kupVnSlIaoneIc_BGKygNL9e_Q6f2 X-Proofpoint-ORIG-GUID: Wl6kupVnSlIaoneIc_BGKygNL9e_Q6f2 X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 1/5/24 06:22, Jan Beulich wrote: > On 03.01.2024 08:15, Indu Bhagat wrote: >> [Changes from V3 to V4] >> - Forward and backward pass failure is an error (was warning in V2). >> Fix the tests. >> - Add new test ginsn-add-1. >> - Add new test scfi-unsupported-insn-1 which includes the new APX >> instructions (pop2, push2). >> [End of changes from V3 to V4] >> >> [Changes from V2 to V3] >> - Fix inconsistent indentation across tests. >> - Fixed some issues in scfi-x86.exp: add scfi-callee-saved-1 to the >> list (was missing earlier), removed redundant test scfi-ignore-1 >> - Adjsuted tests for some rewording in the warning messages. >> - Use register names instead of numbers in some CFI directives. >> - Run each test with and without --scfi. This will keep the CFI >> annotations tested. > > With this, ... > >> - Run scfi-unsupported-1 with --x32 as well. >> - Added more tests: >> + ginsn-dw2-regnum-1 >> + ginsn-pop-1 >> + ginsn-push-1 >> + scfi-enter-1 >> + scfi-cfi-sections-1, etc. >> [End of changes from V2 to V3] >> >> The testsuite for SCFI contains target-specific tests. >> >> As all the tests are executed with --scfi command line option, the CFI >> annotations in the test .s files are skipped altogether by the GAS for >> processing. The CFI directives in the assembly files are added with the >> intention to aid maintainence only: CFI annotations in .s files help >> convey the expected EH Frame / SFrame data in a format-oblivious way. > > ... wouldn't this better have been re-worded? > Right. I have reworded this now for V5. >> Some testcases are used to highlight those asm constructs that the SCFI >> machinery in GAS currently does not support: >> >> - Only AMD64 ABI is supported for now. Using --m32 with --scfi results >> in hard error. >> See scfi-unsupported-1.s. > > DYM --32 here? And did you also want to mention --x32? > Yes, I meant --32. Corrected this here and other instances. Also added --x32 in the text here. >> - Untraceable stack-pointer manipulation in function epilougue and prologue. >> See scfi-unsupported-2.s. >> >> - Using Dynamically Realigned Arguement Pointer (DRAP) register to >> realign the stack. For SCFI, the CFA must be only REG_SP or REG_FP >> based. See scfi-unsupported-drap-1.s >> >> Some testcases are used to highlight some diagnostics that the SCFI >> machinery in GAS currently issues, with an intent to help user correct >> inadvertent errors in their hand-written asm. An error is issued in a >> situation where GAS is not sure it will be able to synthesize valid CFI. >> >> - (#1) "Warning: SCFI: Asymetrical register restore" >> - (#2) "Error: SCFI: usage of REG_FP as scratch not supported" >> - (#3) "Error: SCFI: unsupported stack manipulation pattern" > > When "not sure", I think it should be warnings. The bulleted list looks > to match that, but the earlier text doesn't. > Right. The commit log needs rewording. I have reworded this for V5. >> --- /dev/null >> +++ b/gas/testsuite/gas/scfi/README >> @@ -0,0 +1,17 @@ >> +Notes on the SCFI testsuite in GAS: >> + >> +* At this time, SCFI machinery is only supported for x86_64. >> + >> +* When adding more tests, please keep CFI annotations updated in the .s files. >> + Recall that user-specified, synthesizable CFI annotations are ignored by the >> + GAS when --scfi (=all) is in effect. Adding CFI annocations, irrespectively, >> + makes the testcases clearer in terms of understanding the expected unwind >> + data. > > As per above, this may also want re-wording. > Done. >> --- /dev/null >> +++ b/gas/testsuite/gas/scfi/x86_64/ginsn-add-1.s >> @@ -0,0 +1,26 @@ >> +## Testcase with a variety of add. >> +## Some add insns valid in 64-bit mode may not be processed for SCFI. >> + .text >> + .globl foo >> + .type foo, @function >> +foo: >> + push %rsp >> + movq %rsp, %rbp >> + >> + addq %rax, symbol >> + add symbol, %eax >> + >> + add (%eax), %esp >> + add %esp, (,%eax) >> + >> + addq %rax, %rbx >> + add %eax, %ebx >> + >> + addq $1, -16(%rbp) >> + >> + add (,%eax), %esp >> + add %esp, (,%eax) >> + >> + ret >> +.LFE0: >> + .size foo, .-foo > > In the revision log you say you sorted inconsistent indentation, but > here you clearly didn't. > Clearly. Fixed for V5. >> --- /dev/null >> +++ b/gas/testsuite/gas/scfi/x86_64/scfi-x86-64.exp >> @@ -0,0 +1,113 @@ >> +# Copyright (C) 2022-2023 Free Software Foundation, Inc. >> + >> +# This program is free software; you can redistribute it and/or modify >> +# it under the terms of the GNU General Public License as published by >> +# the Free Software Foundation; either version 3 of the License, or >> +# (at your option) any later version. >> +# >> +# This program is distributed in the hope that it will be useful, >> +# but WITHOUT ANY WARRANTY; without even the implied warranty of >> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >> +# GNU General Public License for more details. >> +# >> +# You should have received a copy of the GNU General Public License >> +# along with this program; if not, write to the Free Software >> +# Foundation, Inc., 51 Franklin Street - Fifth Floor, Boston, MA 02110-1301, USA. >> + >> +if { ![is_elf_format] } then { >> + return >> +} >> + >> +# common tests >> +if { ([istarget "x86_64-*-*"]) } then { >> + >> + global ASFLAGS >> + set old_ASFLAGS "$ASFLAGS" >> + >> + run_list_test "ginsn-dw2-regnum-1" "--scfi -ali" >> + run_list_test "ginsn-add-1" "--scfi -ali" >> + run_list_test "ginsn-pop-1" "--scfi -ali" >> + run_list_test "ginsn-push-1" "--scfi -ali" >> + >> + run_dump_test "scfi-cfi-label-1" >> + run_list_test "scfi-cfi-label-1" "--scfi --warn" > > Starting here, where is it that you also check CFI generated from > the directives? Also, why does each source need assembling twice? > Can't you check for the diagnostics right in the "dump" tests? > Its the run_dump_test which runs each test with and without --scfi. E.g., in scfi-selfalign-func-1.d, we see: #as: --scfi -W #as: #objdump: --sframe Checking for warning in dump tests does not look possible as there will be warning (Warning: --scfi=all ignores most user-specified CFI directives) in only one case (#as: --scfi) and not the other (#as: ). I thought checking for warnings explicitly may help in catching problems as the implementation evolves. Indu