From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by sourceware.org (Postfix) with ESMTPS id 817743857C50 for ; Thu, 4 Jan 2024 09:08:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 817743857C50 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 817743857C50 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::132 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704359297; cv=none; b=SwCJh3R0ZDZS3In0RLYYvoKa+oIiSSJUJR7CDWWXW6I8HSTPHVYvyOVIAEOl5KlbSpe8ZXnUrdPFKVn1jDIgDKeBY6e/w2e9PjkHC/r/OFyeYGwKBD7nxkaDl93xTIkXGq36bbE0l+CHfmGTcvc+bDmZQ9YyW0NpblFb9pmxGQs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704359297; c=relaxed/simple; bh=UdRY4H+I/GrU5VmBXPz5BSKdKPfuBupu3ap6lSnyJWM=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=l8xf3ESyPcfq7ozrJU5Q9U8L0QA2tgJnPsEXMp1VkTrNLq2eoGaChWD9GZ75e5KZrH2jARX/xQE3amsmX3SxOC1kdpIxdbQlxVEyLwfqoZnFe1RupI1gbV3M+AQkg2Bs5FBZesXXicAsHkp4Gf4LZAdEZvqlGQHca3dXNBtDyro= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lf1-x132.google.com with SMTP id 2adb3069b0e04-50e7c6e3c63so282765e87.3 for ; Thu, 04 Jan 2024 01:08:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1704359293; x=1704964093; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=hCVuyKOi2mqsU98CkUvVF82wFtfFeoUfV2thKQbkbG8=; b=Tv8I/L7+tvnDdwSR7GpUS4iK3X0OB9sliuVBhfzwg/abozzSOd7Fagdh86KpuOXeMX t1OagR/maDy95agoi7Gvbv3o/RCu3czl2Dno6JqlPmXa1SDnfV//OG8YaO4i/gX6TLAq 9AK6INLZtVjXQYiRwu46FDtksNDWLHqsbmzVNjiTCLbukj+NE/vNn43XQPXj4jGuk4U/ CTyRJZsW6y5r4Ta8L+bvDFcNlEZu/1Jf3cjyhSdjpHYUexdvZ9OfzhC9sy8Ls5l6rRFV BVF6Cq/tRmRiPZBe3yr6WPgmu+pxiaOmI9MyLu8kfWFDTTh6J7fv6g7XvTn1UDHf/Wg/ gadw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704359293; x=1704964093; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hCVuyKOi2mqsU98CkUvVF82wFtfFeoUfV2thKQbkbG8=; b=SUU6KnkZya+Ydoss4ADlvdDFvkoW+cF5mz9u4MQlsQrTuCoA9HpQvMVjsWTlFqr5nv ZyrWynGI3xzjioReTv6y/dXZwwwj5PssrEyvhnIbQmlGcZnLwbTh6ukwAHn0FPPaqZny ZGo+zp2fjGUUWeUNUC+ziJ9kKPYp6BVvcw01SQtCkHMiGL0TN+RVRj4vluRxWe0fkdXr bAwYJhi5nT4aeakXcDJ60lp0YLzIObDdm5sfQNTkVG8R7O8TUKqFemh89p3sCk2oVbrc wWfg4Yamu1Pd1p43jxsjLRZDCVPrlSFoWkOI0DFKhm3vd7eFp1sQyzWKSR0dXfbuza5h Qu+Q== X-Gm-Message-State: AOJu0Yx8CmJq5v2hxqXQ7HlCgAcoew6ZQcX3Wfm/nGBd4wmACQywlFWq YButiB9sJhND23e8zN1e7iDnD8VilHeJxDeO40YUyNwMLA== X-Google-Smtp-Source: AGHT+IErPrOcLAzrLnOdqWXTlsnDAT9r8RkYgPUI3cDKfjJOzK+/aTSP4IWYtBQs+NdmonKQlzx5jQ== X-Received: by 2002:a05:6512:318f:b0:50d:6249:17cc with SMTP id i15-20020a056512318f00b0050d624917ccmr136879lfe.245.1704359293059; Thu, 04 Jan 2024 01:08:13 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id x18-20020a056e020f1200b0035fd9972e5csm8750395ilj.46.2024.01.04.01.08.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Jan 2024 01:08:12 -0800 (PST) Message-ID: <23d613db-1b3b-49d1-96d2-2c17a5d63a46@suse.com> Date: Thu, 4 Jan 2024 10:08:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 3/9] Support APX GPR32 with extend evex prefix Content-Language: en-US To: "Cui, Lili" Cc: "Lu, Hongjiu" , "binutils@sourceware.org" References: <20231219121218.974012-1-lili.cui@intel.com> <20231219121218.974012-4-lili.cui@intel.com> <1a796802-5267-4c88-abc4-dda4bdd262cc@suse.com> From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3026.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 25.12.2023 13:23, Cui, Lili wrote: >> On 19.12.2023 13:12, Cui, Lili wrote: >>> #define Vsz256 Vsz=VSZ256 >>> #define Vsz512 Vsz=VSZ512 >>> >>> +// The template supports VEX format for cpuid and EVEX format for cpuid & >> apx_f. >>> +#define APX_F(cpuid) cpuid&(cpuid|APX_F) >> >> I think the comment wants to go into further detail. Please can you go back to >> read what I said when I suggested this construct, in particular regarding the >> stripping then done? However, with you not having found a need to fiddle >> with cpu_flags_match(), I wonder if this construct is needed in the first place. >> The earlier suggestion was entirely based on the assumption that stripping >> similar to that for other combined VEX/EVEX templates would be needed here, >> t >> > > Seeing this, I realized the problem and checked opcodes/i386-tbl.h, for the following entry, we want to set CpuAPX_F and CpuBMI to 1, but gen.c doesn't seem to support the format "cpuid&(cpuid|APX_F)", I suppose you mean "cpuid|(cpuid&APX_F)"? > in fact bzhi sets CpuBMI to 1 and CpuAPX_F to 0 . I'm not familiar with the relevant logic in gen.c and don't know how to debug it. when you have time, could you help take a look ? Well, now that the patch was committed I of course can easily take a look. But with such an outstanding issue, how could the patch have been committed in the first place? And isn't it a requirement for making changes to i386-gen.c that you sufficiently understand the logic there (which admittedly has grown non-trivial)? Anyway - I will need to find time to play with what has been committed, but that's not likely to happen in time for 2.42. Hence it is quite possible that 2.42 will turn out to have incomplete and/or broken APX_F support. But perhaps this was intended to be this way by H.J., when he approved the entire series without even a single comment. Jan