From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by sourceware.org (Postfix) with ESMTPS id 6C0F43857033 for ; Fri, 20 May 2022 14:12:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6C0F43857033 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05lp2112.outbound.protection.outlook.com [104.47.17.112]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-26-x6_X3H8NP6iM25_MqPb2-w-1; Fri, 20 May 2022 16:12:53 +0200 X-MC-Unique: x6_X3H8NP6iM25_MqPb2-w-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ajn3i8QV8QL1reGZPoM3S8pMzDKl7dVZ/ZGsibblh5xVG6CYQhKzLwssYWoWV1Z8PiPcM+1RpjGtsE1OhTss8k4dRuFajPw+E0wmxP1oOCjDXS6y1G56m74qY9JBfQHBBbHPAYx7CmQstevxRFhT9sYJNm0KjGU4AqWZxA8OBTAWzfMC/hvP8q+b3jZJplqPctAvqD6Uk/VGOZvybP6zn4IeewVhZAe+BDpSBscVWmKwGumNxFWrpAvmwPhKWo3JXJ69vDjadclAkj8IC8l8WvakKTgzTqPnT6oVKGBnDYW0cmBN/KGtmf0NO12mHeLHdW7MdlPsfQ+yRg3uI6Ib/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=soGAHCXo6TCS7kBGMJ6NVxIRTfkrY81oGxeMPNB1+KI=; b=FBPh0KYCEHFsMbWLVNa4C7fyhcwqKneP1ZiBPm0CZsKBR7GOV6WS2+ZNI9mxtYq8kE0kgX+tkV1MaMjPgh3EoT5d8Yq5LQyKBoFkxvnOqfzJZ4try/DxNBBW6stUn7og3g9Ny3MZfZ4Uqhl29GT1fFd3gjS7jmrI4KtjfzffORc+BCcBfknIIHEBH4QHmiWvf7fYXWVnj33Q9Jc0xslv/qMOrMYJT5vC5nEN3Y8+7dOG8ayj/xAegSeOwby/lqhOTF55Q9kMX4iGAqpx7mX2eTZg63uul6OLAhtupaL8g3Joh1M7bKvfiZgyq9ESw8kOnOcjBgFVIiqq3Loea8p4yA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB6162.eurprd04.prod.outlook.com (2603:10a6:208:147::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.17; Fri, 20 May 2022 14:12:51 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5273.017; Fri, 20 May 2022 14:12:51 +0000 Message-ID: <23e77311-e52d-e972-5fbf-2875fa3f41a0@suse.com> Date: Fri, 20 May 2022 16:12:48 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v4] Add a trie to map quickly from address range to compilation unit. Content-Language: en-US To: "Steinar H. Gunderson" Cc: sesse@chromium.org, binutils@sourceware.org References: <20220422102512.2279635-1-sesse@google.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0212.eurprd06.prod.outlook.com (2603:10a6:20b:45e::33) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 62af4919-7e60-400c-a0ae-08da3a6ad331 X-MS-TrafficTypeDiagnostic: AM0PR04MB6162:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: aDJOVLR7giy8Bx3GRpE5UNDGfOVBVpQrlgVIcNJrRm3aJeLxyI/Ud2DQMHt0kOoBm6s1/BLLTQf2VrVruU/qytSA5IbEnVxfda2rIjoSZzy0T51V0Ag5+KWPpVBTBIprhl12WKBDFJbTdgEz0CWSKyTpfm0k09NIpVoo2f56P56TGFk+BD3RJPtVT7EX1WCO9uLCPaw2JnNu7WewxMAqT+W+ms/+u+/6VeYBT8u1EUs/HbChfV2lG+DFVujEc5ChodwKSGgaOBAsxR0J8oCvNlwUjNFbFvI37aKAQSbDneLudFFo9h1bSbFdImTXOIbOnJprX7LN+O4esMCk4Q2Bhv6aesW7cplVijJsjlr0D08IEfBbk/yxP+YxtJPrUcc+Iz/CiC3v+a3whARdXcBWqDXZrSG2tqhpVEEj9NRvird10KkBYzO91fXivBacHLO/LS/16xz7A4tuRS1ZP40ExW9eM22H7jwAQ3iWRCW2JJh9mO2nlrUFAu3YFN6lYP5ac094cM958zs7OEKH6foEQ0eWo18HLUUALSaaePE4u8gEYnWeUP/5BaPhwuqnl67XzVxRYC6aLCpyEunfBR8WBBUNaXPECSj0P1S/Oh823oXT+QcWTeKkfcFsyVj6MJhul/95h0pa9wXSjbwM2ZwuKCXTxsSWEmnoxs1rb3iU1hzBbr4RiPwTgsZnj6sPzb4zFszvxy7TDcf/PMfae1cURWXvXTyrSQp282DsUEntL/rXhNjqLvc8XSo+SB9aU5t5 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR04MB6560.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(83380400001)(186003)(86362001)(8936002)(5660300002)(4326008)(2906002)(8676002)(66556008)(66946007)(36756003)(6916009)(4744005)(66476007)(316002)(31686004)(6666004)(6512007)(53546011)(6506007)(26005)(6486002)(2616005)(38100700002)(31696002)(508600001)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZHk2UUhTM3crVmV0YXRzREVnMm84c1lkVFBpSCtMOUE5QWNFUTAzSGd5R3Ft?= =?utf-8?B?K0JCUlplemxpMjI4UDZ3US9DN2FsNUVrSHhJTkt4U1cxTlc0WThlZWNNaVVj?= =?utf-8?B?cDFwNlRKZmk4Mmx1a2hFRExoSnhsU29VS1JPYXVDSTd4NEtJVXFaa3RtamVy?= =?utf-8?B?Tm8zUGxiY1d3Z1RaOG5lK0FmeEpPajZ6QW1ZWDdJZ28rVktqRVJMcU1qazdw?= =?utf-8?B?YnQ3U1NKVmwwQzB5WE0yT3g2R2Y4MTJGNHFvWitWYUdsL3NRMGNveTJZV0ls?= =?utf-8?B?b0ZNRVVIMmc1RVNkK3pFektJYzNtUUUwMzlJNjdrMGJ6UnR6RFZUMGhCNTY1?= =?utf-8?B?QVZ5OUJJQ2ozeHpGV3JtS1VVNS9uaWp4eWc4RWJRZ0ZzWnkrT0ZrRlpsc0V1?= =?utf-8?B?WUZ5RnhWZnRLQlExWWZWMHRMNWNsRVRiKzdmQ2pyK1NXYjhKekc3TldhZitR?= =?utf-8?B?d0Y4WDkyc1hUd0JRUnJNSHlsYUlTUFlSaUVCUitIY1RTMytYM09DcXNTWGYv?= =?utf-8?B?TTZFL2VOTVllTWFLYm5EU0t2Uk1iaUxjREwyMHdMK2dLWFlXeU5FUlVxenNK?= =?utf-8?B?OTNYZWdyMzRTMGFVZFZ2MXdpa1pKb1dxaUwrS2UvalVGWjJKZUNadzNFQ0VH?= =?utf-8?B?Q2M1V2N2Z3hZcXljYldKbENRbVhlMThHOGpKTW02dDVEVlcvRmlZVHRkaE9S?= =?utf-8?B?dEZiY0V0cm1vK1N0N0N3QmExR2xHZ3RYcjNrVlQ2YzEzNFBzOU9YYUhWQWtT?= =?utf-8?B?WlVnajlma1I0L3VEdVVCTTVYMU9nOGFMdmNQb1ljdkUrRHcrOW5wVGVLZzVv?= =?utf-8?B?c3VJbHpDMGl0YlF5VzhNQUdnVWFTRkNubE50SGNDZkUxREpKNHVPeHpvWkk1?= =?utf-8?B?dmtwaEcyMFlsQnR4RTdGdlhzOFRwVHRqNUZRZ0t2SzFNbUNCUGk1Sis0Um0r?= =?utf-8?B?a29tcXBSSzJ2NGsyL0g5cS9XS2RJdWpPd3hEa3ZGVGowZk8reTRQeGlKRUFs?= =?utf-8?B?UEFHMm1xNmZEVjB2MGpMUnViSEtGQkN4ekJIZWhYenF4bUd4em5jY0hCampa?= =?utf-8?B?RG5WdGhNVU83Q0RESUFHV2JTYmYwaDlDemNHbTV6cVJJbjY5b0dTQnlSZGcw?= =?utf-8?B?eG1iT1R1TW5pNjZHRFU2dWltaG0yMG92SFM0MUdnL3lvWEFkUkxsM1luK1V0?= =?utf-8?B?d3ZxY2FOZG5uWllmRFNOaXp0WC9uNFNXbG1NSFo1akJYalNtMGxramF1K3Q4?= =?utf-8?B?em9CWnRtcnJZNXVoZzYxcUZJdisveG9lMG82b3BJeUJsQmxXeFNnK2lXNTYx?= =?utf-8?B?TTdZZUFneTI0ZVRzNHgwL29NWURURHpLa29uLzVqdXJZdnk5L08vZHZsRERu?= =?utf-8?B?ZFVDK2Jwd29BRlVwQmVEem4wUU4vbFlodTl2ZjIrTkcxREI1RVN0S1VBSDBa?= =?utf-8?B?eExXZHNXZEsrN0NoU1ZIQ2k3K053TlZiNDYwUDdzWnJoNW9pUm9Lc1FaRzlk?= =?utf-8?B?WHIyN3RtM2hTYzJHak1NTmVLUHhJZllFc3JQMDNiL1E1NWVhMkhldFR3aEM2?= =?utf-8?B?b0xIS3ZqWldZYy9uYWlKcGFTSEFKeDh4cFVKWndnTk0rTm1wUzZlSlI5aTFM?= =?utf-8?B?eWxIak9zTjUrWHB6R29OQlQreDZ0QXcrK2NFQnV6OHFLT2ZnTzNqNURpMFdp?= =?utf-8?B?Vzl4cUxDblI5VmtGRFEydi9BWGhubzRoeXR0cHZzd2Z3TWxaL3FBSDAvdEpn?= =?utf-8?B?Y1FadzhkRDZQKzlJeGxuZkw0RnVWNEZ2Si9ENnRCK2hYeTkvbGhiaUlhUm5v?= =?utf-8?B?cFBaald1WGRPVTlMVlhaNmgwd0NLMTUrcDU2MzlIWEhQUWFYWTQzblhKaTJZ?= =?utf-8?B?UUs3WVdqV2hkdG0wUG1uRFpzdmpCVXNXM0VldTVXdWc4ZzlFTkwweEdRRWxF?= =?utf-8?B?UVpiQVV5bEJ0SHZDVXkycGlHZXpyUVRMeGQ5dDd0d0VnMVNFM1p4SmlFV0NY?= =?utf-8?B?MUhYSlR4bXdtYmFpOEdZTkM5bXRWWEhvc1dEWVJvNytUUkVsWWp1UTJLU0ln?= =?utf-8?B?OVhhSkk4eXgvb1JPWmhMdU1rc3JHZG9aaFUzbFdYYkRFNWhKWnUrUGF4Y3VZ?= =?utf-8?B?K0kyTlhwY0EzeWNPYUNqcm5pM0hDVFduUVlrZGpsb0NoZzQvKy9jNzR5Mi9p?= =?utf-8?B?cDRxOEUwZGQvUnVZa1l4YzJteVdQSEJGN0RndTJlNjZkWFZrOTh4VU5sYTJQ?= =?utf-8?B?d0JRSjFucE5EUWE4WnF3NVROWTdkNkUvNjlZaHR2bVR6cHdkOHViVHVkaSs1?= =?utf-8?B?TEZUbnJ5Z091Z0lYZXlPMlFYaTFaZ2xxZ1cwTmpGTTk0OTg5TFdKZz09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 62af4919-7e60-400c-a0ae-08da3a6ad331 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2022 14:12:51.1785 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9wwb/G5GzBoepcgg7MwTPaE1ZlrKMphtkIiFAhnLD+0J6kQGud4JzENF9AQPlyU/GKu+ateD7VSDX8W0pI3rzg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6162 X-Spam-Status: No, score=-3031.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 May 2022 14:12:58 -0000 On 09.05.2022 14:17, Steinar H. Gunderson via Binutils wrote: > On Fri, Apr 22, 2022 at 12:25:12PM +0200, Steinar H. Gunderson wrote: >> When using perf to profile large binaries, _bfd_dwarf2_find_nearest_line() >> becomes a hotspot, as perf wants to get line number information >> (for inline-detection purposes) for each and every sample. In Chromium >> in particular (the content_shell binary), this entails going through >> 475k address ranges, which takes a long time when done repeatedly. > > Any news on getting this pushed? I've now committed it. In the patch (e.g. as a post-commit-message remark) there was no indication that this needs taking care of by someone, so I was going from the assumption that you would have commit access yourself. Jan